* [PATCH] qga-vss: Add auto generated headers to dependencies
@ 2022-05-12 15:49 Konstantin Kostiuk
2022-05-12 17:00 ` Marc-André Lureau
2022-05-13 7:06 ` Paolo Bonzini
0 siblings, 2 replies; 4+ messages in thread
From: Konstantin Kostiuk @ 2022-05-12 15:49 UTC (permalink / raw)
To: qemu-devel; +Cc: Paolo Bonzini, Marc-André Lureau, Michael Roth
Signed-off-by: Konstantin Kostiuk <kkostiuk@redhat.com>
---
qga/vss-win32/meson.build | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/qga/vss-win32/meson.build b/qga/vss-win32/meson.build
index 26c5dd6e0e..9483ccd3b8 100644
--- a/qga/vss-win32/meson.build
+++ b/qga/vss-win32/meson.build
@@ -7,7 +7,7 @@ link_args = cc.get_supported_link_arguments([
qga_vss = shared_module(
'qga-vss',
- ['requester.cpp', 'provider.cpp', 'install.cpp'],
+ ['requester.cpp', 'provider.cpp', 'install.cpp', genh],
name_prefix: '',
cpp_args: ['-Wno-unknown-pragmas', '-Wno-delete-non-virtual-dtor', '-Wno-non-virtual-dtor'],
link_args: link_args,
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] qga-vss: Add auto generated headers to dependencies
2022-05-12 15:49 [PATCH] qga-vss: Add auto generated headers to dependencies Konstantin Kostiuk
@ 2022-05-12 17:00 ` Marc-André Lureau
2022-05-12 17:10 ` Konstantin Kostiuk
2022-05-13 7:06 ` Paolo Bonzini
1 sibling, 1 reply; 4+ messages in thread
From: Marc-André Lureau @ 2022-05-12 17:00 UTC (permalink / raw)
To: Konstantin Kostiuk; +Cc: qemu-devel, Paolo Bonzini, Michael Roth
Hi
On Thu, May 12, 2022 at 5:49 PM Konstantin Kostiuk <kkostiuk@redhat.com> wrote:
>
> Signed-off-by: Konstantin Kostiuk <kkostiuk@redhat.com>
> ---
> qga/vss-win32/meson.build | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/qga/vss-win32/meson.build b/qga/vss-win32/meson.build
> index 26c5dd6e0e..9483ccd3b8 100644
> --- a/qga/vss-win32/meson.build
> +++ b/qga/vss-win32/meson.build
> @@ -7,7 +7,7 @@ link_args = cc.get_supported_link_arguments([
>
> qga_vss = shared_module(
> 'qga-vss',
> - ['requester.cpp', 'provider.cpp', 'install.cpp'],
> + ['requester.cpp', 'provider.cpp', 'install.cpp', genh],
Looks fine, but could you tell which file was needed? (not qapi or
trace files, I suppose, so what else?)
> name_prefix: '',
> cpp_args: ['-Wno-unknown-pragmas', '-Wno-delete-non-virtual-dtor', '-Wno-non-virtual-dtor'],
> link_args: link_args,
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] qga-vss: Add auto generated headers to dependencies
2022-05-12 17:00 ` Marc-André Lureau
@ 2022-05-12 17:10 ` Konstantin Kostiuk
0 siblings, 0 replies; 4+ messages in thread
From: Konstantin Kostiuk @ 2022-05-12 17:10 UTC (permalink / raw)
To: Marc-André Lureau; +Cc: qemu-devel, Paolo Bonzini, Michael Roth
[-- Attachment #1: Type: text/plain, Size: 1447 bytes --]
Hi
On Thu, May 12, 2022 at 8:00 PM Marc-André Lureau <
marcandre.lureau@redhat.com> wrote:
> Hi
>
> On Thu, May 12, 2022 at 5:49 PM Konstantin Kostiuk <kkostiuk@redhat.com>
> wrote:
> >
> > Signed-off-by: Konstantin Kostiuk <kkostiuk@redhat.com>
> > ---
> > qga/vss-win32/meson.build | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/qga/vss-win32/meson.build b/qga/vss-win32/meson.build
> > index 26c5dd6e0e..9483ccd3b8 100644
> > --- a/qga/vss-win32/meson.build
> > +++ b/qga/vss-win32/meson.build
> > @@ -7,7 +7,7 @@ link_args = cc.get_supported_link_arguments([
> >
> > qga_vss = shared_module(
> > 'qga-vss',
> > - ['requester.cpp', 'provider.cpp', 'install.cpp'],
> > + ['requester.cpp', 'provider.cpp', 'install.cpp', genh],
>
> Looks fine, but could you tell which file was needed? (not qapi or
> trace files, I suppose, so what else?)
>
During the CI build I got the next error
[176/701] Compiling C++ object qga/vss-win32/qga-vss.dll.p/provider.cpp.obj
FAILED: qga/vss-win32/qga-vss.dll.p/provider.cpp.obj
fatal error: config-poison.h: No such file or directory
[180/701] Generating config-poison.h with a custom command (wrapped by
meson to capture output)
>
> > name_prefix: '',
> > cpp_args: ['-Wno-unknown-pragmas', '-Wno-delete-non-virtual-dtor',
> '-Wno-non-virtual-dtor'],
> > link_args: link_args,
> > --
> > 2.25.1
> >
>
>
[-- Attachment #2: Type: text/html, Size: 2276 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] qga-vss: Add auto generated headers to dependencies
2022-05-12 15:49 [PATCH] qga-vss: Add auto generated headers to dependencies Konstantin Kostiuk
2022-05-12 17:00 ` Marc-André Lureau
@ 2022-05-13 7:06 ` Paolo Bonzini
1 sibling, 0 replies; 4+ messages in thread
From: Paolo Bonzini @ 2022-05-13 7:06 UTC (permalink / raw)
To: Konstantin Kostiuk; +Cc: qemu-devel, Marc-André Lureau, Michael Roth
Queued, thanks.
Paolo
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-05-13 7:18 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-12 15:49 [PATCH] qga-vss: Add auto generated headers to dependencies Konstantin Kostiuk
2022-05-12 17:00 ` Marc-André Lureau
2022-05-12 17:10 ` Konstantin Kostiuk
2022-05-13 7:06 ` Paolo Bonzini
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.