[PATCH bpf] bpf: make bpf_skb_ecn_set_ce callable from BPF_PROG_TYPE_SCHED_ACT

[PATCH bpf] bpf: make bpf_skb_ecn_set_ce callable from BPF_PROG_TYPE_SCHED_ACT

[Peter Oskolkov]

This helper is useful if a bpf tc filter sets skb->tstamp.

Signed-off-by: Peter Oskolkov <posk@google.com>
---
 net/core/filter.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/net/core/filter.c b/net/core/filter.c
index 647c63a7b25b..c6d016d9c4b8 100644
--- a/net/core/filter.c
+++ b/net/core/filter.c
@@ -5719,6 +5719,8 @@ tc_cls_act_func_proto(enum bpf_func_id func_id, const struct bpf_prog *prog)
 		return &bpf_tcp_sock_proto;
 	case BPF_FUNC_get_listener_sock:
 		return &bpf_get_listener_sock_proto;
+	case BPF_FUNC_skb_ecn_set_ce:
+		return &bpf_skb_ecn_set_ce_proto;
 #endif
 	default:
 		return bpf_base_func_proto(func_id);
-- 
2.21.0.360.g471c308f928-goog

Re: [PATCH bpf] bpf: make bpf_skb_ecn_set_ce callable from BPF_PROG_TYPE_SCHED_ACT

[Martin Lau]

On Thu, Mar 14, 2019 at 05:28:58PM -0700, Peter Oskolkov wrote:
> This helper is useful if a bpf tc filter sets skb->tstamp.
> 
For the patch,
Acked-by: Martin KaFai Lau <kafai@fb.com>

Not sure if it should belong to bpf-next material though.

Re: [PATCH bpf] bpf: make bpf_skb_ecn_set_ce callable from BPF_PROG_TYPE_SCHED_ACT

[Peter Oskolkov]

On Fri, Mar 15, 2019 at 9:52 AM Martin Lau <kafai@fb.com> wrote:
>
> On Thu, Mar 14, 2019 at 05:28:58PM -0700, Peter Oskolkov wrote:
> > This helper is useful if a bpf tc filter sets skb->tstamp.
> >
> For the patch,
> Acked-by: Martin KaFai Lau <kafai@fb.com>
>
> Not sure if it should belong to bpf-next material though.

Thanks, Martin! I consider it a bug that the helper is not available
in TC context... ;-)

Re: [PATCH bpf] bpf: make bpf_skb_ecn_set_ce callable from BPF_PROG_TYPE_SCHED_ACT

[Alexei Starovoitov]

On Thu, Mar 14, 2019 at 05:28:58PM -0700, Peter Oskolkov wrote:
> This helper is useful if a bpf tc filter sets skb->tstamp.
> 
> Signed-off-by: Peter Oskolkov <posk@google.com>

pls resubmit when bpf-next reopens.