All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Gideon D'souza" <gidisrael@gmail.com>
To: Joe Perches <joe@perches.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Greg Ungerer <gerg@linux-m68k.org>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	linux-m68k <linux-m68k@vger.kernel.org>
Subject: Re: [PATCH 1/2] compiler-gcc.h: Added new macro for gcc attribute
Date: Wed, 25 Jan 2017 10:20:07 +0530	[thread overview]
Message-ID: <CAPNrq4wbhovDcyuNdK84kA1nYtVKcSw42SJGHPsJK68VVuyyyg@mail.gmail.com> (raw)
In-Reply-To: <1485309036.12563.46.camel@perches.com>

>#define __mode(x)       __attribute__((mode(x)))
Well that's embarrassing. I so sorry for the trouble guys :( I'll resend this.

On Wed, Jan 25, 2017 at 7:20 AM, Joe Perches <joe@perches.com> wrote:
> On Tue, 2017-01-24 at 17:44 +0530, Gideon Israel Dsouza wrote:
>> Added __mode(x) into compiler-gcc.h as part of a cleanup task I've
>> taken up, to replace gcc specific attributes with macros.
>>
>> Last accepted patch I sent into linux-next for crypto: d8c34b949d8c:
>> crypto: Replaced gcc specific attributes with macros from compiler.h
>>
>> The last commit of this task that went through you: 52f5684c8e1ec
>> kernel: use macros from compiler.h instead of __attribute__((...))
>>
>> The next patch is for cleaning up the m68k subsystem and it requires
>> a new macro to wrap __attribute__ ((mode (...)))
> []
>> diff --git a/include/linux/compiler-gcc.h b/include/linux/compiler-gcc.h
> []
>> @@ -121,6 +121,7 @@
>>  #define __attribute_const__  __attribute__((__const__))
>>  #define __maybe_unused               __attribute__((unused))
>>  #define __always_unused              __attribute__((unused))
>> +#define __mode                  __attribute__((mode(x)))
>
> Huh?
>
> Perhaps you meant
>
> #define __mode(x)       __attribute__((mode(x)))
>
> ?
>

  parent reply	other threads:[~2017-01-25  4:50 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-24 12:14 [PATCH 1/2] compiler-gcc.h: Added new macro for gcc attribute Gideon Israel Dsouza
2017-01-24 12:14 ` Gideon Israel Dsouza
2017-01-24 12:14 ` [PATCH 2/2] m68k: replaced gcc specific macros with ones from compiler.h Gideon Israel Dsouza
2017-01-25  1:04   ` Greg Ungerer
2017-01-25  1:04   ` Greg Ungerer
2017-01-25  6:54   ` kbuild test robot
2017-01-25  6:54     ` kbuild test robot
2017-01-27 16:39   ` Paul Gortmaker
2017-01-27 16:39     ` Paul Gortmaker
2017-01-27 17:18     ` Gideon D'souza
2017-01-27 17:18       ` Gideon D'souza
2017-01-24 12:14 ` Gideon Israel Dsouza
2017-01-25  1:50 ` [PATCH 1/2] compiler-gcc.h: Added new macro for gcc attribute Joe Perches
2017-01-25  1:50 ` Joe Perches
2017-01-25  4:50   ` Gideon D'souza
2017-01-25  4:50   ` Gideon D'souza [this message]
2017-01-27 13:34     ` Gideon D'souza
2017-01-27 13:34     ` Gideon D'souza
2017-01-27 13:45       ` Joe Perches
2017-01-27 17:20         ` Gideon D'souza
2017-01-27 17:20           ` Gideon D'souza
2017-01-27 13:45       ` Joe Perches
  -- strict thread matches above, loose matches on Subject: below --
2017-01-19 13:34 Gideon Israel Dsouza
2017-01-19 13:34 ` Gideon Israel Dsouza

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAPNrq4wbhovDcyuNdK84kA1nYtVKcSw42SJGHPsJK68VVuyyyg@mail.gmail.com \
    --to=gidisrael@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=geert@linux-m68k.org \
    --cc=gerg@linux-m68k.org \
    --cc=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-m68k@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.