From: "Gideon D'souza" <gidisrael@gmail.com> To: Paul Gortmaker <paul.gortmaker@windriver.com> Cc: Andrew Morton <akpm@linux-foundation.org>, LKML <linux-kernel@vger.kernel.org>, Greg Ungerer <gerg@linux-m68k.org>, Geert Uytterhoeven <geert@linux-m68k.org>, linux-m68k <linux-m68k@vger.kernel.org>, "linux-next@vger.kernel.org" <linux-next@vger.kernel.org> Subject: Re: [PATCH 2/2] m68k: replaced gcc specific macros with ones from compiler.h Date: Fri, 27 Jan 2017 22:48:31 +0530 [thread overview] Message-ID: <CAPNrq4wf_ZwjN5uwzz6vgm8EMuMR5pf1CkTLHUZQNZyNo7bwYA@mail.gmail.com> (raw) In-Reply-To: <CAP=VYLobUppjdMpeoQ7gXn60zmbEZU6d5Ga1mccCPbbpw9n1yA@mail.gmail.com> >You've gone from printf to print here. This commit is breaking the >linux-next builds on m68k. I see the kbuild bot tripped over the same >issue and did the same bisect. I did do a build before sending, as you may guess I'm not on an m68k machine. Forgive the newbie please! I'm re-sending my patch with the correction. On Fri, Jan 27, 2017 at 10:09 PM, Paul Gortmaker <paul.gortmaker@windriver.com> wrote: > On Tue, Jan 24, 2017 at 7:14 AM, Gideon Israel Dsouza > <gidisrael@gmail.com> wrote: >> There is <linux/compiler.h> which provides macros for various gcc specific >> constructs. Eg: __weak for __attribute__((weak)). I've cleaned all >> instances of gcc specific attributes with the right macros for all files >> under /arch/m68k >> >> This patch depends on the previous with changes in > >> @@ -17,6 +18,6 @@ void nf_init(void); >> void nf_shutdown(void); >> >> void nfprint(const char *fmt, ...) >> - __attribute__ ((format (printf, 1, 2))); >> + __print(1, 2); >> > > You've gone from printf to print here. This commit is breaking the > linux-next builds on m68k. I see the kbuild bot tripped over the same > issue and did the same bisect. > > http://kisskb.ellerman.id.au/kisskb/buildresult/12916834/ > > Paul. > --
WARNING: multiple messages have this Message-ID (diff)
From: "Gideon D'souza" <gidisrael@gmail.com> To: Paul Gortmaker <paul.gortmaker@windriver.com> Cc: Andrew Morton <akpm@linux-foundation.org>, LKML <linux-kernel@vger.kernel.org>, Greg Ungerer <gerg@linux-m68k.org>, Geert Uytterhoeven <geert@linux-m68k.org>, linux-m68k <linux-m68k@lists.linux-m68k.org>, "linux-next@vger.kernel.org" <linux-next@vger.kernel.org> Subject: Re: [PATCH 2/2] m68k: replaced gcc specific macros with ones from compiler.h Date: Fri, 27 Jan 2017 22:48:31 +0530 [thread overview] Message-ID: <CAPNrq4wf_ZwjN5uwzz6vgm8EMuMR5pf1CkTLHUZQNZyNo7bwYA@mail.gmail.com> (raw) In-Reply-To: <CAP=VYLobUppjdMpeoQ7gXn60zmbEZU6d5Ga1mccCPbbpw9n1yA@mail.gmail.com> >You've gone from printf to print here. This commit is breaking the >linux-next builds on m68k. I see the kbuild bot tripped over the same >issue and did the same bisect. I did do a build before sending, as you may guess I'm not on an m68k machine. Forgive the newbie please! I'm re-sending my patch with the correction. On Fri, Jan 27, 2017 at 10:09 PM, Paul Gortmaker <paul.gortmaker@windriver.com> wrote: > On Tue, Jan 24, 2017 at 7:14 AM, Gideon Israel Dsouza > <gidisrael@gmail.com> wrote: >> There is <linux/compiler.h> which provides macros for various gcc specific >> constructs. Eg: __weak for __attribute__((weak)). I've cleaned all >> instances of gcc specific attributes with the right macros for all files >> under /arch/m68k >> >> This patch depends on the previous with changes in > >> @@ -17,6 +18,6 @@ void nf_init(void); >> void nf_shutdown(void); >> >> void nfprint(const char *fmt, ...) >> - __attribute__ ((format (printf, 1, 2))); >> + __print(1, 2); >> > > You've gone from printf to print here. This commit is breaking the > linux-next builds on m68k. I see the kbuild bot tripped over the same > issue and did the same bisect. > > http://kisskb.ellerman.id.au/kisskb/buildresult/12916834/ > > Paul. > --
next prev parent reply other threads:[~2017-01-27 17:19 UTC|newest] Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-01-24 12:14 [PATCH 1/2] compiler-gcc.h: Added new macro for gcc attribute Gideon Israel Dsouza 2017-01-24 12:14 ` Gideon Israel Dsouza 2017-01-24 12:14 ` [PATCH 2/2] m68k: replaced gcc specific macros with ones from compiler.h Gideon Israel Dsouza 2017-01-25 1:04 ` Greg Ungerer 2017-01-25 1:04 ` Greg Ungerer 2017-01-25 6:54 ` kbuild test robot 2017-01-25 6:54 ` kbuild test robot 2017-01-27 16:39 ` Paul Gortmaker 2017-01-27 16:39 ` Paul Gortmaker 2017-01-27 17:18 ` Gideon D'souza [this message] 2017-01-27 17:18 ` Gideon D'souza 2017-01-24 12:14 ` Gideon Israel Dsouza 2017-01-25 1:50 ` [PATCH 1/2] compiler-gcc.h: Added new macro for gcc attribute Joe Perches 2017-01-25 1:50 ` Joe Perches 2017-01-25 4:50 ` Gideon D'souza 2017-01-25 4:50 ` Gideon D'souza 2017-01-27 13:34 ` Gideon D'souza 2017-01-27 13:34 ` Gideon D'souza 2017-01-27 13:45 ` Joe Perches 2017-01-27 17:20 ` Gideon D'souza 2017-01-27 17:20 ` Gideon D'souza 2017-01-27 13:45 ` Joe Perches -- strict thread matches above, loose matches on Subject: below -- 2017-01-27 18:14 Gideon Israel Dsouza 2017-01-27 18:15 ` [PATCH 2/2] m68k: replaced gcc specific macros with ones from compiler.h Gideon Israel Dsouza 2017-01-27 18:15 ` Gideon Israel Dsouza 2017-01-19 13:35 Gideon Israel Dsouza 2017-01-19 13:35 ` Gideon Israel Dsouza 2017-01-19 20:31 ` kbuild test robot 2017-01-20 7:44 ` Geert Uytterhoeven 2017-01-20 7:44 ` Geert Uytterhoeven 2017-01-20 10:21 ` Gideon D'souza 2017-01-20 10:21 ` Gideon D'souza 2017-01-20 10:34 ` Geert Uytterhoeven 2017-01-20 10:34 ` Geert Uytterhoeven 2017-01-20 11:24 ` Gideon D'souza 2017-01-20 11:24 ` Gideon D'souza 2017-01-19 20:31 ` kbuild test robot 2017-01-19 20:48 ` kbuild test robot 2017-01-19 20:48 ` kbuild test robot 2017-01-20 5:21 ` Gideon D'souza 2017-01-20 5:21 ` Gideon D'souza
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CAPNrq4wf_ZwjN5uwzz6vgm8EMuMR5pf1CkTLHUZQNZyNo7bwYA@mail.gmail.com \ --to=gidisrael@gmail.com \ --cc=akpm@linux-foundation.org \ --cc=geert@linux-m68k.org \ --cc=gerg@linux-m68k.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-m68k@vger.kernel.org \ --cc=linux-next@vger.kernel.org \ --cc=paul.gortmaker@windriver.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.