From: Badhri Jagan Sridharan <badhri@google.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Guenter Roeck <linux@roeck-us.net>,
Heikki Krogerus <heikki.krogerus@linux.intel.com>,
Kyle Tso <kyletso@google.com>, USB <linux-usb@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v1] usb: typec: tcpm: Wait for vbus discharge to VSAFE0V before toggling
Date: Fri, 19 Feb 2021 01:06:24 -0800 [thread overview]
Message-ID: <CAPTae5LuxPw+4DKt4_NFmBnZxgvM7nTDFtXJsTiqsevi4krLjQ@mail.gmail.com> (raw)
In-Reply-To: <YC5EpqqNM+gnD6Zg@kroah.com>
Done. Just sent out the following patch and CCed stable@vger.kernel.org as well.
[PATCH v2] usb: typec: tcpm: Wait for vbus discharge to VSAFE0V before toggling
Thanks,
Badhri
On Thu, Feb 18, 2021 at 2:42 AM Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
>
> On Thu, Feb 18, 2021 at 02:38:45AM -0800, Badhri Jagan Sridharan wrote:
> > Hi Greg,
> >
> > This patch is a bug fix for the following patch which was introduced in 5.11.
> >
> > commit f321a02caebdd0c56e167610cda2fa148cd96e8b
> > Author: Badhri Jagan Sridharan <badhri@google.com>
> > Date: Wed Oct 28 23:31:35 2020 -0700
> >
> > usb: typec: tcpm: Implement enabling Auto Discharge disconnect support
> >
> > TCPCI spec allows TCPC hardware to autonomously discharge the vbus
> > capacitance upon disconnect. The expectation is that the TCPM enables
> > AutoDischargeDisconnect while entering SNK/SRC_ATTACHED states. Hardware
> > then automously discharges vbus when the vbus falls below a certain
> > threshold i.e. VBUS_SINK_DISCONNECT_THRESHOLD.
> >
> > Apart from enabling the vbus discharge circuit, AutoDischargeDisconnect
> > is also used a flag to move TCPCI based TCPC implementations into
> > Attached.Snk/Attached.Src state as mentioned in
> > Figure 4-15. TCPC State Diagram before a Connection of the
> > USB Type-C Port Controller Interface Specification.
> > In such TCPC implementations, setting AutoDischargeDisconnect would
> > prevent TCPC into entering "Connection_Invalid" state as well.
> >
> > Signed-off-by: Badhri Jagan Sridharan <badhri@google.com>
> > Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> > Link: https://lore.kernel.org/r/20201029063138.1429760-8-badhri@google.com
> > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>
> Great, then can you resend the patch and add a proper Fixes: tag, along
> with a cc: stable as well?
>
> thanks,
>
> greg k-h
prev parent reply other threads:[~2021-02-19 9:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-18 10:02 [PATCH v1] usb: typec: tcpm: Wait for vbus discharge to VSAFE0V before toggling Badhri Jagan Sridharan
2021-02-18 10:09 ` Greg Kroah-Hartman
2021-02-18 10:38 ` Badhri Jagan Sridharan
2021-02-18 10:42 ` Greg Kroah-Hartman
2021-02-19 9:06 ` Badhri Jagan Sridharan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPTae5LuxPw+4DKt4_NFmBnZxgvM7nTDFtXJsTiqsevi4krLjQ@mail.gmail.com \
--to=badhri@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=kyletso@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux@roeck-us.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.