All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 00/16] IIO: Tidy up inconsistent spacing in ID tables.
@ 2021-12-30 17:48 Jonathan Cameron
  2021-12-30 17:48 ` [PATCH 01/16] iio:chemical:atlas: Trivial white space cleanup to add space before } Jonathan Cameron
                   ` (16 more replies)
  0 siblings, 17 replies; 34+ messages in thread
From: Jonathan Cameron @ 2021-12-30 17:48 UTC (permalink / raw)
  To: linux-iio
  Cc: Gwendal Grignou, Andy Shevchenko, Jonathan Cameron,
	Matt Ranostay, Parthiban Nallathambi, Nikita Travkin,
	Maslov Dmitry, Andreas Klinger, Antoniu Miclaus, Zhiyong Tao,
	Hui Liu, Ivan Drobyshevskyi

From: Jonathan Cameron <Jonathan.Cameron@huawei.com>

Andy's review of Gwendal's sx9324 patch included a comment on having
a space before the } in id tables. It is a more general comment, but
this series only addresses the id table cases where things are
inconsistent.  I said I would send a clean up set when I got bored. That
happened sooner than expected (I blame tax returns).

Found using:
  git grep -re "[0-9A-Za-z]}" drivers/iio/ | grep "{\ "

Note that the fact that we have a clump of these in proximity drivers
suggests that copy and paste is leading to this odd bit of formatting
getting copied into new drivers.

As ever, some of these don't have active driver maintainers so please
take a quick look at the whole series if you have time.

Thanks,

Jonathan

Cc: Matt Ranostay <matt.ranostay@konsulko.com>
Cc: Parthiban Nallathambi <pn@denx.de>
Cc: Nikita Travkin <nikita@trvn.ru>
Cc: Maslov Dmitry <maslovdmitry@seeed.cc>
Cc: Andreas Klinger <ak@it-klinger.de>
Cc: Antoniu Miclaus <antoniu.miclaus@analog.com>
Cc: Zhiyong Tao <zhiyong.tao@mediatek.com>
Cc: Hui Liu <hui.liu@mediatek.com>
Cc: Gwendal Grignou <gwendal@chromium.org>
Cc: Ivan Drobyshevskyi <drobyshevskyi@gmail.com>

Jonathan Cameron (16):
  iio:chemical:atlas: Trivial white space cleanup to add space before }
  iio:light:pa12203001: Tidy up white space change to add spaces after {
    and before }
  iio:light:vcnl4035: Trivial whitespace cleanup to add space before }
  iio:light:us5182: White space cleanup of spacing around {} in id
    tables
  iio:light:ltr501: White space cleanup of spacing around {} in id
    tables
  iio:proximity:ping: White space cleanup of spacing around {} in id
    tables
  iio:proximity:rfd77402: White space cleanup of spacing around {} in id
    tables
  iio:proximity:srf04: White space cleanup of spacing around {} in id
    tables
  iio:proximity:srf08: White space cleanup of spacing around {} in id
    tables
  iio:frequency:admv1013: White space cleanup of spacing around {} in id
    tables
  iio:adc:mt6577_auxadc: Tidy up white space around {} in id tables
  iio:adc:hi8435: Tidy up white space around {} in id tables
  iio:adc:ti-adc084s021: Tidy up white space around {}
  iio:light:tsl2722: Fix inconsistent spacing before } in id table
  iio:proximity:vl53l0x: Tidy up white space around {} in id tables
  iio:accel:dmard09: Tidy up white space around {} in id table

 drivers/iio/accel/dmard09.c         |  2 +-
 drivers/iio/adc/hi8435.c            |  2 +-
 drivers/iio/adc/mt6577_auxadc.c     | 10 +++++-----
 drivers/iio/adc/ti-adc084s021.c     |  2 +-
 drivers/iio/chemical/atlas-sensor.c | 10 +++++-----
 drivers/iio/frequency/admv1013.c    |  2 +-
 drivers/iio/light/ltr501.c          | 14 +++++++-------
 drivers/iio/light/pa12203001.c      |  4 ++--
 drivers/iio/light/tsl2772.c         |  2 +-
 drivers/iio/light/us5182d.c         |  6 +++---
 drivers/iio/light/vcnl4035.c        |  2 +-
 drivers/iio/proximity/ping.c        |  4 ++--
 drivers/iio/proximity/rfd77402.c    |  2 +-
 drivers/iio/proximity/srf04.c       | 12 ++++++------
 drivers/iio/proximity/srf08.c       |  6 +++---
 drivers/iio/proximity/vl53l0x-i2c.c |  2 +-
 16 files changed, 41 insertions(+), 41 deletions(-)

-- 
2.34.1


^ permalink raw reply	[flat|nested] 34+ messages in thread

* [PATCH 01/16] iio:chemical:atlas: Trivial white space cleanup to add space before }
  2021-12-30 17:48 [PATCH 00/16] IIO: Tidy up inconsistent spacing in ID tables Jonathan Cameron
@ 2021-12-30 17:48 ` Jonathan Cameron
  2021-12-31  5:46   ` Gwendal Grignou
  2021-12-30 17:48 ` [PATCH 02/16] iio:light:pa12203001: Tidy up white space change to add spaces after { and " Jonathan Cameron
                   ` (15 subsequent siblings)
  16 siblings, 1 reply; 34+ messages in thread
From: Jonathan Cameron @ 2021-12-30 17:48 UTC (permalink / raw)
  To: linux-iio
  Cc: Gwendal Grignou, Andy Shevchenko, Jonathan Cameron, Matt Ranostay

From: Jonathan Cameron <Jonathan.Cameron@huawei.com>

Having a space after the { and not one before the } is inconsistent and
good to remove examples that might get copied into new drivers.

Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Cc: Matt Ranostay <matt.ranostay@konsulko.com>
---
 drivers/iio/chemical/atlas-sensor.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/iio/chemical/atlas-sensor.c b/drivers/iio/chemical/atlas-sensor.c
index 04b44a327614..a8211dd20b35 100644
--- a/drivers/iio/chemical/atlas-sensor.c
+++ b/drivers/iio/chemical/atlas-sensor.c
@@ -589,11 +589,11 @@ static const struct iio_info atlas_info = {
 };
 
 static const struct i2c_device_id atlas_id[] = {
-	{ "atlas-ph-sm", ATLAS_PH_SM},
-	{ "atlas-ec-sm", ATLAS_EC_SM},
-	{ "atlas-orp-sm", ATLAS_ORP_SM},
-	{ "atlas-do-sm", ATLAS_DO_SM},
-	{ "atlas-rtd-sm", ATLAS_RTD_SM},
+	{ "atlas-ph-sm", ATLAS_PH_SM },
+	{ "atlas-ec-sm", ATLAS_EC_SM },
+	{ "atlas-orp-sm", ATLAS_ORP_SM },
+	{ "atlas-do-sm", ATLAS_DO_SM },
+	{ "atlas-rtd-sm", ATLAS_RTD_SM },
 	{}
 };
 MODULE_DEVICE_TABLE(i2c, atlas_id);
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 34+ messages in thread

* [PATCH 02/16] iio:light:pa12203001: Tidy up white space change to add spaces after { and before }
  2021-12-30 17:48 [PATCH 00/16] IIO: Tidy up inconsistent spacing in ID tables Jonathan Cameron
  2021-12-30 17:48 ` [PATCH 01/16] iio:chemical:atlas: Trivial white space cleanup to add space before } Jonathan Cameron
@ 2021-12-30 17:48 ` Jonathan Cameron
  2021-12-31  5:45   ` Gwendal Grignou
  2021-12-30 17:48 ` [PATCH 03/16] iio:light:vcnl4035: Trivial whitespace cleanup to add space " Jonathan Cameron
                   ` (14 subsequent siblings)
  16 siblings, 1 reply; 34+ messages in thread
From: Jonathan Cameron @ 2021-12-30 17:48 UTC (permalink / raw)
  To: linux-iio; +Cc: Gwendal Grignou, Andy Shevchenko, Jonathan Cameron

From: Jonathan Cameron <Jonathan.Cameron@huawei.com>

One case in here was inconsistent and was main focus of this patch.
In that case there was a space after the { and none before the }.
The second case was then inconsistent in having now spaces.
Change makes sure there are spaces.

Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
---
 drivers/iio/light/pa12203001.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/iio/light/pa12203001.c b/drivers/iio/light/pa12203001.c
index a52b2c788540..528fa5dd2b13 100644
--- a/drivers/iio/light/pa12203001.c
+++ b/drivers/iio/light/pa12203001.c
@@ -452,14 +452,14 @@ static const struct dev_pm_ops pa12203001_pm_ops = {
 };
 
 static const struct acpi_device_id pa12203001_acpi_match[] = {
-	{ "TXCPA122", 0},
+	{ "TXCPA122", 0 },
 	{}
 };
 
 MODULE_DEVICE_TABLE(acpi, pa12203001_acpi_match);
 
 static const struct i2c_device_id pa12203001_id[] = {
-		{"txcpa122", 0},
+		{ "txcpa122", 0 },
 		{}
 };
 
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 34+ messages in thread

* [PATCH 03/16] iio:light:vcnl4035: Trivial whitespace cleanup to add space before }
  2021-12-30 17:48 [PATCH 00/16] IIO: Tidy up inconsistent spacing in ID tables Jonathan Cameron
  2021-12-30 17:48 ` [PATCH 01/16] iio:chemical:atlas: Trivial white space cleanup to add space before } Jonathan Cameron
  2021-12-30 17:48 ` [PATCH 02/16] iio:light:pa12203001: Tidy up white space change to add spaces after { and " Jonathan Cameron
@ 2021-12-30 17:48 ` Jonathan Cameron
  2021-12-31  5:46   ` Gwendal Grignou
  2021-12-30 17:48 ` [PATCH 04/16] iio:light:us5182: White space cleanup of spacing around {} in id tables Jonathan Cameron
                   ` (13 subsequent siblings)
  16 siblings, 1 reply; 34+ messages in thread
From: Jonathan Cameron @ 2021-12-30 17:48 UTC (permalink / raw)
  To: linux-iio
  Cc: Gwendal Grignou, Andy Shevchenko, Jonathan Cameron,
	Parthiban Nallathambi

From: Jonathan Cameron <Jonathan.Cameron@huawei.com>

Having a space after the { and not one before the } is inconsistent and
I'd rather not have examples of this that get copied into new drivers.

Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Cc: Parthiban Nallathambi <pn@denx.de>
---
 drivers/iio/light/vcnl4035.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/iio/light/vcnl4035.c b/drivers/iio/light/vcnl4035.c
index 0db306ee910e..da2bf622a67b 100644
--- a/drivers/iio/light/vcnl4035.c
+++ b/drivers/iio/light/vcnl4035.c
@@ -651,7 +651,7 @@ static const struct dev_pm_ops vcnl4035_pm_ops = {
 };
 
 static const struct i2c_device_id vcnl4035_id[] = {
-	{ "vcnl4035", 0},
+	{ "vcnl4035", 0 },
 	{ }
 };
 MODULE_DEVICE_TABLE(i2c, vcnl4035_id);
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 34+ messages in thread

* [PATCH 04/16] iio:light:us5182: White space cleanup of spacing around {} in id tables
  2021-12-30 17:48 [PATCH 00/16] IIO: Tidy up inconsistent spacing in ID tables Jonathan Cameron
                   ` (2 preceding siblings ...)
  2021-12-30 17:48 ` [PATCH 03/16] iio:light:vcnl4035: Trivial whitespace cleanup to add space " Jonathan Cameron
@ 2021-12-30 17:48 ` Jonathan Cameron
  2021-12-31  5:47   ` Gwendal Grignou
  2021-12-30 17:49 ` [PATCH 05/16] iio:light:ltr501: " Jonathan Cameron
                   ` (12 subsequent siblings)
  16 siblings, 1 reply; 34+ messages in thread
From: Jonathan Cameron @ 2021-12-30 17:48 UTC (permalink / raw)
  To: linux-iio; +Cc: Gwendal Grignou, Andy Shevchenko, Jonathan Cameron

From: Jonathan Cameron <Jonathan.Cameron@huawei.com>

The spacing in this driver was inconsistent so make sure we have a space
after { and before } for the two id tables.

Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
---
 drivers/iio/light/us5182d.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/iio/light/us5182d.c b/drivers/iio/light/us5182d.c
index 96e4a66ddf28..1492aaf8d84c 100644
--- a/drivers/iio/light/us5182d.c
+++ b/drivers/iio/light/us5182d.c
@@ -947,15 +947,15 @@ static const struct dev_pm_ops us5182d_pm_ops = {
 };
 
 static const struct acpi_device_id us5182d_acpi_match[] = {
-	{ "USD5182", 0},
+	{ "USD5182", 0 },
 	{}
 };
 
 MODULE_DEVICE_TABLE(acpi, us5182d_acpi_match);
 
 static const struct i2c_device_id us5182d_id[] = {
-		{"usd5182", 0},
-		{}
+	{ "usd5182", 0 },
+	{}
 };
 
 MODULE_DEVICE_TABLE(i2c, us5182d_id);
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 34+ messages in thread

* [PATCH 05/16] iio:light:ltr501: White space cleanup of spacing around {} in id tables
  2021-12-30 17:48 [PATCH 00/16] IIO: Tidy up inconsistent spacing in ID tables Jonathan Cameron
                   ` (3 preceding siblings ...)
  2021-12-30 17:48 ` [PATCH 04/16] iio:light:us5182: White space cleanup of spacing around {} in id tables Jonathan Cameron
@ 2021-12-30 17:49 ` Jonathan Cameron
  2021-12-31  5:47   ` Gwendal Grignou
  2021-12-30 17:49 ` [PATCH 06/16] iio:proximity:ping: " Jonathan Cameron
                   ` (11 subsequent siblings)
  16 siblings, 1 reply; 34+ messages in thread
From: Jonathan Cameron @ 2021-12-30 17:49 UTC (permalink / raw)
  To: linux-iio
  Cc: Gwendal Grignou, Andy Shevchenko, Jonathan Cameron,
	Nikita Travkin, Maslov Dmitry

From: Jonathan Cameron <Jonathan.Cameron@huawei.com>

The spacing in this driver was inconsistent so make sure we have a space
after { and before } for the two id tables.
Part of aim is to avoid providing examples of this inconsistency that
get copied into new drivers.

Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Cc: Nikita Travkin <nikita@trvn.ru>
Cc: Maslov Dmitry <maslovdmitry@seeed.cc>
---
 drivers/iio/light/ltr501.c | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/drivers/iio/light/ltr501.c b/drivers/iio/light/ltr501.c
index 47d61ec2bb50..d1532ef5f08b 100644
--- a/drivers/iio/light/ltr501.c
+++ b/drivers/iio/light/ltr501.c
@@ -1632,18 +1632,18 @@ static int ltr501_resume(struct device *dev)
 static SIMPLE_DEV_PM_OPS(ltr501_pm_ops, ltr501_suspend, ltr501_resume);
 
 static const struct acpi_device_id ltr_acpi_match[] = {
-	{"LTER0501", ltr501},
-	{"LTER0559", ltr559},
-	{"LTER0301", ltr301},
+	{ "LTER0501", ltr501 },
+	{ "LTER0559", ltr559 },
+	{ "LTER0301", ltr301 },
 	{ },
 };
 MODULE_DEVICE_TABLE(acpi, ltr_acpi_match);
 
 static const struct i2c_device_id ltr501_id[] = {
-	{ "ltr501", ltr501},
-	{ "ltr559", ltr559},
-	{ "ltr301", ltr301},
-	{ "ltr303", ltr303},
+	{ "ltr501", ltr501 },
+	{ "ltr559", ltr559 },
+	{ "ltr301", ltr301 },
+	{ "ltr303", ltr303 },
 	{ }
 };
 MODULE_DEVICE_TABLE(i2c, ltr501_id);
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 34+ messages in thread

* [PATCH 06/16] iio:proximity:ping: White space cleanup of spacing around {} in id tables
  2021-12-30 17:48 [PATCH 00/16] IIO: Tidy up inconsistent spacing in ID tables Jonathan Cameron
                   ` (4 preceding siblings ...)
  2021-12-30 17:49 ` [PATCH 05/16] iio:light:ltr501: " Jonathan Cameron
@ 2021-12-30 17:49 ` Jonathan Cameron
  2021-12-31  5:48   ` Gwendal Grignou
  2021-12-30 17:49 ` [PATCH 07/16] iio:proximity:rfd77402: " Jonathan Cameron
                   ` (10 subsequent siblings)
  16 siblings, 1 reply; 34+ messages in thread
From: Jonathan Cameron @ 2021-12-30 17:49 UTC (permalink / raw)
  To: linux-iio
  Cc: Gwendal Grignou, Andy Shevchenko, Jonathan Cameron, Andreas Klinger

From: Jonathan Cameron <Jonathan.Cameron@huawei.com>

The spacing in this driver was inconsistent so make sure we have a space
after { and before } for the two id tables.
Avoid providing examples of this inconsistency that get copied into new
drivers.

Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Cc: Andreas Klinger <ak@it-klinger.de>
---
 drivers/iio/proximity/ping.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/iio/proximity/ping.c b/drivers/iio/proximity/ping.c
index 1283ac1c2e03..24a97d41e115 100644
--- a/drivers/iio/proximity/ping.c
+++ b/drivers/iio/proximity/ping.c
@@ -267,8 +267,8 @@ static const struct iio_chan_spec ping_chan_spec[] = {
 };
 
 static const struct of_device_id of_ping_match[] = {
-	{ .compatible = "parallax,ping", .data = &pa_ping_cfg},
-	{ .compatible = "parallax,laserping", .data = &pa_laser_ping_cfg},
+	{ .compatible = "parallax,ping", .data = &pa_ping_cfg },
+	{ .compatible = "parallax,laserping", .data = &pa_laser_ping_cfg },
 	{},
 };
 
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 34+ messages in thread

* [PATCH 07/16] iio:proximity:rfd77402: White space cleanup of spacing around {} in id tables
  2021-12-30 17:48 [PATCH 00/16] IIO: Tidy up inconsistent spacing in ID tables Jonathan Cameron
                   ` (5 preceding siblings ...)
  2021-12-30 17:49 ` [PATCH 06/16] iio:proximity:ping: " Jonathan Cameron
@ 2021-12-30 17:49 ` Jonathan Cameron
  2021-12-31  5:48   ` Gwendal Grignou
  2021-12-30 17:49 ` [PATCH 08/16] iio:proximity:srf04: " Jonathan Cameron
                   ` (9 subsequent siblings)
  16 siblings, 1 reply; 34+ messages in thread
From: Jonathan Cameron @ 2021-12-30 17:49 UTC (permalink / raw)
  To: linux-iio; +Cc: Gwendal Grignou, Andy Shevchenko, Jonathan Cameron

From: Jonathan Cameron <Jonathan.Cameron@huawei.com>

The spacing in this driver was inconsistent with a space after the {
but not before the }.  Tidy this up to avoid providing a bad example
to copy into new drivers.

Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
---
 drivers/iio/proximity/rfd77402.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/iio/proximity/rfd77402.c b/drivers/iio/proximity/rfd77402.c
index 8c06d02139b6..0ae91963b570 100644
--- a/drivers/iio/proximity/rfd77402.c
+++ b/drivers/iio/proximity/rfd77402.c
@@ -310,7 +310,7 @@ static int rfd77402_resume(struct device *dev)
 static SIMPLE_DEV_PM_OPS(rfd77402_pm_ops, rfd77402_suspend, rfd77402_resume);
 
 static const struct i2c_device_id rfd77402_id[] = {
-	{ "rfd77402", 0},
+	{ "rfd77402", 0 },
 	{ }
 };
 MODULE_DEVICE_TABLE(i2c, rfd77402_id);
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 34+ messages in thread

* [PATCH 08/16] iio:proximity:srf04: White space cleanup of spacing around {} in id tables
  2021-12-30 17:48 [PATCH 00/16] IIO: Tidy up inconsistent spacing in ID tables Jonathan Cameron
                   ` (6 preceding siblings ...)
  2021-12-30 17:49 ` [PATCH 07/16] iio:proximity:rfd77402: " Jonathan Cameron
@ 2021-12-30 17:49 ` Jonathan Cameron
  2021-12-31  5:48   ` Gwendal Grignou
  2021-12-30 17:49 ` [PATCH 09/16] iio:proximity:srf08: " Jonathan Cameron
                   ` (8 subsequent siblings)
  16 siblings, 1 reply; 34+ messages in thread
From: Jonathan Cameron @ 2021-12-30 17:49 UTC (permalink / raw)
  To: linux-iio
  Cc: Gwendal Grignou, Andy Shevchenko, Jonathan Cameron, Andreas Klinger

From: Jonathan Cameron <Jonathan.Cameron@huawei.com>

The spacing in this driver was inconsistent with a space after the {
but not before the }.  Tidy this up to avoid providing a bad example
to copy into new drivers.

Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Cc: Andreas Klinger <ak@it-klinger.de>
---
 drivers/iio/proximity/srf04.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/iio/proximity/srf04.c b/drivers/iio/proximity/srf04.c
index fe88b2bb60bc..4e6286765f01 100644
--- a/drivers/iio/proximity/srf04.c
+++ b/drivers/iio/proximity/srf04.c
@@ -235,12 +235,12 @@ static const struct iio_chan_spec srf04_chan_spec[] = {
 };
 
 static const struct of_device_id of_srf04_match[] = {
-	{ .compatible = "devantech,srf04", .data = &srf04_cfg},
-	{ .compatible = "maxbotix,mb1000", .data = &mb_lv_cfg},
-	{ .compatible = "maxbotix,mb1010", .data = &mb_lv_cfg},
-	{ .compatible = "maxbotix,mb1020", .data = &mb_lv_cfg},
-	{ .compatible = "maxbotix,mb1030", .data = &mb_lv_cfg},
-	{ .compatible = "maxbotix,mb1040", .data = &mb_lv_cfg},
+	{ .compatible = "devantech,srf04", .data = &srf04_cfg },
+	{ .compatible = "maxbotix,mb1000", .data = &mb_lv_cfg },
+	{ .compatible = "maxbotix,mb1010", .data = &mb_lv_cfg },
+	{ .compatible = "maxbotix,mb1020", .data = &mb_lv_cfg },
+	{ .compatible = "maxbotix,mb1030", .data = &mb_lv_cfg },
+	{ .compatible = "maxbotix,mb1040", .data = &mb_lv_cfg },
 	{},
 };
 
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 34+ messages in thread

* [PATCH 09/16] iio:proximity:srf08: White space cleanup of spacing around {} in id tables
  2021-12-30 17:48 [PATCH 00/16] IIO: Tidy up inconsistent spacing in ID tables Jonathan Cameron
                   ` (7 preceding siblings ...)
  2021-12-30 17:49 ` [PATCH 08/16] iio:proximity:srf04: " Jonathan Cameron
@ 2021-12-30 17:49 ` Jonathan Cameron
  2021-12-31  5:49   ` Gwendal Grignou
  2021-12-30 17:49 ` [PATCH 10/16] iio:frequency:admv1013: " Jonathan Cameron
                   ` (7 subsequent siblings)
  16 siblings, 1 reply; 34+ messages in thread
From: Jonathan Cameron @ 2021-12-30 17:49 UTC (permalink / raw)
  To: linux-iio
  Cc: Gwendal Grignou, Andy Shevchenko, Jonathan Cameron, Andreas Klinger

From: Jonathan Cameron <Jonathan.Cameron@huawei.com>

The spacing in this driver was inconsistent with a space after the {
but not before the }.  Tidy this up to avoid providing a bad example
to copy into new drivers.

Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Cc: Andreas Klinger <ak@it-klinger.de>
---
 drivers/iio/proximity/srf08.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/iio/proximity/srf08.c b/drivers/iio/proximity/srf08.c
index 9b0886760f76..ac1ab7e89d4e 100644
--- a/drivers/iio/proximity/srf08.c
+++ b/drivers/iio/proximity/srf08.c
@@ -528,9 +528,9 @@ static int srf08_probe(struct i2c_client *client,
 }
 
 static const struct of_device_id of_srf08_match[] = {
-	{ .compatible = "devantech,srf02", (void *)SRF02},
-	{ .compatible = "devantech,srf08", (void *)SRF08},
-	{ .compatible = "devantech,srf10", (void *)SRF10},
+	{ .compatible = "devantech,srf02", (void *)SRF02 },
+	{ .compatible = "devantech,srf08", (void *)SRF08 },
+	{ .compatible = "devantech,srf10", (void *)SRF10 },
 	{},
 };
 
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 34+ messages in thread

* [PATCH 10/16] iio:frequency:admv1013: White space cleanup of spacing around {} in id tables
  2021-12-30 17:48 [PATCH 00/16] IIO: Tidy up inconsistent spacing in ID tables Jonathan Cameron
                   ` (8 preceding siblings ...)
  2021-12-30 17:49 ` [PATCH 09/16] iio:proximity:srf08: " Jonathan Cameron
@ 2021-12-30 17:49 ` Jonathan Cameron
  2021-12-31  5:49   ` Gwendal Grignou
  2021-12-30 17:49 ` [PATCH 11/16] iio:adc:mt6577_auxadc: Tidy up white space " Jonathan Cameron
                   ` (6 subsequent siblings)
  16 siblings, 1 reply; 34+ messages in thread
From: Jonathan Cameron @ 2021-12-30 17:49 UTC (permalink / raw)
  To: linux-iio
  Cc: Gwendal Grignou, Andy Shevchenko, Jonathan Cameron, Antoniu Miclaus

From: Jonathan Cameron <Jonathan.Cameron@huawei.com>

The spacing was inconsistent with a space after the { but not
before the }. Tidy this up to avoid providing a bad example to copy into
new drivers.

Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Cc: Antoniu Miclaus <antoniu.miclaus@analog.com>
---
 drivers/iio/frequency/admv1013.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/iio/frequency/admv1013.c b/drivers/iio/frequency/admv1013.c
index 6cdeb50143af..849a9ea7ebe5 100644
--- a/drivers/iio/frequency/admv1013.c
+++ b/drivers/iio/frequency/admv1013.c
@@ -630,7 +630,7 @@ static int admv1013_probe(struct spi_device *spi)
 }
 
 static const struct spi_device_id admv1013_id[] = {
-	{ "admv1013", 0},
+	{ "admv1013", 0 },
 	{}
 };
 MODULE_DEVICE_TABLE(spi, admv1013_id);
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 34+ messages in thread

* [PATCH 11/16] iio:adc:mt6577_auxadc: Tidy up white space around {} in id tables
  2021-12-30 17:48 [PATCH 00/16] IIO: Tidy up inconsistent spacing in ID tables Jonathan Cameron
                   ` (9 preceding siblings ...)
  2021-12-30 17:49 ` [PATCH 10/16] iio:frequency:admv1013: " Jonathan Cameron
@ 2021-12-30 17:49 ` Jonathan Cameron
  2021-12-31  5:49   ` Gwendal Grignou
  2021-12-30 17:49 ` [PATCH 12/16] iio:adc:hi8435: " Jonathan Cameron
                   ` (5 subsequent siblings)
  16 siblings, 1 reply; 34+ messages in thread
From: Jonathan Cameron @ 2021-12-30 17:49 UTC (permalink / raw)
  To: linux-iio
  Cc: Gwendal Grignou, Andy Shevchenko, Jonathan Cameron, Zhiyong Tao, Hui Liu

From: Jonathan Cameron <Jonathan.Cameron@huawei.com>

Previously inconsistent with space after { and not before }.
Tidy that up to avoid providing a bad example to copy into new drivers.

Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Cc: Zhiyong Tao <zhiyong.tao@mediatek.com>
Cc: Hui Liu <hui.liu@mediatek.com>
---
 drivers/iio/adc/mt6577_auxadc.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/iio/adc/mt6577_auxadc.c b/drivers/iio/adc/mt6577_auxadc.c
index d4fccd52ef08..327fff96c6c8 100644
--- a/drivers/iio/adc/mt6577_auxadc.c
+++ b/drivers/iio/adc/mt6577_auxadc.c
@@ -330,11 +330,11 @@ static SIMPLE_DEV_PM_OPS(mt6577_auxadc_pm_ops,
 			 mt6577_auxadc_resume);
 
 static const struct of_device_id mt6577_auxadc_of_match[] = {
-	{ .compatible = "mediatek,mt2701-auxadc", .data = &mt8173_compat},
-	{ .compatible = "mediatek,mt2712-auxadc", .data = &mt8173_compat},
-	{ .compatible = "mediatek,mt7622-auxadc", .data = &mt8173_compat},
-	{ .compatible = "mediatek,mt8173-auxadc", .data = &mt8173_compat},
-	{ .compatible = "mediatek,mt6765-auxadc", .data = &mt6765_compat},
+	{ .compatible = "mediatek,mt2701-auxadc", .data = &mt8173_compat },
+	{ .compatible = "mediatek,mt2712-auxadc", .data = &mt8173_compat },
+	{ .compatible = "mediatek,mt7622-auxadc", .data = &mt8173_compat },
+	{ .compatible = "mediatek,mt8173-auxadc", .data = &mt8173_compat },
+	{ .compatible = "mediatek,mt6765-auxadc", .data = &mt6765_compat },
 	{ }
 };
 MODULE_DEVICE_TABLE(of, mt6577_auxadc_of_match);
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 34+ messages in thread

* [PATCH 12/16] iio:adc:hi8435: Tidy up white space around {} in id tables
  2021-12-30 17:48 [PATCH 00/16] IIO: Tidy up inconsistent spacing in ID tables Jonathan Cameron
                   ` (10 preceding siblings ...)
  2021-12-30 17:49 ` [PATCH 11/16] iio:adc:mt6577_auxadc: Tidy up white space " Jonathan Cameron
@ 2021-12-30 17:49 ` Jonathan Cameron
  2021-12-31  5:49   ` Gwendal Grignou
  2021-12-30 17:49 ` [PATCH 13/16] iio:adc:ti-adc084s021: Tidy up white space around {} Jonathan Cameron
                   ` (4 subsequent siblings)
  16 siblings, 1 reply; 34+ messages in thread
From: Jonathan Cameron @ 2021-12-30 17:49 UTC (permalink / raw)
  To: linux-iio; +Cc: Gwendal Grignou, Andy Shevchenko, Jonathan Cameron

From: Jonathan Cameron <Jonathan.Cameron@huawei.com>

Previously inconsistent with space after { but not before }.
Tidy that up to avoid providing a bad example to copy into new drivers.

Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
---
 drivers/iio/adc/hi8435.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/iio/adc/hi8435.c b/drivers/iio/adc/hi8435.c
index e665e14c6e54..8eb0140df133 100644
--- a/drivers/iio/adc/hi8435.c
+++ b/drivers/iio/adc/hi8435.c
@@ -529,7 +529,7 @@ static const struct of_device_id hi8435_dt_ids[] = {
 MODULE_DEVICE_TABLE(of, hi8435_dt_ids);
 
 static const struct spi_device_id hi8435_id[] = {
-	{ "hi8435", 0},
+	{ "hi8435", 0 },
 	{ }
 };
 MODULE_DEVICE_TABLE(spi, hi8435_id);
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 34+ messages in thread

* [PATCH 13/16] iio:adc:ti-adc084s021: Tidy up white space around {}
  2021-12-30 17:48 [PATCH 00/16] IIO: Tidy up inconsistent spacing in ID tables Jonathan Cameron
                   ` (11 preceding siblings ...)
  2021-12-30 17:49 ` [PATCH 12/16] iio:adc:hi8435: " Jonathan Cameron
@ 2021-12-30 17:49 ` Jonathan Cameron
  2021-12-31  5:50   ` Gwendal Grignou
  2021-12-30 17:49 ` [PATCH 14/16] iio:light:tsl2722: Fix inconsistent spacing before } in id table Jonathan Cameron
                   ` (3 subsequent siblings)
  16 siblings, 1 reply; 34+ messages in thread
From: Jonathan Cameron @ 2021-12-30 17:49 UTC (permalink / raw)
  To: linux-iio; +Cc: Gwendal Grignou, Andy Shevchenko, Jonathan Cameron

From: Jonathan Cameron <Jonathan.Cameron@huawei.com>

Previously inconsistent with a space after { but not before }.
Tidy that up to avoid providing an example to copy into new drivers.

Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Cc: Gwendal Grignou <gwendal@chromium.org>
---
 drivers/iio/adc/ti-adc084s021.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/iio/adc/ti-adc084s021.c b/drivers/iio/adc/ti-adc084s021.c
index ce3f5a3814f9..c9b5d9aec3dc 100644
--- a/drivers/iio/adc/ti-adc084s021.c
+++ b/drivers/iio/adc/ti-adc084s021.c
@@ -248,7 +248,7 @@ static const struct of_device_id adc084s021_of_match[] = {
 MODULE_DEVICE_TABLE(of, adc084s021_of_match);
 
 static const struct spi_device_id adc084s021_id[] = {
-	{ ADC084S021_DRIVER_NAME, 0},
+	{ ADC084S021_DRIVER_NAME, 0 },
 	{}
 };
 MODULE_DEVICE_TABLE(spi, adc084s021_id);
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 34+ messages in thread

* [PATCH 14/16] iio:light:tsl2722: Fix inconsistent spacing before } in id table
  2021-12-30 17:48 [PATCH 00/16] IIO: Tidy up inconsistent spacing in ID tables Jonathan Cameron
                   ` (12 preceding siblings ...)
  2021-12-30 17:49 ` [PATCH 13/16] iio:adc:ti-adc084s021: Tidy up white space around {} Jonathan Cameron
@ 2021-12-30 17:49 ` Jonathan Cameron
  2021-12-31  5:50   ` Gwendal Grignou
  2021-12-30 17:49 ` [PATCH 15/16] iio:proximity:vl53l0x: Tidy up white space around {} in id tables Jonathan Cameron
                   ` (2 subsequent siblings)
  16 siblings, 1 reply; 34+ messages in thread
From: Jonathan Cameron @ 2021-12-30 17:49 UTC (permalink / raw)
  To: linux-iio; +Cc: Gwendal Grignou, Andy Shevchenko, Jonathan Cameron

From: Jonathan Cameron <Jonathan.Cameron@huawei.com>

The final entry was missing a space. Tidy that up.

Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
---
 drivers/iio/light/tsl2772.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/iio/light/tsl2772.c b/drivers/iio/light/tsl2772.c
index d79205361dfa..729f14d9f2a4 100644
--- a/drivers/iio/light/tsl2772.c
+++ b/drivers/iio/light/tsl2772.c
@@ -1902,7 +1902,7 @@ static const struct i2c_device_id tsl2772_idtable[] = {
 	{ "tmd2672", tmd2672 },
 	{ "tsl2772", tsl2772 },
 	{ "tmd2772", tmd2772 },
-	{ "apds9930", apds9930},
+	{ "apds9930", apds9930 },
 	{}
 };
 
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 34+ messages in thread

* [PATCH 15/16] iio:proximity:vl53l0x: Tidy up white space around {} in id tables
  2021-12-30 17:48 [PATCH 00/16] IIO: Tidy up inconsistent spacing in ID tables Jonathan Cameron
                   ` (13 preceding siblings ...)
  2021-12-30 17:49 ` [PATCH 14/16] iio:light:tsl2722: Fix inconsistent spacing before } in id table Jonathan Cameron
@ 2021-12-30 17:49 ` Jonathan Cameron
  2021-12-31  5:50   ` Gwendal Grignou
  2021-12-30 17:49 ` [PATCH 16/16] iio:accel:dmard09: Tidy up white space around {} in id table Jonathan Cameron
  2022-01-09 15:00 ` [PATCH 00/16] IIO: Tidy up inconsistent spacing in ID tables Jonathan Cameron
  16 siblings, 1 reply; 34+ messages in thread
From: Jonathan Cameron @ 2021-12-30 17:49 UTC (permalink / raw)
  To: linux-iio
  Cc: Gwendal Grignou, Andy Shevchenko, Jonathan Cameron, Ivan Drobyshevskyi

From: Jonathan Cameron <Jonathan.Cameron@huawei.com>

Previously inconsistent with a space after { but not before }.
Tidy that up to avoid providing a bad example that might get copied
into other drivers.

Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Cc: Ivan Drobyshevskyi <drobyshevskyi@gmail.com>
---
 drivers/iio/proximity/vl53l0x-i2c.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/iio/proximity/vl53l0x-i2c.c b/drivers/iio/proximity/vl53l0x-i2c.c
index cf38144b6f95..661a79ea200d 100644
--- a/drivers/iio/proximity/vl53l0x-i2c.c
+++ b/drivers/iio/proximity/vl53l0x-i2c.c
@@ -226,7 +226,7 @@ static int vl53l0x_probe(struct i2c_client *client)
 }
 
 static const struct i2c_device_id vl53l0x_id[] = {
-	{ "vl53l0x", 0},
+	{ "vl53l0x", 0 },
 	{ }
 };
 MODULE_DEVICE_TABLE(i2c, vl53l0x_id);
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 34+ messages in thread

* [PATCH 16/16] iio:accel:dmard09: Tidy up white space around {} in id table
  2021-12-30 17:48 [PATCH 00/16] IIO: Tidy up inconsistent spacing in ID tables Jonathan Cameron
                   ` (14 preceding siblings ...)
  2021-12-30 17:49 ` [PATCH 15/16] iio:proximity:vl53l0x: Tidy up white space around {} in id tables Jonathan Cameron
@ 2021-12-30 17:49 ` Jonathan Cameron
  2021-12-31  5:50   ` Gwendal Grignou
  2022-01-09 15:00 ` [PATCH 00/16] IIO: Tidy up inconsistent spacing in ID tables Jonathan Cameron
  16 siblings, 1 reply; 34+ messages in thread
From: Jonathan Cameron @ 2021-12-30 17:49 UTC (permalink / raw)
  To: linux-iio; +Cc: Gwendal Grignou, Andy Shevchenko, Jonathan Cameron

From: Jonathan Cameron <Jonathan.Cameron@huawei.com>

Previously inconsistent with a space after { but not before }.
Tidy that up to avoid providing a bad example that might get
copied into other drivers.

Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
---
 drivers/iio/accel/dmard09.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/iio/accel/dmard09.c b/drivers/iio/accel/dmard09.c
index e6e28c964777..53ab6078cb7f 100644
--- a/drivers/iio/accel/dmard09.c
+++ b/drivers/iio/accel/dmard09.c
@@ -126,7 +126,7 @@ static int dmard09_probe(struct i2c_client *client,
 }
 
 static const struct i2c_device_id dmard09_id[] = {
-	{ "dmard09", 0},
+	{ "dmard09", 0 },
 	{ },
 };
 
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 34+ messages in thread

* Re: [PATCH 02/16] iio:light:pa12203001: Tidy up white space change to add spaces after { and before }
  2021-12-30 17:48 ` [PATCH 02/16] iio:light:pa12203001: Tidy up white space change to add spaces after { and " Jonathan Cameron
@ 2021-12-31  5:45   ` Gwendal Grignou
  0 siblings, 0 replies; 34+ messages in thread
From: Gwendal Grignou @ 2021-12-31  5:45 UTC (permalink / raw)
  To: Jonathan Cameron; +Cc: linux-iio, Andy Shevchenko, Jonathan Cameron

On Thu, Dec 30, 2021 at 9:43 AM Jonathan Cameron <jic23@kernel.org> wrote:
>
> From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
>
> One case in here was inconsistent and was main focus of this patch.
> In that case there was a space after the { and none before the }.
> The second case was then inconsistent in having now spaces.
> Change makes sure there are spaces.
>
> Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> ---
Reviewed-by: Gwendal Grignou <gwendal@chromium.org>
>  drivers/iio/light/pa12203001.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/iio/light/pa12203001.c b/drivers/iio/light/pa12203001.c
> index a52b2c788540..528fa5dd2b13 100644
> --- a/drivers/iio/light/pa12203001.c
> +++ b/drivers/iio/light/pa12203001.c
> @@ -452,14 +452,14 @@ static const struct dev_pm_ops pa12203001_pm_ops = {
>  };
>
>  static const struct acpi_device_id pa12203001_acpi_match[] = {
> -       { "TXCPA122", 0},
> +       { "TXCPA122", 0 },
>         {}
>  };
>
>  MODULE_DEVICE_TABLE(acpi, pa12203001_acpi_match);
>
>  static const struct i2c_device_id pa12203001_id[] = {
> -               {"txcpa122", 0},
> +               { "txcpa122", 0 },
>                 {}
>  };
>
> --
> 2.34.1
>

^ permalink raw reply	[flat|nested] 34+ messages in thread

* Re: [PATCH 01/16] iio:chemical:atlas: Trivial white space cleanup to add space before }
  2021-12-30 17:48 ` [PATCH 01/16] iio:chemical:atlas: Trivial white space cleanup to add space before } Jonathan Cameron
@ 2021-12-31  5:46   ` Gwendal Grignou
  0 siblings, 0 replies; 34+ messages in thread
From: Gwendal Grignou @ 2021-12-31  5:46 UTC (permalink / raw)
  To: Jonathan Cameron
  Cc: linux-iio, Andy Shevchenko, Jonathan Cameron, Matt Ranostay

On Thu, Dec 30, 2021 at 9:43 AM Jonathan Cameron <jic23@kernel.org> wrote:
>
> From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
>
> Having a space after the { and not one before the } is inconsistent and
> good to remove examples that might get copied into new drivers.
>
> Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> Cc: Matt Ranostay <matt.ranostay@konsulko.com>
> ---
Reviewed-by: Gwendal Grignou <gwendal@chromium.org>
>  drivers/iio/chemical/atlas-sensor.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/iio/chemical/atlas-sensor.c b/drivers/iio/chemical/atlas-sensor.c
> index 04b44a327614..a8211dd20b35 100644
> --- a/drivers/iio/chemical/atlas-sensor.c
> +++ b/drivers/iio/chemical/atlas-sensor.c
> @@ -589,11 +589,11 @@ static const struct iio_info atlas_info = {
>  };
>
>  static const struct i2c_device_id atlas_id[] = {
> -       { "atlas-ph-sm", ATLAS_PH_SM},
> -       { "atlas-ec-sm", ATLAS_EC_SM},
> -       { "atlas-orp-sm", ATLAS_ORP_SM},
> -       { "atlas-do-sm", ATLAS_DO_SM},
> -       { "atlas-rtd-sm", ATLAS_RTD_SM},
> +       { "atlas-ph-sm", ATLAS_PH_SM },
> +       { "atlas-ec-sm", ATLAS_EC_SM },
> +       { "atlas-orp-sm", ATLAS_ORP_SM },
> +       { "atlas-do-sm", ATLAS_DO_SM },
> +       { "atlas-rtd-sm", ATLAS_RTD_SM },
>         {}
>  };
>  MODULE_DEVICE_TABLE(i2c, atlas_id);
> --
> 2.34.1
>

^ permalink raw reply	[flat|nested] 34+ messages in thread

* Re: [PATCH 03/16] iio:light:vcnl4035: Trivial whitespace cleanup to add space before }
  2021-12-30 17:48 ` [PATCH 03/16] iio:light:vcnl4035: Trivial whitespace cleanup to add space " Jonathan Cameron
@ 2021-12-31  5:46   ` Gwendal Grignou
  0 siblings, 0 replies; 34+ messages in thread
From: Gwendal Grignou @ 2021-12-31  5:46 UTC (permalink / raw)
  To: Jonathan Cameron
  Cc: linux-iio, Andy Shevchenko, Jonathan Cameron, Parthiban Nallathambi

On Thu, Dec 30, 2021 at 9:43 AM Jonathan Cameron <jic23@kernel.org> wrote:
>
> From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
>
> Having a space after the { and not one before the } is inconsistent and
> I'd rather not have examples of this that get copied into new drivers.
>
> Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> Cc: Parthiban Nallathambi <pn@denx.de>
> ---
Reviewed-by: Gwendal Grignou <gwendal@chromium.org>
>  drivers/iio/light/vcnl4035.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/light/vcnl4035.c b/drivers/iio/light/vcnl4035.c
> index 0db306ee910e..da2bf622a67b 100644
> --- a/drivers/iio/light/vcnl4035.c
> +++ b/drivers/iio/light/vcnl4035.c
> @@ -651,7 +651,7 @@ static const struct dev_pm_ops vcnl4035_pm_ops = {
>  };
>
>  static const struct i2c_device_id vcnl4035_id[] = {
> -       { "vcnl4035", 0},
> +       { "vcnl4035", 0 },
>         { }
>  };
>  MODULE_DEVICE_TABLE(i2c, vcnl4035_id);
> --
> 2.34.1
>

^ permalink raw reply	[flat|nested] 34+ messages in thread

* Re: [PATCH 04/16] iio:light:us5182: White space cleanup of spacing around {} in id tables
  2021-12-30 17:48 ` [PATCH 04/16] iio:light:us5182: White space cleanup of spacing around {} in id tables Jonathan Cameron
@ 2021-12-31  5:47   ` Gwendal Grignou
  0 siblings, 0 replies; 34+ messages in thread
From: Gwendal Grignou @ 2021-12-31  5:47 UTC (permalink / raw)
  To: Jonathan Cameron; +Cc: linux-iio, Andy Shevchenko, Jonathan Cameron

On Thu, Dec 30, 2021 at 9:43 AM Jonathan Cameron <jic23@kernel.org> wrote:
>
> From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
>
> The spacing in this driver was inconsistent so make sure we have a space
> after { and before } for the two id tables.
>
> Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> ---
Reviewed-by: Gwendal Grignou <gwendal@chromium.org>
>  drivers/iio/light/us5182d.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/iio/light/us5182d.c b/drivers/iio/light/us5182d.c
> index 96e4a66ddf28..1492aaf8d84c 100644
> --- a/drivers/iio/light/us5182d.c
> +++ b/drivers/iio/light/us5182d.c
> @@ -947,15 +947,15 @@ static const struct dev_pm_ops us5182d_pm_ops = {
>  };
>
>  static const struct acpi_device_id us5182d_acpi_match[] = {
> -       { "USD5182", 0},
> +       { "USD5182", 0 },
>         {}
>  };
>
>  MODULE_DEVICE_TABLE(acpi, us5182d_acpi_match);
>
>  static const struct i2c_device_id us5182d_id[] = {
> -               {"usd5182", 0},
> -               {}
> +       { "usd5182", 0 },
> +       {}
>  };
>
>  MODULE_DEVICE_TABLE(i2c, us5182d_id);
> --
> 2.34.1
>

^ permalink raw reply	[flat|nested] 34+ messages in thread

* Re: [PATCH 05/16] iio:light:ltr501: White space cleanup of spacing around {} in id tables
  2021-12-30 17:49 ` [PATCH 05/16] iio:light:ltr501: " Jonathan Cameron
@ 2021-12-31  5:47   ` Gwendal Grignou
  0 siblings, 0 replies; 34+ messages in thread
From: Gwendal Grignou @ 2021-12-31  5:47 UTC (permalink / raw)
  To: Jonathan Cameron
  Cc: linux-iio, Andy Shevchenko, Jonathan Cameron, Nikita Travkin,
	Maslov Dmitry

On Thu, Dec 30, 2021 at 9:44 AM Jonathan Cameron <jic23@kernel.org> wrote:
>
> From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
>
> The spacing in this driver was inconsistent so make sure we have a space
> after { and before } for the two id tables.
> Part of aim is to avoid providing examples of this inconsistency that
> get copied into new drivers.
>
> Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> Cc: Nikita Travkin <nikita@trvn.ru>
> Cc: Maslov Dmitry <maslovdmitry@seeed.cc>
> ---
Reviewed-by: Gwendal Grignou <gwendal@chromium.org>
>  drivers/iio/light/ltr501.c | 14 +++++++-------
>  1 file changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/iio/light/ltr501.c b/drivers/iio/light/ltr501.c
> index 47d61ec2bb50..d1532ef5f08b 100644
> --- a/drivers/iio/light/ltr501.c
> +++ b/drivers/iio/light/ltr501.c
> @@ -1632,18 +1632,18 @@ static int ltr501_resume(struct device *dev)
>  static SIMPLE_DEV_PM_OPS(ltr501_pm_ops, ltr501_suspend, ltr501_resume);
>
>  static const struct acpi_device_id ltr_acpi_match[] = {
> -       {"LTER0501", ltr501},
> -       {"LTER0559", ltr559},
> -       {"LTER0301", ltr301},
> +       { "LTER0501", ltr501 },
> +       { "LTER0559", ltr559 },
> +       { "LTER0301", ltr301 },
>         { },
>  };
>  MODULE_DEVICE_TABLE(acpi, ltr_acpi_match);
>
>  static const struct i2c_device_id ltr501_id[] = {
> -       { "ltr501", ltr501},
> -       { "ltr559", ltr559},
> -       { "ltr301", ltr301},
> -       { "ltr303", ltr303},
> +       { "ltr501", ltr501 },
> +       { "ltr559", ltr559 },
> +       { "ltr301", ltr301 },
> +       { "ltr303", ltr303 },
>         { }
>  };
>  MODULE_DEVICE_TABLE(i2c, ltr501_id);
> --
> 2.34.1
>

^ permalink raw reply	[flat|nested] 34+ messages in thread

* Re: [PATCH 06/16] iio:proximity:ping: White space cleanup of spacing around {} in id tables
  2021-12-30 17:49 ` [PATCH 06/16] iio:proximity:ping: " Jonathan Cameron
@ 2021-12-31  5:48   ` Gwendal Grignou
  0 siblings, 0 replies; 34+ messages in thread
From: Gwendal Grignou @ 2021-12-31  5:48 UTC (permalink / raw)
  To: Jonathan Cameron
  Cc: linux-iio, Andy Shevchenko, Jonathan Cameron, Andreas Klinger

On Thu, Dec 30, 2021 at 9:44 AM Jonathan Cameron <jic23@kernel.org> wrote:
>
> From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
>
> The spacing in this driver was inconsistent so make sure we have a space
> after { and before } for the two id tables.
> Avoid providing examples of this inconsistency that get copied into new
> drivers.
>
> Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> Cc: Andreas Klinger <ak@it-klinger.de>
> ---
Reviewed-by: Gwendal Grignou <gwendal@chromium.org>
>  drivers/iio/proximity/ping.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/iio/proximity/ping.c b/drivers/iio/proximity/ping.c
> index 1283ac1c2e03..24a97d41e115 100644
> --- a/drivers/iio/proximity/ping.c
> +++ b/drivers/iio/proximity/ping.c
> @@ -267,8 +267,8 @@ static const struct iio_chan_spec ping_chan_spec[] = {
>  };
>
>  static const struct of_device_id of_ping_match[] = {
> -       { .compatible = "parallax,ping", .data = &pa_ping_cfg},
> -       { .compatible = "parallax,laserping", .data = &pa_laser_ping_cfg},
> +       { .compatible = "parallax,ping", .data = &pa_ping_cfg },
> +       { .compatible = "parallax,laserping", .data = &pa_laser_ping_cfg },
>         {},
>  };
>
> --
> 2.34.1
>

^ permalink raw reply	[flat|nested] 34+ messages in thread

* Re: [PATCH 07/16] iio:proximity:rfd77402: White space cleanup of spacing around {} in id tables
  2021-12-30 17:49 ` [PATCH 07/16] iio:proximity:rfd77402: " Jonathan Cameron
@ 2021-12-31  5:48   ` Gwendal Grignou
  0 siblings, 0 replies; 34+ messages in thread
From: Gwendal Grignou @ 2021-12-31  5:48 UTC (permalink / raw)
  To: Jonathan Cameron; +Cc: linux-iio, Andy Shevchenko, Jonathan Cameron

On Thu, Dec 30, 2021 at 9:44 AM Jonathan Cameron <jic23@kernel.org> wrote:
>
> From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
>
> The spacing in this driver was inconsistent with a space after the {
> but not before the }.  Tidy this up to avoid providing a bad example
> to copy into new drivers.
>
> Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> ---
Reviewed-by: Gwendal Grignou <gwendal@chromium.org>
>  drivers/iio/proximity/rfd77402.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/proximity/rfd77402.c b/drivers/iio/proximity/rfd77402.c
> index 8c06d02139b6..0ae91963b570 100644
> --- a/drivers/iio/proximity/rfd77402.c
> +++ b/drivers/iio/proximity/rfd77402.c
> @@ -310,7 +310,7 @@ static int rfd77402_resume(struct device *dev)
>  static SIMPLE_DEV_PM_OPS(rfd77402_pm_ops, rfd77402_suspend, rfd77402_resume);
>
>  static const struct i2c_device_id rfd77402_id[] = {
> -       { "rfd77402", 0},
> +       { "rfd77402", 0 },
>         { }
>  };
>  MODULE_DEVICE_TABLE(i2c, rfd77402_id);
> --
> 2.34.1
>

^ permalink raw reply	[flat|nested] 34+ messages in thread

* Re: [PATCH 08/16] iio:proximity:srf04: White space cleanup of spacing around {} in id tables
  2021-12-30 17:49 ` [PATCH 08/16] iio:proximity:srf04: " Jonathan Cameron
@ 2021-12-31  5:48   ` Gwendal Grignou
  0 siblings, 0 replies; 34+ messages in thread
From: Gwendal Grignou @ 2021-12-31  5:48 UTC (permalink / raw)
  To: Jonathan Cameron
  Cc: linux-iio, Andy Shevchenko, Jonathan Cameron, Andreas Klinger

On Thu, Dec 30, 2021 at 9:44 AM Jonathan Cameron <jic23@kernel.org> wrote:
>
> From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
>
> The spacing in this driver was inconsistent with a space after the {
> but not before the }.  Tidy this up to avoid providing a bad example
> to copy into new drivers.
>
> Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> Cc: Andreas Klinger <ak@it-klinger.de>
> ---
Reviewed-by: Gwendal Grignou <gwendal@chromium.org>
>  drivers/iio/proximity/srf04.c | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/iio/proximity/srf04.c b/drivers/iio/proximity/srf04.c
> index fe88b2bb60bc..4e6286765f01 100644
> --- a/drivers/iio/proximity/srf04.c
> +++ b/drivers/iio/proximity/srf04.c
> @@ -235,12 +235,12 @@ static const struct iio_chan_spec srf04_chan_spec[] = {
>  };
>
>  static const struct of_device_id of_srf04_match[] = {
> -       { .compatible = "devantech,srf04", .data = &srf04_cfg},
> -       { .compatible = "maxbotix,mb1000", .data = &mb_lv_cfg},
> -       { .compatible = "maxbotix,mb1010", .data = &mb_lv_cfg},
> -       { .compatible = "maxbotix,mb1020", .data = &mb_lv_cfg},
> -       { .compatible = "maxbotix,mb1030", .data = &mb_lv_cfg},
> -       { .compatible = "maxbotix,mb1040", .data = &mb_lv_cfg},
> +       { .compatible = "devantech,srf04", .data = &srf04_cfg },
> +       { .compatible = "maxbotix,mb1000", .data = &mb_lv_cfg },
> +       { .compatible = "maxbotix,mb1010", .data = &mb_lv_cfg },
> +       { .compatible = "maxbotix,mb1020", .data = &mb_lv_cfg },
> +       { .compatible = "maxbotix,mb1030", .data = &mb_lv_cfg },
> +       { .compatible = "maxbotix,mb1040", .data = &mb_lv_cfg },
>         {},
>  };
>
> --
> 2.34.1
>

^ permalink raw reply	[flat|nested] 34+ messages in thread

* Re: [PATCH 09/16] iio:proximity:srf08: White space cleanup of spacing around {} in id tables
  2021-12-30 17:49 ` [PATCH 09/16] iio:proximity:srf08: " Jonathan Cameron
@ 2021-12-31  5:49   ` Gwendal Grignou
  0 siblings, 0 replies; 34+ messages in thread
From: Gwendal Grignou @ 2021-12-31  5:49 UTC (permalink / raw)
  To: Jonathan Cameron
  Cc: linux-iio, Andy Shevchenko, Jonathan Cameron, Andreas Klinger

On Thu, Dec 30, 2021 at 9:44 AM Jonathan Cameron <jic23@kernel.org> wrote:
>
> From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
>
> The spacing in this driver was inconsistent with a space after the {
> but not before the }.  Tidy this up to avoid providing a bad example
> to copy into new drivers.
>
> Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> Cc: Andreas Klinger <ak@it-klinger.de>
> ---
Reviewed-by: Gwendal Grignou <gwendal@chromium.org>
>  drivers/iio/proximity/srf08.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/iio/proximity/srf08.c b/drivers/iio/proximity/srf08.c
> index 9b0886760f76..ac1ab7e89d4e 100644
> --- a/drivers/iio/proximity/srf08.c
> +++ b/drivers/iio/proximity/srf08.c
> @@ -528,9 +528,9 @@ static int srf08_probe(struct i2c_client *client,
>  }
>
>  static const struct of_device_id of_srf08_match[] = {
> -       { .compatible = "devantech,srf02", (void *)SRF02},
> -       { .compatible = "devantech,srf08", (void *)SRF08},
> -       { .compatible = "devantech,srf10", (void *)SRF10},
> +       { .compatible = "devantech,srf02", (void *)SRF02 },
> +       { .compatible = "devantech,srf08", (void *)SRF08 },
> +       { .compatible = "devantech,srf10", (void *)SRF10 },
>         {},
>  };
>
> --
> 2.34.1
>

^ permalink raw reply	[flat|nested] 34+ messages in thread

* Re: [PATCH 10/16] iio:frequency:admv1013: White space cleanup of spacing around {} in id tables
  2021-12-30 17:49 ` [PATCH 10/16] iio:frequency:admv1013: " Jonathan Cameron
@ 2021-12-31  5:49   ` Gwendal Grignou
  0 siblings, 0 replies; 34+ messages in thread
From: Gwendal Grignou @ 2021-12-31  5:49 UTC (permalink / raw)
  To: Jonathan Cameron
  Cc: linux-iio, Andy Shevchenko, Jonathan Cameron, Antoniu Miclaus

On Thu, Dec 30, 2021 at 9:44 AM Jonathan Cameron <jic23@kernel.org> wrote:
>
> From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
>
> The spacing was inconsistent with a space after the { but not
> before the }. Tidy this up to avoid providing a bad example to copy into
> new drivers.
>
> Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> Cc: Antoniu Miclaus <antoniu.miclaus@analog.com>
> ---
Reviewed-by: Gwendal Grignou <gwendal@chromium.org>
>  drivers/iio/frequency/admv1013.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/frequency/admv1013.c b/drivers/iio/frequency/admv1013.c
> index 6cdeb50143af..849a9ea7ebe5 100644
> --- a/drivers/iio/frequency/admv1013.c
> +++ b/drivers/iio/frequency/admv1013.c
> @@ -630,7 +630,7 @@ static int admv1013_probe(struct spi_device *spi)
>  }
>
>  static const struct spi_device_id admv1013_id[] = {
> -       { "admv1013", 0},
> +       { "admv1013", 0 },
>         {}
>  };
>  MODULE_DEVICE_TABLE(spi, admv1013_id);
> --
> 2.34.1
>

^ permalink raw reply	[flat|nested] 34+ messages in thread

* Re: [PATCH 11/16] iio:adc:mt6577_auxadc: Tidy up white space around {} in id tables
  2021-12-30 17:49 ` [PATCH 11/16] iio:adc:mt6577_auxadc: Tidy up white space " Jonathan Cameron
@ 2021-12-31  5:49   ` Gwendal Grignou
  0 siblings, 0 replies; 34+ messages in thread
From: Gwendal Grignou @ 2021-12-31  5:49 UTC (permalink / raw)
  To: Jonathan Cameron
  Cc: linux-iio, Andy Shevchenko, Jonathan Cameron, Zhiyong Tao, Hui Liu

On Thu, Dec 30, 2021 at 9:44 AM Jonathan Cameron <jic23@kernel.org> wrote:
>
> From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
>
> Previously inconsistent with space after { and not before }.
> Tidy that up to avoid providing a bad example to copy into new drivers.
>
> Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> Cc: Zhiyong Tao <zhiyong.tao@mediatek.com>
> Cc: Hui Liu <hui.liu@mediatek.com>
> ---
Reviewed-by: Gwendal Grignou <gwendal@chromium.org>
>  drivers/iio/adc/mt6577_auxadc.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/iio/adc/mt6577_auxadc.c b/drivers/iio/adc/mt6577_auxadc.c
> index d4fccd52ef08..327fff96c6c8 100644
> --- a/drivers/iio/adc/mt6577_auxadc.c
> +++ b/drivers/iio/adc/mt6577_auxadc.c
> @@ -330,11 +330,11 @@ static SIMPLE_DEV_PM_OPS(mt6577_auxadc_pm_ops,
>                          mt6577_auxadc_resume);
>
>  static const struct of_device_id mt6577_auxadc_of_match[] = {
> -       { .compatible = "mediatek,mt2701-auxadc", .data = &mt8173_compat},
> -       { .compatible = "mediatek,mt2712-auxadc", .data = &mt8173_compat},
> -       { .compatible = "mediatek,mt7622-auxadc", .data = &mt8173_compat},
> -       { .compatible = "mediatek,mt8173-auxadc", .data = &mt8173_compat},
> -       { .compatible = "mediatek,mt6765-auxadc", .data = &mt6765_compat},
> +       { .compatible = "mediatek,mt2701-auxadc", .data = &mt8173_compat },
> +       { .compatible = "mediatek,mt2712-auxadc", .data = &mt8173_compat },
> +       { .compatible = "mediatek,mt7622-auxadc", .data = &mt8173_compat },
> +       { .compatible = "mediatek,mt8173-auxadc", .data = &mt8173_compat },
> +       { .compatible = "mediatek,mt6765-auxadc", .data = &mt6765_compat },
>         { }
>  };
>  MODULE_DEVICE_TABLE(of, mt6577_auxadc_of_match);
> --
> 2.34.1
>

^ permalink raw reply	[flat|nested] 34+ messages in thread

* Re: [PATCH 12/16] iio:adc:hi8435: Tidy up white space around {} in id tables
  2021-12-30 17:49 ` [PATCH 12/16] iio:adc:hi8435: " Jonathan Cameron
@ 2021-12-31  5:49   ` Gwendal Grignou
  0 siblings, 0 replies; 34+ messages in thread
From: Gwendal Grignou @ 2021-12-31  5:49 UTC (permalink / raw)
  To: Jonathan Cameron; +Cc: linux-iio, Andy Shevchenko, Jonathan Cameron

On Thu, Dec 30, 2021 at 9:44 AM Jonathan Cameron <jic23@kernel.org> wrote:
>
> From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
>
> Previously inconsistent with space after { but not before }.
> Tidy that up to avoid providing a bad example to copy into new drivers.
>
> Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> ---
Reviewed-by: Gwendal Grignou <gwendal@chromium.org>
>  drivers/iio/adc/hi8435.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/adc/hi8435.c b/drivers/iio/adc/hi8435.c
> index e665e14c6e54..8eb0140df133 100644
> --- a/drivers/iio/adc/hi8435.c
> +++ b/drivers/iio/adc/hi8435.c
> @@ -529,7 +529,7 @@ static const struct of_device_id hi8435_dt_ids[] = {
>  MODULE_DEVICE_TABLE(of, hi8435_dt_ids);
>
>  static const struct spi_device_id hi8435_id[] = {
> -       { "hi8435", 0},
> +       { "hi8435", 0 },
>         { }
>  };
>  MODULE_DEVICE_TABLE(spi, hi8435_id);
> --
> 2.34.1
>

^ permalink raw reply	[flat|nested] 34+ messages in thread

* Re: [PATCH 13/16] iio:adc:ti-adc084s021: Tidy up white space around {}
  2021-12-30 17:49 ` [PATCH 13/16] iio:adc:ti-adc084s021: Tidy up white space around {} Jonathan Cameron
@ 2021-12-31  5:50   ` Gwendal Grignou
  0 siblings, 0 replies; 34+ messages in thread
From: Gwendal Grignou @ 2021-12-31  5:50 UTC (permalink / raw)
  To: Jonathan Cameron; +Cc: linux-iio, Andy Shevchenko, Jonathan Cameron

On Thu, Dec 30, 2021 at 9:44 AM Jonathan Cameron <jic23@kernel.org> wrote:
>
> From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
>
> Previously inconsistent with a space after { but not before }.
> Tidy that up to avoid providing an example to copy into new drivers.
>
> Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> Cc: Gwendal Grignou <gwendal@chromium.org>
> ---
Reviewed-by: Gwendal Grignou <gwendal@chromium.org>
>  drivers/iio/adc/ti-adc084s021.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/adc/ti-adc084s021.c b/drivers/iio/adc/ti-adc084s021.c
> index ce3f5a3814f9..c9b5d9aec3dc 100644
> --- a/drivers/iio/adc/ti-adc084s021.c
> +++ b/drivers/iio/adc/ti-adc084s021.c
> @@ -248,7 +248,7 @@ static const struct of_device_id adc084s021_of_match[] = {
>  MODULE_DEVICE_TABLE(of, adc084s021_of_match);
>
>  static const struct spi_device_id adc084s021_id[] = {
> -       { ADC084S021_DRIVER_NAME, 0},
> +       { ADC084S021_DRIVER_NAME, 0 },
>         {}
>  };
>  MODULE_DEVICE_TABLE(spi, adc084s021_id);
> --
> 2.34.1
>

^ permalink raw reply	[flat|nested] 34+ messages in thread

* Re: [PATCH 14/16] iio:light:tsl2722: Fix inconsistent spacing before } in id table
  2021-12-30 17:49 ` [PATCH 14/16] iio:light:tsl2722: Fix inconsistent spacing before } in id table Jonathan Cameron
@ 2021-12-31  5:50   ` Gwendal Grignou
  0 siblings, 0 replies; 34+ messages in thread
From: Gwendal Grignou @ 2021-12-31  5:50 UTC (permalink / raw)
  To: Jonathan Cameron; +Cc: linux-iio, Andy Shevchenko, Jonathan Cameron

On Thu, Dec 30, 2021 at 9:44 AM Jonathan Cameron <jic23@kernel.org> wrote:
>
> From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
>
> The final entry was missing a space. Tidy that up.
>
> Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> ---
Reviewed-by: Gwendal Grignou <gwendal@chromium.org>
>  drivers/iio/light/tsl2772.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/light/tsl2772.c b/drivers/iio/light/tsl2772.c
> index d79205361dfa..729f14d9f2a4 100644
> --- a/drivers/iio/light/tsl2772.c
> +++ b/drivers/iio/light/tsl2772.c
> @@ -1902,7 +1902,7 @@ static const struct i2c_device_id tsl2772_idtable[] = {
>         { "tmd2672", tmd2672 },
>         { "tsl2772", tsl2772 },
>         { "tmd2772", tmd2772 },
> -       { "apds9930", apds9930},
> +       { "apds9930", apds9930 },
>         {}
>  };
>
> --
> 2.34.1
>

^ permalink raw reply	[flat|nested] 34+ messages in thread

* Re: [PATCH 15/16] iio:proximity:vl53l0x: Tidy up white space around {} in id tables
  2021-12-30 17:49 ` [PATCH 15/16] iio:proximity:vl53l0x: Tidy up white space around {} in id tables Jonathan Cameron
@ 2021-12-31  5:50   ` Gwendal Grignou
  0 siblings, 0 replies; 34+ messages in thread
From: Gwendal Grignou @ 2021-12-31  5:50 UTC (permalink / raw)
  To: Jonathan Cameron
  Cc: linux-iio, Andy Shevchenko, Jonathan Cameron, Ivan Drobyshevskyi

On Thu, Dec 30, 2021 at 9:44 AM Jonathan Cameron <jic23@kernel.org> wrote:
>
> From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
>
> Previously inconsistent with a space after { but not before }.
> Tidy that up to avoid providing a bad example that might get copied
> into other drivers.
>
> Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> Cc: Ivan Drobyshevskyi <drobyshevskyi@gmail.com>
> ---
Reviewed-by: Gwendal Grignou <gwendal@chromium.org>
>  drivers/iio/proximity/vl53l0x-i2c.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/proximity/vl53l0x-i2c.c b/drivers/iio/proximity/vl53l0x-i2c.c
> index cf38144b6f95..661a79ea200d 100644
> --- a/drivers/iio/proximity/vl53l0x-i2c.c
> +++ b/drivers/iio/proximity/vl53l0x-i2c.c
> @@ -226,7 +226,7 @@ static int vl53l0x_probe(struct i2c_client *client)
>  }
>
>  static const struct i2c_device_id vl53l0x_id[] = {
> -       { "vl53l0x", 0},
> +       { "vl53l0x", 0 },
>         { }
>  };
>  MODULE_DEVICE_TABLE(i2c, vl53l0x_id);
> --
> 2.34.1
>

^ permalink raw reply	[flat|nested] 34+ messages in thread

* Re: [PATCH 16/16] iio:accel:dmard09: Tidy up white space around {} in id table
  2021-12-30 17:49 ` [PATCH 16/16] iio:accel:dmard09: Tidy up white space around {} in id table Jonathan Cameron
@ 2021-12-31  5:50   ` Gwendal Grignou
  0 siblings, 0 replies; 34+ messages in thread
From: Gwendal Grignou @ 2021-12-31  5:50 UTC (permalink / raw)
  To: Jonathan Cameron; +Cc: linux-iio, Andy Shevchenko, Jonathan Cameron

On Thu, Dec 30, 2021 at 9:44 AM Jonathan Cameron <jic23@kernel.org> wrote:
>
> From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
>
> Previously inconsistent with a space after { but not before }.
> Tidy that up to avoid providing a bad example that might get
> copied into other drivers.
>
> Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> ---
Reviewed-by: Gwendal Grignou <gwendal@chromium.org>
>  drivers/iio/accel/dmard09.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/accel/dmard09.c b/drivers/iio/accel/dmard09.c
> index e6e28c964777..53ab6078cb7f 100644
> --- a/drivers/iio/accel/dmard09.c
> +++ b/drivers/iio/accel/dmard09.c
> @@ -126,7 +126,7 @@ static int dmard09_probe(struct i2c_client *client,
>  }
>
>  static const struct i2c_device_id dmard09_id[] = {
> -       { "dmard09", 0},
> +       { "dmard09", 0 },
>         { },
>  };
>
> --
> 2.34.1
>

^ permalink raw reply	[flat|nested] 34+ messages in thread

* Re: [PATCH 00/16] IIO: Tidy up inconsistent spacing in ID tables.
  2021-12-30 17:48 [PATCH 00/16] IIO: Tidy up inconsistent spacing in ID tables Jonathan Cameron
                   ` (15 preceding siblings ...)
  2021-12-30 17:49 ` [PATCH 16/16] iio:accel:dmard09: Tidy up white space around {} in id table Jonathan Cameron
@ 2022-01-09 15:00 ` Jonathan Cameron
  16 siblings, 0 replies; 34+ messages in thread
From: Jonathan Cameron @ 2022-01-09 15:00 UTC (permalink / raw)
  To: linux-iio
  Cc: Gwendal Grignou, Andy Shevchenko, Jonathan Cameron,
	Matt Ranostay, Parthiban Nallathambi, Nikita Travkin,
	Maslov Dmitry, Andreas Klinger, Antoniu Miclaus, Zhiyong Tao,
	Hui Liu, Ivan Drobyshevskyi

On Thu, 30 Dec 2021 17:48:55 +0000
Jonathan Cameron <jic23@kernel.org> wrote:

> From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> 
> Andy's review of Gwendal's sx9324 patch included a comment on having
> a space before the } in id tables. It is a more general comment, but
> this series only addresses the id table cases where things are
> inconsistent.  I said I would send a clean up set when I got bored. That
> happened sooner than expected (I blame tax returns).
> 
> Found using:
>   git grep -re "[0-9A-Za-z]}" drivers/iio/ | grep "{\ "
> 
> Note that the fact that we have a clump of these in proximity drivers
> suggests that copy and paste is leading to this odd bit of formatting
> getting copied into new drivers.
> 
> As ever, some of these don't have active driver maintainers so please
> take a quick look at the whole series if you have time.

Series applied to the togreg branch of iio.git, pushed out as testing for
0-day to poke at it until after the merge window.

Thanks,

Jonathan

> 
> Thanks,
> 
> Jonathan
> 
> Cc: Matt Ranostay <matt.ranostay@konsulko.com>
> Cc: Parthiban Nallathambi <pn@denx.de>
> Cc: Nikita Travkin <nikita@trvn.ru>
> Cc: Maslov Dmitry <maslovdmitry@seeed.cc>
> Cc: Andreas Klinger <ak@it-klinger.de>
> Cc: Antoniu Miclaus <antoniu.miclaus@analog.com>
> Cc: Zhiyong Tao <zhiyong.tao@mediatek.com>
> Cc: Hui Liu <hui.liu@mediatek.com>
> Cc: Gwendal Grignou <gwendal@chromium.org>
> Cc: Ivan Drobyshevskyi <drobyshevskyi@gmail.com>
> 
> Jonathan Cameron (16):
>   iio:chemical:atlas: Trivial white space cleanup to add space before }
>   iio:light:pa12203001: Tidy up white space change to add spaces after {
>     and before }
>   iio:light:vcnl4035: Trivial whitespace cleanup to add space before }
>   iio:light:us5182: White space cleanup of spacing around {} in id
>     tables
>   iio:light:ltr501: White space cleanup of spacing around {} in id
>     tables
>   iio:proximity:ping: White space cleanup of spacing around {} in id
>     tables
>   iio:proximity:rfd77402: White space cleanup of spacing around {} in id
>     tables
>   iio:proximity:srf04: White space cleanup of spacing around {} in id
>     tables
>   iio:proximity:srf08: White space cleanup of spacing around {} in id
>     tables
>   iio:frequency:admv1013: White space cleanup of spacing around {} in id
>     tables
>   iio:adc:mt6577_auxadc: Tidy up white space around {} in id tables
>   iio:adc:hi8435: Tidy up white space around {} in id tables
>   iio:adc:ti-adc084s021: Tidy up white space around {}
>   iio:light:tsl2722: Fix inconsistent spacing before } in id table
>   iio:proximity:vl53l0x: Tidy up white space around {} in id tables
>   iio:accel:dmard09: Tidy up white space around {} in id table
> 
>  drivers/iio/accel/dmard09.c         |  2 +-
>  drivers/iio/adc/hi8435.c            |  2 +-
>  drivers/iio/adc/mt6577_auxadc.c     | 10 +++++-----
>  drivers/iio/adc/ti-adc084s021.c     |  2 +-
>  drivers/iio/chemical/atlas-sensor.c | 10 +++++-----
>  drivers/iio/frequency/admv1013.c    |  2 +-
>  drivers/iio/light/ltr501.c          | 14 +++++++-------
>  drivers/iio/light/pa12203001.c      |  4 ++--
>  drivers/iio/light/tsl2772.c         |  2 +-
>  drivers/iio/light/us5182d.c         |  6 +++---
>  drivers/iio/light/vcnl4035.c        |  2 +-
>  drivers/iio/proximity/ping.c        |  4 ++--
>  drivers/iio/proximity/rfd77402.c    |  2 +-
>  drivers/iio/proximity/srf04.c       | 12 ++++++------
>  drivers/iio/proximity/srf08.c       |  6 +++---
>  drivers/iio/proximity/vl53l0x-i2c.c |  2 +-
>  16 files changed, 41 insertions(+), 41 deletions(-)
> 


^ permalink raw reply	[flat|nested] 34+ messages in thread

end of thread, other threads:[~2022-01-09 14:54 UTC | newest]

Thread overview: 34+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-30 17:48 [PATCH 00/16] IIO: Tidy up inconsistent spacing in ID tables Jonathan Cameron
2021-12-30 17:48 ` [PATCH 01/16] iio:chemical:atlas: Trivial white space cleanup to add space before } Jonathan Cameron
2021-12-31  5:46   ` Gwendal Grignou
2021-12-30 17:48 ` [PATCH 02/16] iio:light:pa12203001: Tidy up white space change to add spaces after { and " Jonathan Cameron
2021-12-31  5:45   ` Gwendal Grignou
2021-12-30 17:48 ` [PATCH 03/16] iio:light:vcnl4035: Trivial whitespace cleanup to add space " Jonathan Cameron
2021-12-31  5:46   ` Gwendal Grignou
2021-12-30 17:48 ` [PATCH 04/16] iio:light:us5182: White space cleanup of spacing around {} in id tables Jonathan Cameron
2021-12-31  5:47   ` Gwendal Grignou
2021-12-30 17:49 ` [PATCH 05/16] iio:light:ltr501: " Jonathan Cameron
2021-12-31  5:47   ` Gwendal Grignou
2021-12-30 17:49 ` [PATCH 06/16] iio:proximity:ping: " Jonathan Cameron
2021-12-31  5:48   ` Gwendal Grignou
2021-12-30 17:49 ` [PATCH 07/16] iio:proximity:rfd77402: " Jonathan Cameron
2021-12-31  5:48   ` Gwendal Grignou
2021-12-30 17:49 ` [PATCH 08/16] iio:proximity:srf04: " Jonathan Cameron
2021-12-31  5:48   ` Gwendal Grignou
2021-12-30 17:49 ` [PATCH 09/16] iio:proximity:srf08: " Jonathan Cameron
2021-12-31  5:49   ` Gwendal Grignou
2021-12-30 17:49 ` [PATCH 10/16] iio:frequency:admv1013: " Jonathan Cameron
2021-12-31  5:49   ` Gwendal Grignou
2021-12-30 17:49 ` [PATCH 11/16] iio:adc:mt6577_auxadc: Tidy up white space " Jonathan Cameron
2021-12-31  5:49   ` Gwendal Grignou
2021-12-30 17:49 ` [PATCH 12/16] iio:adc:hi8435: " Jonathan Cameron
2021-12-31  5:49   ` Gwendal Grignou
2021-12-30 17:49 ` [PATCH 13/16] iio:adc:ti-adc084s021: Tidy up white space around {} Jonathan Cameron
2021-12-31  5:50   ` Gwendal Grignou
2021-12-30 17:49 ` [PATCH 14/16] iio:light:tsl2722: Fix inconsistent spacing before } in id table Jonathan Cameron
2021-12-31  5:50   ` Gwendal Grignou
2021-12-30 17:49 ` [PATCH 15/16] iio:proximity:vl53l0x: Tidy up white space around {} in id tables Jonathan Cameron
2021-12-31  5:50   ` Gwendal Grignou
2021-12-30 17:49 ` [PATCH 16/16] iio:accel:dmard09: Tidy up white space around {} in id table Jonathan Cameron
2021-12-31  5:50   ` Gwendal Grignou
2022-01-09 15:00 ` [PATCH 00/16] IIO: Tidy up inconsistent spacing in ID tables Jonathan Cameron

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.