* Re: [PATCH] staging: rtl8187se: Remove pt_regs * irq handler parameter
@ 2013-08-23 12:19 navin patidar
0 siblings, 0 replies; 3+ messages in thread
From: navin patidar @ 2013-08-23 12:19 UTC (permalink / raw)
To: Dan Carpenter; +Cc: Greg KH, devel, maxtram95, viro, linux-kernel
On August 23, 2013 at 5:18 PM Dan Carpenter <dan.carpenter@oracle.com> wrote:
> On Fri, Aug 23, 2013 at 05:00:06PM +0530, navin patidar wrote:
> > struct pt_regs pointer is no longer passed as a irq handler
> > argument.
> >
>
> Good eye.
>
> Could you also remove the cast to (void *) so the compiler can catch
> this in the future?
>
> - if (request_irq(dev->irq, (void *)rtl8180_interrupt, IRQF_SHARED, dev->name, dev)) {
> + if (request_irq(dev->irq, rtl8180_interrupt, IRQF_SHARED, dev->name, dev)) {
>
i will resend patch with this.
regards,
--navin-patidar
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] staging: rtl8187se: Remove pt_regs * irq handler parameter
2013-08-23 11:30 navin patidar
@ 2013-08-23 11:48 ` Dan Carpenter
0 siblings, 0 replies; 3+ messages in thread
From: Dan Carpenter @ 2013-08-23 11:48 UTC (permalink / raw)
To: navin patidar; +Cc: gregkh, devel, maxtram95, viro, linux-kernel
On Fri, Aug 23, 2013 at 05:00:06PM +0530, navin patidar wrote:
> struct pt_regs pointer is no longer passed as a irq handler
> argument.
>
Good eye.
Could you also remove the cast to (void *) so the compiler can catch
this in the future?
- if (request_irq(dev->irq, (void *)rtl8180_interrupt, IRQF_SHARED, dev->name, dev)) {
+ if (request_irq(dev->irq, rtl8180_interrupt, IRQF_SHARED, dev->name, dev)) {
regrds,
dan carpenter
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] staging: rtl8187se: Remove pt_regs * irq handler parameter
@ 2013-08-23 11:30 navin patidar
2013-08-23 11:48 ` Dan Carpenter
0 siblings, 1 reply; 3+ messages in thread
From: navin patidar @ 2013-08-23 11:30 UTC (permalink / raw)
To: gregkh; +Cc: maxtram95, viro, devel, linux-kernel, navin patidar
struct pt_regs pointer is no longer passed as a irq handler
argument.
Signed-off-by: navin patidar <navinp@cdac.in>
---
drivers/staging/rtl8187se/r8180_core.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8187se/r8180_core.c b/drivers/staging/rtl8187se/r8180_core.c
index ca69155..d722bed 100644
--- a/drivers/staging/rtl8187se/r8180_core.c
+++ b/drivers/staging/rtl8187se/r8180_core.c
@@ -197,7 +197,7 @@ inline void force_pci_posting(struct net_device *dev)
mb();
}
-irqreturn_t rtl8180_interrupt(int irq, void *netdev, struct pt_regs *regs);
+static irqreturn_t rtl8180_interrupt(int irq, void *netdev);
void set_nic_rxring(struct net_device *dev);
void set_nic_txring(struct net_device *dev);
static struct net_device_stats *rtl8180_stats(struct net_device *dev);
@@ -3537,7 +3537,7 @@ void rtl8180_tx_isr(struct net_device *dev, int pri, short error)
spin_unlock_irqrestore(&priv->tx_lock, flag);
}
-irqreturn_t rtl8180_interrupt(int irq, void *netdev, struct pt_regs *regs)
+irqreturn_t rtl8180_interrupt(int irq, void *netdev)
{
struct net_device *dev = (struct net_device *) netdev;
struct r8180_priv *priv = (struct r8180_priv *)ieee80211_priv(dev);
--
1.7.10.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-08-23 12:19 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-08-23 12:19 [PATCH] staging: rtl8187se: Remove pt_regs * irq handler parameter navin patidar
-- strict thread matches above, loose matches on Subject: below --
2013-08-23 11:30 navin patidar
2013-08-23 11:48 ` Dan Carpenter
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.