* [PATCH net-next] vxlan: remove vni zero check and drop for COLLECT_METADATA
@ 2017-02-11 5:38 Roopa Prabhu
2017-02-11 20:09 ` Joe Stringer
2017-02-12 2:26 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Roopa Prabhu @ 2017-02-11 5:38 UTC (permalink / raw)
To: davem; +Cc: netdev, joe
From: Roopa Prabhu <roopa@cumulusnetworks.com>
This patch drops the vni zero check for COLLECT_METADATA mode.
It is not really needed, vni zero is a valid vni.
Fixes: 3ad7a4b141eb ("vxlan: support fdb and learning in COLLECT_METADATA mode"
Reported-by: Joe Stringer <joe@ovn.org>
Signed-off-by: Roopa Prabhu <roopa@cumulusnetworks.com>
---
drivers/net/vxlan.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c
index 2374a75..4e27c5b 100644
--- a/drivers/net/vxlan.c
+++ b/drivers/net/vxlan.c
@@ -1333,9 +1333,6 @@ static int vxlan_rcv(struct sock *sk, struct sk_buff *skb)
vni = vxlan_vni(vxlan_hdr(skb)->vx_vni);
- if ((vs->flags & VXLAN_F_COLLECT_METADATA) && !vni)
- goto drop;
-
vxlan = vxlan_vs_find_vni(vs, vni);
if (!vxlan)
goto drop;
--
1.7.10.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] vxlan: remove vni zero check and drop for COLLECT_METADATA
2017-02-11 5:38 [PATCH net-next] vxlan: remove vni zero check and drop for COLLECT_METADATA Roopa Prabhu
@ 2017-02-11 20:09 ` Joe Stringer
2017-02-12 2:26 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Joe Stringer @ 2017-02-11 20:09 UTC (permalink / raw)
To: Roopa Prabhu; +Cc: David S. Miller, netdev
On 10 February 2017 at 21:38, Roopa Prabhu <roopa@cumulusnetworks.com> wrote:
> From: Roopa Prabhu <roopa@cumulusnetworks.com>
>
> This patch drops the vni zero check for COLLECT_METADATA mode.
> It is not really needed, vni zero is a valid vni.
>
> Fixes: 3ad7a4b141eb ("vxlan: support fdb and learning in COLLECT_METADATA mode"
> Reported-by: Joe Stringer <joe@ovn.org>
> Signed-off-by: Roopa Prabhu <roopa@cumulusnetworks.com>
Thanks, I tried this out and it fixes the issue.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] vxlan: remove vni zero check and drop for COLLECT_METADATA
2017-02-11 5:38 [PATCH net-next] vxlan: remove vni zero check and drop for COLLECT_METADATA Roopa Prabhu
2017-02-11 20:09 ` Joe Stringer
@ 2017-02-12 2:26 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2017-02-12 2:26 UTC (permalink / raw)
To: roopa; +Cc: netdev, joe
From: Roopa Prabhu <roopa@cumulusnetworks.com>
Date: Fri, 10 Feb 2017 21:38:36 -0800
> From: Roopa Prabhu <roopa@cumulusnetworks.com>
>
> This patch drops the vni zero check for COLLECT_METADATA mode.
> It is not really needed, vni zero is a valid vni.
>
> Fixes: 3ad7a4b141eb ("vxlan: support fdb and learning in COLLECT_METADATA mode"
> Reported-by: Joe Stringer <joe@ovn.org>
> Signed-off-by: Roopa Prabhu <roopa@cumulusnetworks.com>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-02-12 2:26 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-02-11 5:38 [PATCH net-next] vxlan: remove vni zero check and drop for COLLECT_METADATA Roopa Prabhu
2017-02-11 20:09 ` Joe Stringer
2017-02-12 2:26 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.