* possible bug in init-ceph.in
@ 2013-11-21 7:23 Dietmar Maurer
2013-11-21 17:18 ` Loic Dachary
0 siblings, 1 reply; 6+ messages in thread
From: Dietmar Maurer @ 2013-11-21 7:23 UTC (permalink / raw)
To: ceph-devel
http://ceph.com/git/?p=ceph.git;a=blob;f=src/init-ceph.in;h=7399abb8f85855f2248c4afb22bf94f2e2f080a2;hb=HEAD
line 320:
if [ "${update_crush:-1}" = "1" -o "{$update_crush:-1}" = "true" ]; then
looks strange to me. Maybe that should be:
- if [ "${update_crush:-1}" = "1" -o "{$update_crush:-1}" = "true" ]; then
+ if [ "${update_crush:-1}" = "1" -o "${update_crush:-1}" = "true" ]; then
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: possible bug in init-ceph.in
2013-11-21 7:23 possible bug in init-ceph.in Dietmar Maurer
@ 2013-11-21 17:18 ` Loic Dachary
2013-11-21 17:57 ` Loic Dachary
0 siblings, 1 reply; 6+ messages in thread
From: Loic Dachary @ 2013-11-21 17:18 UTC (permalink / raw)
To: Dietmar Maurer, ceph-devel
[-- Attachment #1: Type: text/plain, Size: 850 bytes --]
Hi,
I believe there is either a pull request or a ticket with this fix. Definitely a typo ;-)
Cheers
On 21/11/2013 08:23, Dietmar Maurer wrote:
> http://ceph.com/git/?p=ceph.git;a=blob;f=src/init-ceph.in;h=7399abb8f85855f2248c4afb22bf94f2e2f080a2;hb=HEAD
>
> line 320:
>
> if [ "${update_crush:-1}" = "1" -o "{$update_crush:-1}" = "true" ]; then
>
> looks strange to me. Maybe that should be:
>
> - if [ "${update_crush:-1}" = "1" -o "{$update_crush:-1}" = "true" ]; then
> + if [ "${update_crush:-1}" = "1" -o "${update_crush:-1}" = "true" ]; then
>
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
Loïc Dachary, Artisan Logiciel Libre
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 263 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: possible bug in init-ceph.in
2013-11-21 17:18 ` Loic Dachary
@ 2013-11-21 17:57 ` Loic Dachary
2013-11-21 17:59 ` Gregory Farnum
0 siblings, 1 reply; 6+ messages in thread
From: Loic Dachary @ 2013-11-21 17:57 UTC (permalink / raw)
To: Dietmar Maurer, ceph-devel
[-- Attachment #1: Type: text/plain, Size: 1104 bytes --]
Hi,
It turns out there was no pull request or bug report, sorry about that. Here is the pull request with your patch included:
https://github.com/ceph/ceph/pull/861
Cheers
On 21/11/2013 18:18, Loic Dachary wrote:
> Hi,
>
> I believe there is either a pull request or a ticket with this fix. Definitely a typo ;-)
>
> Cheers
>
> On 21/11/2013 08:23, Dietmar Maurer wrote:
>> http://ceph.com/git/?p=ceph.git;a=blob;f=src/init-ceph.in;h=7399abb8f85855f2248c4afb22bf94f2e2f080a2;hb=HEAD
>>
>> line 320:
>>
>> if [ "${update_crush:-1}" = "1" -o "{$update_crush:-1}" = "true" ]; then
>>
>> looks strange to me. Maybe that should be:
>>
>> - if [ "${update_crush:-1}" = "1" -o "{$update_crush:-1}" = "true" ]; then
>> + if [ "${update_crush:-1}" = "1" -o "${update_crush:-1}" = "true" ]; then
>>
>>
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>>
>
--
Loïc Dachary, Artisan Logiciel Libre
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 263 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: possible bug in init-ceph.in
2013-11-21 17:57 ` Loic Dachary
@ 2013-11-21 17:59 ` Gregory Farnum
2013-11-22 4:54 ` Dietmar Maurer
0 siblings, 1 reply; 6+ messages in thread
From: Gregory Farnum @ 2013-11-21 17:59 UTC (permalink / raw)
To: Dietmar Maurer; +Cc: ceph-devel, Loic Dachary
Can we take that diff you provided as coming with a signed-off-by, as
in the pull request Loic generated? :)
-Greg
Software Engineer #42 @ http://inktank.com | http://ceph.com
On Thu, Nov 21, 2013 at 9:57 AM, Loic Dachary <loic@dachary.org> wrote:
> Hi,
>
> It turns out there was no pull request or bug report, sorry about that. Here is the pull request with your patch included:
>
> https://github.com/ceph/ceph/pull/861
>
> Cheers
>
> On 21/11/2013 18:18, Loic Dachary wrote:
>> Hi,
>>
>> I believe there is either a pull request or a ticket with this fix. Definitely a typo ;-)
>>
>> Cheers
>>
>> On 21/11/2013 08:23, Dietmar Maurer wrote:
>>> http://ceph.com/git/?p=ceph.git;a=blob;f=src/init-ceph.in;h=7399abb8f85855f2248c4afb22bf94f2e2f080a2;hb=HEAD
>>>
>>> line 320:
>>>
>>> if [ "${update_crush:-1}" = "1" -o "{$update_crush:-1}" = "true" ]; then
>>>
>>> looks strange to me. Maybe that should be:
>>>
>>> - if [ "${update_crush:-1}" = "1" -o "{$update_crush:-1}" = "true" ]; then
>>> + if [ "${update_crush:-1}" = "1" -o "${update_crush:-1}" = "true" ]; then
>>>
>>>
>>>
>>> --
>>> To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
>>> the body of a message to majordomo@vger.kernel.org
>>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>>>
>>
>
> --
> Loïc Dachary, Artisan Logiciel Libre
>
--
To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: possible bug in init-ceph.in
2013-11-21 17:59 ` Gregory Farnum
@ 2013-11-22 4:54 ` Dietmar Maurer
2013-11-25 6:08 ` Gregory Farnum
0 siblings, 1 reply; 6+ messages in thread
From: Dietmar Maurer @ 2013-11-22 4:54 UTC (permalink / raw)
To: Gregory Farnum; +Cc: ceph-devel, Loic Dachary
> Can we take that diff you provided as coming with a signed-off-by, as in the pull
> request Loic generated? :)
Sure.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: possible bug in init-ceph.in
2013-11-22 4:54 ` Dietmar Maurer
@ 2013-11-25 6:08 ` Gregory Farnum
0 siblings, 0 replies; 6+ messages in thread
From: Gregory Farnum @ 2013-11-25 6:08 UTC (permalink / raw)
To: Dietmar Maurer; +Cc: ceph-devel, Loic Dachary
Merged; thanks guys.
-Greg
Software Engineer #42 @ http://inktank.com | http://ceph.com
On Thu, Nov 21, 2013 at 8:54 PM, Dietmar Maurer <dietmar@proxmox.com> wrote:
>> Can we take that diff you provided as coming with a signed-off-by, as in the pull
>> request Loic generated? :)
>
> Sure.
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2013-11-25 6:08 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-11-21 7:23 possible bug in init-ceph.in Dietmar Maurer
2013-11-21 17:18 ` Loic Dachary
2013-11-21 17:57 ` Loic Dachary
2013-11-21 17:59 ` Gregory Farnum
2013-11-22 4:54 ` Dietmar Maurer
2013-11-25 6:08 ` Gregory Farnum
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.