* Re: [PATCH v2 0/2] [media] Depth confidence pixel-format for Intel RealSense cameras
2018-09-12 6:42 [PATCH v2 0/2] [media] Depth confidence pixel-format for Intel RealSense cameras dorodnic
@ 2018-09-12 6:39 ` Hans Verkuil
2018-10-03 12:08 ` Raikhel, Evgeni
2018-09-12 6:42 ` [PATCH v2 1/2] [media] CNF4 fourcc for 4 bit-per-pixel packed depth confidence information dorodnic
2018-09-12 6:42 ` [PATCH v2 2/2] [media] CNF4 pixel format for media subsystem dorodnic
2 siblings, 1 reply; 10+ messages in thread
From: Hans Verkuil @ 2018-09-12 6:39 UTC (permalink / raw)
To: dorodnic, linux-media; +Cc: laurent.pinchart, evgeni.raikhel, Sergey Dorodnicov
On 09/12/2018 08:42 AM, dorodnic@gmail.com wrote:
> From: Sergey Dorodnicov <sergey.dorodnicov@intel.com>
>
> Define new fourcc describing depth sensor confidence data used in Intel RealSense cameras.
> Confidence information is stored as packed 4 bits per pixel single-plane image.
> The patches were tested on 4.18-rc2 and merged with media_tree/master.
> Addressing code-review comments by Hans Verkuil <hverkuil@xs4all.nl> and
> Laurent Pinchart <laurent.pinchart@ideasonboard.com>.
>
> Sergey Dorodnicov (2):
> CNF4 fourcc for 4 bit-per-pixel packed depth confidence information
> CNF4 pixel format for media subsystem
>
> Documentation/media/uapi/v4l/depth-formats.rst | 1 +
> Documentation/media/uapi/v4l/pixfmt-cnf4.rst | 31 ++++++++++++++++++++++++++
> drivers/media/usb/uvc/uvc_driver.c | 5 +++++
> drivers/media/usb/uvc/uvcvideo.h | 3 +++
> drivers/media/v4l2-core/v4l2-ioctl.c | 1 +
> include/uapi/linux/videodev2.h | 1 +
> 6 files changed, 42 insertions(+)
> create mode 100644 Documentation/media/uapi/v4l/pixfmt-cnf4.rst
>
Laurent, this looks good to me. Do you want to take this series or shall I?
If you take it, then you can add my:
Acked-by: Hans Verkuil <hans.verkuil@cisco.com>
to these patches. If you want me to take it, then I'll need your Ack of course.
Regards,
Hans
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH v2 0/2] [media] Depth confidence pixel-format for Intel RealSense cameras
@ 2018-09-12 6:42 dorodnic
2018-09-12 6:39 ` Hans Verkuil
` (2 more replies)
0 siblings, 3 replies; 10+ messages in thread
From: dorodnic @ 2018-09-12 6:42 UTC (permalink / raw)
To: linux-media; +Cc: laurent.pinchart, evgeni.raikhel, Sergey Dorodnicov
From: Sergey Dorodnicov <sergey.dorodnicov@intel.com>
Define new fourcc describing depth sensor confidence data used in Intel RealSense cameras.
Confidence information is stored as packed 4 bits per pixel single-plane image.
The patches were tested on 4.18-rc2 and merged with media_tree/master.
Addressing code-review comments by Hans Verkuil <hverkuil@xs4all.nl> and
Laurent Pinchart <laurent.pinchart@ideasonboard.com>.
Sergey Dorodnicov (2):
CNF4 fourcc for 4 bit-per-pixel packed depth confidence information
CNF4 pixel format for media subsystem
Documentation/media/uapi/v4l/depth-formats.rst | 1 +
Documentation/media/uapi/v4l/pixfmt-cnf4.rst | 31 ++++++++++++++++++++++++++
drivers/media/usb/uvc/uvc_driver.c | 5 +++++
drivers/media/usb/uvc/uvcvideo.h | 3 +++
drivers/media/v4l2-core/v4l2-ioctl.c | 1 +
include/uapi/linux/videodev2.h | 1 +
6 files changed, 42 insertions(+)
create mode 100644 Documentation/media/uapi/v4l/pixfmt-cnf4.rst
--
2.7.4
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH v2 1/2] [media] CNF4 fourcc for 4 bit-per-pixel packed depth confidence information
2018-09-12 6:42 [PATCH v2 0/2] [media] Depth confidence pixel-format for Intel RealSense cameras dorodnic
2018-09-12 6:39 ` Hans Verkuil
@ 2018-09-12 6:42 ` dorodnic
2018-11-01 16:10 ` Laurent Pinchart
2018-09-12 6:42 ` [PATCH v2 2/2] [media] CNF4 pixel format for media subsystem dorodnic
2 siblings, 1 reply; 10+ messages in thread
From: dorodnic @ 2018-09-12 6:42 UTC (permalink / raw)
To: linux-media; +Cc: laurent.pinchart, evgeni.raikhel, Sergey Dorodnicov
From: Sergey Dorodnicov <sergey.dorodnicov@intel.com>
Adding new fourcc CNF4 for 4 bit-per-pixel packed depth confidence
information provided by Intel RealSense cameras. Every two consecutive
pixels are packed into a single byte.
Signed-off-by: Sergey Dorodnicov <sergey.dorodnicov@intel.com>
Signed-off-by: Evgeni Raikhel <evgeni.raikhel@intel.com>
---
Documentation/media/uapi/v4l/depth-formats.rst | 1 +
Documentation/media/uapi/v4l/pixfmt-cnf4.rst | 31 ++++++++++++++++++++++++++
drivers/media/v4l2-core/v4l2-ioctl.c | 1 +
include/uapi/linux/videodev2.h | 1 +
4 files changed, 34 insertions(+)
create mode 100644 Documentation/media/uapi/v4l/pixfmt-cnf4.rst
diff --git a/Documentation/media/uapi/v4l/depth-formats.rst b/Documentation/media/uapi/v4l/depth-formats.rst
index d1641e9..9533348 100644
--- a/Documentation/media/uapi/v4l/depth-formats.rst
+++ b/Documentation/media/uapi/v4l/depth-formats.rst
@@ -14,3 +14,4 @@ Depth data provides distance to points, mapped onto the image plane
pixfmt-inzi
pixfmt-z16
+ pixfmt-cnf4
diff --git a/Documentation/media/uapi/v4l/pixfmt-cnf4.rst b/Documentation/media/uapi/v4l/pixfmt-cnf4.rst
new file mode 100644
index 0000000..8f46929
--- /dev/null
+++ b/Documentation/media/uapi/v4l/pixfmt-cnf4.rst
@@ -0,0 +1,31 @@
+.. -*- coding: utf-8; mode: rst -*-
+
+.. _V4L2-PIX-FMT-CNF4:
+
+******************************
+V4L2_PIX_FMT_CNF4 ('CNF4')
+******************************
+
+Depth sensor confidence information as a 4 bits per pixel packed array
+
+Description
+===========
+
+Proprietary format used by Intel RealSense Depth cameras containing depth
+confidence information in range 0-15 with 0 indicating that the sensor was
+unable to resolve any signal and 15 indicating maximum level of confidence for
+the specific sensor (actual error margins might change from sensor to sensor).
+
+Every two consecutive pixels are packed into a single byte.
+Bits 0-3 of byte n refer to confidence value of depth pixel 2*n,
+bits 4-7 to confidence value of depth pixel 2*n+1.
+
+**Bit-packed representation.**
+
+.. flat-table::
+ :header-rows: 0
+ :stub-columns: 0
+ :widths: 64 64
+
+ * - Y'\ :sub:`01[3:0]`\ (bits 7--4) Y'\ :sub:`00[3:0]`\ (bits 3--0)
+ - Y'\ :sub:`03[3:0]`\ (bits 7--4) Y'\ :sub:`02[3:0]`\ (bits 3--0)
diff --git a/drivers/media/v4l2-core/v4l2-ioctl.c b/drivers/media/v4l2-core/v4l2-ioctl.c
index 54afc9c..f9aa8bd 100644
--- a/drivers/media/v4l2-core/v4l2-ioctl.c
+++ b/drivers/media/v4l2-core/v4l2-ioctl.c
@@ -1189,6 +1189,7 @@ static void v4l_fill_fmtdesc(struct v4l2_fmtdesc *fmt)
case V4L2_PIX_FMT_Y12I: descr = "Interleaved 12-bit Greyscale"; break;
case V4L2_PIX_FMT_Z16: descr = "16-bit Depth"; break;
case V4L2_PIX_FMT_INZI: descr = "Planar 10:16 Greyscale Depth"; break;
+ case V4L2_PIX_FMT_CNF4: descr = "4-bit Depth Confidence (Packed)"; break;
case V4L2_PIX_FMT_PAL8: descr = "8-bit Palette"; break;
case V4L2_PIX_FMT_UV8: descr = "8-bit Chrominance UV 4-4"; break;
case V4L2_PIX_FMT_YVU410: descr = "Planar YVU 4:1:0"; break;
diff --git a/include/uapi/linux/videodev2.h b/include/uapi/linux/videodev2.h
index 622f047..2837c93 100644
--- a/include/uapi/linux/videodev2.h
+++ b/include/uapi/linux/videodev2.h
@@ -676,6 +676,7 @@ struct v4l2_pix_format {
#define V4L2_PIX_FMT_Z16 v4l2_fourcc('Z', '1', '6', ' ') /* Depth data 16-bit */
#define V4L2_PIX_FMT_MT21C v4l2_fourcc('M', 'T', '2', '1') /* Mediatek compressed block mode */
#define V4L2_PIX_FMT_INZI v4l2_fourcc('I', 'N', 'Z', 'I') /* Intel Planar Greyscale 10-bit and Depth 16-bit */
+#define V4L2_PIX_FMT_CNF4 v4l2_fourcc('C', 'N', 'F', '4') /* Intel 4-bit packed depth confidence information */
/* 10bit raw bayer packed, 32 bytes for every 25 pixels, last LSB 6 bits unused */
#define V4L2_PIX_FMT_IPU3_SBGGR10 v4l2_fourcc('i', 'p', '3', 'b') /* IPU3 packed 10-bit BGGR bayer */
--
2.7.4
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH v2 2/2] [media] CNF4 pixel format for media subsystem
2018-09-12 6:42 [PATCH v2 0/2] [media] Depth confidence pixel-format for Intel RealSense cameras dorodnic
2018-09-12 6:39 ` Hans Verkuil
2018-09-12 6:42 ` [PATCH v2 1/2] [media] CNF4 fourcc for 4 bit-per-pixel packed depth confidence information dorodnic
@ 2018-09-12 6:42 ` dorodnic
2018-11-01 16:10 ` Laurent Pinchart
2 siblings, 1 reply; 10+ messages in thread
From: dorodnic @ 2018-09-12 6:42 UTC (permalink / raw)
To: linux-media; +Cc: laurent.pinchart, evgeni.raikhel, Sergey Dorodnicov
From: Sergey Dorodnicov <sergey.dorodnicov@intel.com>
Registering new GUID used by Intel RealSense cameras with fourcc CNF4,
encoding depth sensor confidence information for every pixel.
Signed-off-by: Sergey Dorodnicov <sergey.dorodnicov@intel.com>
Signed-off-by: Evgeni Raikhel <evgeni.raikhel@intel.com>
---
drivers/media/usb/uvc/uvc_driver.c | 5 +++++
drivers/media/usb/uvc/uvcvideo.h | 3 +++
2 files changed, 8 insertions(+)
diff --git a/drivers/media/usb/uvc/uvc_driver.c b/drivers/media/usb/uvc/uvc_driver.c
index d46dc43..19f129f 100644
--- a/drivers/media/usb/uvc/uvc_driver.c
+++ b/drivers/media/usb/uvc/uvc_driver.c
@@ -214,6 +214,11 @@ static struct uvc_format_desc uvc_fmts[] = {
.guid = UVC_GUID_FORMAT_INZI,
.fcc = V4L2_PIX_FMT_INZI,
},
+ {
+ .name = "4-bit Depth Confidence (Packed)",
+ .guid = UVC_GUID_FORMAT_CNF4,
+ .fcc = V4L2_PIX_FMT_CNF4,
+ },
};
/* ------------------------------------------------------------------------
diff --git a/drivers/media/usb/uvc/uvcvideo.h b/drivers/media/usb/uvc/uvcvideo.h
index e5f5d84..779bab2 100644
--- a/drivers/media/usb/uvc/uvcvideo.h
+++ b/drivers/media/usb/uvc/uvcvideo.h
@@ -154,6 +154,9 @@
#define UVC_GUID_FORMAT_INVI \
{ 'I', 'N', 'V', 'I', 0xdb, 0x57, 0x49, 0x5e, \
0x8e, 0x3f, 0xf4, 0x79, 0x53, 0x2b, 0x94, 0x6f}
+#define UVC_GUID_FORMAT_CNF4 \
+ { 'C', ' ', ' ', ' ', 0x00, 0x00, 0x10, 0x00, \
+ 0x80, 0x00, 0x00, 0xaa, 0x00, 0x38, 0x9b, 0x71}
#define UVC_GUID_FORMAT_D3DFMT_L8 \
{0x32, 0x00, 0x00, 0x00, 0x00, 0x00, 0x10, 0x00, \
--
2.7.4
^ permalink raw reply related [flat|nested] 10+ messages in thread
* RE: [PATCH v2 0/2] [media] Depth confidence pixel-format for Intel RealSense cameras
2018-09-12 6:39 ` Hans Verkuil
@ 2018-10-03 12:08 ` Raikhel, Evgeni
2018-10-03 12:26 ` Hans Verkuil
0 siblings, 1 reply; 10+ messages in thread
From: Raikhel, Evgeni @ 2018-10-03 12:08 UTC (permalink / raw)
To: Hans Verkuil, dorodnic, linux-media; +Cc: laurent.pinchart, Dorodnicov, Sergey
Hans hello,
Can you update this patch series status ?
Thanks in advance,
With regards,
Evgeni
-----Original Message-----
From: Hans Verkuil [mailto:hverkuil@xs4all.nl]
Sent: Wednesday, September 12, 2018 09:40
To: dorodnic@gmail.com; linux-media@vger.kernel.org
Cc: laurent.pinchart@ideasonboard.com; Raikhel, Evgeni <evgeni.raikhel@intel.com>; Dorodnicov, Sergey <sergey.dorodnicov@intel.com>
Subject: Re: [PATCH v2 0/2] [media] Depth confidence pixel-format for Intel RealSense cameras
On 09/12/2018 08:42 AM, dorodnic@gmail.com wrote:
> From: Sergey Dorodnicov <sergey.dorodnicov@intel.com>
>
> Define new fourcc describing depth sensor confidence data used in Intel RealSense cameras.
> Confidence information is stored as packed 4 bits per pixel single-plane image.
> The patches were tested on 4.18-rc2 and merged with media_tree/master.
> Addressing code-review comments by Hans Verkuil <hverkuil@xs4all.nl>
> and Laurent Pinchart <laurent.pinchart@ideasonboard.com>.
>
> Sergey Dorodnicov (2):
> CNF4 fourcc for 4 bit-per-pixel packed depth confidence information
> CNF4 pixel format for media subsystem
>
> Documentation/media/uapi/v4l/depth-formats.rst | 1 +
> Documentation/media/uapi/v4l/pixfmt-cnf4.rst | 31 ++++++++++++++++++++++++++
> drivers/media/usb/uvc/uvc_driver.c | 5 +++++
> drivers/media/usb/uvc/uvcvideo.h | 3 +++
> drivers/media/v4l2-core/v4l2-ioctl.c | 1 +
> include/uapi/linux/videodev2.h | 1 +
> 6 files changed, 42 insertions(+)
> create mode 100644 Documentation/media/uapi/v4l/pixfmt-cnf4.rst
>
Laurent, this looks good to me. Do you want to take this series or shall I?
If you take it, then you can add my:
Acked-by: Hans Verkuil <hans.verkuil@cisco.com>
to these patches. If you want me to take it, then I'll need your Ack of course.
Regards,
Hans
---------------------------------------------------------------------
Intel Israel (74) Limited
This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v2 0/2] [media] Depth confidence pixel-format for Intel RealSense cameras
2018-10-03 12:08 ` Raikhel, Evgeni
@ 2018-10-03 12:26 ` Hans Verkuil
2018-11-01 14:42 ` Sergey Dorodnic
0 siblings, 1 reply; 10+ messages in thread
From: Hans Verkuil @ 2018-10-03 12:26 UTC (permalink / raw)
To: Raikhel, Evgeni, dorodnic, linux-media
Cc: laurent.pinchart, Dorodnicov, Sergey
On 10/03/18 14:08, Raikhel, Evgeni wrote:
> Hans hello,
>
> Can you update this patch series status ?
> Thanks in advance,
>
> With regards,
> Evgeni
>
> -----Original Message-----
> From: Hans Verkuil [mailto:hverkuil@xs4all.nl]
> Sent: Wednesday, September 12, 2018 09:40
> To: dorodnic@gmail.com; linux-media@vger.kernel.org
> Cc: laurent.pinchart@ideasonboard.com; Raikhel, Evgeni <evgeni.raikhel@intel.com>; Dorodnicov, Sergey <sergey.dorodnicov@intel.com>
> Subject: Re: [PATCH v2 0/2] [media] Depth confidence pixel-format for Intel RealSense cameras
>
> On 09/12/2018 08:42 AM, dorodnic@gmail.com wrote:
>> From: Sergey Dorodnicov <sergey.dorodnicov@intel.com>
>>
>> Define new fourcc describing depth sensor confidence data used in Intel RealSense cameras.
>> Confidence information is stored as packed 4 bits per pixel single-plane image.
>> The patches were tested on 4.18-rc2 and merged with media_tree/master.
>> Addressing code-review comments by Hans Verkuil <hverkuil@xs4all.nl>
>> and Laurent Pinchart <laurent.pinchart@ideasonboard.com>.
>>
>> Sergey Dorodnicov (2):
>> CNF4 fourcc for 4 bit-per-pixel packed depth confidence information
>> CNF4 pixel format for media subsystem
>>
>> Documentation/media/uapi/v4l/depth-formats.rst | 1 +
>> Documentation/media/uapi/v4l/pixfmt-cnf4.rst | 31 ++++++++++++++++++++++++++
>> drivers/media/usb/uvc/uvc_driver.c | 5 +++++
>> drivers/media/usb/uvc/uvcvideo.h | 3 +++
>> drivers/media/v4l2-core/v4l2-ioctl.c | 1 +
>> include/uapi/linux/videodev2.h | 1 +
>> 6 files changed, 42 insertions(+)
>> create mode 100644 Documentation/media/uapi/v4l/pixfmt-cnf4.rst
>>
>
> Laurent, this looks good to me. Do you want to take this series or shall I?
>
> If you take it, then you can add my:
>
> Acked-by: Hans Verkuil <hans.verkuil@cisco.com>
>
> to these patches. If you want me to take it, then I'll need your Ack of course.
Still waiting for a reply from Laurent. But thanks for reminding us,
I've pinged Laurent and he will hopefully come back with an Ack or review
by the end of the week.
Regards,
Hans
>
> Regards,
>
> Hans
> ---------------------------------------------------------------------
> Intel Israel (74) Limited
>
> This e-mail and any attachments may contain confidential material for
> the sole use of the intended recipient(s). Any review or distribution
> by others is strictly prohibited. If you are not the intended
> recipient, please contact the sender and delete all copies.
>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v2 0/2] [media] Depth confidence pixel-format for Intel RealSense cameras
2018-10-03 12:26 ` Hans Verkuil
@ 2018-11-01 14:42 ` Sergey Dorodnic
0 siblings, 0 replies; 10+ messages in thread
From: Sergey Dorodnic @ 2018-11-01 14:42 UTC (permalink / raw)
To: hverkuil
Cc: Evgeni Raikhel, linux-media, laurent.pinchart, Dorodnicov, Sergey
Hello Hans, Laurent
Could you please comment on this topic?
If the patches require any additional work, we will be eager to address it.
For now we are publishing a custom DKMS, but it would be great to see
better 3D-camera hardware support in the near future.
Regards,
Sergey
(sorry, re-sending in plain-text mode)
On Wed, Oct 3, 2018 at 5:27 AM Hans Verkuil <hverkuil@xs4all.nl> wrote:
>
> On 10/03/18 14:08, Raikhel, Evgeni wrote:
> > Hans hello,
> >
> > Can you update this patch series status ?
> > Thanks in advance,
> >
> > With regards,
> > Evgeni
> >
> > -----Original Message-----
> > From: Hans Verkuil [mailto:hverkuil@xs4all.nl]
> > Sent: Wednesday, September 12, 2018 09:40
> > To: dorodnic@gmail.com; linux-media@vger.kernel.org
> > Cc: laurent.pinchart@ideasonboard.com; Raikhel, Evgeni <evgeni.raikhel@intel.com>; Dorodnicov, Sergey <sergey.dorodnicov@intel.com>
> > Subject: Re: [PATCH v2 0/2] [media] Depth confidence pixel-format for Intel RealSense cameras
> >
> > On 09/12/2018 08:42 AM, dorodnic@gmail.com wrote:
> >> From: Sergey Dorodnicov <sergey.dorodnicov@intel.com>
> >>
> >> Define new fourcc describing depth sensor confidence data used in Intel RealSense cameras.
> >> Confidence information is stored as packed 4 bits per pixel single-plane image.
> >> The patches were tested on 4.18-rc2 and merged with media_tree/master.
> >> Addressing code-review comments by Hans Verkuil <hverkuil@xs4all.nl>
> >> and Laurent Pinchart <laurent.pinchart@ideasonboard.com>.
> >>
> >> Sergey Dorodnicov (2):
> >> CNF4 fourcc for 4 bit-per-pixel packed depth confidence information
> >> CNF4 pixel format for media subsystem
> >>
> >> Documentation/media/uapi/v4l/depth-formats.rst | 1 +
> >> Documentation/media/uapi/v4l/pixfmt-cnf4.rst | 31 ++++++++++++++++++++++++++
> >> drivers/media/usb/uvc/uvc_driver.c | 5 +++++
> >> drivers/media/usb/uvc/uvcvideo.h | 3 +++
> >> drivers/media/v4l2-core/v4l2-ioctl.c | 1 +
> >> include/uapi/linux/videodev2.h | 1 +
> >> 6 files changed, 42 insertions(+)
> >> create mode 100644 Documentation/media/uapi/v4l/pixfmt-cnf4.rst
> >>
> >
> > Laurent, this looks good to me. Do you want to take this series or shall I?
> >
> > If you take it, then you can add my:
> >
> > Acked-by: Hans Verkuil <hans.verkuil@cisco.com>
> >
> > to these patches. If you want me to take it, then I'll need your Ack of course.
>
> Still waiting for a reply from Laurent. But thanks for reminding us,
> I've pinged Laurent and he will hopefully come back with an Ack or review
> by the end of the week.
>
> Regards,
>
> Hans
>
> >
> > Regards,
> >
> > Hans
> > ---------------------------------------------------------------------
> > Intel Israel (74) Limited
> >
> > This e-mail and any attachments may contain confidential material for
> > the sole use of the intended recipient(s). Any review or distribution
> > by others is strictly prohibited. If you are not the intended
> > recipient, please contact the sender and delete all copies.
> >
>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v2 1/2] [media] CNF4 fourcc for 4 bit-per-pixel packed depth confidence information
2018-09-12 6:42 ` [PATCH v2 1/2] [media] CNF4 fourcc for 4 bit-per-pixel packed depth confidence information dorodnic
@ 2018-11-01 16:10 ` Laurent Pinchart
0 siblings, 0 replies; 10+ messages in thread
From: Laurent Pinchart @ 2018-11-01 16:10 UTC (permalink / raw)
To: dorodnic; +Cc: linux-media, evgeni.raikhel, Sergey Dorodnicov
Hi Sergey,
Thank you for the patch.
The subject line should start with an appropriate prefix. I propose rewriting
it as
media: v4l: Add 4bpp packed depth confidence format CNF4
Apart from that the patch looks good to me,
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
If you're fine with the subject line change there's no need to resubmit, I'll
fix it when applying the patch to my tree.
On Wednesday, 12 September 2018 09:42:06 EET dorodnic@gmail.com wrote:
> From: Sergey Dorodnicov <sergey.dorodnicov@intel.com>
>
> Adding new fourcc CNF4 for 4 bit-per-pixel packed depth confidence
> information provided by Intel RealSense cameras. Every two consecutive
> pixels are packed into a single byte.
>
> Signed-off-by: Sergey Dorodnicov <sergey.dorodnicov@intel.com>
> Signed-off-by: Evgeni Raikhel <evgeni.raikhel@intel.com>
> ---
> Documentation/media/uapi/v4l/depth-formats.rst | 1 +
> Documentation/media/uapi/v4l/pixfmt-cnf4.rst | 31 +++++++++++++++++++++++
> drivers/media/v4l2-core/v4l2-ioctl.c | 1 +
> include/uapi/linux/videodev2.h | 1 +
> 4 files changed, 34 insertions(+)
> create mode 100644 Documentation/media/uapi/v4l/pixfmt-cnf4.rst
>
> diff --git a/Documentation/media/uapi/v4l/depth-formats.rst
> b/Documentation/media/uapi/v4l/depth-formats.rst index d1641e9..9533348
> 100644
> --- a/Documentation/media/uapi/v4l/depth-formats.rst
> +++ b/Documentation/media/uapi/v4l/depth-formats.rst
> @@ -14,3 +14,4 @@ Depth data provides distance to points, mapped onto the
> image plane
>
> pixfmt-inzi
> pixfmt-z16
> + pixfmt-cnf4
> diff --git a/Documentation/media/uapi/v4l/pixfmt-cnf4.rst
> b/Documentation/media/uapi/v4l/pixfmt-cnf4.rst new file mode 100644
> index 0000000..8f46929
> --- /dev/null
> +++ b/Documentation/media/uapi/v4l/pixfmt-cnf4.rst
> @@ -0,0 +1,31 @@
> +.. -*- coding: utf-8; mode: rst -*-
> +
> +.. _V4L2-PIX-FMT-CNF4:
> +
> +******************************
> +V4L2_PIX_FMT_CNF4 ('CNF4')
> +******************************
> +
> +Depth sensor confidence information as a 4 bits per pixel packed array
> +
> +Description
> +===========
> +
> +Proprietary format used by Intel RealSense Depth cameras containing depth
> +confidence information in range 0-15 with 0 indicating that the sensor was
> +unable to resolve any signal and 15 indicating maximum level of confidence
> for +the specific sensor (actual error margins might change from sensor to
> sensor). +
> +Every two consecutive pixels are packed into a single byte.
> +Bits 0-3 of byte n refer to confidence value of depth pixel 2*n,
> +bits 4-7 to confidence value of depth pixel 2*n+1.
> +
> +**Bit-packed representation.**
> +
> +.. flat-table::
> + :header-rows: 0
> + :stub-columns: 0
> + :widths: 64 64
> +
> + * - Y'\ :sub:`01[3:0]`\ (bits 7--4) Y'\ :sub:`00[3:0]`\ (bits 3--0)
> + - Y'\ :sub:`03[3:0]`\ (bits 7--4) Y'\ :sub:`02[3:0]`\ (bits 3--0)
> diff --git a/drivers/media/v4l2-core/v4l2-ioctl.c
> b/drivers/media/v4l2-core/v4l2-ioctl.c index 54afc9c..f9aa8bd 100644
> --- a/drivers/media/v4l2-core/v4l2-ioctl.c
> +++ b/drivers/media/v4l2-core/v4l2-ioctl.c
> @@ -1189,6 +1189,7 @@ static void v4l_fill_fmtdesc(struct v4l2_fmtdesc *fmt)
> case V4L2_PIX_FMT_Y12I: descr = "Interleaved 12-bit Greyscale"; break;
> case V4L2_PIX_FMT_Z16: descr = "16-bit Depth"; break;
> case V4L2_PIX_FMT_INZI: descr = "Planar 10:16 Greyscale Depth"; break;
> + case V4L2_PIX_FMT_CNF4: descr = "4-bit Depth Confidence (Packed)";
break;
> case V4L2_PIX_FMT_PAL8: descr = "8-bit Palette"; break;
> case V4L2_PIX_FMT_UV8: descr = "8-bit Chrominance UV 4-4"; break;
> case V4L2_PIX_FMT_YVU410: descr = "Planar YVU 4:1:0"; break;
> diff --git a/include/uapi/linux/videodev2.h b/include/uapi/linux/videodev2.h
> index 622f047..2837c93 100644
> --- a/include/uapi/linux/videodev2.h
> +++ b/include/uapi/linux/videodev2.h
> @@ -676,6 +676,7 @@ struct v4l2_pix_format {
> #define V4L2_PIX_FMT_Z16 v4l2_fourcc('Z', '1', '6', ' ') /* Depth data
> 16-bit */ #define V4L2_PIX_FMT_MT21C v4l2_fourcc('M', 'T', '2', '1') /*
> Mediatek compressed block mode */ #define V4L2_PIX_FMT_INZI
> v4l2_fourcc('I', 'N', 'Z', 'I') /* Intel Planar Greyscale 10-bit and Depth
> 16-bit */ +#define V4L2_PIX_FMT_CNF4 v4l2_fourcc('C', 'N', 'F', '4') /*
> Intel 4-bit packed depth confidence information */
>
> /* 10bit raw bayer packed, 32 bytes for every 25 pixels, last LSB 6 bits
> unused */ #define V4L2_PIX_FMT_IPU3_SBGGR10 v4l2_fourcc('i', 'p', '3',
'b')
> /* IPU3 packed 10-bit BGGR bayer */
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v2 2/2] [media] CNF4 pixel format for media subsystem
2018-09-12 6:42 ` [PATCH v2 2/2] [media] CNF4 pixel format for media subsystem dorodnic
@ 2018-11-01 16:10 ` Laurent Pinchart
2018-11-04 16:10 ` Sergey Dorodnic
0 siblings, 1 reply; 10+ messages in thread
From: Laurent Pinchart @ 2018-11-01 16:10 UTC (permalink / raw)
To: dorodnic; +Cc: linux-media, evgeni.raikhel, Sergey Dorodnicov
Hi Sergey,
Thank you for the patch.
As for patch 1/2, the subject line needs a prefix. Furthermore it doesn't
really describe the patch. I propose writing it as
media: uvcvideo: Add support for the CNF4 format
On Wednesday, 12 September 2018 09:42:07 EET dorodnic@gmail.com wrote:
> From: Sergey Dorodnicov <sergey.dorodnicov@intel.com>
>
> Registering new GUID used by Intel RealSense cameras with fourcc CNF4,
> encoding depth sensor confidence information for every pixel.
And there I would write "Register the GUID ...".
Apart from that the patch looks good to me,
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
If you're fine with the subject line change there's no need to resubmit, I'll
fix it when applying the patch to my tree.
> Signed-off-by: Sergey Dorodnicov <sergey.dorodnicov@intel.com>
> Signed-off-by: Evgeni Raikhel <evgeni.raikhel@intel.com>
> ---
> drivers/media/usb/uvc/uvc_driver.c | 5 +++++
> drivers/media/usb/uvc/uvcvideo.h | 3 +++
> 2 files changed, 8 insertions(+)
>
> diff --git a/drivers/media/usb/uvc/uvc_driver.c
> b/drivers/media/usb/uvc/uvc_driver.c index d46dc43..19f129f 100644
> --- a/drivers/media/usb/uvc/uvc_driver.c
> +++ b/drivers/media/usb/uvc/uvc_driver.c
> @@ -214,6 +214,11 @@ static struct uvc_format_desc uvc_fmts[] = {
> .guid = UVC_GUID_FORMAT_INZI,
> .fcc = V4L2_PIX_FMT_INZI,
> },
> + {
> + .name = "4-bit Depth Confidence (Packed)",
> + .guid = UVC_GUID_FORMAT_CNF4,
> + .fcc = V4L2_PIX_FMT_CNF4,
> + },
> };
>
> /* ------------------------------------------------------------------------
> diff --git a/drivers/media/usb/uvc/uvcvideo.h
> b/drivers/media/usb/uvc/uvcvideo.h index e5f5d84..779bab2 100644
> --- a/drivers/media/usb/uvc/uvcvideo.h
> +++ b/drivers/media/usb/uvc/uvcvideo.h
> @@ -154,6 +154,9 @@
> #define UVC_GUID_FORMAT_INVI \
> { 'I', 'N', 'V', 'I', 0xdb, 0x57, 0x49, 0x5e, \
> 0x8e, 0x3f, 0xf4, 0x79, 0x53, 0x2b, 0x94, 0x6f}
> +#define UVC_GUID_FORMAT_CNF4 \
> + { 'C', ' ', ' ', ' ', 0x00, 0x00, 0x10, 0x00, \
> + 0x80, 0x00, 0x00, 0xaa, 0x00, 0x38, 0x9b, 0x71}
>
> #define UVC_GUID_FORMAT_D3DFMT_L8 \
> {0x32, 0x00, 0x00, 0x00, 0x00, 0x00, 0x10, 0x00, \
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v2 2/2] [media] CNF4 pixel format for media subsystem
2018-11-01 16:10 ` Laurent Pinchart
@ 2018-11-04 16:10 ` Sergey Dorodnic
0 siblings, 0 replies; 10+ messages in thread
From: Sergey Dorodnic @ 2018-11-04 16:10 UTC (permalink / raw)
To: laurent.pinchart; +Cc: linux-media, Evgeni Raikhel, Dorodnicov, Sergey
Hello Laurent,
Thank you for the review and the comments.
Please modify the subject / description as you see fit.
I will make sure to use the right prefix in future submissions.
Best regards,
Sergey
On Thu, Nov 1, 2018 at 9:10 AM Laurent Pinchart
<laurent.pinchart@ideasonboard.com> wrote:
>
> Hi Sergey,
>
> Thank you for the patch.
>
> As for patch 1/2, the subject line needs a prefix. Furthermore it doesn't
> really describe the patch. I propose writing it as
>
> media: uvcvideo: Add support for the CNF4 format
>
> On Wednesday, 12 September 2018 09:42:07 EET dorodnic@gmail.com wrote:
> > From: Sergey Dorodnicov <sergey.dorodnicov@intel.com>
> >
> > Registering new GUID used by Intel RealSense cameras with fourcc CNF4,
> > encoding depth sensor confidence information for every pixel.
>
> And there I would write "Register the GUID ...".
>
> Apart from that the patch looks good to me,
>
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>
> If you're fine with the subject line change there's no need to resubmit, I'll
> fix it when applying the patch to my tree.
>
> > Signed-off-by: Sergey Dorodnicov <sergey.dorodnicov@intel.com>
> > Signed-off-by: Evgeni Raikhel <evgeni.raikhel@intel.com>
> > ---
> > drivers/media/usb/uvc/uvc_driver.c | 5 +++++
> > drivers/media/usb/uvc/uvcvideo.h | 3 +++
> > 2 files changed, 8 insertions(+)
> >
> > diff --git a/drivers/media/usb/uvc/uvc_driver.c
> > b/drivers/media/usb/uvc/uvc_driver.c index d46dc43..19f129f 100644
> > --- a/drivers/media/usb/uvc/uvc_driver.c
> > +++ b/drivers/media/usb/uvc/uvc_driver.c
> > @@ -214,6 +214,11 @@ static struct uvc_format_desc uvc_fmts[] = {
> > .guid = UVC_GUID_FORMAT_INZI,
> > .fcc = V4L2_PIX_FMT_INZI,
> > },
> > + {
> > + .name = "4-bit Depth Confidence (Packed)",
> > + .guid = UVC_GUID_FORMAT_CNF4,
> > + .fcc = V4L2_PIX_FMT_CNF4,
> > + },
> > };
> >
> > /* ------------------------------------------------------------------------
> > diff --git a/drivers/media/usb/uvc/uvcvideo.h
> > b/drivers/media/usb/uvc/uvcvideo.h index e5f5d84..779bab2 100644
> > --- a/drivers/media/usb/uvc/uvcvideo.h
> > +++ b/drivers/media/usb/uvc/uvcvideo.h
> > @@ -154,6 +154,9 @@
> > #define UVC_GUID_FORMAT_INVI \
> > { 'I', 'N', 'V', 'I', 0xdb, 0x57, 0x49, 0x5e, \
> > 0x8e, 0x3f, 0xf4, 0x79, 0x53, 0x2b, 0x94, 0x6f}
> > +#define UVC_GUID_FORMAT_CNF4 \
> > + { 'C', ' ', ' ', ' ', 0x00, 0x00, 0x10, 0x00, \
> > + 0x80, 0x00, 0x00, 0xaa, 0x00, 0x38, 0x9b, 0x71}
> >
> > #define UVC_GUID_FORMAT_D3DFMT_L8 \
> > {0x32, 0x00, 0x00, 0x00, 0x00, 0x00, 0x10, 0x00, \
>
> --
> Regards,
>
> Laurent Pinchart
>
>
>
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2018-11-05 1:31 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-09-12 6:42 [PATCH v2 0/2] [media] Depth confidence pixel-format for Intel RealSense cameras dorodnic
2018-09-12 6:39 ` Hans Verkuil
2018-10-03 12:08 ` Raikhel, Evgeni
2018-10-03 12:26 ` Hans Verkuil
2018-11-01 14:42 ` Sergey Dorodnic
2018-09-12 6:42 ` [PATCH v2 1/2] [media] CNF4 fourcc for 4 bit-per-pixel packed depth confidence information dorodnic
2018-11-01 16:10 ` Laurent Pinchart
2018-09-12 6:42 ` [PATCH v2 2/2] [media] CNF4 pixel format for media subsystem dorodnic
2018-11-01 16:10 ` Laurent Pinchart
2018-11-04 16:10 ` Sergey Dorodnic
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.