All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] virtio-gpu: fix a missing check to avoid NULL dereference
@ 2022-03-27  5:09 ` Xiaomeng Tong
  0 siblings, 0 replies; 5+ messages in thread
From: Xiaomeng Tong @ 2022-03-27  5:09 UTC (permalink / raw)
  To: airlied
  Cc: kraxel, gurchetansingh, olvaffe, daniel, airlied, dri-devel,
	virtualization, linux-kernel, Xiaomeng Tong

'cache_ent' could be set NULL inside virtio_gpu_cmd_get_capset()
and it will lead to a NULL dereference by a lately use of it
(i.e., ptr = cache_ent->caps_cache). Fix it with a NULL check.

Fixes: 62fb7a5e10962 ("virtio-gpu: add 3d/virgl support")
Signed-off-by: Xiaomeng Tong <xiam0nd.tong@gmail.com>
---
 drivers/gpu/drm/virtio/virtgpu_ioctl.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/virtio/virtgpu_ioctl.c b/drivers/gpu/drm/virtio/virtgpu_ioctl.c
index c708bab555c6..b0f1c4d8fd23 100644
--- a/drivers/gpu/drm/virtio/virtgpu_ioctl.c
+++ b/drivers/gpu/drm/virtio/virtgpu_ioctl.c
@@ -579,8 +579,10 @@ static int virtio_gpu_get_caps_ioctl(struct drm_device *dev,
 	spin_unlock(&vgdev->display_info_lock);
 
 	/* not in cache - need to talk to hw */
-	virtio_gpu_cmd_get_capset(vgdev, found_valid, args->cap_set_ver,
+	ret = virtio_gpu_cmd_get_capset(vgdev, found_valid, args->cap_set_ver,
 				  &cache_ent);
+	if (ret)
+		return ret;
 	virtio_gpu_notify(vgdev);
 
 copy_exit:

base-commit: f443e374ae131c168a065ea1748feac6b2e76613
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 5+ messages in thread
* [PATCH] virtio-gpu: fix a missing check to avoid NULL dereference
@ 2022-03-27  5:09 ` Xiaomeng Tong
  0 siblings, 0 replies; 5+ messages in thread
From: Xiaomeng Tong @ 2022-03-27  5:09 UTC (permalink / raw)
  To: airlied
  Cc: linux-kernel, dri-devel, gurchetansingh, Xiaomeng Tong, kraxel,
	airlied, virtualization

'cache_ent' could be set NULL inside virtio_gpu_cmd_get_capset()
and it will lead to a NULL dereference by a lately use of it
(i.e., ptr = cache_ent->caps_cache). Fix it with a NULL check.

Fixes: 62fb7a5e10962 ("virtio-gpu: add 3d/virgl support")
Signed-off-by: Xiaomeng Tong <xiam0nd.tong@gmail.com>
---
 drivers/gpu/drm/virtio/virtgpu_ioctl.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/virtio/virtgpu_ioctl.c b/drivers/gpu/drm/virtio/virtgpu_ioctl.c
index c708bab555c6..b0f1c4d8fd23 100644
--- a/drivers/gpu/drm/virtio/virtgpu_ioctl.c
+++ b/drivers/gpu/drm/virtio/virtgpu_ioctl.c
@@ -579,8 +579,10 @@ static int virtio_gpu_get_caps_ioctl(struct drm_device *dev,
 	spin_unlock(&vgdev->display_info_lock);
 
 	/* not in cache - need to talk to hw */
-	virtio_gpu_cmd_get_capset(vgdev, found_valid, args->cap_set_ver,
+	ret = virtio_gpu_cmd_get_capset(vgdev, found_valid, args->cap_set_ver,
 				  &cache_ent);
+	if (ret)
+		return ret;
 	virtio_gpu_notify(vgdev);
 
 copy_exit:

base-commit: f443e374ae131c168a065ea1748feac6b2e76613
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 5+ messages in thread
* Re: [PATCH] virtio-gpu: fix a missing check to avoid NULL dereference
  2022-03-27  5:09 ` Xiaomeng Tong
  (?)
@ 2022-03-28 21:08   ` Chia-I Wu
  -1 siblings, 0 replies; 5+ messages in thread
From: Chia-I Wu @ 2022-03-28 21:08 UTC (permalink / raw)
  To: Xiaomeng Tong
  Cc: David Airlie, Gerd Hoffmann, Gurchetan Singh, Daniel Vetter,
	Dave Airlie, ML dri-devel, open list:VIRTIO CORE,
	NET AND BLOCK DRIVERS, open list

On Sat, Mar 26, 2022 at 10:09 PM Xiaomeng Tong <xiam0nd.tong@gmail.com> wrote:
>
> 'cache_ent' could be set NULL inside virtio_gpu_cmd_get_capset()
> and it will lead to a NULL dereference by a lately use of it
> (i.e., ptr = cache_ent->caps_cache). Fix it with a NULL check.
>
> Fixes: 62fb7a5e10962 ("virtio-gpu: add 3d/virgl support")
> Signed-off-by: Xiaomeng Tong <xiam0nd.tong@gmail.com>
Reviewed-by: Chia-I Wu <olvaffe@gmail.com>
> ---
>  drivers/gpu/drm/virtio/virtgpu_ioctl.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/virtio/virtgpu_ioctl.c b/drivers/gpu/drm/virtio/virtgpu_ioctl.c
> index c708bab555c6..b0f1c4d8fd23 100644
> --- a/drivers/gpu/drm/virtio/virtgpu_ioctl.c
> +++ b/drivers/gpu/drm/virtio/virtgpu_ioctl.c
> @@ -579,8 +579,10 @@ static int virtio_gpu_get_caps_ioctl(struct drm_device *dev,
>         spin_unlock(&vgdev->display_info_lock);
>
>         /* not in cache - need to talk to hw */
> -       virtio_gpu_cmd_get_capset(vgdev, found_valid, args->cap_set_ver,
> +       ret = virtio_gpu_cmd_get_capset(vgdev, found_valid, args->cap_set_ver,
>                                   &cache_ent);
> +       if (ret)
> +               return ret;
>         virtio_gpu_notify(vgdev);
>
>  copy_exit:
>
> base-commit: f443e374ae131c168a065ea1748feac6b2e76613
> --
> 2.17.1
>

^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [PATCH] virtio-gpu: fix a missing check to avoid NULL dereference
@ 2022-03-28 21:08   ` Chia-I Wu
  0 siblings, 0 replies; 5+ messages in thread
From: Chia-I Wu @ 2022-03-28 21:08 UTC (permalink / raw)
  To: Xiaomeng Tong
  Cc: David Airlie, open list, ML dri-devel, Gurchetan Singh,
	Daniel Vetter, Dave Airlie, open list:VIRTIO CORE,
	NET AND BLOCK DRIVERS

On Sat, Mar 26, 2022 at 10:09 PM Xiaomeng Tong <xiam0nd.tong@gmail.com> wrote:
>
> 'cache_ent' could be set NULL inside virtio_gpu_cmd_get_capset()
> and it will lead to a NULL dereference by a lately use of it
> (i.e., ptr = cache_ent->caps_cache). Fix it with a NULL check.
>
> Fixes: 62fb7a5e10962 ("virtio-gpu: add 3d/virgl support")
> Signed-off-by: Xiaomeng Tong <xiam0nd.tong@gmail.com>
Reviewed-by: Chia-I Wu <olvaffe@gmail.com>
> ---
>  drivers/gpu/drm/virtio/virtgpu_ioctl.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/virtio/virtgpu_ioctl.c b/drivers/gpu/drm/virtio/virtgpu_ioctl.c
> index c708bab555c6..b0f1c4d8fd23 100644
> --- a/drivers/gpu/drm/virtio/virtgpu_ioctl.c
> +++ b/drivers/gpu/drm/virtio/virtgpu_ioctl.c
> @@ -579,8 +579,10 @@ static int virtio_gpu_get_caps_ioctl(struct drm_device *dev,
>         spin_unlock(&vgdev->display_info_lock);
>
>         /* not in cache - need to talk to hw */
> -       virtio_gpu_cmd_get_capset(vgdev, found_valid, args->cap_set_ver,
> +       ret = virtio_gpu_cmd_get_capset(vgdev, found_valid, args->cap_set_ver,
>                                   &cache_ent);
> +       if (ret)
> +               return ret;
>         virtio_gpu_notify(vgdev);
>
>  copy_exit:
>
> base-commit: f443e374ae131c168a065ea1748feac6b2e76613
> --
> 2.17.1
>
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization

^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [PATCH] virtio-gpu: fix a missing check to avoid NULL dereference
@ 2022-03-28 21:08   ` Chia-I Wu
  0 siblings, 0 replies; 5+ messages in thread
From: Chia-I Wu @ 2022-03-28 21:08 UTC (permalink / raw)
  To: Xiaomeng Tong
  Cc: David Airlie, open list, ML dri-devel, Gurchetan Singh,
	Gerd Hoffmann, Dave Airlie, open list:VIRTIO CORE,
	NET AND BLOCK DRIVERS

On Sat, Mar 26, 2022 at 10:09 PM Xiaomeng Tong <xiam0nd.tong@gmail.com> wrote:
>
> 'cache_ent' could be set NULL inside virtio_gpu_cmd_get_capset()
> and it will lead to a NULL dereference by a lately use of it
> (i.e., ptr = cache_ent->caps_cache). Fix it with a NULL check.
>
> Fixes: 62fb7a5e10962 ("virtio-gpu: add 3d/virgl support")
> Signed-off-by: Xiaomeng Tong <xiam0nd.tong@gmail.com>
Reviewed-by: Chia-I Wu <olvaffe@gmail.com>
> ---
>  drivers/gpu/drm/virtio/virtgpu_ioctl.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/virtio/virtgpu_ioctl.c b/drivers/gpu/drm/virtio/virtgpu_ioctl.c
> index c708bab555c6..b0f1c4d8fd23 100644
> --- a/drivers/gpu/drm/virtio/virtgpu_ioctl.c
> +++ b/drivers/gpu/drm/virtio/virtgpu_ioctl.c
> @@ -579,8 +579,10 @@ static int virtio_gpu_get_caps_ioctl(struct drm_device *dev,
>         spin_unlock(&vgdev->display_info_lock);
>
>         /* not in cache - need to talk to hw */
> -       virtio_gpu_cmd_get_capset(vgdev, found_valid, args->cap_set_ver,
> +       ret = virtio_gpu_cmd_get_capset(vgdev, found_valid, args->cap_set_ver,
>                                   &cache_ent);
> +       if (ret)
> +               return ret;
>         virtio_gpu_notify(vgdev);
>
>  copy_exit:
>
> base-commit: f443e374ae131c168a065ea1748feac6b2e76613
> --
> 2.17.1
>

^ permalink raw reply	[flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-03-28 21:08 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-27  5:09 [PATCH] virtio-gpu: fix a missing check to avoid NULL dereference Xiaomeng Tong
2022-03-27  5:09 ` Xiaomeng Tong
2022-03-28 21:08 ` Chia-I Wu
2022-03-28 21:08   ` Chia-I Wu
2022-03-28 21:08   ` Chia-I Wu

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.