[PATCH] xen: delete references to xenstored.socket and xenstored_ro.socket in xen.inc

[PATCH] xen: delete references to xenstored.socket and xenstored_ro.socket in xen.inc

[Yan Yankovskyi]

[-- Attachment #1: Type: text/plain, Size: 1545 bytes --]

These files were removed since the followine patch
http://xenbits.xen.org/gitweb/?p=xen.git;a=commit;h=976ce01e103fc03bb3336cdbc6c951a709e285fe
and are absent in xen 4.8.0 and further, which leads to
the following error during the Xen build process:
do_package: SYSTEMD_SERVICE_xen-xencommons value xenstored.socket does not
exist

Signed-off-by: Yan Yankovskyi <yan.yankovskyi@globallogic.com>
---
 recipes-extended/xen/xen.inc | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/recipes-extended/xen/xen.inc b/recipes-extended/xen/xen.inc
index cb314f8..4d56de9 100644
--- a/recipes-extended/xen/xen.inc
+++ b/recipes-extended/xen/xen.inc
@@ -739,8 +739,6 @@ FILES_${PN}-xencommons += "\
     ${systemd_unitdir}/system/xenconsoled.service \
     ${systemd_unitdir}/system/xen-init-dom0.service \
     ${systemd_unitdir}/system/xenstored.service \
-    ${systemd_unitdir}/system/xenstored.socket \
-    ${systemd_unitdir}/system/xenstored_ro.socket \
     ${systemd_unitdir}/system/var-lib-xenstored.mount \
     "

@@ -780,8 +778,6 @@ SYSTEMD_SERVICE_${PN}-xencommons = " \
     xenconsoled.service \
     xen-init-dom0.service \
     xenstored.service \
-    xenstored.socket \
-    xenstored_ro.socket \
     "
 SYSTEMD_SERVICE_${PN}-xendomains = "xendomains.service"

-- 
2.7.4

-- 
Best regards,

Yan Yankovskyi | Associate Software Engineer, Ukraine
GlobalLogic
M  +380.95.049.64.73 <+380950496473>   Skype huandesale

www.globallogic.com

http://www.globallogic.com/email_disclaimer.txt

[-- Attachment #2: Type: text/html, Size: 4796 bytes --]

Re: [PATCH] xen: delete references to xenstored.socket and xenstored_ro.socket in xen.inc

[Yan Yankovskyi]

[-- Attachment #1: Type: text/plain, Size: 2137 bytes --]

So, what do you think about this patch? Presence of references to these
files breaks out of box xen build, and no one cares. Am I missing
something, or just so few people use xen?

On Mon, Nov 6, 2017 at 3:24 PM, Yan Yankovskyi <
yan.yankovskyi@globallogic.com> wrote:

> These files were removed since the followine patch
> http://xenbits.xen.org/gitweb/?p=xen.git;a=commit;h=
> 976ce01e103fc03bb3336cdbc6c951a709e285fe
> and are absent in xen 4.8.0 and further, which leads to
> the following error during the Xen build process:
> do_package: SYSTEMD_SERVICE_xen-xencommons value xenstored.socket does not
> exist
>
> Signed-off-by: Yan Yankovskyi <yan.yankovskyi@globallogic.com>
> ---
>  recipes-extended/xen/xen.inc | 4 ----
>  1 file changed, 4 deletions(-)
>
> diff --git a/recipes-extended/xen/xen.inc b/recipes-extended/xen/xen.inc
> index cb314f8..4d56de9 100644
> --- a/recipes-extended/xen/xen.inc
> +++ b/recipes-extended/xen/xen.inc
> @@ -739,8 +739,6 @@ FILES_${PN}-xencommons += "\
>      ${systemd_unitdir}/system/xenconsoled.service \
>      ${systemd_unitdir}/system/xen-init-dom0.service \
>      ${systemd_unitdir}/system/xenstored.service \
> -    ${systemd_unitdir}/system/xenstored.socket \
> -    ${systemd_unitdir}/system/xenstored_ro.socket \
>      ${systemd_unitdir}/system/var-lib-xenstored.mount \
>      "
>
> @@ -780,8 +778,6 @@ SYSTEMD_SERVICE_${PN}-xencommons = " \
>      xenconsoled.service \
>      xen-init-dom0.service \
>      xenstored.service \
> -    xenstored.socket \
> -    xenstored_ro.socket \
>      "
>  SYSTEMD_SERVICE_${PN}-xendomains = "xendomains.service"
>
> --
> 2.7.4
>
> --
> Best regards,
>
> Yan Yankovskyi | Associate Software Engineer, Ukraine
> GlobalLogic
> M  +380.95.049.64.73 <+380950496473>   Skype huandesale
>
> www.globallogic.com
>
> http://www.globallogic.com/email_disclaimer.txt
>



-- 
Best regards,

Yan Yankovskyi | Junior Software Engineer, Ukraine
GlobalLogic
M  +380.95.049.64.73 <+380950496473>   Skype huandesale

www.globallogic.com

http://www.globallogic.com/email_disclaimer.txt

[-- Attachment #2: Type: text/html, Size: 8787 bytes --]

Re: [PATCH] xen: delete references to xenstored.socket and xenstored_ro.socket in xen.inc

[Bruce Ashfield]

On Mon, Nov 13, 2017 at 4:40 AM, Yan Yankovskyi
<yan.yankovskyi@globallogic.com> wrote:
> So, what do you think about this patch? Presence of references to these
> files breaks out of box xen build, and no one cares. Am I missing something,
> or just so few people use xen?

Check the mailing list archive in the past months. There are multiple, active
Xen users sending patches (upgrading and fixing) .. so they are clearly
building.

As I mentioned, I'd like a full v2 repost so they can comment. I no longer have
the original patch, and maybe others don't as well .. they can't apply a quoted
reply of the old patch, so it needs to be resent to restart the conversation.

Cheers,

Bruce

>
> On Mon, Nov 6, 2017 at 3:24 PM, Yan Yankovskyi
> <yan.yankovskyi@globallogic.com> wrote:
>>
>> These files were removed since the followine patch
>>
>> http://xenbits.xen.org/gitweb/?p=xen.git;a=commit;h=976ce01e103fc03bb3336cdbc6c951a709e285fe
>> and are absent in xen 4.8.0 and further, which leads to
>> the following error during the Xen build process:
>> do_package: SYSTEMD_SERVICE_xen-xencommons value xenstored.socket does not
>> exist
>>
>> Signed-off-by: Yan Yankovskyi <yan.yankovskyi@globallogic.com>
>> ---
>>  recipes-extended/xen/xen.inc | 4 ----
>>  1 file changed, 4 deletions(-)
>>
>> diff --git a/recipes-extended/xen/xen.inc b/recipes-extended/xen/xen.inc
>> index cb314f8..4d56de9 100644
>> --- a/recipes-extended/xen/xen.inc
>> +++ b/recipes-extended/xen/xen.inc
>> @@ -739,8 +739,6 @@ FILES_${PN}-xencommons += "\
>>      ${systemd_unitdir}/system/xenconsoled.service \
>>      ${systemd_unitdir}/system/xen-init-dom0.service \
>>      ${systemd_unitdir}/system/xenstored.service \
>> -    ${systemd_unitdir}/system/xenstored.socket \
>> -    ${systemd_unitdir}/system/xenstored_ro.socket \
>>      ${systemd_unitdir}/system/var-lib-xenstored.mount \
>>      "
>>
>> @@ -780,8 +778,6 @@ SYSTEMD_SERVICE_${PN}-xencommons = " \
>>      xenconsoled.service \
>>      xen-init-dom0.service \
>>      xenstored.service \
>> -    xenstored.socket \
>> -    xenstored_ro.socket \
>>      "
>>  SYSTEMD_SERVICE_${PN}-xendomains = "xendomains.service"
>>
>> --
>> 2.7.4
>>
>> --
>> Best regards,
>>
>> Yan Yankovskyi | Associate Software Engineer, Ukraine
>> GlobalLogic
>> M  +380.95.049.64.73   Skype huandesale
>>
>> www.globallogic.com
>>
>> http://www.globallogic.com/email_disclaimer.txt
>
>
>
>
> --
> Best regards,
>
> Yan Yankovskyi | Junior Software Engineer, Ukraine
> GlobalLogic
> M  +380.95.049.64.73   Skype huandesale
>
> www.globallogic.com
>
> http://www.globallogic.com/email_disclaimer.txt



-- 
"Thou shalt not follow the NULL pointer, for chaos and madness await
thee at its end"

Re: [PATCH] xen: delete references to xenstored.socket and xenstored_ro.socket in xen.inc

[Bruce Ashfield]

[-- Attachment #1: Type: text/plain, Size: 1843 bytes --]

I see no complaints, so this is now merged.

Bruce

On Thu, Nov 23, 2017 at 9:24 AM, Yan Yankovskyi <
yan.yankovskyi@globallogic.com> wrote:

> These files were removed since the followine patch
> http://xenbits.xen.org/gitweb/?p=xen.git;a=commit;h=
> 976ce01e103fc03bb3336cdbc6c951a709e285fe
> and are absent in xen 4.8.0 and further, which leads to
> the following error during the Xen build process:
> do_package: SYSTEMD_SERVICE_xen-xencommons value xenstored.socket does not
> exist
>
> Signed-off-by: Yan Yankovskyi <yan.yankovskyi@globallogic.com>
> ---
>  recipes-extended/xen/xen.inc | 4 ----
>  1 file changed, 4 deletions(-)
>
> diff --git a/recipes-extended/xen/xen.inc b/recipes-extended/xen/xen.inc
> index cb314f8..4d56de9 100644
> --- a/recipes-extended/xen/xen.inc
> +++ b/recipes-extended/xen/xen.inc
> @@ -739,8 +739,6 @@ FILES_${PN}-xencommons += "\
>      ${systemd_unitdir}/system/xenconsoled.service \
>      ${systemd_unitdir}/system/xen-init-dom0.service \
>      ${systemd_unitdir}/system/xenstored.service \
> -    ${systemd_unitdir}/system/xenstored.socket \
> -    ${systemd_unitdir}/system/xenstored_ro.socket \
>      ${systemd_unitdir}/system/var-lib-xenstored.mount \
>      "
>
> @@ -780,8 +778,6 @@ SYSTEMD_SERVICE_${PN}-xencommons = " \
>      xenconsoled.service \
>      xen-init-dom0.service \
>      xenstored.service \
> -    xenstored.socket \
> -    xenstored_ro.socket \
>      "
>  SYSTEMD_SERVICE_${PN}-xendomains = "xendomains.service"
>
> --
> 1.9.1
>
> --
> _______________________________________________
> meta-virtualization mailing list
> meta-virtualization@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/meta-virtualization
>



-- 
"Thou shalt not follow the NULL pointer, for chaos and madness await thee
at its end"

[-- Attachment #2: Type: text/html, Size: 2913 bytes --]

[PATCH] xen: delete references to xenstored.socket and xenstored_ro.socket in xen.inc

[Yan Yankovskyi]

These files were removed since the followine patch
http://xenbits.xen.org/gitweb/?p=xen.git;a=commit;h=976ce01e103fc03bb3336cdbc6c951a709e285fe
and are absent in xen 4.8.0 and further, which leads to
the following error during the Xen build process:
do_package: SYSTEMD_SERVICE_xen-xencommons value xenstored.socket does not exist

Signed-off-by: Yan Yankovskyi <yan.yankovskyi@globallogic.com>
---
 recipes-extended/xen/xen.inc | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/recipes-extended/xen/xen.inc b/recipes-extended/xen/xen.inc
index cb314f8..4d56de9 100644
--- a/recipes-extended/xen/xen.inc
+++ b/recipes-extended/xen/xen.inc
@@ -739,8 +739,6 @@ FILES_${PN}-xencommons += "\
     ${systemd_unitdir}/system/xenconsoled.service \
     ${systemd_unitdir}/system/xen-init-dom0.service \
     ${systemd_unitdir}/system/xenstored.service \
-    ${systemd_unitdir}/system/xenstored.socket \
-    ${systemd_unitdir}/system/xenstored_ro.socket \
     ${systemd_unitdir}/system/var-lib-xenstored.mount \
     "
 
@@ -780,8 +778,6 @@ SYSTEMD_SERVICE_${PN}-xencommons = " \
     xenconsoled.service \
     xen-init-dom0.service \
     xenstored.service \
-    xenstored.socket \
-    xenstored_ro.socket \
     "
 SYSTEMD_SERVICE_${PN}-xendomains = "xendomains.service"
 
-- 
1.9.1

Re: [PATCH] xen: delete references to xenstored.socket and xenstored_ro.socket in xen.inc

[Bruce Ashfield]

Looks like it was just missed (it happens).

Also, there was no ack on the list by the folks that are actively
building and using Xen .. which means they are not hitting the
same error.

I'd suggest re-posting the patch and then we can see if there's
any new discussion on the list.

Bruce

On Mon, Nov 6, 2017 at 4:45 AM, Wei, Yunguo (Bryan)
<Yunguo.Wei@windriver.com> wrote:
> Hi Yan
>
> Do you know why this patch was not merged? I'm running into same problem.
>
> Regards,
> Yunguo
>
> -----Original Message-----
> From: meta-virtualization-bounces@yoctoproject.org [mailto:meta-virtualization-bounces@yoctoproject.org] On Behalf Of Yan Yankovskyi
> Sent: Wednesday, August 30, 2017 5:03 PM
> To: meta-virtualization@yoctoproject.org
> Subject: [meta-virtualization] [PATCH] xen: delete references to xenstored.socket and xenstored_ro.socket in xen.inc
>
> These files were removed since the following patch http://xenbits.xen.org/gitweb/?p=xen.git;a=commit;h=976ce01e103fc03bb3336cdbc6c951a709e285fe
> and are absent in xen 4.8.0 and further, which leads to the following error during the Xen build process:
> do_package: SYSTEMD_SERVICE_xen-xencommons value xenstored.socket does not exist
>
> Signed-off-by: Yan Yankovskyi <yan.yankovskyi@globallogic.com>
> ---
>  recipes-extended/xen/xen.inc | 4 ----
>  1 file changed, 4 deletions(-)
>
> diff --git a/recipes-extended/xen/xen.inc b/recipes-extended/xen/xen.inc index b5c5f03..717424b 100644
> --- a/recipes-extended/xen/xen.inc
> +++ b/recipes-extended/xen/xen.inc
> @@ -687,8 +687,6 @@ FILES_${PN}-xencommons += "\
>      ${systemd_unitdir}/system/xenconsoled.service \
>      ${systemd_unitdir}/system/xen-init-dom0.service \
>      ${systemd_unitdir}/system/xenstored.service \
> -    ${systemd_unitdir}/system/xenstored.socket \
> -    ${systemd_unitdir}/system/xenstored_ro.socket \
>      ${systemd_unitdir}/system/var-lib-xenstored.mount \
>      "
>
> @@ -728,8 +726,6 @@ SYSTEMD_SERVICE_${PN}-xencommons = " \
>      xenconsoled.service \
>      xen-init-dom0.service \
>      xenstored.service \
> -    xenstored.socket \
> -    xenstored_ro.socket \
>      "
>  SYSTEMD_SERVICE_${PN}-xendomains = "xendomains.service"
>
> --
> 1.9.1
>
> --
> _______________________________________________
> meta-virtualization mailing list
> meta-virtualization@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/meta-virtualization
> --
> _______________________________________________
> meta-virtualization mailing list
> meta-virtualization@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/meta-virtualization



-- 
"Thou shalt not follow the NULL pointer, for chaos and madness await
thee at its end"

Re: [PATCH] xen: delete references to xenstored.socket and xenstored_ro.socket in xen.inc

[Yan Yankovskyi]

[-- Attachment #1: Type: text/plain, Size: 2882 bytes --]

Hi Wei

Unfortunately, I haven't got any response about that. I'm not the only one
who experienced such problem, even among my friends. Another solution might
be to create custom bbappend with the following content:

FILES_${PN}-xencommons_remove = "xenstored.socket xenstored_ro.socket"
SYSTEMD_SERVICE_${PN}-xencommons_remove = "xenstored.socket
xenstored_ro.socket"

(haven't checked it), but I don't understand what are these lines in
xen.inc for?

On Mon, Nov 6, 2017 at 10:45 AM, Wei, Yunguo (Bryan) <
Yunguo.Wei@windriver.com> wrote:

> Hi Yan
>
> Do you know why this patch was not merged? I'm running into same problem.
>
> Regards,
> Yunguo
>
> -----Original Message-----
> From: meta-virtualization-bounces@yoctoproject.org [mailto:
> meta-virtualization-bounces@yoctoproject.org] On Behalf Of Yan Yankovskyi
> Sent: Wednesday, August 30, 2017 5:03 PM
> To: meta-virtualization@yoctoproject.org
> Subject: [meta-virtualization] [PATCH] xen: delete references to
> xenstored.socket and xenstored_ro.socket in xen.inc
>
> These files were removed since the following patch
> http://xenbits.xen.org/gitweb/?p=xen.git;a=commit;h=
> 976ce01e103fc03bb3336cdbc6c951a709e285fe
> and are absent in xen 4.8.0 and further, which leads to the following
> error during the Xen build process:
> do_package: SYSTEMD_SERVICE_xen-xencommons value xenstored.socket does not
> exist
>
> Signed-off-by: Yan Yankovskyi <yan.yankovskyi@globallogic.com>
> ---
>  recipes-extended/xen/xen.inc | 4 ----
>  1 file changed, 4 deletions(-)
>
> diff --git a/recipes-extended/xen/xen.inc b/recipes-extended/xen/xen.inc
> index b5c5f03..717424b 100644
> --- a/recipes-extended/xen/xen.inc
> +++ b/recipes-extended/xen/xen.inc
> @@ -687,8 +687,6 @@ FILES_${PN}-xencommons += "\
>      ${systemd_unitdir}/system/xenconsoled.service \
>      ${systemd_unitdir}/system/xen-init-dom0.service \
>      ${systemd_unitdir}/system/xenstored.service \
> -    ${systemd_unitdir}/system/xenstored.socket \
> -    ${systemd_unitdir}/system/xenstored_ro.socket \
>      ${systemd_unitdir}/system/var-lib-xenstored.mount \
>      "
>
> @@ -728,8 +726,6 @@ SYSTEMD_SERVICE_${PN}-xencommons = " \
>      xenconsoled.service \
>      xen-init-dom0.service \
>      xenstored.service \
> -    xenstored.socket \
> -    xenstored_ro.socket \
>      "
>  SYSTEMD_SERVICE_${PN}-xendomains = "xendomains.service"
>
> --
> 1.9.1
>
> --
> _______________________________________________
> meta-virtualization mailing list
> meta-virtualization@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/meta-virtualization
>



-- 
Best regards,

Yan Yankovskyi | Associate Software Engineer, Ukraine
GlobalLogic
M  +380.95.049.64.73 <+380950496473>   Skype huandesale

www.globallogic.com

http://www.globallogic.com/email_disclaimer.txt

[-- Attachment #2: Type: text/html, Size: 7211 bytes --]

Re: [PATCH] xen: delete references to xenstored.socket and xenstored_ro.socket in xen.inc

[Wei, Yunguo (Bryan)]

Hi Yan

Do you know why this patch was not merged? I'm running into same problem.

Regards,
Yunguo

-----Original Message-----
From: meta-virtualization-bounces@yoctoproject.org [mailto:meta-virtualization-bounces@yoctoproject.org] On Behalf Of Yan Yankovskyi
Sent: Wednesday, August 30, 2017 5:03 PM
To: meta-virtualization@yoctoproject.org
Subject: [meta-virtualization] [PATCH] xen: delete references to xenstored.socket and xenstored_ro.socket in xen.inc

These files were removed since the following patch http://xenbits.xen.org/gitweb/?p=xen.git;a=commit;h=976ce01e103fc03bb3336cdbc6c951a709e285fe
and are absent in xen 4.8.0 and further, which leads to the following error during the Xen build process:
do_package: SYSTEMD_SERVICE_xen-xencommons value xenstored.socket does not exist

Signed-off-by: Yan Yankovskyi <yan.yankovskyi@globallogic.com>
---
 recipes-extended/xen/xen.inc | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/recipes-extended/xen/xen.inc b/recipes-extended/xen/xen.inc index b5c5f03..717424b 100644
--- a/recipes-extended/xen/xen.inc
+++ b/recipes-extended/xen/xen.inc
@@ -687,8 +687,6 @@ FILES_${PN}-xencommons += "\
     ${systemd_unitdir}/system/xenconsoled.service \
     ${systemd_unitdir}/system/xen-init-dom0.service \
     ${systemd_unitdir}/system/xenstored.service \
-    ${systemd_unitdir}/system/xenstored.socket \
-    ${systemd_unitdir}/system/xenstored_ro.socket \
     ${systemd_unitdir}/system/var-lib-xenstored.mount \
     "
 
@@ -728,8 +726,6 @@ SYSTEMD_SERVICE_${PN}-xencommons = " \
     xenconsoled.service \
     xen-init-dom0.service \
     xenstored.service \
-    xenstored.socket \
-    xenstored_ro.socket \
     "
 SYSTEMD_SERVICE_${PN}-xendomains = "xendomains.service"
 
--
1.9.1

--
_______________________________________________
meta-virtualization mailing list
meta-virtualization@yoctoproject.org
https://lists.yoctoproject.org/listinfo/meta-virtualization

[PATCH] xen: delete references to xenstored.socket and xenstored_ro.socket in xen.inc

[Yan Yankovskyi]

These files were removed since the following patch
http://xenbits.xen.org/gitweb/?p=xen.git;a=commit;h=976ce01e103fc03bb3336cdbc6c951a709e285fe
and are absent in xen 4.8.0 and further, which leads to
the following error during the Xen build process:
do_package: SYSTEMD_SERVICE_xen-xencommons value xenstored.socket does not exist

Signed-off-by: Yan Yankovskyi <yan.yankovskyi@globallogic.com>
---
 recipes-extended/xen/xen.inc | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/recipes-extended/xen/xen.inc b/recipes-extended/xen/xen.inc
index b5c5f03..717424b 100644
--- a/recipes-extended/xen/xen.inc
+++ b/recipes-extended/xen/xen.inc
@@ -687,8 +687,6 @@ FILES_${PN}-xencommons += "\
     ${systemd_unitdir}/system/xenconsoled.service \
     ${systemd_unitdir}/system/xen-init-dom0.service \
     ${systemd_unitdir}/system/xenstored.service \
-    ${systemd_unitdir}/system/xenstored.socket \
-    ${systemd_unitdir}/system/xenstored_ro.socket \
     ${systemd_unitdir}/system/var-lib-xenstored.mount \
     "
 
@@ -728,8 +726,6 @@ SYSTEMD_SERVICE_${PN}-xencommons = " \
     xenconsoled.service \
     xen-init-dom0.service \
     xenstored.service \
-    xenstored.socket \
-    xenstored_ro.socket \
     "
 SYSTEMD_SERVICE_${PN}-xendomains = "xendomains.service"
 
-- 
1.9.1