* [PATCH] libusb1: Update to 1.0.18
@ 2014-05-15 15:58 Saul Wold
2014-05-16 5:13 ` Jacob Kroon
0 siblings, 1 reply; 8+ messages in thread
From: Saul Wold @ 2014-05-15 15:58 UTC (permalink / raw)
To: openembedded-core
Signed-off-by: Saul Wold <sgw@linux.intel.com>
---
.../{libusb1-1.0.9 => libusb1}/obsolete_automake_macros.patch | 0
.../recipes-support/libusb/{libusb1_1.0.9.bb => libusb1_1.0.18.bb} | 7 ++-----
2 files changed, 2 insertions(+), 5 deletions(-)
rename meta/recipes-support/libusb/{libusb1-1.0.9 => libusb1}/obsolete_automake_macros.patch (100%)
rename meta/recipes-support/libusb/{libusb1_1.0.9.bb => libusb1_1.0.18.bb} (78%)
diff --git a/meta/recipes-support/libusb/libusb1-1.0.9/obsolete_automake_macros.patch b/meta/recipes-support/libusb/libusb1/obsolete_automake_macros.patch
similarity index 100%
rename from meta/recipes-support/libusb/libusb1-1.0.9/obsolete_automake_macros.patch
rename to meta/recipes-support/libusb/libusb1/obsolete_automake_macros.patch
diff --git a/meta/recipes-support/libusb/libusb1_1.0.9.bb b/meta/recipes-support/libusb/libusb1_1.0.18.bb
similarity index 78%
rename from meta/recipes-support/libusb/libusb1_1.0.9.bb
rename to meta/recipes-support/libusb/libusb1_1.0.18.bb
index d57425b..c64f1db 100644
--- a/meta/recipes-support/libusb/libusb1_1.0.9.bb
+++ b/meta/recipes-support/libusb/libusb1_1.0.18.bb
@@ -8,14 +8,11 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=fbc093901857fcd118f065f900982c24"
BBCLASSEXTEND = "native nativesdk"
-PR = "r1"
-
SRC_URI = "${SOURCEFORGE_MIRROR}/libusb/libusb-${PV}.tar.bz2 \
- file://obsolete_automake_macros.patch \
"
-SRC_URI[md5sum] = "7f5a02375ad960d4e33a6dae7d63cfcb"
-SRC_URI[sha256sum] = "e920eedc2d06b09606611c99ec7304413c6784cba6e33928e78243d323195f9b"
+SRC_URI[md5sum] = "4a6d049923efc6496f1d383054dac1a6"
+SRC_URI[sha256sum] = "c73f5cec45a5de94418da4e151b7232958571926984acfb9bce02b9424e83720"
S = "${WORKDIR}/libusb-${PV}"
--
1.8.3.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH] libusb1: Update to 1.0.18
2014-05-15 15:58 [PATCH] libusb1: Update to 1.0.18 Saul Wold
@ 2014-05-16 5:13 ` Jacob Kroon
2014-05-16 12:16 ` Jacob Kroon
0 siblings, 1 reply; 8+ messages in thread
From: Jacob Kroon @ 2014-05-16 5:13 UTC (permalink / raw)
To: Saul Wold; +Cc: openembedded-core
[-- Attachment #1: Type: text/plain, Size: 1699 bytes --]
Hello Saul,
On Thu, May 15, 2014 at 5:58 PM, Saul Wold <sgw@linux.intel.com> wrote:
> Signed-off-by: Saul Wold <sgw@linux.intel.com>
> ---
> .../{libusb1-1.0.9 => libusb1}/obsolete_automake_macros.patch | 0
> .../recipes-support/libusb/{libusb1_1.0.9.bb => libusb1_1.0.18.bb} | 7
> ++-----
> 2 files changed, 2 insertions(+), 5 deletions(-)
> rename meta/recipes-support/libusb/{libusb1-1.0.9 =>
> libusb1}/obsolete_automake_macros.patch (100%)
> rename meta/recipes-support/libusb/{libusb1_1.0.9.bb => libusb1_1.0.18.bb}
> (78%)
>
> diff --git
> a/meta/recipes-support/libusb/libusb1-1.0.9/obsolete_automake_macros.patch
> b/meta/recipes-support/libusb/libusb1/obsolete_automake_macros.patch
> similarity index 100%
> rename from
> meta/recipes-support/libusb/libusb1-1.0.9/obsolete_automake_macros.patch
> rename to
> meta/recipes-support/libusb/libusb1/obsolete_automake_macros.patch
> diff --git a/meta/recipes-support/libusb/libusb1_1.0.9.bbb/meta/recipes-support/libusb/
> libusb1_1.0.18.bb
> similarity index 78%
> rename from meta/recipes-support/libusb/libusb1_1.0.9.bb
> rename to meta/recipes-support/libusb/libusb1_1.0.18.bb
> index d57425b..c64f1db 100644
> --- a/meta/recipes-support/libusb/libusb1_1.0.9.bb
> +++ b/meta/recipes-support/libusb/libusb1_1.0.18.bb
> @@ -8,14 +8,11 @@ LIC_FILES_CHKSUM =
> "file://COPYING;md5=fbc093901857fcd118f065f900982c24"
>
> BBCLASSEXTEND = "native nativesdk"
>
> -PR = "r1"
> -
> SRC_URI = "${SOURCEFORGE_MIRROR}/libusb/libusb-${PV}.tar.bz2 \
> - file://obsolete_automake_macros.patch \
> "
>
That patch is still in git, maybe it should be removed as well ?
/Jacob
[-- Attachment #2: Type: text/html, Size: 2740 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] libusb1: Update to 1.0.18
2014-05-16 5:13 ` Jacob Kroon
@ 2014-05-16 12:16 ` Jacob Kroon
2014-05-16 17:14 ` Saul Wold
0 siblings, 1 reply; 8+ messages in thread
From: Jacob Kroon @ 2014-05-16 12:16 UTC (permalink / raw)
To: Saul Wold; +Cc: openembedded-core
[-- Attachment #1: Type: text/plain, Size: 2906 bytes --]
On Fri, May 16, 2014 at 7:13 AM, Jacob Kroon <jacob.kroon@gmail.com> wrote:
> Hello Saul,
>
>
> On Thu, May 15, 2014 at 5:58 PM, Saul Wold <sgw@linux.intel.com> wrote:
>
>> Signed-off-by: Saul Wold <sgw@linux.intel.com>
>> ---
>> .../{libusb1-1.0.9 => libusb1}/obsolete_automake_macros.patch | 0
>> .../recipes-support/libusb/{libusb1_1.0.9.bb => libusb1_1.0.18.bb} | 7
>> ++-----
>> 2 files changed, 2 insertions(+), 5 deletions(-)
>> rename meta/recipes-support/libusb/{libusb1-1.0.9 =>
>> libusb1}/obsolete_automake_macros.patch (100%)
>> rename meta/recipes-support/libusb/{libusb1_1.0.9.bb =>
>> libusb1_1.0.18.bb} (78%)
>>
>> diff --git
>> a/meta/recipes-support/libusb/libusb1-1.0.9/obsolete_automake_macros.patch
>> b/meta/recipes-support/libusb/libusb1/obsolete_automake_macros.patch
>> similarity index 100%
>> rename from
>> meta/recipes-support/libusb/libusb1-1.0.9/obsolete_automake_macros.patch
>> rename to
>> meta/recipes-support/libusb/libusb1/obsolete_automake_macros.patch
>> diff --git a/meta/recipes-support/libusb/libusb1_1.0.9.bbb/meta/recipes-support/libusb/
>> libusb1_1.0.18.bb
>> similarity index 78%
>> rename from meta/recipes-support/libusb/libusb1_1.0.9.bb
>> rename to meta/recipes-support/libusb/libusb1_1.0.18.bb
>> index d57425b..c64f1db 100644
>> --- a/meta/recipes-support/libusb/libusb1_1.0.9.bb
>> +++ b/meta/recipes-support/libusb/libusb1_1.0.18.bb
>> @@ -8,14 +8,11 @@ LIC_FILES_CHKSUM =
>> "file://COPYING;md5=fbc093901857fcd118f065f900982c24"
>>
>> BBCLASSEXTEND = "native nativesdk"
>>
>> -PR = "r1"
>> -
>> SRC_URI = "${SOURCEFORGE_MIRROR}/libusb/libusb-${PV}.tar.bz2 \
>> - file://obsolete_automake_macros.patch \
>> "
>>
>
> That patch is still in git, maybe it should be removed as well ?
>
>
Also, I think it needs to be added a PACKAGECONFIG for "udev", otherwise I
get a build failure when I generate an SDK on my system,
configure script can't find udev although it was requested.
Something like the patch below does the trick for me:
--- a/meta/recipes-support/libusb/libusb1_1.0.18.bb
+++ b/meta/recipes-support/libusb/libusb1_1.0.18.bb
@@ -8,12 +8,17 @@ LIC_FILES_CHKSUM =
"file://COPYING;md5=fbc093901857fcd118f065f900982c24"
BBCLASSEXTEND = "native nativesdk"
-SRC_URI = "${SOURCEFORGE_MIRROR}/libusb/libusb-${PV}.tar.bz2 \
- "
+SRC_URI = "${SOURCEFORGE_MIRROR}/libusb/libusb-${PV}.tar.bz2"
SRC_URI[md5sum] = "4a6d049923efc6496f1d383054dac1a6"
SRC_URI[sha256sum] =
"c73f5cec45a5de94418da4e151b7232958571926984acfb9bce02b9424e83720"
+PACKAGECONFIG ?= "udev"
+PACKAGECONFIG_class-native = ""
+PACKAGECONFIG_class-nativesdk = ""
+
+PACKAGECONFIG[udev] = "--enable-udev,--disable-udev,udev"
+
S = "${WORKDIR}/libusb-${PV}"
inherit autotools pkgconfig
If this looks good I can submit a proper patch for it.
/Jacob
[-- Attachment #2: Type: text/html, Size: 4639 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] libusb1: Update to 1.0.18
2014-05-16 12:16 ` Jacob Kroon
@ 2014-05-16 17:14 ` Saul Wold
2014-05-16 18:47 ` Jacob Kroon
2014-05-17 5:26 ` Khem Raj
0 siblings, 2 replies; 8+ messages in thread
From: Saul Wold @ 2014-05-16 17:14 UTC (permalink / raw)
To: Jacob Kroon; +Cc: openembedded-core
On 05/16/2014 05:16 AM, Jacob Kroon wrote:
> On Fri, May 16, 2014 at 7:13 AM, Jacob Kroon <jacob.kroon@gmail.com> wrote:
>
>> Hello Saul,
>>
>>
>> On Thu, May 15, 2014 at 5:58 PM, Saul Wold <sgw@linux.intel.com> wrote:
>>
>>> Signed-off-by: Saul Wold <sgw@linux.intel.com>
>>> ---
>>> .../{libusb1-1.0.9 => libusb1}/obsolete_automake_macros.patch | 0
>>> .../recipes-support/libusb/{libusb1_1.0.9.bb => libusb1_1.0.18.bb} | 7
>>> ++-----
>>> 2 files changed, 2 insertions(+), 5 deletions(-)
>>> rename meta/recipes-support/libusb/{libusb1-1.0.9 =>
>>> libusb1}/obsolete_automake_macros.patch (100%)
>>> rename meta/recipes-support/libusb/{libusb1_1.0.9.bb =>
>>> libusb1_1.0.18.bb} (78%)
>>>
>>> diff --git
>>> a/meta/recipes-support/libusb/libusb1-1.0.9/obsolete_automake_macros.patch
>>> b/meta/recipes-support/libusb/libusb1/obsolete_automake_macros.patch
>>> similarity index 100%
>>> rename from
>>> meta/recipes-support/libusb/libusb1-1.0.9/obsolete_automake_macros.patch
>>> rename to
>>> meta/recipes-support/libusb/libusb1/obsolete_automake_macros.patch
>>> diff --git a/meta/recipes-support/libusb/libusb1_1.0.9.bbb/meta/recipes-support/libusb/
>>> libusb1_1.0.18.bb
>>> similarity index 78%
>>> rename from meta/recipes-support/libusb/libusb1_1.0.9.bb
>>> rename to meta/recipes-support/libusb/libusb1_1.0.18.bb
>>> index d57425b..c64f1db 100644
>>> --- a/meta/recipes-support/libusb/libusb1_1.0.9.bb
>>> +++ b/meta/recipes-support/libusb/libusb1_1.0.18.bb
>>> @@ -8,14 +8,11 @@ LIC_FILES_CHKSUM =
>>> "file://COPYING;md5=fbc093901857fcd118f065f900982c24"
>>>
>>> BBCLASSEXTEND = "native nativesdk"
>>>
>>> -PR = "r1"
>>> -
>>> SRC_URI = "${SOURCEFORGE_MIRROR}/libusb/libusb-${PV}.tar.bz2 \
>>> - file://obsolete_automake_macros.patch \
>>> "
>>>
>>
>> That patch is still in git, maybe it should be removed as well ?
>>
>>
> Also, I think it needs to be added a PACKAGECONFIG for "udev", otherwise I
> get a build failure when I generate an SDK on my system,
> configure script can't find udev although it was requested.
>
> Something like the patch below does the trick for me:
>
I am supprised you did not see a circular dependency with udev -> libusb
-> udev, I think we need to disable-udev as default and if there is a
need for a libusb with udev support we will have to create a new recipe
possibly to build it after udev is built.
Thoughts here?
Sau!
> --- a/meta/recipes-support/libusb/libusb1_1.0.18.bb
> +++ b/meta/recipes-support/libusb/libusb1_1.0.18.bb
> @@ -8,12 +8,17 @@ LIC_FILES_CHKSUM =
> "file://COPYING;md5=fbc093901857fcd118f065f900982c24"
>
> BBCLASSEXTEND = "native nativesdk"
>
> -SRC_URI = "${SOURCEFORGE_MIRROR}/libusb/libusb-${PV}.tar.bz2 \
> - "
> +SRC_URI = "${SOURCEFORGE_MIRROR}/libusb/libusb-${PV}.tar.bz2"
>
> SRC_URI[md5sum] = "4a6d049923efc6496f1d383054dac1a6"
> SRC_URI[sha256sum] =
> "c73f5cec45a5de94418da4e151b7232958571926984acfb9bce02b9424e83720"
>
> +PACKAGECONFIG ?= "udev"
> +PACKAGECONFIG_class-native = ""
> +PACKAGECONFIG_class-nativesdk = ""
> +
> +PACKAGECONFIG[udev] = "--enable-udev,--disable-udev,udev"
> +
> S = "${WORKDIR}/libusb-${PV}"
>
> inherit autotools pkgconfig
>
> If this looks good I can submit a proper patch for it.
>
> /Jacob
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] libusb1: Update to 1.0.18
2014-05-16 17:14 ` Saul Wold
@ 2014-05-16 18:47 ` Jacob Kroon
2014-05-16 20:18 ` Andrea Adami
2014-05-17 5:26 ` Khem Raj
1 sibling, 1 reply; 8+ messages in thread
From: Jacob Kroon @ 2014-05-16 18:47 UTC (permalink / raw)
To: Saul Wold; +Cc: openembedded-core
[-- Attachment #1: Type: text/plain, Size: 3898 bytes --]
On Fri, May 16, 2014 at 7:14 PM, Saul Wold <sgw@linux.intel.com> wrote:
> On 05/16/2014 05:16 AM, Jacob Kroon wrote:
>
>> On Fri, May 16, 2014 at 7:13 AM, Jacob Kroon <jacob.kroon@gmail.com>
>> wrote:
>>
>> Hello Saul,
>>>
>>>
>>> On Thu, May 15, 2014 at 5:58 PM, Saul Wold <sgw@linux.intel.com> wrote:
>>>
>>> Signed-off-by: Saul Wold <sgw@linux.intel.com>
>>>> ---
>>>> .../{libusb1-1.0.9 => libusb1}/obsolete_automake_macros.patch |
>>>> 0
>>>> .../recipes-support/libusb/{libusb1_1.0.9.bb => libusb1_1.0.18.bb} |
>>>> 7
>>>> ++-----
>>>> 2 files changed, 2 insertions(+), 5 deletions(-)
>>>> rename meta/recipes-support/libusb/{libusb1-1.0.9 =>
>>>> libusb1}/obsolete_automake_macros.patch (100%)
>>>> rename meta/recipes-support/libusb/{libusb1_1.0.9.bb =>
>>>> libusb1_1.0.18.bb} (78%)
>>>>
>>>> diff --git
>>>> a/meta/recipes-support/libusb/libusb1-1.0.9/obsolete_
>>>> automake_macros.patch
>>>> b/meta/recipes-support/libusb/libusb1/obsolete_automake_macros.patch
>>>> similarity index 100%
>>>> rename from
>>>> meta/recipes-support/libusb/libusb1-1.0.9/obsolete_
>>>> automake_macros.patch
>>>> rename to
>>>> meta/recipes-support/libusb/libusb1/obsolete_automake_macros.patch
>>>> diff --git a/meta/recipes-support/libusb/libusb1_1.0.9.bbb/meta/
>>>> recipes-support/libusb/
>>>> libusb1_1.0.18.bb
>>>> similarity index 78%
>>>> rename from meta/recipes-support/libusb/libusb1_1.0.9.bb
>>>> rename to meta/recipes-support/libusb/libusb1_1.0.18.bb
>>>> index d57425b..c64f1db 100644
>>>> --- a/meta/recipes-support/libusb/libusb1_1.0.9.bb
>>>> +++ b/meta/recipes-support/libusb/libusb1_1.0.18.bb
>>>> @@ -8,14 +8,11 @@ LIC_FILES_CHKSUM =
>>>> "file://COPYING;md5=fbc093901857fcd118f065f900982c24"
>>>>
>>>> BBCLASSEXTEND = "native nativesdk"
>>>>
>>>> -PR = "r1"
>>>> -
>>>> SRC_URI = "${SOURCEFORGE_MIRROR}/libusb/libusb-${PV}.tar.bz2 \
>>>> - file://obsolete_automake_macros.patch \
>>>> "
>>>>
>>>>
>>> That patch is still in git, maybe it should be removed as well ?
>>>
>>>
>>> Also, I think it needs to be added a PACKAGECONFIG for "udev",
>> otherwise I
>> get a build failure when I generate an SDK on my system,
>> configure script can't find udev although it was requested.
>>
>>
> Something like the patch below does the trick for me:
>>
>> I am supprised you did not see a circular dependency with udev -> libusb
> -> udev, I think we need to disable-udev as default and if there is a need
> for a libusb with udev support we will have to create a new recipe possibly
> to build it after udev is built.
>
>
With the patch applied, I wiped my sysroots and did a "cleansstate libusb1
udev", and then rebuilt both successfully with no warning
about circular dependency. Maybe I'm not hitting the error since I have
"systemd" in DISTRO_FEATURES, so it's actually systemd that is the udev
provider.
Thoughts here?
>
> Sau!
>
>
>
> --- a/meta/recipes-support/libusb/libusb1_1.0.18.bb
>> +++ b/meta/recipes-support/libusb/libusb1_1.0.18.bb
>> @@ -8,12 +8,17 @@ LIC_FILES_CHKSUM =
>> "file://COPYING;md5=fbc093901857fcd118f065f900982c24"
>>
>> BBCLASSEXTEND = "native nativesdk"
>>
>> -SRC_URI = "${SOURCEFORGE_MIRROR}/libusb/libusb-${PV}.tar.bz2 \
>> - "
>> +SRC_URI = "${SOURCEFORGE_MIRROR}/libusb/libusb-${PV}.tar.bz2"
>>
>> SRC_URI[md5sum] = "4a6d049923efc6496f1d383054dac1a6"
>> SRC_URI[sha256sum] =
>> "c73f5cec45a5de94418da4e151b7232958571926984acfb9bce02b9424e83720"
>>
>> +PACKAGECONFIG ?= "udev"
>> +PACKAGECONFIG_class-native = ""
>> +PACKAGECONFIG_class-nativesdk = ""
>> +
>> +PACKAGECONFIG[udev] = "--enable-udev,--disable-udev,udev"
>> +
>> S = "${WORKDIR}/libusb-${PV}"
>>
>> inherit autotools pkgconfig
>>
>> If this looks good I can submit a proper patch for it.
>>
>> /Jacob
>>
>>
[-- Attachment #2: Type: text/html, Size: 6285 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] libusb1: Update to 1.0.18
2014-05-16 18:47 ` Jacob Kroon
@ 2014-05-16 20:18 ` Andrea Adami
2014-05-16 20:29 ` Andrea Adami
0 siblings, 1 reply; 8+ messages in thread
From: Andrea Adami @ 2014-05-16 20:18 UTC (permalink / raw)
To: openembedded-core
On Fri, May 16, 2014 at 8:47 PM, Jacob Kroon <jacob.kroon@gmail.com> wrote:
> On Fri, May 16, 2014 at 7:14 PM, Saul Wold <sgw@linux.intel.com> wrote:
>>
>> On 05/16/2014 05:16 AM, Jacob Kroon wrote:
>>>
>>> On Fri, May 16, 2014 at 7:13 AM, Jacob Kroon <jacob.kroon@gmail.com>
>>> wrote:
>>>
>>>> Hello Saul,
>>>>
>>>>
>>>> On Thu, May 15, 2014 at 5:58 PM, Saul Wold <sgw@linux.intel.com> wrote:
>>>>
>>>>> Signed-off-by: Saul Wold <sgw@linux.intel.com>
>>>>> ---
>>>>> .../{libusb1-1.0.9 => libusb1}/obsolete_automake_macros.patch |
>>>>> 0
>>>>> .../recipes-support/libusb/{libusb1_1.0.9.bb => libusb1_1.0.18.bb} |
>>>>> 7
>>>>> ++-----
>>>>> 2 files changed, 2 insertions(+), 5 deletions(-)
>>>>> rename meta/recipes-support/libusb/{libusb1-1.0.9 =>
>>>>> libusb1}/obsolete_automake_macros.patch (100%)
>>>>> rename meta/recipes-support/libusb/{libusb1_1.0.9.bb =>
>>>>> libusb1_1.0.18.bb} (78%)
>>>>>
>>>>> diff --git
>>>>>
>>>>> a/meta/recipes-support/libusb/libusb1-1.0.9/obsolete_automake_macros.patch
>>>>> b/meta/recipes-support/libusb/libusb1/obsolete_automake_macros.patch
>>>>> similarity index 100%
>>>>> rename from
>>>>>
>>>>> meta/recipes-support/libusb/libusb1-1.0.9/obsolete_automake_macros.patch
>>>>> rename to
>>>>> meta/recipes-support/libusb/libusb1/obsolete_automake_macros.patch
>>>>> diff --git
>>>>> a/meta/recipes-support/libusb/libusb1_1.0.9.bbb/meta/recipes-support/libusb/
>>>>> libusb1_1.0.18.bb
>>>>> similarity index 78%
>>>>> rename from meta/recipes-support/libusb/libusb1_1.0.9.bb
>>>>> rename to meta/recipes-support/libusb/libusb1_1.0.18.bb
>>>>> index d57425b..c64f1db 100644
>>>>> --- a/meta/recipes-support/libusb/libusb1_1.0.9.bb
>>>>> +++ b/meta/recipes-support/libusb/libusb1_1.0.18.bb
>>>>> @@ -8,14 +8,11 @@ LIC_FILES_CHKSUM =
>>>>> "file://COPYING;md5=fbc093901857fcd118f065f900982c24"
>>>>>
>>>>> BBCLASSEXTEND = "native nativesdk"
>>>>>
>>>>> -PR = "r1"
>>>>> -
>>>>> SRC_URI = "${SOURCEFORGE_MIRROR}/libusb/libusb-${PV}.tar.bz2 \
>>>>> - file://obsolete_automake_macros.patch \
>>>>> "
>>>>>
>>>>
>>>> That patch is still in git, maybe it should be removed as well ?
>>>>
>>>>
>>> Also, I think it needs to be added a PACKAGECONFIG for "udev", otherwise
>>> I
>>> get a build failure when I generate an SDK on my system,
>>> configure script can't find udev although it was requested.
>>>
>>
>>> Something like the patch below does the trick for me:
>>>
>> I am supprised you did not see a circular dependency with udev -> libusb
>> -> udev, I think we need to disable-udev as default and if there is a need
>> for a libusb with udev support we will have to create a new recipe possibly
>> to build it after udev is built.
>>
>
> With the patch applied, I wiped my sysroots and did a "cleansstate libusb1
> udev", and then rebuilt both successfully with no warning
> about circular dependency. Maybe I'm not hitting the error since I have
> "systemd" in DISTRO_FEATURES, so it's actually systemd that is the udev
> provider.
>
>> Thoughts here?
>>
>> Sau!
>>
>>
Yes, building sysvinit I get the failure:
| checking operating system... Linux
| checking for library containing clock_gettime... none required
| checking libudev.h usability... no
| checking libudev.h presence... no
| checking for libudev.h... no
| configure: error: "udev support requested but libudev not installed"
| Configure failed. The contents of all config.log files follows to
aid debugging
| ERROR: oe_runconf failed
| WARNING: exit code 1 from a shell command.
| ERROR: Function failed: do_configure (log file is located at
/oe/oe-core/build/tmp-eglibc/
work/armv4-oe-linux-gnueabi/libusb1/1.0.18-r0/temp/log.do_configure.23838)
ERROR: Task 1803
(/oe/oe-core/meta/recipes-support/libusb/libusb1_1.0.18.bb,
do_configure) failed with exit code '1'
Andrea
>>
>>> --- a/meta/recipes-support/libusb/libusb1_1.0.18.bb
>>> +++ b/meta/recipes-support/libusb/libusb1_1.0.18.bb
>>> @@ -8,12 +8,17 @@ LIC_FILES_CHKSUM =
>>> "file://COPYING;md5=fbc093901857fcd118f065f900982c24"
>>>
>>> BBCLASSEXTEND = "native nativesdk"
>>>
>>> -SRC_URI = "${SOURCEFORGE_MIRROR}/libusb/libusb-${PV}.tar.bz2 \
>>> - "
>>> +SRC_URI = "${SOURCEFORGE_MIRROR}/libusb/libusb-${PV}.tar.bz2"
>>>
>>> SRC_URI[md5sum] = "4a6d049923efc6496f1d383054dac1a6"
>>> SRC_URI[sha256sum] =
>>> "c73f5cec45a5de94418da4e151b7232958571926984acfb9bce02b9424e83720"
>>>
>>> +PACKAGECONFIG ?= "udev"
>>> +PACKAGECONFIG_class-native = ""
>>> +PACKAGECONFIG_class-nativesdk = ""
>>> +
>>> +PACKAGECONFIG[udev] = "--enable-udev,--disable-udev,udev"
>>> +
>>> S = "${WORKDIR}/libusb-${PV}"
>>>
>>> inherit autotools pkgconfig
>>>
>>> If this looks good I can submit a proper patch for it.
>>>
>>> /Jacob
>>>
>
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] libusb1: Update to 1.0.18
2014-05-16 20:18 ` Andrea Adami
@ 2014-05-16 20:29 ` Andrea Adami
0 siblings, 0 replies; 8+ messages in thread
From: Andrea Adami @ 2014-05-16 20:29 UTC (permalink / raw)
To: openembedded-core
On Fri, May 16, 2014 at 10:18 PM, Andrea Adami <andrea.adami@gmail.com> wrote:
> On Fri, May 16, 2014 at 8:47 PM, Jacob Kroon <jacob.kroon@gmail.com> wrote:
>> On Fri, May 16, 2014 at 7:14 PM, Saul Wold <sgw@linux.intel.com> wrote:
>>>
>>> On 05/16/2014 05:16 AM, Jacob Kroon wrote:
>>>>
>>>> On Fri, May 16, 2014 at 7:13 AM, Jacob Kroon <jacob.kroon@gmail.com>
>>>> wrote:
>>>>
>>>>> Hello Saul,
>>>>>
>>>>>
>>>>> On Thu, May 15, 2014 at 5:58 PM, Saul Wold <sgw@linux.intel.com> wrote:
>>>>>
>>>>>> Signed-off-by: Saul Wold <sgw@linux.intel.com>
>>>>>> ---
>>>>>> .../{libusb1-1.0.9 => libusb1}/obsolete_automake_macros.patch |
>>>>>> 0
>>>>>> .../recipes-support/libusb/{libusb1_1.0.9.bb => libusb1_1.0.18.bb} |
>>>>>> 7
>>>>>> ++-----
>>>>>> 2 files changed, 2 insertions(+), 5 deletions(-)
>>>>>> rename meta/recipes-support/libusb/{libusb1-1.0.9 =>
>>>>>> libusb1}/obsolete_automake_macros.patch (100%)
>>>>>> rename meta/recipes-support/libusb/{libusb1_1.0.9.bb =>
>>>>>> libusb1_1.0.18.bb} (78%)
>>>>>>
>>>>>> diff --git
>>>>>>
>>>>>> a/meta/recipes-support/libusb/libusb1-1.0.9/obsolete_automake_macros.patch
>>>>>> b/meta/recipes-support/libusb/libusb1/obsolete_automake_macros.patch
>>>>>> similarity index 100%
>>>>>> rename from
>>>>>>
>>>>>> meta/recipes-support/libusb/libusb1-1.0.9/obsolete_automake_macros.patch
>>>>>> rename to
>>>>>> meta/recipes-support/libusb/libusb1/obsolete_automake_macros.patch
>>>>>> diff --git
>>>>>> a/meta/recipes-support/libusb/libusb1_1.0.9.bbb/meta/recipes-support/libusb/
>>>>>> libusb1_1.0.18.bb
>>>>>> similarity index 78%
>>>>>> rename from meta/recipes-support/libusb/libusb1_1.0.9.bb
>>>>>> rename to meta/recipes-support/libusb/libusb1_1.0.18.bb
>>>>>> index d57425b..c64f1db 100644
>>>>>> --- a/meta/recipes-support/libusb/libusb1_1.0.9.bb
>>>>>> +++ b/meta/recipes-support/libusb/libusb1_1.0.18.bb
>>>>>> @@ -8,14 +8,11 @@ LIC_FILES_CHKSUM =
>>>>>> "file://COPYING;md5=fbc093901857fcd118f065f900982c24"
>>>>>>
>>>>>> BBCLASSEXTEND = "native nativesdk"
>>>>>>
>>>>>> -PR = "r1"
>>>>>> -
>>>>>> SRC_URI = "${SOURCEFORGE_MIRROR}/libusb/libusb-${PV}.tar.bz2 \
>>>>>> - file://obsolete_automake_macros.patch \
>>>>>> "
>>>>>>
>>>>>
>>>>> That patch is still in git, maybe it should be removed as well ?
>>>>>
>>>>>
>>>> Also, I think it needs to be added a PACKAGECONFIG for "udev", otherwise
>>>> I
>>>> get a build failure when I generate an SDK on my system,
>>>> configure script can't find udev although it was requested.
>>>>
>>>
>>>> Something like the patch below does the trick for me:
>>>>
>>> I am supprised you did not see a circular dependency with udev -> libusb
>>> -> udev, I think we need to disable-udev as default and if there is a need
>>> for a libusb with udev support we will have to create a new recipe possibly
>>> to build it after udev is built.
>>>
>>
>> With the patch applied, I wiped my sysroots and did a "cleansstate libusb1
>> udev", and then rebuilt both successfully with no warning
>> about circular dependency. Maybe I'm not hitting the error since I have
>> "systemd" in DISTRO_FEATURES, so it's actually systemd that is the udev
>> provider.
>>
>>> Thoughts here?
>>>
>>> Sau!
>>>
>>>
>
> Yes, building sysvinit I get the failure:
> | checking operating system... Linux
> | checking for library containing clock_gettime... none required
> | checking libudev.h usability... no
> | checking libudev.h presence... no
> | checking for libudev.h... no
> | configure: error: "udev support requested but libudev not installed"
> | Configure failed. The contents of all config.log files follows to
> aid debugging
> | ERROR: oe_runconf failed
> | WARNING: exit code 1 from a shell command.
> | ERROR: Function failed: do_configure (log file is located at
> /oe/oe-core/build/tmp-eglibc/
> work/armv4-oe-linux-gnueabi/libusb1/1.0.18-r0/temp/log.do_configure.23838)
> ERROR: Task 1803
> (/oe/oe-core/meta/recipes-support/libusb/libusb1_1.0.18.bb,
> do_configure) failed with exit code '1'
>
> Andrea
>
>
And I can confirm the patch gives circular dependencies issues with sysvinit.
ERROR:
Dependency loop #1 found:
Task 734 (/oe/oe-core/meta/recipes-core/udev/udev_182.bb,
do_packagedata) (dependent Tasks ['udev, do_package'])
...
Workaround for now is
PACKAGECONFIG ?= "--disable-udev"
Cheers
Andrea
>>>
>>>> --- a/meta/recipes-support/libusb/libusb1_1.0.18.bb
>>>> +++ b/meta/recipes-support/libusb/libusb1_1.0.18.bb
>>>> @@ -8,12 +8,17 @@ LIC_FILES_CHKSUM =
>>>> "file://COPYING;md5=fbc093901857fcd118f065f900982c24"
>>>>
>>>> BBCLASSEXTEND = "native nativesdk"
>>>>
>>>> -SRC_URI = "${SOURCEFORGE_MIRROR}/libusb/libusb-${PV}.tar.bz2 \
>>>> - "
>>>> +SRC_URI = "${SOURCEFORGE_MIRROR}/libusb/libusb-${PV}.tar.bz2"
>>>>
>>>> SRC_URI[md5sum] = "4a6d049923efc6496f1d383054dac1a6"
>>>> SRC_URI[sha256sum] =
>>>> "c73f5cec45a5de94418da4e151b7232958571926984acfb9bce02b9424e83720"
>>>>
>>>> +PACKAGECONFIG ?= "udev"
>>>> +PACKAGECONFIG_class-native = ""
>>>> +PACKAGECONFIG_class-nativesdk = ""
>>>> +
>>>> +PACKAGECONFIG[udev] = "--enable-udev,--disable-udev,udev"
>>>> +
>>>> S = "${WORKDIR}/libusb-${PV}"
>>>>
>>>> inherit autotools pkgconfig
>>>>
>>>> If this looks good I can submit a proper patch for it.
>>>>
>>>> /Jacob
>>>>
>>
>>
>> --
>> _______________________________________________
>> Openembedded-core mailing list
>> Openembedded-core@lists.openembedded.org
>> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] libusb1: Update to 1.0.18
2014-05-16 17:14 ` Saul Wold
2014-05-16 18:47 ` Jacob Kroon
@ 2014-05-17 5:26 ` Khem Raj
1 sibling, 0 replies; 8+ messages in thread
From: Khem Raj @ 2014-05-17 5:26 UTC (permalink / raw)
To: Saul Wold; +Cc: openembedded-core
On Fri, May 16, 2014 at 10:14 AM, Saul Wold <sgw@linux.intel.com> wrote:
> I am supprised you did not see a circular dependency with udev -> libusb ->
> udev, I think we need to disable-udev as default and if there is a need for
> a libusb with udev support we will have to create a new recipe possibly to
> build it after udev is built.
>
> Thoughts here?
udev dependency on libusb seems wrong to me. Do we use usbutils IDs somehow ?
otherwise remove the dep from udev.
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2014-05-17 5:27 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-05-15 15:58 [PATCH] libusb1: Update to 1.0.18 Saul Wold
2014-05-16 5:13 ` Jacob Kroon
2014-05-16 12:16 ` Jacob Kroon
2014-05-16 17:14 ` Saul Wold
2014-05-16 18:47 ` Jacob Kroon
2014-05-16 20:18 ` Andrea Adami
2014-05-16 20:29 ` Andrea Adami
2014-05-17 5:26 ` Khem Raj
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.