* [PATCH 3/8 linux-next] libnvdimm, namespace: move persistence warning
@ 2016-12-02 19:20 ` Fabian Frederick
0 siblings, 0 replies; 4+ messages in thread
From: Fabian Frederick @ 2016-12-02 19:20 UTC (permalink / raw)
To: Dan Williams; +Cc: fabf, linux-kernel, linux-nvdimm
There's no need to warn on persistence yet as some validity tests
are on the way.
Signed-off-by: Fabian Frederick <fabf@skynet.be>
---
drivers/nvdimm/pmem.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/nvdimm/pmem.c b/drivers/nvdimm/pmem.c
index 822a712..204912c 100644
--- a/drivers/nvdimm/pmem.c
+++ b/drivers/nvdimm/pmem.c
@@ -266,9 +266,6 @@ static int pmem_attach_disk(struct device *dev,
dev_set_drvdata(dev, pmem);
pmem->phys_addr = res->start;
pmem->size = resource_size(res);
- if (nvdimm_has_flush(nd_region) < 0)
- dev_warn(dev, "unable to guarantee persistence of writes due to unknown flushing capability of the memory region\n");
-
if (!devm_request_mem_region(dev, res->start, resource_size(res),
dev_name(dev))) {
dev_warn(dev, "could not reserve region %pR\n", res);
@@ -279,6 +276,9 @@ static int pmem_attach_disk(struct device *dev,
if (!q)
return -ENOMEM;
+ if (nvdimm_has_flush(nd_region) < 0)
+ dev_warn(dev, "unable to guarantee persistence of writes due to unknown flushing capability of the memory region\n");
+
pmem->pfn_flags = PFN_DEV;
if (is_nd_pfn(dev)) {
addr = devm_memremap_pages(dev, &pfn_res, &q->q_usage_counter,
--
2.7.4
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 3/8 linux-next] libnvdimm, namespace: move persistence warning
@ 2016-12-02 19:20 ` Fabian Frederick
0 siblings, 0 replies; 4+ messages in thread
From: Fabian Frederick @ 2016-12-02 19:20 UTC (permalink / raw)
To: Dan Williams; +Cc: linux-nvdimm, linux-kernel, fabf
There's no need to warn on persistence yet as some validity tests
are on the way.
Signed-off-by: Fabian Frederick <fabf@skynet.be>
---
drivers/nvdimm/pmem.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/nvdimm/pmem.c b/drivers/nvdimm/pmem.c
index 822a712..204912c 100644
--- a/drivers/nvdimm/pmem.c
+++ b/drivers/nvdimm/pmem.c
@@ -266,9 +266,6 @@ static int pmem_attach_disk(struct device *dev,
dev_set_drvdata(dev, pmem);
pmem->phys_addr = res->start;
pmem->size = resource_size(res);
- if (nvdimm_has_flush(nd_region) < 0)
- dev_warn(dev, "unable to guarantee persistence of writes due to unknown flushing capability of the memory region\n");
-
if (!devm_request_mem_region(dev, res->start, resource_size(res),
dev_name(dev))) {
dev_warn(dev, "could not reserve region %pR\n", res);
@@ -279,6 +276,9 @@ static int pmem_attach_disk(struct device *dev,
if (!q)
return -ENOMEM;
+ if (nvdimm_has_flush(nd_region) < 0)
+ dev_warn(dev, "unable to guarantee persistence of writes due to unknown flushing capability of the memory region\n");
+
pmem->pfn_flags = PFN_DEV;
if (is_nd_pfn(dev)) {
addr = devm_memremap_pages(dev, &pfn_res, &q->q_usage_counter,
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 3/8 linux-next] libnvdimm, namespace: move persistence warning
2016-12-02 19:20 ` Fabian Frederick
@ 2016-12-02 20:51 ` Dan Williams
-1 siblings, 0 replies; 4+ messages in thread
From: Dan Williams @ 2016-12-02 20:51 UTC (permalink / raw)
To: Fabian Frederick; +Cc: linux-kernel, linux-nvdimm
On Fri, Dec 2, 2016 at 11:20 AM, Fabian Frederick <fabf@skynet.be> wrote:
> There's no need to warn on persistence yet as some validity tests
> are on the way.
>
> Signed-off-by: Fabian Frederick <fabf@skynet.be>
> ---
> drivers/nvdimm/pmem.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/nvdimm/pmem.c b/drivers/nvdimm/pmem.c
> index 822a712..204912c 100644
> --- a/drivers/nvdimm/pmem.c
> +++ b/drivers/nvdimm/pmem.c
> @@ -266,9 +266,6 @@ static int pmem_attach_disk(struct device *dev,
> dev_set_drvdata(dev, pmem);
> pmem->phys_addr = res->start;
> pmem->size = resource_size(res);
> - if (nvdimm_has_flush(nd_region) < 0)
> - dev_warn(dev, "unable to guarantee persistence of writes due to unknown flushing capability of the memory region\n");
> -
> if (!devm_request_mem_region(dev, res->start, resource_size(res),
> dev_name(dev))) {
> dev_warn(dev, "could not reserve region %pR\n", res);
> @@ -279,6 +276,9 @@ static int pmem_attach_disk(struct device *dev,
> if (!q)
> return -ENOMEM;
>
> + if (nvdimm_has_flush(nd_region) < 0)
> + dev_warn(dev, "unable to guarantee persistence of writes due to unknown flushing capability of the memory region\n");
> +
> pmem->pfn_flags = PFN_DEV;
> if (is_nd_pfn(dev)) {
> addr = devm_memremap_pages(dev, &pfn_res, &q->q_usage_counter,
With the new sub-section hotplug support I don't think we need this.
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 3/8 linux-next] libnvdimm, namespace: move persistence warning
@ 2016-12-02 20:51 ` Dan Williams
0 siblings, 0 replies; 4+ messages in thread
From: Dan Williams @ 2016-12-02 20:51 UTC (permalink / raw)
To: Fabian Frederick; +Cc: linux-nvdimm@lists.01.org, linux-kernel
On Fri, Dec 2, 2016 at 11:20 AM, Fabian Frederick <fabf@skynet.be> wrote:
> There's no need to warn on persistence yet as some validity tests
> are on the way.
>
> Signed-off-by: Fabian Frederick <fabf@skynet.be>
> ---
> drivers/nvdimm/pmem.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/nvdimm/pmem.c b/drivers/nvdimm/pmem.c
> index 822a712..204912c 100644
> --- a/drivers/nvdimm/pmem.c
> +++ b/drivers/nvdimm/pmem.c
> @@ -266,9 +266,6 @@ static int pmem_attach_disk(struct device *dev,
> dev_set_drvdata(dev, pmem);
> pmem->phys_addr = res->start;
> pmem->size = resource_size(res);
> - if (nvdimm_has_flush(nd_region) < 0)
> - dev_warn(dev, "unable to guarantee persistence of writes due to unknown flushing capability of the memory region\n");
> -
> if (!devm_request_mem_region(dev, res->start, resource_size(res),
> dev_name(dev))) {
> dev_warn(dev, "could not reserve region %pR\n", res);
> @@ -279,6 +276,9 @@ static int pmem_attach_disk(struct device *dev,
> if (!q)
> return -ENOMEM;
>
> + if (nvdimm_has_flush(nd_region) < 0)
> + dev_warn(dev, "unable to guarantee persistence of writes due to unknown flushing capability of the memory region\n");
> +
> pmem->pfn_flags = PFN_DEV;
> if (is_nd_pfn(dev)) {
> addr = devm_memremap_pages(dev, &pfn_res, &q->q_usage_counter,
With the new sub-section hotplug support I don't think we need this.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-12-02 20:51 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-12-02 19:20 [PATCH 3/8 linux-next] libnvdimm, namespace: move persistence warning Fabian Frederick
2016-12-02 19:20 ` Fabian Frederick
2016-12-02 20:51 ` Dan Williams
2016-12-02 20:51 ` Dan Williams
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.