From: Dan Williams <dan.j.williams@intel.com>
To: Anup Patel <anup.patel@broadcom.com>
Cc: Vinod Koul <vinod.koul@intel.com>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
"David S . Miller" <davem@davemloft.net>,
Jassi Brar <jassisinghbrar@gmail.com>,
Ray Jui <rjui@broadcom.com>,
Scott Branden <sbranden@broadcom.com>,
Jon Mason <jonmason@broadcom.com>,
Rob Rice <rob.rice@broadcom.com>,
BCM Kernel Feedback <bcm-kernel-feedback-list@broadcom.com>,
"dmaengine@vger.kernel.org" <dmaengine@vger.kernel.org>,
Device Tree <devicetree@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
linux-crypto@vger.kernel.org,
linux-raid <linux-raid@vger.kernel.org>
Subject: Re: [PATCH v2 2/5] async_tx: Handle DMA devices having support for fewer PQ coefficients
Date: Tue, 7 Feb 2017 00:27:23 -0800 [thread overview]
Message-ID: <CAPcyv4gbV1yf52JrejW+Dn3wOPn7Er+8HWdu2qsW0+Qm+cRr9g@mail.gmail.com> (raw)
In-Reply-To: <1486455406-11202-3-git-send-email-anup.patel@broadcom.com>
On Tue, Feb 7, 2017 at 12:16 AM, Anup Patel <anup.patel@broadcom.com> wrote:
> The DMAENGINE framework assumes that if PQ offload is supported by a
> DMA device then all 256 PQ coefficients are supported. This assumption
> does not hold anymore because we now have BCM-SBA-RAID offload engine
> which supports PQ offload with limited number of PQ coefficients.
>
> This patch extends async_tx APIs to handle DMA devices with support
> for fewer PQ coefficients.
>
> Signed-off-by: Anup Patel <anup.patel@broadcom.com>
> Reviewed-by: Scott Branden <scott.branden@broadcom.com>
I don't like this approach. Define an interface for md to query the
offload engine once at the beginning of time. We should not be adding
any new extensions to async_tx.
WARNING: multiple messages have this Message-ID (diff)
From: dan.j.williams@intel.com (Dan Williams)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 2/5] async_tx: Handle DMA devices having support for fewer PQ coefficients
Date: Tue, 7 Feb 2017 00:27:23 -0800 [thread overview]
Message-ID: <CAPcyv4gbV1yf52JrejW+Dn3wOPn7Er+8HWdu2qsW0+Qm+cRr9g@mail.gmail.com> (raw)
In-Reply-To: <1486455406-11202-3-git-send-email-anup.patel@broadcom.com>
On Tue, Feb 7, 2017 at 12:16 AM, Anup Patel <anup.patel@broadcom.com> wrote:
> The DMAENGINE framework assumes that if PQ offload is supported by a
> DMA device then all 256 PQ coefficients are supported. This assumption
> does not hold anymore because we now have BCM-SBA-RAID offload engine
> which supports PQ offload with limited number of PQ coefficients.
>
> This patch extends async_tx APIs to handle DMA devices with support
> for fewer PQ coefficients.
>
> Signed-off-by: Anup Patel <anup.patel@broadcom.com>
> Reviewed-by: Scott Branden <scott.branden@broadcom.com>
I don't like this approach. Define an interface for md to query the
offload engine once at the beginning of time. We should not be adding
any new extensions to async_tx.
next prev parent reply other threads:[~2017-02-07 8:27 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-07 8:16 [PATCH v2 0/5] Broadcom SBA RAID support Anup Patel
2017-02-07 8:16 ` Anup Patel
2017-02-07 8:16 ` [PATCH v2 1/5] lib/raid6: Add log-of-2 table for RAID6 HW requiring disk position Anup Patel
2017-02-07 8:16 ` Anup Patel
[not found] ` <1486455406-11202-1-git-send-email-anup.patel-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>
2017-02-07 8:16 ` [PATCH v2 2/5] async_tx: Handle DMA devices having support for fewer PQ coefficients Anup Patel
2017-02-07 8:16 ` Anup Patel
2017-02-07 8:16 ` Anup Patel
2017-02-07 8:27 ` Dan Williams [this message]
2017-02-07 8:27 ` Dan Williams
2017-02-07 8:27 ` Dan Williams
2017-02-07 9:02 ` Anup Patel
2017-02-07 9:02 ` Anup Patel
2017-02-07 9:02 ` Anup Patel
2017-02-07 16:42 ` Vinod Koul
2017-02-07 16:42 ` Vinod Koul
2017-02-07 16:42 ` Vinod Koul
2017-02-08 6:37 ` Anup Patel
2017-02-08 6:37 ` Anup Patel
2017-02-08 6:37 ` Anup Patel
2017-02-07 18:16 ` Dan Williams
2017-02-07 18:16 ` Dan Williams
2017-02-07 18:16 ` Dan Williams
2017-02-08 8:57 ` Anup Patel
2017-02-08 8:57 ` Anup Patel
2017-02-08 8:57 ` Anup Patel
2017-02-08 16:24 ` Dan Williams
2017-02-08 16:24 ` Dan Williams
2017-02-08 16:24 ` Dan Williams
[not found] ` <CAPcyv4iFJXxvJFrUs2jtwP9GX5NcJ8LiEDHeZ5b1fwjCAToe5w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-02-09 9:29 ` Anup Patel
2017-02-09 9:29 ` Anup Patel
2017-02-09 9:29 ` Anup Patel
2017-02-09 16:44 ` Dan Williams
2017-02-09 16:44 ` Dan Williams
2017-02-09 16:44 ` Dan Williams
2017-02-10 3:24 ` Anup Patel
2017-02-10 3:24 ` Anup Patel
2017-02-10 3:24 ` Anup Patel
2017-02-07 8:16 ` [PATCH v2 3/5] async_tx: Fix DMA_PREP_FENCE usage in do_async_gen_syndrome() Anup Patel
2017-02-07 8:16 ` Anup Patel
2017-02-07 8:16 ` Anup Patel
2017-02-07 8:16 ` [PATCH v2 4/5] dmaengine: Add Broadcom SBA RAID driver Anup Patel
2017-02-07 8:16 ` Anup Patel
2017-02-07 8:16 ` [PATCH v2 5/5] dt-bindings: Add DT bindings document for " Anup Patel
2017-02-07 8:16 ` Anup Patel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPcyv4gbV1yf52JrejW+Dn3wOPn7Er+8HWdu2qsW0+Qm+cRr9g@mail.gmail.com \
--to=dan.j.williams@intel.com \
--cc=anup.patel@broadcom.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=herbert@gondor.apana.org.au \
--cc=jassisinghbrar@gmail.com \
--cc=jonmason@broadcom.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=rjui@broadcom.com \
--cc=rob.rice@broadcom.com \
--cc=robh+dt@kernel.org \
--cc=sbranden@broadcom.com \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.