From: Dan Williams <dan.j.williams@intel.com>
To: Ben Widawsky <ben.widawsky@intel.com>
Cc: linux-cxl@vger.kernel.org, Andrew Donnellan <ajd@linux.ibm.com>,
Bjorn Helgaas <helgaas@kernel.org>,
"David E. Box" <david.e.box@linux.intel.com>,
David Woodhouse <dwmw2@infradead.org>,
Frederic Barrat <fbarrat@linux.ibm.com>,
Kan Liang <kan.liang@linux.intel.com>,
Lu Baolu <baolu.lu@linux.intel.com>,
"open list:DMA MAPPING HELPERS"
<iommu@lists.linux-foundation.org>,
Linux PCI <linux-pci@vger.kernel.org>,
linuxppc-dev <linuxppc-dev@lists.ozlabs.org>
Subject: Re: [PATCH v2 2/9] cxl/pci: Remove dev_dbg for unknown register blocks
Date: Tue, 28 Sep 2021 07:37:58 -0700 [thread overview]
Message-ID: <CAPcyv4gyLKpOh4Scbbq8O8_5HByAymigrybek4F_3_+=3cQ9LQ@mail.gmail.com> (raw)
In-Reply-To: <20210923172647.72738-3-ben.widawsky@intel.com>
On Thu, Sep 23, 2021 at 10:27 AM Ben Widawsky <ben.widawsky@intel.com> wrote:
>
> While interesting to driver developers, the dev_dbg message doesn't do
> much except clutter up logs. This information should be attainable
> through sysfs, and someday lspci like utilities. This change
> additionally helps reduce the LOC in a subsequent patch to refactor some
> of cxl_pci register mapping.
Looks good to me:
Reviewed-by: Dan Williams <dan.j.williams@intel.com>
WARNING: multiple messages have this Message-ID (diff)
From: Dan Williams <dan.j.williams@intel.com>
To: Ben Widawsky <ben.widawsky@intel.com>
Cc: Andrew Donnellan <ajd@linux.ibm.com>,
Linux PCI <linux-pci@vger.kernel.org>,
linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,
linux-cxl@vger.kernel.org,
"open list:DMA MAPPING HELPERS"
<iommu@lists.linux-foundation.org>,
Bjorn Helgaas <helgaas@kernel.org>,
"David E. Box" <david.e.box@linux.intel.com>,
David Woodhouse <dwmw2@infradead.org>,
Kan Liang <kan.liang@linux.intel.com>
Subject: Re: [PATCH v2 2/9] cxl/pci: Remove dev_dbg for unknown register blocks
Date: Tue, 28 Sep 2021 07:37:58 -0700 [thread overview]
Message-ID: <CAPcyv4gyLKpOh4Scbbq8O8_5HByAymigrybek4F_3_+=3cQ9LQ@mail.gmail.com> (raw)
In-Reply-To: <20210923172647.72738-3-ben.widawsky@intel.com>
On Thu, Sep 23, 2021 at 10:27 AM Ben Widawsky <ben.widawsky@intel.com> wrote:
>
> While interesting to driver developers, the dev_dbg message doesn't do
> much except clutter up logs. This information should be attainable
> through sysfs, and someday lspci like utilities. This change
> additionally helps reduce the LOC in a subsequent patch to refactor some
> of cxl_pci register mapping.
Looks good to me:
Reviewed-by: Dan Williams <dan.j.williams@intel.com>
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
WARNING: multiple messages have this Message-ID (diff)
From: Dan Williams <dan.j.williams@intel.com>
To: Ben Widawsky <ben.widawsky@intel.com>
Cc: Andrew Donnellan <ajd@linux.ibm.com>,
Linux PCI <linux-pci@vger.kernel.org>,
linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,
linux-cxl@vger.kernel.org,
"open list:DMA MAPPING HELPERS"
<iommu@lists.linux-foundation.org>,
Bjorn Helgaas <helgaas@kernel.org>,
"David E. Box" <david.e.box@linux.intel.com>,
Frederic Barrat <fbarrat@linux.ibm.com>,
Lu Baolu <baolu.lu@linux.intel.com>,
David Woodhouse <dwmw2@infradead.org>,
Kan Liang <kan.liang@linux.intel.com>
Subject: Re: [PATCH v2 2/9] cxl/pci: Remove dev_dbg for unknown register blocks
Date: Tue, 28 Sep 2021 07:37:58 -0700 [thread overview]
Message-ID: <CAPcyv4gyLKpOh4Scbbq8O8_5HByAymigrybek4F_3_+=3cQ9LQ@mail.gmail.com> (raw)
In-Reply-To: <20210923172647.72738-3-ben.widawsky@intel.com>
On Thu, Sep 23, 2021 at 10:27 AM Ben Widawsky <ben.widawsky@intel.com> wrote:
>
> While interesting to driver developers, the dev_dbg message doesn't do
> much except clutter up logs. This information should be attainable
> through sysfs, and someday lspci like utilities. This change
> additionally helps reduce the LOC in a subsequent patch to refactor some
> of cxl_pci register mapping.
Looks good to me:
Reviewed-by: Dan Williams <dan.j.williams@intel.com>
next prev parent reply other threads:[~2021-09-28 14:38 UTC|newest]
Thread overview: 72+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-23 17:26 [PATCH v2 0/9] cxl_pci refactor for reusability Ben Widawsky
2021-09-23 17:26 ` Ben Widawsky
2021-09-23 17:26 ` Ben Widawsky
2021-09-23 17:26 ` [PATCH v2 1/9] cxl: Convert "RBI" to enum Ben Widawsky
2021-09-23 17:26 ` Ben Widawsky
2021-09-23 17:26 ` Ben Widawsky
2021-09-27 23:13 ` Dan Williams
2021-09-27 23:13 ` Dan Williams
2021-09-27 23:13 ` Dan Williams
2021-09-23 17:26 ` [PATCH v2 2/9] cxl/pci: Remove dev_dbg for unknown register blocks Ben Widawsky
2021-09-23 17:26 ` Ben Widawsky
2021-09-23 17:26 ` Ben Widawsky
2021-09-28 14:37 ` Dan Williams [this message]
2021-09-28 14:37 ` Dan Williams
2021-09-28 14:37 ` Dan Williams
2021-09-23 17:26 ` [PATCH v2 3/9] cxl/pci: Remove pci request/release regions Ben Widawsky
2021-09-23 17:26 ` Ben Widawsky
2021-09-23 17:26 ` Ben Widawsky
2021-09-28 14:42 ` Dan Williams
2021-09-28 14:42 ` Dan Williams
2021-09-28 14:42 ` Dan Williams
2021-09-23 17:26 ` [PATCH v2 4/9] cxl/pci: Refactor cxl_pci_setup_regs Ben Widawsky
2021-09-23 17:26 ` Ben Widawsky
2021-09-23 17:26 ` Ben Widawsky
2021-09-28 17:35 ` Dan Williams
2021-09-28 17:35 ` Dan Williams
2021-09-28 17:35 ` Dan Williams
2021-09-23 17:26 ` [PATCH v2 5/9] cxl/pci: Make more use of cxl_register_map Ben Widawsky
2021-09-23 17:26 ` Ben Widawsky
2021-09-23 17:26 ` Ben Widawsky
2021-09-28 17:41 ` Dan Williams
2021-09-28 17:41 ` Dan Williams
2021-09-28 17:41 ` Dan Williams
2021-09-23 17:26 ` [PATCH v2 6/9] PCI: Add pci_find_dvsec_capability to find designated VSEC Ben Widawsky
2021-09-23 17:26 ` Ben Widawsky
2021-09-23 17:26 ` Ben Widawsky
2021-09-23 21:37 ` Liang, Kan
2021-09-23 21:37 ` Liang, Kan
2021-09-23 21:37 ` Liang, Kan
2021-09-27 17:46 ` Bjorn Helgaas
2021-09-27 17:46 ` Bjorn Helgaas
2021-09-27 17:46 ` Bjorn Helgaas
2021-09-28 5:50 ` Andrew Donnellan
2021-09-28 5:50 ` Andrew Donnellan
2021-09-28 5:50 ` Andrew Donnellan
2021-10-01 9:42 ` Jonathan Cameron
2021-10-01 9:42 ` Jonathan Cameron
2021-10-01 9:42 ` Jonathan Cameron
2021-09-23 17:26 ` [PATCH v2 7/9] cxl/pci: Use pci core's DVSEC functionality Ben Widawsky
2021-09-23 17:26 ` Ben Widawsky
2021-09-23 17:26 ` Ben Widawsky
2021-09-28 17:43 ` Dan Williams
2021-09-28 17:43 ` Dan Williams
2021-09-28 17:43 ` Dan Williams
2021-09-23 17:26 ` [PATCH v2 8/9] ocxl: " Ben Widawsky
2021-09-23 17:26 ` Ben Widawsky
2021-09-23 17:26 ` Ben Widawsky
2021-09-28 5:52 ` Andrew Donnellan
2021-09-28 5:52 ` Andrew Donnellan
2021-09-28 5:52 ` Andrew Donnellan
2021-09-23 17:26 ` [PATCH v2 9/9] iommu/vt-d: " Ben Widawsky
2021-09-23 17:26 ` Ben Widawsky
2021-09-23 17:26 ` Ben Widawsky
2021-09-24 6:42 ` Christoph Hellwig
2021-09-24 6:42 ` Christoph Hellwig
2021-09-24 6:42 ` Christoph Hellwig
2021-09-28 17:54 ` Dan Williams
2021-09-28 17:54 ` Dan Williams
2021-09-28 17:54 ` Dan Williams
2021-09-29 1:36 ` Lu Baolu
2021-09-29 1:36 ` Lu Baolu
2021-09-29 1:36 ` Lu Baolu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPcyv4gyLKpOh4Scbbq8O8_5HByAymigrybek4F_3_+=3cQ9LQ@mail.gmail.com' \
--to=dan.j.williams@intel.com \
--cc=ajd@linux.ibm.com \
--cc=baolu.lu@linux.intel.com \
--cc=ben.widawsky@intel.com \
--cc=david.e.box@linux.intel.com \
--cc=dwmw2@infradead.org \
--cc=fbarrat@linux.ibm.com \
--cc=helgaas@kernel.org \
--cc=iommu@lists.linux-foundation.org \
--cc=kan.liang@linux.intel.com \
--cc=linux-cxl@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.