From: Dan Williams <dan.j.williams@intel.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: "Michal Hocko" <mhocko@suse.com>,
"David Hildenbrand" <david@redhat.com>,
linux-nvdimm <linux-nvdimm@lists.01.org>,
stable <stable@vger.kernel.org>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
"Linux MM" <linux-mm@kvack.org>,
"Jérôme Glisse" <jglisse@redhat.com>,
"Vlastimil Babka" <vbabka@suse.cz>,
osalvador@suse.de
Subject: Re: [PATCH v6 00/12] mm: Sub-section memory hotplug support
Date: Wed, 17 Apr 2019 15:59:46 -0700 [thread overview]
Message-ID: <CAPcyv4hB47NJrVi1sm+7msL+6dJNhBD10BJbtLPZRcK2JK6+pg@mail.gmail.com> (raw)
In-Reply-To: <20190417150331.90219ca42a1c0db8632d0fd5@linux-foundation.org>
On Wed, Apr 17, 2019 at 3:04 PM Andrew Morton <akpm@linux-foundation.org> wrote:
>
> On Wed, 17 Apr 2019 11:38:55 -0700 Dan Williams <dan.j.williams@intel.com> wrote:
>
> > The memory hotplug section is an arbitrary / convenient unit for memory
> > hotplug. 'Section-size' units have bled into the user interface
> > ('memblock' sysfs) and can not be changed without breaking existing
> > userspace. The section-size constraint, while mostly benign for typical
> > memory hotplug, has and continues to wreak havoc with 'device-memory'
> > use cases, persistent memory (pmem) in particular. Recall that pmem uses
> > devm_memremap_pages(), and subsequently arch_add_memory(), to allocate a
> > 'struct page' memmap for pmem. However, it does not use the 'bottom
> > half' of memory hotplug, i.e. never marks pmem pages online and never
> > exposes the userspace memblock interface for pmem. This leaves an
> > opening to redress the section-size constraint.
>
> v6 and we're not showing any review activity. Who would be suitable
> people to help out here?
There was quite a bit of review of the cover letter from Michal and
David, but you're right the details not so much as of yet. I'd like to
call out other people where I can reciprocate with some review of my
own. Oscar's altmap work looks like a good candidate for that.
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
WARNING: multiple messages have this Message-ID (diff)
From: Dan Williams <dan.j.williams@intel.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: "David Hildenbrand" <david@redhat.com>,
"Jérôme Glisse" <jglisse@redhat.com>,
"Logan Gunthorpe" <logang@deltatee.com>,
"Toshi Kani" <toshi.kani@hpe.com>,
"Jeff Moyer" <jmoyer@redhat.com>,
"Michal Hocko" <mhocko@suse.com>,
"Vlastimil Babka" <vbabka@suse.cz>,
stable <stable@vger.kernel.org>, "Linux MM" <linux-mm@kvack.org>,
linux-nvdimm <linux-nvdimm@lists.01.org>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
osalvador@suse.de
Subject: Re: [PATCH v6 00/12] mm: Sub-section memory hotplug support
Date: Wed, 17 Apr 2019 15:59:46 -0700 [thread overview]
Message-ID: <CAPcyv4hB47NJrVi1sm+7msL+6dJNhBD10BJbtLPZRcK2JK6+pg@mail.gmail.com> (raw)
In-Reply-To: <20190417150331.90219ca42a1c0db8632d0fd5@linux-foundation.org>
On Wed, Apr 17, 2019 at 3:04 PM Andrew Morton <akpm@linux-foundation.org> wrote:
>
> On Wed, 17 Apr 2019 11:38:55 -0700 Dan Williams <dan.j.williams@intel.com> wrote:
>
> > The memory hotplug section is an arbitrary / convenient unit for memory
> > hotplug. 'Section-size' units have bled into the user interface
> > ('memblock' sysfs) and can not be changed without breaking existing
> > userspace. The section-size constraint, while mostly benign for typical
> > memory hotplug, has and continues to wreak havoc with 'device-memory'
> > use cases, persistent memory (pmem) in particular. Recall that pmem uses
> > devm_memremap_pages(), and subsequently arch_add_memory(), to allocate a
> > 'struct page' memmap for pmem. However, it does not use the 'bottom
> > half' of memory hotplug, i.e. never marks pmem pages online and never
> > exposes the userspace memblock interface for pmem. This leaves an
> > opening to redress the section-size constraint.
>
> v6 and we're not showing any review activity. Who would be suitable
> people to help out here?
There was quite a bit of review of the cover letter from Michal and
David, but you're right the details not so much as of yet. I'd like to
call out other people where I can reciprocate with some review of my
own. Oscar's altmap work looks like a good candidate for that.
next prev parent reply other threads:[~2019-04-17 22:59 UTC|newest]
Thread overview: 111+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-17 18:38 [PATCH v6 00/12] mm: Sub-section memory hotplug support Dan Williams
2019-04-17 18:38 ` Dan Williams
2019-04-17 18:39 ` [PATCH v6 01/12] mm/sparsemem: Introduce struct mem_section_usage Dan Williams
2019-04-17 18:39 ` Dan Williams
2019-05-01 23:25 ` Pavel Tatashin
2019-05-01 23:25 ` Pavel Tatashin
2019-05-02 6:07 ` Dan Williams
2019-05-02 6:07 ` Dan Williams
2019-05-02 14:16 ` Pavel Tatashin
2019-05-02 14:16 ` Pavel Tatashin
2019-05-04 0:22 ` Dan Williams
2019-05-04 0:22 ` Dan Williams
2019-05-04 0:22 ` Dan Williams
2019-05-04 15:55 ` Pavel Tatashin
2019-05-04 15:55 ` Pavel Tatashin
2019-05-04 15:55 ` Pavel Tatashin
2019-04-17 18:39 ` [PATCH v6 02/12] mm/sparsemem: Introduce common definitions for the size and mask of a section Dan Williams
2019-04-17 18:39 ` Dan Williams
2019-05-02 14:53 ` Pavel Tatashin
2019-05-03 0:41 ` Dan Williams
2019-05-03 0:41 ` Dan Williams
2019-05-03 10:35 ` Robin Murphy
2019-05-03 10:35 ` Robin Murphy
2019-05-03 12:57 ` Pavel Tatashin
2019-05-03 13:00 ` Oscar Salvador
2019-05-03 13:00 ` Oscar Salvador
2019-04-17 18:39 ` [PATCH v6 03/12] mm/sparsemem: Add helpers track active portions of a section at boot Dan Williams
2019-04-17 18:39 ` Dan Williams
2019-04-25 14:33 ` Oscar Salvador
2019-04-25 14:43 ` Oscar Salvador
2019-04-25 14:43 ` Oscar Salvador
2019-04-25 14:43 ` Oscar Salvador
2019-04-26 12:57 ` Oscar Salvador
2019-04-26 12:57 ` Oscar Salvador
2019-05-02 16:12 ` Pavel Tatashin
2019-05-02 16:12 ` Pavel Tatashin
2019-05-02 16:12 ` Pavel Tatashin
2019-05-04 19:26 ` Dan Williams
2019-05-04 19:26 ` Dan Williams
2019-05-04 19:26 ` Dan Williams
2019-05-04 19:40 ` Pavel Tatashin
2019-05-04 19:40 ` Pavel Tatashin
2019-04-17 18:39 ` [PATCH v6 04/12] mm/hotplug: Prepare shrink_{zone, pgdat}_span for sub-section removal Dan Williams
2019-04-17 18:39 ` Dan Williams
2019-04-19 23:09 ` Ralph Campbell
2019-04-19 23:09 ` Ralph Campbell
2019-04-19 23:13 ` Dan Williams
2019-04-19 23:13 ` Dan Williams
2019-04-19 23:13 ` Dan Williams
2019-04-26 13:59 ` Oscar Salvador
2019-04-26 14:00 ` Oscar Salvador
2019-05-02 19:18 ` Pavel Tatashin
2019-05-02 19:18 ` Pavel Tatashin
2019-05-02 19:18 ` Pavel Tatashin
2019-04-17 18:39 ` [PATCH v6 05/12] mm/sparsemem: Convert kmalloc_section_memmap() to populate_section_memmap() Dan Williams
2019-04-17 18:39 ` Dan Williams
2019-05-02 19:28 ` Pavel Tatashin
2019-05-02 19:28 ` Pavel Tatashin
2019-04-17 18:39 ` [PATCH v6 06/12] mm/hotplug: Add mem-hotplug restrictions for remove_memory() Dan Williams
2019-04-17 18:39 ` Dan Williams
2019-04-23 21:21 ` David Hildenbrand
2019-04-23 21:21 ` David Hildenbrand
2019-04-24 18:07 ` Dan Williams
2019-04-24 18:07 ` Dan Williams
2019-04-17 18:39 ` [PATCH v6 07/12] mm: Kill is_dev_zone() helper Dan Williams
2019-04-17 18:39 ` Dan Williams
2019-04-17 20:17 ` David Hildenbrand
2019-04-17 20:17 ` David Hildenbrand
2019-04-26 14:04 ` Oscar Salvador
2019-04-26 14:04 ` Oscar Salvador
2019-05-02 20:37 ` Pavel Tatashin
2019-05-02 20:37 ` Pavel Tatashin
2019-05-02 20:37 ` Pavel Tatashin
2019-04-17 18:39 ` [PATCH v6 08/12] mm/sparsemem: Prepare for sub-section ranges Dan Williams
2019-04-17 18:39 ` Dan Williams
2019-05-02 21:25 ` Pavel Tatashin
2019-05-02 21:25 ` Pavel Tatashin
2019-05-02 21:25 ` Pavel Tatashin
2019-04-17 18:39 ` [PATCH v6 09/12] mm/sparsemem: Support sub-section hotplug Dan Williams
2019-04-17 18:39 ` Dan Williams
2019-04-17 18:39 ` [PATCH v6 10/12] mm/devm_memremap_pages: Enable sub-section remap Dan Williams
2019-04-17 18:39 ` Dan Williams
2019-04-17 18:39 ` [PATCH v6 11/12] libnvdimm/pfn: Fix fsdax-mode namespace info-block zero-fields Dan Williams
2019-04-17 18:39 ` Dan Williams
2019-04-17 22:02 ` Andrew Morton
2019-04-17 22:02 ` Andrew Morton
2019-04-17 22:09 ` Dan Williams
2019-04-17 22:09 ` Dan Williams
2019-04-17 18:39 ` [PATCH v6 12/12] libnvdimm/pfn: Stop padding pmem namespaces to section alignment Dan Williams
2019-04-17 18:39 ` Dan Williams
2019-04-17 22:03 ` [PATCH v6 00/12] mm: Sub-section memory hotplug support Andrew Morton
2019-04-17 22:03 ` Andrew Morton
2019-04-17 22:59 ` Dan Williams [this message]
2019-04-17 22:59 ` Dan Williams
2019-04-18 2:09 ` Dan Williams
2019-04-18 2:09 ` Dan Williams
2019-04-18 12:45 ` Jeff Moyer
2019-04-18 12:45 ` Jeff Moyer
2019-04-19 3:25 ` Dan Williams
2019-04-19 3:25 ` Dan Williams
2019-04-23 13:16 ` Oscar Salvador
2019-04-23 13:16 ` Oscar Salvador
2019-04-24 20:43 ` Pavel Tatashin
2019-04-24 20:43 ` Pavel Tatashin
2019-05-02 22:46 ` Pavel Tatashin
2019-05-02 23:20 ` Dan Williams
2019-05-02 23:20 ` Dan Williams
2019-05-02 23:21 ` Dan Williams
2019-05-02 23:21 ` Dan Williams
2019-05-03 10:48 ` Oscar Salvador
2019-05-03 10:48 ` Oscar Salvador
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPcyv4hB47NJrVi1sm+7msL+6dJNhBD10BJbtLPZRcK2JK6+pg@mail.gmail.com \
--to=dan.j.williams@intel.com \
--cc=akpm@linux-foundation.org \
--cc=david@redhat.com \
--cc=jglisse@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-nvdimm@lists.01.org \
--cc=mhocko@suse.com \
--cc=osalvador@suse.de \
--cc=stable@vger.kernel.org \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.