From: Dan Williams <dan.j.williams@intel.com>
To: David Woodhouse <dwmw2@infradead.org>
Cc: "hch@lst.de" <hch@lst.de>,
"david.e.box@linux.intel.com" <david.e.box@linux.intel.com>,
"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
"sagi@grimberg.me" <sagi@grimberg.me>,
"lenb@kernel.org" <lenb@kernel.org>,
"rjw@rjwysocki.net" <rjw@rjwysocki.net>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
"axboe@fb.com" <axboe@fb.com>,
"kbusch@kernel.org" <kbusch@kernel.org>,
"bhelgaas@google.com" <bhelgaas@google.com>
Subject: Re: [PATCH 0/2] Add support for StorageD3Enable _DSD property
Date: Mon, 18 May 2020 10:20:23 -0700 [thread overview]
Message-ID: <CAPcyv4hE6iW3MwW=qybN8aXN4wHJ7R2OCDCUEw9FdKu4NeZ6iw@mail.gmail.com> (raw)
In-Reply-To: <b0ca81f973ba55a2d6a8c84bc00f2324bad64f30.camel@infradead.org>
On Mon, May 18, 2020 at 6:52 AM David Woodhouse <dwmw2@infradead.org> wrote:
>
> On Wed, 2020-04-29 at 05:20 +0000, Williams, Dan J wrote:
> > The *patch* is not trying to overrule NVME, and the best I can say is
> > that the Intel Linux team was not in the loop when this was being
> > decided between the platform BIOS implemenation and whomever thought
> > they could just publish random ACPI properties that impacted NVME
> > operation [1].
> >
> > So now David is trying to get these platform unbroken because they are
> > already shipping with this b0rkage.
>
> This is what we have WARN_TAINT() for though, right? It can suitably
> warn users when such breakage is detected in the platform.
>
I see WARN_TAINT() as "BIOS implemented its specification wrong". This
case is BIOS "implemented a mechanism in the wrong specification".
WARNING: multiple messages have this Message-ID (diff)
From: Dan Williams <dan.j.williams@intel.com>
To: David Woodhouse <dwmw2@infradead.org>
Cc: "sagi@grimberg.me" <sagi@grimberg.me>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
"rjw@rjwysocki.net" <rjw@rjwysocki.net>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
"axboe@fb.com" <axboe@fb.com>,
"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
"david.e.box@linux.intel.com" <david.e.box@linux.intel.com>,
"kbusch@kernel.org" <kbusch@kernel.org>,
"bhelgaas@google.com" <bhelgaas@google.com>,
"hch@lst.de" <hch@lst.de>, "lenb@kernel.org" <lenb@kernel.org>
Subject: Re: [PATCH 0/2] Add support for StorageD3Enable _DSD property
Date: Mon, 18 May 2020 10:20:23 -0700 [thread overview]
Message-ID: <CAPcyv4hE6iW3MwW=qybN8aXN4wHJ7R2OCDCUEw9FdKu4NeZ6iw@mail.gmail.com> (raw)
In-Reply-To: <b0ca81f973ba55a2d6a8c84bc00f2324bad64f30.camel@infradead.org>
On Mon, May 18, 2020 at 6:52 AM David Woodhouse <dwmw2@infradead.org> wrote:
>
> On Wed, 2020-04-29 at 05:20 +0000, Williams, Dan J wrote:
> > The *patch* is not trying to overrule NVME, and the best I can say is
> > that the Intel Linux team was not in the loop when this was being
> > decided between the platform BIOS implemenation and whomever thought
> > they could just publish random ACPI properties that impacted NVME
> > operation [1].
> >
> > So now David is trying to get these platform unbroken because they are
> > already shipping with this b0rkage.
>
> This is what we have WARN_TAINT() for though, right? It can suitably
> warn users when such breakage is detected in the platform.
>
I see WARN_TAINT() as "BIOS implemented its specification wrong". This
case is BIOS "implemented a mechanism in the wrong specification".
_______________________________________________
linux-nvme mailing list
linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2020-05-18 17:20 UTC|newest]
Thread overview: 78+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-28 0:32 [PATCH 0/2] Add support for StorageD3Enable _DSD property David E. Box
2020-04-28 0:32 ` David E. Box
2020-04-28 0:32 ` [PATCH 1/2] pci: Add ACPI StorageD3Enable _DSD support David E. Box
2020-04-28 0:32 ` David E. Box
2020-05-18 12:34 ` Rafael J. Wysocki
2020-05-18 12:34 ` Rafael J. Wysocki
2020-05-19 17:10 ` David E. Box
2020-05-19 17:10 ` David E. Box
2020-04-28 0:32 ` [PATCH 2/2] drivers/nvme: Add support for ACPI StorageD3Enable property David E. Box
2020-04-28 0:32 ` David E. Box
2020-04-28 5:13 ` [PATCH 0/2] Add support for StorageD3Enable _DSD property Christoph Hellwig
2020-04-28 5:13 ` Christoph Hellwig
2020-04-28 14:09 ` David E. Box
2020-04-28 14:09 ` David E. Box
2020-04-28 14:22 ` Christoph Hellwig
2020-04-28 14:22 ` Christoph Hellwig
2020-04-28 15:27 ` David E. Box
2020-04-28 15:27 ` David E. Box
2020-04-29 5:20 ` Williams, Dan J
2020-04-29 5:20 ` Williams, Dan J
2020-04-29 15:10 ` Keith Busch
2020-04-29 15:10 ` Keith Busch
2020-04-29 16:11 ` David E. Box
2020-04-29 16:11 ` David E. Box
2020-05-01 13:12 ` hch
2020-05-01 13:12 ` hch
2020-05-01 15:54 ` David E. Box
2020-05-01 15:54 ` David E. Box
2020-05-01 13:10 ` hch
2020-05-01 13:10 ` hch
2020-05-18 13:51 ` David Woodhouse
2020-05-18 13:51 ` David Woodhouse
2020-05-18 17:20 ` Dan Williams [this message]
2020-05-18 17:20 ` Dan Williams
2020-06-12 20:48 ` [PATCH V2 0/2] nvme: Add support for ACPI StorageD3Enable property David E. Box
2020-06-12 20:48 ` David E. Box
2020-06-24 18:55 ` David E. Box
2020-06-24 18:55 ` David E. Box
2020-06-24 19:10 ` Dan Williams
2020-06-24 19:10 ` Dan Williams
2020-06-24 19:39 ` David E. Box
2020-06-24 19:39 ` David E. Box
2020-07-02 21:04 ` [PATCH v3] drivers/nvme: " David E. Box
2020-07-02 22:50 ` [PATCH v4] " David E. Box
2020-07-02 22:50 ` David E. Box
2020-07-03 7:18 ` kernel test robot
2020-07-03 7:18 ` kernel test robot
2020-07-06 14:57 ` Rafael J. Wysocki
2020-07-06 14:57 ` Rafael J. Wysocki
2020-07-07 21:24 ` David E. Box
2020-07-07 21:24 ` David E. Box
2020-07-07 7:09 ` Christoph Hellwig
2020-07-07 7:09 ` Christoph Hellwig
2020-07-09 18:43 ` [PATCH V5] " David E. Box
2020-07-09 18:43 ` David E. Box
2020-07-13 11:12 ` Rafael J. Wysocki
2020-07-13 11:12 ` Rafael J. Wysocki
2020-07-16 14:39 ` Christoph Hellwig
2020-07-16 14:39 ` Christoph Hellwig
2021-05-26 19:25 ` Raul E Rangel
2021-05-26 19:25 ` Raul E Rangel
2020-06-12 20:48 ` [PATCH V2 1/2] PCI: Add ACPI StorageD3Enable _DSD support David E. Box
2020-06-12 20:48 ` David E. Box
2020-06-24 21:15 ` Bjorn Helgaas
2020-06-24 21:15 ` Bjorn Helgaas
2020-06-25 11:30 ` Rafael J. Wysocki
2020-06-25 11:30 ` Rafael J. Wysocki
2020-06-25 12:16 ` Mika Westerberg
2020-06-25 12:16 ` Mika Westerberg
2020-06-25 17:07 ` David E. Box
2020-06-25 17:30 ` Bjorn Helgaas
2020-06-25 17:30 ` Bjorn Helgaas
2020-06-24 21:37 ` Bjorn Helgaas
2020-06-24 21:37 ` Bjorn Helgaas
2020-06-24 22:09 ` David E. Box
2020-06-24 22:09 ` David E. Box
2020-06-12 20:48 ` [PATCH V2 2/2] drivers/nvme: Add support for ACPI StorageD3Enable property David E. Box
2020-06-12 20:48 ` David E. Box
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPcyv4hE6iW3MwW=qybN8aXN4wHJ7R2OCDCUEw9FdKu4NeZ6iw@mail.gmail.com' \
--to=dan.j.williams@intel.com \
--cc=axboe@fb.com \
--cc=bhelgaas@google.com \
--cc=david.e.box@linux.intel.com \
--cc=dwmw2@infradead.org \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-pci@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.