* [PATCH 2/8 linux-next] libnvdimm, namespace: add verbosity to persistence warning
@ 2016-12-02 19:20 ` Fabian Frederick
0 siblings, 0 replies; 4+ messages in thread
From: Fabian Frederick @ 2016-12-02 19:20 UTC (permalink / raw)
To: Dan Williams; +Cc: fabf, linux-kernel, linux-nvdimm
Signed-off-by: Fabian Frederick <fabf@skynet.be>
---
drivers/nvdimm/pmem.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/nvdimm/pmem.c b/drivers/nvdimm/pmem.c
index 2461843..822a712 100644
--- a/drivers/nvdimm/pmem.c
+++ b/drivers/nvdimm/pmem.c
@@ -267,7 +267,7 @@ static int pmem_attach_disk(struct device *dev,
pmem->phys_addr = res->start;
pmem->size = resource_size(res);
if (nvdimm_has_flush(nd_region) < 0)
- dev_warn(dev, "unable to guarantee persistence of writes\n");
+ dev_warn(dev, "unable to guarantee persistence of writes due to unknown flushing capability of the memory region\n");
if (!devm_request_mem_region(dev, res->start, resource_size(res),
dev_name(dev))) {
--
2.7.4
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH 2/8 linux-next] libnvdimm, namespace: add verbosity to persistence warning
@ 2016-12-02 19:20 ` Fabian Frederick
0 siblings, 0 replies; 4+ messages in thread
From: Fabian Frederick @ 2016-12-02 19:20 UTC (permalink / raw)
To: Dan Williams; +Cc: linux-nvdimm, linux-kernel, fabf
Signed-off-by: Fabian Frederick <fabf@skynet.be>
---
drivers/nvdimm/pmem.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/nvdimm/pmem.c b/drivers/nvdimm/pmem.c
index 2461843..822a712 100644
--- a/drivers/nvdimm/pmem.c
+++ b/drivers/nvdimm/pmem.c
@@ -267,7 +267,7 @@ static int pmem_attach_disk(struct device *dev,
pmem->phys_addr = res->start;
pmem->size = resource_size(res);
if (nvdimm_has_flush(nd_region) < 0)
- dev_warn(dev, "unable to guarantee persistence of writes\n");
+ dev_warn(dev, "unable to guarantee persistence of writes due to unknown flushing capability of the memory region\n");
if (!devm_request_mem_region(dev, res->start, resource_size(res),
dev_name(dev))) {
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH 2/8 linux-next] libnvdimm, namespace: add verbosity to persistence warning
2016-12-02 19:20 ` Fabian Frederick
@ 2016-12-02 20:53 ` Dan Williams
-1 siblings, 0 replies; 4+ messages in thread
From: Dan Williams @ 2016-12-02 20:53 UTC (permalink / raw)
To: Fabian Frederick; +Cc: linux-kernel, linux-nvdimm
On Fri, Dec 2, 2016 at 11:20 AM, Fabian Frederick <fabf@skynet.be> wrote:
> Signed-off-by: Fabian Frederick <fabf@skynet.be>
> ---
> drivers/nvdimm/pmem.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/nvdimm/pmem.c b/drivers/nvdimm/pmem.c
> index 2461843..822a712 100644
> --- a/drivers/nvdimm/pmem.c
> +++ b/drivers/nvdimm/pmem.c
> @@ -267,7 +267,7 @@ static int pmem_attach_disk(struct device *dev,
> pmem->phys_addr = res->start;
> pmem->size = resource_size(res);
> if (nvdimm_has_flush(nd_region) < 0)
> - dev_warn(dev, "unable to guarantee persistence of writes\n");
> + dev_warn(dev, "unable to guarantee persistence of writes due to unknown flushing capability of the memory region\n");
I'll pass on this one. Another reason could be that the flushing
capability is present but disabled. Just seeing it's not guaranteed
is sufficient.
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 2/8 linux-next] libnvdimm, namespace: add verbosity to persistence warning
@ 2016-12-02 20:53 ` Dan Williams
0 siblings, 0 replies; 4+ messages in thread
From: Dan Williams @ 2016-12-02 20:53 UTC (permalink / raw)
To: Fabian Frederick; +Cc: linux-nvdimm@lists.01.org, linux-kernel
On Fri, Dec 2, 2016 at 11:20 AM, Fabian Frederick <fabf@skynet.be> wrote:
> Signed-off-by: Fabian Frederick <fabf@skynet.be>
> ---
> drivers/nvdimm/pmem.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/nvdimm/pmem.c b/drivers/nvdimm/pmem.c
> index 2461843..822a712 100644
> --- a/drivers/nvdimm/pmem.c
> +++ b/drivers/nvdimm/pmem.c
> @@ -267,7 +267,7 @@ static int pmem_attach_disk(struct device *dev,
> pmem->phys_addr = res->start;
> pmem->size = resource_size(res);
> if (nvdimm_has_flush(nd_region) < 0)
> - dev_warn(dev, "unable to guarantee persistence of writes\n");
> + dev_warn(dev, "unable to guarantee persistence of writes due to unknown flushing capability of the memory region\n");
I'll pass on this one. Another reason could be that the flushing
capability is present but disabled. Just seeing it's not guaranteed
is sufficient.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-12-02 20:53 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-12-02 19:20 [PATCH 2/8 linux-next] libnvdimm, namespace: add verbosity to persistence warning Fabian Frederick
2016-12-02 19:20 ` Fabian Frederick
2016-12-02 20:53 ` Dan Williams
2016-12-02 20:53 ` Dan Williams
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.