* [PATCH -next v2] tools/testing/nvdimm: Make symbol '__nfit_test_ioremap' static
@ 2021-04-20 7:47 ` Zou Wei
0 siblings, 0 replies; 4+ messages in thread
From: Zou Wei @ 2021-04-20 7:47 UTC (permalink / raw)
To: dan.j.williams, vishal.l.verma, dave.jiang, santosh, ira.weiny,
akpm, dan.carpenter, boris.ostrovsky
Cc: linux-nvdimm, linux-kernel, Zou Wei
The sparse tool complains as follows:
tools/testing/nvdimm/test/iomap.c:65:14: warning:
symbol '__nfit_test_ioremap' was not declared. Should it be static?
This symbol is not used outside of iomap.c, so this
commit marks it static.
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zou Wei <zou_wei@huawei.com>
---
tools/testing/nvdimm/test/iomap.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/nvdimm/test/iomap.c b/tools/testing/nvdimm/test/iomap.c
index c62d372..ed563bd 100644
--- a/tools/testing/nvdimm/test/iomap.c
+++ b/tools/testing/nvdimm/test/iomap.c
@@ -62,7 +62,7 @@ struct nfit_test_resource *get_nfit_res(resource_size_t resource)
}
EXPORT_SYMBOL(get_nfit_res);
-void __iomem *__nfit_test_ioremap(resource_size_t offset, unsigned long size,
+static void __iomem *__nfit_test_ioremap(resource_size_t offset, unsigned long size,
void __iomem *(*fallback_fn)(resource_size_t, unsigned long))
{
struct nfit_test_resource *nfit_res = get_nfit_res(offset);
--
2.6.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH -next v2] tools/testing/nvdimm: Make symbol '__nfit_test_ioremap' static
@ 2021-04-20 7:47 ` Zou Wei
0 siblings, 0 replies; 4+ messages in thread
From: Zou Wei @ 2021-04-20 7:47 UTC (permalink / raw)
To: dan.j.williams, vishal.l.verma, dave.jiang, santosh, ira.weiny,
akpm, dan.carpenter, boris.ostrovsky
Cc: linux-nvdimm, linux-kernel, Zou Wei
The sparse tool complains as follows:
tools/testing/nvdimm/test/iomap.c:65:14: warning:
symbol '__nfit_test_ioremap' was not declared. Should it be static?
This symbol is not used outside of iomap.c, so this
commit marks it static.
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zou Wei <zou_wei@huawei.com>
---
tools/testing/nvdimm/test/iomap.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/nvdimm/test/iomap.c b/tools/testing/nvdimm/test/iomap.c
index c62d372..ed563bd 100644
--- a/tools/testing/nvdimm/test/iomap.c
+++ b/tools/testing/nvdimm/test/iomap.c
@@ -62,7 +62,7 @@ struct nfit_test_resource *get_nfit_res(resource_size_t resource)
}
EXPORT_SYMBOL(get_nfit_res);
-void __iomem *__nfit_test_ioremap(resource_size_t offset, unsigned long size,
+static void __iomem *__nfit_test_ioremap(resource_size_t offset, unsigned long size,
void __iomem *(*fallback_fn)(resource_size_t, unsigned long))
{
struct nfit_test_resource *nfit_res = get_nfit_res(offset);
--
2.6.2
_______________________________________________
Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org
To unsubscribe send an email to linux-nvdimm-leave@lists.01.org
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH -next v2] tools/testing/nvdimm: Make symbol '__nfit_test_ioremap' static
2021-04-20 7:47 ` Zou Wei
@ 2021-04-20 23:58 ` Dan Williams
-1 siblings, 0 replies; 4+ messages in thread
From: Dan Williams @ 2021-04-20 23:58 UTC (permalink / raw)
To: Zou Wei
Cc: Vishal L Verma, Dave Jiang, Santosh Sivaraj, Weiny, Ira,
Andrew Morton, Dan Carpenter, Boris Ostrovsky, linux-nvdimm,
Linux Kernel Mailing List
On Tue, Apr 20, 2021 at 12:31 AM Zou Wei <zou_wei@huawei.com> wrote:
>
> The sparse tool complains as follows:
>
> tools/testing/nvdimm/test/iomap.c:65:14: warning:
> symbol '__nfit_test_ioremap' was not declared. Should it be static?
>
> This symbol is not used outside of iomap.c, so this
> commit marks it static.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Zou Wei <zou_wei@huawei.com>
Looks good to me, thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH -next v2] tools/testing/nvdimm: Make symbol '__nfit_test_ioremap' static
@ 2021-04-20 23:58 ` Dan Williams
0 siblings, 0 replies; 4+ messages in thread
From: Dan Williams @ 2021-04-20 23:58 UTC (permalink / raw)
To: Zou Wei
Cc: Andrew Morton, Dan Carpenter, Boris Ostrovsky, linux-nvdimm,
Linux Kernel Mailing List
On Tue, Apr 20, 2021 at 12:31 AM Zou Wei <zou_wei@huawei.com> wrote:
>
> The sparse tool complains as follows:
>
> tools/testing/nvdimm/test/iomap.c:65:14: warning:
> symbol '__nfit_test_ioremap' was not declared. Should it be static?
>
> This symbol is not used outside of iomap.c, so this
> commit marks it static.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Zou Wei <zou_wei@huawei.com>
Looks good to me, thanks.
_______________________________________________
Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org
To unsubscribe send an email to linux-nvdimm-leave@lists.01.org
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-04-20 23:58 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-20 7:47 [PATCH -next v2] tools/testing/nvdimm: Make symbol '__nfit_test_ioremap' static Zou Wei
2021-04-20 7:47 ` Zou Wei
2021-04-20 23:58 ` Dan Williams
2021-04-20 23:58 ` Dan Williams
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.