All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Williams <dan.j.williams@intel.com>
To: Toshi Kani <toshi.kani@hpe.com>
Cc: Vishal Verma <vishal@kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	micah.parrish@hpe.com,
	"linux-nvdimm@lists.01.org" <linux-nvdimm@lists.01.org>
Subject: Re: [PATCH] BTT: Change nd_btt_arena_is_valid() to verify UUID
Date: Tue, 12 Jan 2016 08:38:33 -0800	[thread overview]
Message-ID: <CAPcyv4hodeRzf_2BwA0j6zdmPAoV21iBKbBFWkQ2oP0X+uU+1g@mail.gmail.com> (raw)
In-Reply-To: <1452610938.19330.66.camel@hpe.com>

On Tue, Jan 12, 2016 at 7:02 AM, Toshi Kani <toshi.kani@hpe.com> wrote:
> On Fri, 2015-12-18 at 14:23 -0800, Dan Williams wrote:
>> On Fri, Dec 18, 2015 at 10:52 AM, Toshi Kani <toshi.kani@hpe.com> wrote:
>> > On Fri, 2015-12-18 at 09:54 -0800, Dan Williams wrote:
>> > > On Fri, Dec 18, 2015 at 7:15 AM, Toshi Kani <toshi.kani@hpe.com>
>> > > wrote:
>> > > > On Fri, 2015-12-18 at 01:34 -0700, Vishal Verma wrote:
>> > > > > Also, I wonder if this problem is solved by using libndctl to
>> > > > > manage
>> > > > > BTTs.
>> > > >
>> > > > I have not tested with libndctl yet, but I think our bind/unbind
>> > > > scripts do the same procedures.
>> > >
>> > > We loop through all combinations of sector size in our unit test.  If
>> > > you want to change the sector size the expectation is that the
>> > > namespace is destroyed and fully re-created, especially due to the
>> > > fact that changing sector size invalidates all data on the namespace.
>> > >
>> > > See: https://github.com/pmem/ndctl/blob/master/lib/test-libndctl.c
>> >
>> > The parent_uuid is not set on our NVDIMM-N systems.  I do not see
>> > 'uuid' file under sysfs 'namespaceX.X' per namespace_visible(), either.
>> > This concept of creating/destroying a namespace is a bit foreign to us
>> > since we've never needed to do.  Can you elaborate how it's supposed to
>> > work for NVDIMM-N?
>> >
>>
>> Ugh, yes.  An oversight on my part, let me give this some thought.
>> Whatever we decide, I want the libndctl api to be identical for the
>> two cases.
>>
>> I expect the simplest option is to have
>> ndctl_namespace_disable_invalidate() destroy the btt-info block in the
>> NVDIMM-N case.
>
> Do you have any update on this?  If we are going to use ndctl to address
> this issue, does it mean that we will have to use ndctl to manage BTT?

This is my current proposal:

https://github.com/pmem/ndctl/blob/pending/Documentation/ndctl-create-namespace.txt

WARNING: multiple messages have this Message-ID (diff)
From: Dan Williams <dan.j.williams@intel.com>
To: Toshi Kani <toshi.kani@hpe.com>
Cc: Vishal Verma <vishal@kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	micah.parrish@hpe.com,
	"linux-nvdimm@lists.01.org" <linux-nvdimm@ml01.01.org>
Subject: Re: [PATCH] BTT: Change nd_btt_arena_is_valid() to verify UUID
Date: Tue, 12 Jan 2016 08:38:33 -0800	[thread overview]
Message-ID: <CAPcyv4hodeRzf_2BwA0j6zdmPAoV21iBKbBFWkQ2oP0X+uU+1g@mail.gmail.com> (raw)
In-Reply-To: <1452610938.19330.66.camel@hpe.com>

On Tue, Jan 12, 2016 at 7:02 AM, Toshi Kani <toshi.kani@hpe.com> wrote:
> On Fri, 2015-12-18 at 14:23 -0800, Dan Williams wrote:
>> On Fri, Dec 18, 2015 at 10:52 AM, Toshi Kani <toshi.kani@hpe.com> wrote:
>> > On Fri, 2015-12-18 at 09:54 -0800, Dan Williams wrote:
>> > > On Fri, Dec 18, 2015 at 7:15 AM, Toshi Kani <toshi.kani@hpe.com>
>> > > wrote:
>> > > > On Fri, 2015-12-18 at 01:34 -0700, Vishal Verma wrote:
>> > > > > Also, I wonder if this problem is solved by using libndctl to
>> > > > > manage
>> > > > > BTTs.
>> > > >
>> > > > I have not tested with libndctl yet, but I think our bind/unbind
>> > > > scripts do the same procedures.
>> > >
>> > > We loop through all combinations of sector size in our unit test.  If
>> > > you want to change the sector size the expectation is that the
>> > > namespace is destroyed and fully re-created, especially due to the
>> > > fact that changing sector size invalidates all data on the namespace.
>> > >
>> > > See: https://github.com/pmem/ndctl/blob/master/lib/test-libndctl.c
>> >
>> > The parent_uuid is not set on our NVDIMM-N systems.  I do not see
>> > 'uuid' file under sysfs 'namespaceX.X' per namespace_visible(), either.
>> > This concept of creating/destroying a namespace is a bit foreign to us
>> > since we've never needed to do.  Can you elaborate how it's supposed to
>> > work for NVDIMM-N?
>> >
>>
>> Ugh, yes.  An oversight on my part, let me give this some thought.
>> Whatever we decide, I want the libndctl api to be identical for the
>> two cases.
>>
>> I expect the simplest option is to have
>> ndctl_namespace_disable_invalidate() destroy the btt-info block in the
>> NVDIMM-N case.
>
> Do you have any update on this?  If we are going to use ndctl to address
> this issue, does it mean that we will have to use ndctl to manage BTT?

This is my current proposal:

https://github.com/pmem/ndctl/blob/pending/Documentation/ndctl-create-namespace.txt

  reply	other threads:[~2016-01-12 16:38 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-17 23:00 [PATCH] BTT: Change nd_btt_arena_is_valid() to verify UUID Toshi Kani
2015-12-17 23:00 ` Toshi Kani
2015-12-18  8:34 ` Vishal Verma
2015-12-18  8:34   ` Vishal Verma
2015-12-18 15:15   ` Toshi Kani
2015-12-18 15:15     ` Toshi Kani
2015-12-18 17:54     ` Dan Williams
2015-12-18 17:54       ` Dan Williams
2015-12-18 18:52       ` Toshi Kani
2015-12-18 18:52         ` Toshi Kani
2015-12-18 22:23         ` Dan Williams
2015-12-18 22:23           ` Dan Williams
2016-01-12 15:02           ` Toshi Kani
2016-01-12 15:02             ` Toshi Kani
2016-01-12 16:38             ` Dan Williams [this message]
2016-01-12 16:38               ` Dan Williams
2016-01-12 16:47               ` Linda Knippers
2016-01-12 16:47                 ` Linda Knippers
2016-01-12 16:51                 ` Dan Williams
2016-01-12 16:51                   ` Dan Williams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAPcyv4hodeRzf_2BwA0j6zdmPAoV21iBKbBFWkQ2oP0X+uU+1g@mail.gmail.com \
    --to=dan.j.williams@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nvdimm@lists.01.org \
    --cc=micah.parrish@hpe.com \
    --cc=toshi.kani@hpe.com \
    --cc=vishal@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.