* [PATCH -mmotm] mm: fix SHUFFLE_PAGE_ALLOCATOR help texts
@ 2019-04-25 20:13 Qian Cai
2019-04-25 20:36 ` Dan Williams
0 siblings, 1 reply; 2+ messages in thread
From: Qian Cai @ 2019-04-25 20:13 UTC (permalink / raw)
To: akpm; +Cc: dan.j.williams, linux-mm, Qian Cai
The help texts for SHUFFLE_PAGE_ALLOCATOR makes a wrong assumption that
a page size is 4KB everywhere.
Signed-off-by: Qian Cai <cai@lca.pw>
---
Fix mm-shuffle-initial-free-memory-to-improve-memory-side-cache-utilization.patch.
init/Kconfig | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/init/Kconfig b/init/Kconfig
index b050890f69dc..d96a910369c7 100644
--- a/init/Kconfig
+++ b/init/Kconfig
@@ -1764,8 +1764,9 @@ config SHUFFLE_PAGE_ALLOCATOR
the presence of a memory-side-cache. There are also incidental
security benefits as it reduces the predictability of page
allocations to compliment SLAB_FREELIST_RANDOM, but the
- default granularity of shuffling on 4MB (MAX_ORDER) pages is
- selected based on cache utilization benefits.
+ default granularity of shuffling on the "MAX_ORDER - 1" i.e,
+ 10th order of pages is selected based on cache utilization
+ benefits on x86.
While the randomization improves cache utilization it may
negatively impact workloads on platforms without a cache. For
--
2.20.1 (Apple Git-117)
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -mmotm] mm: fix SHUFFLE_PAGE_ALLOCATOR help texts
2019-04-25 20:13 [PATCH -mmotm] mm: fix SHUFFLE_PAGE_ALLOCATOR help texts Qian Cai
@ 2019-04-25 20:36 ` Dan Williams
0 siblings, 0 replies; 2+ messages in thread
From: Dan Williams @ 2019-04-25 20:36 UTC (permalink / raw)
To: Qian Cai; +Cc: Andrew Morton, Linux MM
On Thu, Apr 25, 2019 at 1:13 PM Qian Cai <cai@lca.pw> wrote:
>
> The help texts for SHUFFLE_PAGE_ALLOCATOR makes a wrong assumption that
> a page size is 4KB everywhere.
>
> Signed-off-by: Qian Cai <cai@lca.pw>
> ---
>
> Fix mm-shuffle-initial-free-memory-to-improve-memory-side-cache-utilization.patch.
>
> init/Kconfig | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/init/Kconfig b/init/Kconfig
> index b050890f69dc..d96a910369c7 100644
> --- a/init/Kconfig
> +++ b/init/Kconfig
> @@ -1764,8 +1764,9 @@ config SHUFFLE_PAGE_ALLOCATOR
> the presence of a memory-side-cache. There are also incidental
> security benefits as it reduces the predictability of page
> allocations to compliment SLAB_FREELIST_RANDOM, but the
> - default granularity of shuffling on 4MB (MAX_ORDER) pages is
> - selected based on cache utilization benefits.
> + default granularity of shuffling on the "MAX_ORDER - 1" i.e,
> + 10th order of pages is selected based on cache utilization
> + benefits on x86.
>
> While the randomization improves cache utilization it may
> negatively impact workloads on platforms without a cache. For
Looks good,
Reviewed-by: Dan Williams <dan.j.williams@intel.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-04-25 20:36 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-25 20:13 [PATCH -mmotm] mm: fix SHUFFLE_PAGE_ALLOCATOR help texts Qian Cai
2019-04-25 20:36 ` Dan Williams
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.