From: Dan Williams <dan.j.williams@intel.com>
To: Huaisheng Ye <yehs2007@zoho.com>
Cc: Jens Axboe <axboe@kernel.dk>,
linux-s390 <linux-s390@vger.kernel.org>, Jan Kara <jack@suse.cz>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
Matthew Wilcox <mawilcox@microsoft.com>,
NingTing Cheng <chengnt@lenovo.com>,
linux-nvdimm <linux-nvdimm@lists.01.org>,
Heiko Carstens <heiko.carstens@de.ibm.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
colyli <colyli@suse.de>, Bart Van Assche <bart.vanassche@wdc.com>,
Al Viro <viro@zeniv.linux.org.uk>,
Greg KH <gregkh@linuxfoundation.org>,
Martin Schwidefsky <schwidefsky@de.ibm.com>,
Jan Kara <jack@suse.com>
Subject: Re: [PATCH 3/3] fs/dax: Assigning NULL to gfn of dax_direct_access if useless
Date: Wed, 4 Jul 2018 07:41:36 -0700 [thread overview]
Message-ID: <CAPcyv4hxx9JjJZGRTg1NHgN9k0Brwj5yozSWMuNCKBi88wKQWw@mail.gmail.com> (raw)
In-Reply-To: <CAPcyv4hPEch02C7UfCGgpXmsCVyT2zwV=4Tr8jv8W1i6_poAJQ@mail.gmail.com>
On Wed, Jul 4, 2018 at 7:37 AM, Dan Williams <dan.j.williams@intel.com> wrote:
> On Wed, Jul 4, 2018 at 6:07 AM, Huaisheng Ye <yehs2007@zoho.com> wrote:
>> ---- On Wed, 04 Jul 2018 19:30:12 +0800 Jan Kara <jack@suse.cz> wrote ----
>> > On Wed 04-07-18 14:40:58, Huaisheng Ye wrote:
>> > > From: Huaisheng Ye <yehs1@lenovo.com>
>> > >
>> > > Some functions within fs/dax don't need to get gfn from direct_access.
>> > > Assigning NULL to gfn of dax_direct_access is more intuitive and simple
>> > > than offering a useless local variable.
>> > >
>> > > Signed-off-by: Huaisheng Ye <yehs1@lenovo.com>
>> >
>> > I like this. You can add:
>> >
>> > Reviewed-by: Jan Kara <jack@suse.cz>
>> >
>> > for the series.
>> >
>> > Honza
>> >
>> I am so happy you like them, thank you very much.
>
> Yes, I like this too. In fact I have a similar patch in my tree
> already that I have been preparing to send out. I am using it to delay
> when we need to have the 'struct page' memmap for dax initialized.
> Attached is the full patch, but the series is still a work in
> progress.
Btw, I'll drop my version and apply your series since you got it
posted first and it can stand alone as its own cleanup.
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
WARNING: multiple messages have this Message-ID (diff)
From: Dan Williams <dan.j.williams@intel.com>
To: Huaisheng Ye <yehs2007@zoho.com>
Cc: Jan Kara <jack@suse.cz>, linux-nvdimm <linux-nvdimm@lists.01.org>,
Ross Zwisler <ross.zwisler@linux.intel.com>,
Matthew Wilcox <mawilcox@microsoft.com>,
Vishal L Verma <vishal.l.verma@intel.com>,
Dave Jiang <dave.jiang@intel.com>,
Martin Schwidefsky <schwidefsky@de.ibm.com>,
Heiko Carstens <heiko.carstens@de.ibm.com>,
Al Viro <viro@zeniv.linux.org.uk>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Jens Axboe <axboe@kernel.dk>,
Greg KH <gregkh@linuxfoundation.org>,
Bart Van Assche <bart.vanassche@wdc.com>,
Jan Kara <jack@suse.com>, NingTing Cheng <chengnt@lenovo.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-s390 <linux-s390@vger.kernel.org>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
Huaisheng Ye <yehs1@lenovo.com>, colyli <colyli@suse.de>
Subject: Re: [PATCH 3/3] fs/dax: Assigning NULL to gfn of dax_direct_access if useless
Date: Wed, 4 Jul 2018 07:41:36 -0700 [thread overview]
Message-ID: <CAPcyv4hxx9JjJZGRTg1NHgN9k0Brwj5yozSWMuNCKBi88wKQWw@mail.gmail.com> (raw)
In-Reply-To: <CAPcyv4hPEch02C7UfCGgpXmsCVyT2zwV=4Tr8jv8W1i6_poAJQ@mail.gmail.com>
On Wed, Jul 4, 2018 at 7:37 AM, Dan Williams <dan.j.williams@intel.com> wrote:
> On Wed, Jul 4, 2018 at 6:07 AM, Huaisheng Ye <yehs2007@zoho.com> wrote:
>> ---- On Wed, 04 Jul 2018 19:30:12 +0800 Jan Kara <jack@suse.cz> wrote ----
>> > On Wed 04-07-18 14:40:58, Huaisheng Ye wrote:
>> > > From: Huaisheng Ye <yehs1@lenovo.com>
>> > >
>> > > Some functions within fs/dax don't need to get gfn from direct_access.
>> > > Assigning NULL to gfn of dax_direct_access is more intuitive and simple
>> > > than offering a useless local variable.
>> > >
>> > > Signed-off-by: Huaisheng Ye <yehs1@lenovo.com>
>> >
>> > I like this. You can add:
>> >
>> > Reviewed-by: Jan Kara <jack@suse.cz>
>> >
>> > for the series.
>> >
>> > Honza
>> >
>> I am so happy you like them, thank you very much.
>
> Yes, I like this too. In fact I have a similar patch in my tree
> already that I have been preparing to send out. I am using it to delay
> when we need to have the 'struct page' memmap for dax initialized.
> Attached is the full patch, but the series is still a work in
> progress.
Btw, I'll drop my version and apply your series since you got it
posted first and it can stand alone as its own cleanup.
next prev parent reply other threads:[~2018-07-04 14:41 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-04 6:40 [PATCH 1/3] nvdimm/pmem: check the validity of the pointer pfn Huaisheng Ye
2018-07-04 6:40 ` Huaisheng Ye
2018-07-04 6:40 ` [PATCH 2/3] drivers/s390/block/dcssblk: " Huaisheng Ye
2018-07-04 6:40 ` Huaisheng Ye
2018-07-04 6:40 ` [PATCH 3/3] fs/dax: Assigning NULL to gfn of dax_direct_access if useless Huaisheng Ye
2018-07-04 6:40 ` Huaisheng Ye
2018-07-04 11:30 ` Jan Kara
2018-07-04 11:30 ` Jan Kara
2018-07-04 13:07 ` Huaisheng Ye
2018-07-04 13:07 ` Huaisheng Ye
2018-07-04 13:07 ` Huaisheng Ye
2018-07-04 14:37 ` Dan Williams
2018-07-04 14:37 ` Dan Williams
2018-07-04 14:41 ` Dan Williams [this message]
2018-07-04 14:41 ` Dan Williams
2018-07-04 15:35 ` [External] " Huaisheng HS1 Ye
2018-07-04 15:35 ` Huaisheng HS1 Ye
2018-07-04 14:40 ` [PATCH 1/3] nvdimm/pmem: check the validity of the pointer pfn Dan Williams
2018-07-04 14:40 ` Dan Williams
2018-07-04 15:35 ` [External] " Huaisheng HS1 Ye
2018-07-04 15:35 ` Huaisheng HS1 Ye
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPcyv4hxx9JjJZGRTg1NHgN9k0Brwj5yozSWMuNCKBi88wKQWw@mail.gmail.com \
--to=dan.j.williams@intel.com \
--cc=axboe@kernel.dk \
--cc=bart.vanassche@wdc.com \
--cc=chengnt@lenovo.com \
--cc=colyli@suse.de \
--cc=gregkh@linuxfoundation.org \
--cc=heiko.carstens@de.ibm.com \
--cc=jack@suse.com \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvdimm@lists.01.org \
--cc=linux-s390@vger.kernel.org \
--cc=mawilcox@microsoft.com \
--cc=schwidefsky@de.ibm.com \
--cc=viro@zeniv.linux.org.uk \
--cc=yehs2007@zoho.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.