All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] dax: pr_err() strings should end with newlines
@ 2017-09-25 10:41 Arvind Yadav
  2017-09-25 15:41 ` Dan Williams
  0 siblings, 1 reply; 2+ messages in thread
From: Arvind Yadav @ 2017-09-25 10:41 UTC (permalink / raw)
  To: dan.j.williams, snitzer, jack, toshi.kani; +Cc: linux-kernel

pr_err() messages should terminated with a new-line to avoid
other messages being concatenated onto the end.

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
 drivers/dax/super.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/dax/super.c b/drivers/dax/super.c
index 557b9370..30d8a5a 100644
--- a/drivers/dax/super.c
+++ b/drivers/dax/super.c
@@ -118,7 +118,7 @@ int __bdev_dax_supported(struct super_block *sb, int blocksize)
 	put_dax(dax_dev);
 
 	if (len < 1) {
-		pr_err("VFS (%s): error: dax access failed (%ld)",
+		pr_err("VFS (%s): error: dax access failed (%ld)\n",
 				sb->s_id, len);
 		return len < 0 ? len : -EIO;
 	}
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] dax: pr_err() strings should end with newlines
  2017-09-25 10:41 [PATCH] dax: pr_err() strings should end with newlines Arvind Yadav
@ 2017-09-25 15:41 ` Dan Williams
  0 siblings, 0 replies; 2+ messages in thread
From: Dan Williams @ 2017-09-25 15:41 UTC (permalink / raw)
  To: Arvind Yadav; +Cc: Mike Snitzer, Jan Kara, Toshi Kani, linux-kernel

On Mon, Sep 25, 2017 at 3:41 AM, Arvind Yadav <arvind.yadav.cs@gmail.com> wrote:
> pr_err() messages should terminated with a new-line to avoid
> other messages being concatenated onto the end.
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>

Thanks, applied.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2017-09-25 15:41 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-09-25 10:41 [PATCH] dax: pr_err() strings should end with newlines Arvind Yadav
2017-09-25 15:41 ` Dan Williams

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.