All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Williams <dan.j.williams@intel.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: linux-fsdevel <linux-fsdevel@vger.kernel.org>,
	linux-nvdimm <linux-nvdimm@lists.01.org>,
	device-mapper development <dm-devel@redhat.com>
Subject: Re: [PATCH 1/5] dax, pmem: Add a dax operation zero_page_range
Date: Fri, 7 Feb 2020 08:57:39 -0800	[thread overview]
Message-ID: <CAPcyv4iTBTOuKjQX3eoojLM=Eai_pfARXmzpMAtgi5OWBHXvzQ@mail.gmail.com> (raw)
In-Reply-To: <20200206074142.GB28365@infradead.org>

On Wed, Feb 5, 2020 at 11:41 PM Christoph Hellwig <hch@infradead.org> wrote:
>
> On Wed, Feb 05, 2020 at 04:40:44PM -0800, Dan Williams wrote:
> > > I don't have any reason not to pass phys_addr_t. If that sounds better,
> > > will make changes.
> >
> > The problem is device-mapper. That wants to use offset to route
> > through the map to the leaf device. If it weren't for the firmware
> > communication requirement you could do:
> >
> > dax_direct_access(...)
> > generic_dax_zero_page_range(...)
> >
> > ...but as long as the firmware error clearing path is required I think
> > we need to do pass the pgoff through the interface and do the pgoff to
> > virt / phys translation inside the ops handler.
>
> Maybe phys_addr_t was the wrong type - but why do we split the offset
> into the block device argument into a pgoff and offset into page instead
> of a single 64-bit value?

Oh, got it yes, that looks odd for sub-page zeroing. Yes, let's just
have one device relative byte-offset.
_______________________________________________
Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org
To unsubscribe send an email to linux-nvdimm-leave@lists.01.org

WARNING: multiple messages have this Message-ID (diff)
From: Dan Williams <dan.j.williams@intel.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Vivek Goyal <vgoyal@redhat.com>,
	linux-fsdevel <linux-fsdevel@vger.kernel.org>,
	linux-nvdimm <linux-nvdimm@lists.01.org>,
	device-mapper development <dm-devel@redhat.com>
Subject: Re: [PATCH 1/5] dax, pmem: Add a dax operation zero_page_range
Date: Fri, 7 Feb 2020 08:57:39 -0800	[thread overview]
Message-ID: <CAPcyv4iTBTOuKjQX3eoojLM=Eai_pfARXmzpMAtgi5OWBHXvzQ@mail.gmail.com> (raw)
In-Reply-To: <20200206074142.GB28365@infradead.org>

On Wed, Feb 5, 2020 at 11:41 PM Christoph Hellwig <hch@infradead.org> wrote:
>
> On Wed, Feb 05, 2020 at 04:40:44PM -0800, Dan Williams wrote:
> > > I don't have any reason not to pass phys_addr_t. If that sounds better,
> > > will make changes.
> >
> > The problem is device-mapper. That wants to use offset to route
> > through the map to the leaf device. If it weren't for the firmware
> > communication requirement you could do:
> >
> > dax_direct_access(...)
> > generic_dax_zero_page_range(...)
> >
> > ...but as long as the firmware error clearing path is required I think
> > we need to do pass the pgoff through the interface and do the pgoff to
> > virt / phys translation inside the ops handler.
>
> Maybe phys_addr_t was the wrong type - but why do we split the offset
> into the block device argument into a pgoff and offset into page instead
> of a single 64-bit value?

Oh, got it yes, that looks odd for sub-page zeroing. Yes, let's just
have one device relative byte-offset.

  reply	other threads:[~2020-02-07 16:57 UTC|newest]

Thread overview: 52+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-03 20:00 [RFC PATCH 0/5][V2] dax,pmem: Provide a dax operation to zero range of memory Vivek Goyal
2020-02-03 20:00 ` Vivek Goyal
2020-02-03 20:00 ` [PATCH 1/5] dax, pmem: Add a dax operation zero_page_range Vivek Goyal
2020-02-03 20:00   ` Vivek Goyal
2020-02-05 18:30   ` Christoph Hellwig
2020-02-05 18:30     ` Christoph Hellwig
2020-02-05 20:02     ` Vivek Goyal
2020-02-05 20:02       ` Vivek Goyal
2020-02-06  0:40       ` Dan Williams
2020-02-06  0:40         ` Dan Williams
2020-02-06  7:41         ` Christoph Hellwig
2020-02-06  7:41           ` Christoph Hellwig
2020-02-07 16:57           ` Dan Williams [this message]
2020-02-07 16:57             ` Dan Williams
2020-02-07 17:01             ` Vivek Goyal
2020-02-07 17:01               ` Vivek Goyal
2020-02-07 17:06               ` Dan Williams
2020-02-07 17:06                 ` Dan Williams
2020-02-06 14:34         ` Vivek Goyal
2020-02-06 14:34           ` Vivek Goyal
2020-02-07 16:58           ` Dan Williams
2020-02-07 16:58             ` Dan Williams
2020-02-03 20:00 ` [PATCH 2/5] s390,dax: Add dax zero_page_range operation to dcssblk driver Vivek Goyal
2020-02-03 20:00   ` Vivek Goyal
2020-02-05 18:32   ` Christoph Hellwig
2020-02-05 18:32     ` Christoph Hellwig
2020-02-05 20:04     ` Vivek Goyal
2020-02-05 20:04       ` Vivek Goyal
2020-02-03 20:00 ` [PATCH 3/5] dm,dax: Add dax zero_page_range operation Vivek Goyal
2020-02-03 20:00   ` Vivek Goyal
2020-02-05 18:33   ` Christoph Hellwig
2020-02-05 18:33     ` Christoph Hellwig
2020-02-07 16:34     ` Vivek Goyal
2020-02-07 16:34       ` Vivek Goyal
2020-02-03 20:00 ` [PATCH 4/5] dax,iomap: Start using dax native zero_page_range() Vivek Goyal
2020-02-03 20:00   ` Vivek Goyal
2020-02-05 18:33   ` Christoph Hellwig
2020-02-05 18:33     ` Christoph Hellwig
2020-02-05 20:10     ` Vivek Goyal
2020-02-05 20:10       ` Vivek Goyal
2020-02-07 15:31     ` Vivek Goyal
2020-02-07 15:31       ` Vivek Goyal
2020-02-03 20:00 ` [PATCH 5/5] dax,iomap: Add helper dax_iomap_zero() to zero a range Vivek Goyal
2020-02-03 20:00   ` Vivek Goyal
2020-02-04  5:17   ` kbuild test robot
2020-02-04  5:17     ` [PATCH 5/5] dax, iomap: " kbuild test robot
2020-02-04  5:17     ` [PATCH 5/5] dax,iomap: " kbuild test robot
2020-02-04  5:17     ` kbuild test robot
2020-02-05 18:36   ` Christoph Hellwig
2020-02-05 18:36     ` Christoph Hellwig
2020-02-05 20:15     ` Vivek Goyal
2020-02-05 20:15       ` Vivek Goyal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAPcyv4iTBTOuKjQX3eoojLM=Eai_pfARXmzpMAtgi5OWBHXvzQ@mail.gmail.com' \
    --to=dan.j.williams@intel.com \
    --cc=dm-devel@redhat.com \
    --cc=hch@infradead.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-nvdimm@lists.01.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.