* [PATCH] JFS: use list_move instead of list_del/list_add
@ 2012-09-06 7:33 Wei Yongjun
2012-09-17 21:42 ` Dave Kleikamp
0 siblings, 1 reply; 2+ messages in thread
From: Wei Yongjun @ 2012-09-06 7:33 UTC (permalink / raw)
To: shaggy; +Cc: yongjun_wei, jfs-discussion, linux-kernel
From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Using list_move() instead of list_del() + list_add().
spatch with a semantic match is used to found this problem.
(http://coccinelle.lip6.fr/)
Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
---
fs/jfs/jfs_txnmgr.c | 9 +++------
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/fs/jfs/jfs_txnmgr.c b/fs/jfs/jfs_txnmgr.c
index bb8b661..5fcc02e 100644
--- a/fs/jfs/jfs_txnmgr.c
+++ b/fs/jfs/jfs_txnmgr.c
@@ -2977,12 +2977,9 @@ int jfs_sync(void *arg)
* put back on the anon_list.
*/
- /* Take off anon_list */
- list_del(&jfs_ip->anon_inode_list);
-
- /* Put on anon_list2 */
- list_add(&jfs_ip->anon_inode_list,
- &TxAnchor.anon_list2);
+ /* Move from anon_list to anon_list2 */
+ list_move(&jfs_ip->anon_inode_list,
+ &TxAnchor.anon_list2);
TXN_UNLOCK();
iput(ip);
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] JFS: use list_move instead of list_del/list_add
2012-09-06 7:33 [PATCH] JFS: use list_move instead of list_del/list_add Wei Yongjun
@ 2012-09-17 21:42 ` Dave Kleikamp
0 siblings, 0 replies; 2+ messages in thread
From: Dave Kleikamp @ 2012-09-17 21:42 UTC (permalink / raw)
To: Wei Yongjun; +Cc: yongjun_wei, jfs-discussion, linux-kernel
Meant to reply earlier. I've sent this to linux-next and will target for
the next mainline merge window.
Thanks,
Shaggy
On 09/06/2012 02:33 AM, Wei Yongjun wrote:
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> Using list_move() instead of list_del() + list_add().
>
> spatch with a semantic match is used to found this problem.
> (http://coccinelle.lip6.fr/)
>
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
> ---
> fs/jfs/jfs_txnmgr.c | 9 +++------
> 1 file changed, 3 insertions(+), 6 deletions(-)
>
> diff --git a/fs/jfs/jfs_txnmgr.c b/fs/jfs/jfs_txnmgr.c
> index bb8b661..5fcc02e 100644
> --- a/fs/jfs/jfs_txnmgr.c
> +++ b/fs/jfs/jfs_txnmgr.c
> @@ -2977,12 +2977,9 @@ int jfs_sync(void *arg)
> * put back on the anon_list.
> */
>
> - /* Take off anon_list */
> - list_del(&jfs_ip->anon_inode_list);
> -
> - /* Put on anon_list2 */
> - list_add(&jfs_ip->anon_inode_list,
> - &TxAnchor.anon_list2);
> + /* Move from anon_list to anon_list2 */
> + list_move(&jfs_ip->anon_inode_list,
> + &TxAnchor.anon_list2);
>
> TXN_UNLOCK();
> iput(ip);
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-09-17 21:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-09-06 7:33 [PATCH] JFS: use list_move instead of list_del/list_add Wei Yongjun
2012-09-17 21:42 ` Dave Kleikamp
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.