* [PATCH] vfio: make local function vfio_pci_intx_unmask_handler() static
@ 2013-03-21 7:45 Wei Yongjun
2013-03-25 17:17 ` Alex Williamson
0 siblings, 1 reply; 2+ messages in thread
From: Wei Yongjun @ 2013-03-21 7:45 UTC (permalink / raw)
To: alex.williamson, arnd; +Cc: yongjun_wei, kvm
From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
vfio_pci_intx_unmask_handler() was not declared. It should be static.
Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
---
drivers/vfio/pci/vfio_pci_intrs.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/vfio/pci/vfio_pci_intrs.c b/drivers/vfio/pci/vfio_pci_intrs.c
index a965091..865175e 100644
--- a/drivers/vfio/pci/vfio_pci_intrs.c
+++ b/drivers/vfio/pci/vfio_pci_intrs.c
@@ -287,7 +287,8 @@ void vfio_pci_intx_mask(struct vfio_pci_device *vdev)
* a signal is necessary, which can then be handled via a work queue
* or directly depending on the caller.
*/
-int vfio_pci_intx_unmask_handler(struct vfio_pci_device *vdev, void *unused)
+static int vfio_pci_intx_unmask_handler(struct vfio_pci_device *vdev,
+ void *unused)
{
struct pci_dev *pdev = vdev->pdev;
unsigned long flags;
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] vfio: make local function vfio_pci_intx_unmask_handler() static
2013-03-21 7:45 [PATCH] vfio: make local function vfio_pci_intx_unmask_handler() static Wei Yongjun
@ 2013-03-25 17:17 ` Alex Williamson
0 siblings, 0 replies; 2+ messages in thread
From: Alex Williamson @ 2013-03-25 17:17 UTC (permalink / raw)
To: Wei Yongjun; +Cc: arnd, yongjun_wei, kvm
On Thu, 2013-03-21 at 15:45 +0800, Wei Yongjun wrote:
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> vfio_pci_intx_unmask_handler() was not declared. It should be static.
>
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
> ---
> drivers/vfio/pci/vfio_pci_intrs.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/vfio/pci/vfio_pci_intrs.c b/drivers/vfio/pci/vfio_pci_intrs.c
> index a965091..865175e 100644
> --- a/drivers/vfio/pci/vfio_pci_intrs.c
> +++ b/drivers/vfio/pci/vfio_pci_intrs.c
> @@ -287,7 +287,8 @@ void vfio_pci_intx_mask(struct vfio_pci_device *vdev)
> * a signal is necessary, which can then be handled via a work queue
> * or directly depending on the caller.
> */
> -int vfio_pci_intx_unmask_handler(struct vfio_pci_device *vdev, void *unused)
> +static int vfio_pci_intx_unmask_handler(struct vfio_pci_device *vdev,
> + void *unused)
> {
> struct pci_dev *pdev = vdev->pdev;
> unsigned long flags;
>
Applied. Thanks,
Alex
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-03-25 17:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-03-21 7:45 [PATCH] vfio: make local function vfio_pci_intx_unmask_handler() static Wei Yongjun
2013-03-25 17:17 ` Alex Williamson
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.