All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH -next] vxlan: fix some sparse warnings
@ 2013-04-12  5:00 Wei Yongjun
  2013-04-12 19:03 ` David Miller
  0 siblings, 1 reply; 2+ messages in thread
From: Wei Yongjun @ 2013-04-12  5:00 UTC (permalink / raw)
  To: davem, stephen, pshelar, alexander.h.duyck, dlstevens, zealot0630
  Cc: yongjun_wei, netdev

From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>

Fixes following warning:
drivers/net/vxlan.c:406:6: warning: symbol 'vxlan_fdb_free' was not declared. Should it be static?
drivers/net/vxlan.c:1111:37: warning: Using plain integer as NULL pointer

Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
---
 drivers/net/vxlan.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c
index 9a64715..ee02ecd 100644
--- a/drivers/net/vxlan.c
+++ b/drivers/net/vxlan.c
@@ -403,7 +403,7 @@ static int vxlan_fdb_create(struct vxlan_dev *vxlan,
 	return 0;
 }
 
-void vxlan_fdb_free(struct rcu_head *head)
+static void vxlan_fdb_free(struct rcu_head *head)
 {
 	struct vxlan_fdb *f = container_of(head, struct vxlan_fdb, rcu);
 
@@ -1108,7 +1108,7 @@ static netdev_tx_t vxlan_xmit(struct sk_buff *skb, struct net_device *dev)
 		group.remote_vni = vxlan->vni;
 		group.remote_ip = vxlan->gaddr;
 		group.remote_ifindex = vxlan->link;
-		group.remote_next = 0;
+		group.remote_next = NULL;
 		rdst0 = &group;
 
 		if (group.remote_ip == htonl(INADDR_ANY) &&

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH -next] vxlan: fix some sparse warnings
  2013-04-12  5:00 [PATCH -next] vxlan: fix some sparse warnings Wei Yongjun
@ 2013-04-12 19:03 ` David Miller
  0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2013-04-12 19:03 UTC (permalink / raw)
  To: weiyj.lk
  Cc: stephen, pshelar, alexander.h.duyck, dlstevens, zealot0630,
	yongjun_wei, netdev

From: Wei Yongjun <weiyj.lk@gmail.com>
Date: Fri, 12 Apr 2013 13:00:35 +0800

> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
> 
> Fixes following warning:
> drivers/net/vxlan.c:406:6: warning: symbol 'vxlan_fdb_free' was not declared. Should it be static?
> drivers/net/vxlan.c:1111:37: warning: Using plain integer as NULL pointer
> 
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>

Applied.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2013-04-12 19:03 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-04-12  5:00 [PATCH -next] vxlan: fix some sparse warnings Wei Yongjun
2013-04-12 19:03 ` David Miller

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.