From: Song Liu <song@kernel.org>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Martin KaFai Lau <kafai@fb.com>, Song Liu <songliubraving@fb.com>,
Yonghong Song <yhs@fb.com>, Andrii Nakryiko <andriin@fb.com>,
John Fastabend <john.fastabend@gmail.com>,
KP Singh <kpsingh@chromium.org>, bpf <bpf@vger.kernel.org>,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH v2 bpf-next] bpf: Fix an error code in check_btf_func()
Date: Thu, 4 Jun 2020 11:37:09 -0700 [thread overview]
Message-ID: <CAPhsuW7BK+4sJ42YpseWkHf0brW65se5HkQCkq-ONHx--sW4iw@mail.gmail.com> (raw)
In-Reply-To: <20200604085436.GA943001@mwanda>
On Thu, Jun 4, 2020 at 1:55 AM Dan Carpenter <dan.carpenter@oracle.com> wrote:
>
> This code returns success if the "info_aux" allocation fails but it
> should return -ENOMEM.
>
> Fixes: 8c1b6e69dcc1 ("bpf: Compare BTF types of functions arguments with actual types")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Song Liu <songliubraving@fb.com>
> ---
> v2: style change
>
WARNING: multiple messages have this Message-ID (diff)
From: Song Liu <song@kernel.org>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Martin KaFai Lau <kafai@fb.com>, Song Liu <songliubraving@fb.com>,
Yonghong Song <yhs@fb.com>, Andrii Nakryiko <andriin@fb.com>,
John Fastabend <john.fastabend@gmail.com>,
KP Singh <kpsingh@chromium.org>, bpf <bpf@vger.kernel.org>,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH v2 bpf-next] bpf: Fix an error code in check_btf_func()
Date: Thu, 04 Jun 2020 18:37:09 +0000 [thread overview]
Message-ID: <CAPhsuW7BK+4sJ42YpseWkHf0brW65se5HkQCkq-ONHx--sW4iw@mail.gmail.com> (raw)
In-Reply-To: <20200604085436.GA943001@mwanda>
On Thu, Jun 4, 2020 at 1:55 AM Dan Carpenter <dan.carpenter@oracle.com> wrote:
>
> This code returns success if the "info_aux" allocation fails but it
> should return -ENOMEM.
>
> Fixes: 8c1b6e69dcc1 ("bpf: Compare BTF types of functions arguments with actual types")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Song Liu <songliubraving@fb.com>
> ---
> v2: style change
>
next prev parent reply other threads:[~2020-06-04 18:37 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-03 17:55 [PATCH bpf-next] bpf: Fix an error code in check_btf_func() Dan Carpenter
2020-06-03 17:55 ` Dan Carpenter
2020-06-03 17:57 ` Alexei Starovoitov
2020-06-03 17:57 ` Alexei Starovoitov
2020-06-04 8:54 ` [PATCH v2 " Dan Carpenter
2020-06-04 8:54 ` Dan Carpenter
2020-06-04 18:37 ` Song Liu [this message]
2020-06-04 18:37 ` Song Liu
2020-06-04 21:43 ` Daniel Borkmann
2020-06-04 21:43 ` Daniel Borkmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPhsuW7BK+4sJ42YpseWkHf0brW65se5HkQCkq-ONHx--sW4iw@mail.gmail.com \
--to=song@kernel.org \
--cc=andriin@fb.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=dan.carpenter@oracle.com \
--cc=daniel@iogearbox.net \
--cc=john.fastabend@gmail.com \
--cc=kafai@fb.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kpsingh@chromium.org \
--cc=songliubraving@fb.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.