* [Buildroot] [PATCH 1/1] package/vlc: fix build with opencv3
@ 2020-02-28 13:38 Fabrice Fontaine
2020-03-08 14:42 ` Thomas Petazzoni
0 siblings, 1 reply; 5+ messages in thread
From: Fabrice Fontaine @ 2020-02-28 13:38 UTC (permalink / raw)
To: buildroot
Fixes:
- http://autobuild.buildroot.org/results/210424bd33f660aa0757f62a558e1e03faf0f371
Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
...lter-opencv_example.cpp-fix-build-wi.patch | 38 +++++++++++++++++++
1 file changed, 38 insertions(+)
create mode 100644 package/vlc/0010-modules-video_filter-opencv_example.cpp-fix-build-wi.patch
diff --git a/package/vlc/0010-modules-video_filter-opencv_example.cpp-fix-build-wi.patch b/package/vlc/0010-modules-video_filter-opencv_example.cpp-fix-build-wi.patch
new file mode 100644
index 0000000000..04c9958298
--- /dev/null
+++ b/package/vlc/0010-modules-video_filter-opencv_example.cpp-fix-build-wi.patch
@@ -0,0 +1,38 @@
+From 67244e60fc1d8c7a9350bac30611f56c398761e5 Mon Sep 17 00:00:00 2001
+From: Fabrice Fontaine <fontaine.fabrice@gmail.com>
+Date: Fri, 28 Feb 2020 14:29:47 +0100
+Subject: [PATCH] modules/video_filter/opencv_example.cpp: fix build with
+ opencv 3.4.9
+
+Convert CV_RGB to cvScalar to avoid the following build failure with
+opencv 3.4.9:
+
+In file included from /home/naourr/work/instance-2/output-1/host/x86_64-buildroot-linux-uclibc/sysroot/usr/include/opencv2/imgproc/imgproc.hpp:48,
+ from video_filter/opencv_example.cpp:46:
+video_filter/opencv_example.cpp: In function 'picture_t* Filter(filter_t*, picture_t*)':
+video_filter/opencv_example.cpp:200:46: error: could not convert 'cv::Scalar_<double>((double)0, (double)0, (double)0, (double)0)' from 'cv::Scalar' {aka 'cv::Scalar_<double>'} to 'CvScalar'
+ cvRectangle( p_img[0], pt1, pt2, CV_RGB(0,0,0), 3, 8, 0 );
+ ^~~~~~
+
+Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
+[Upstream status: sent to vlc-devel at videolan.org]
+---
+ modules/video_filter/opencv_example.cpp | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/modules/video_filter/opencv_example.cpp b/modules/video_filter/opencv_example.cpp
+index 1334cd4c36..292f24b257 100644
+--- a/modules/video_filter/opencv_example.cpp
++++ b/modules/video_filter/opencv_example.cpp
+@@ -202,7 +202,7 @@ static picture_t *Filter( filter_t *p_filter, picture_t *p_pic )
+ pt2.x = (r->x+r->width)*scale;
+ pt1.y = r->y*scale;
+ pt2.y = (r->y+r->height)*scale;
+- cvRectangle( p_img[0], pt1, pt2, CV_RGB(0,0,0), 3, 8, 0 );
++ cvRectangle( p_img[0], pt1, pt2, cvScalar(CV_RGB(0,0,0)), 3, 8, 0 );
+
+ *(CvRect*)(&(p_sys->event_info.p_region[i])) = *r;
+ p_sys->event_info.p_region[i].i_id = p_sys->i_id++;
+--
+2.25.0
+
--
2.25.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH 1/1] package/vlc: fix build with opencv3
2020-02-28 13:38 [Buildroot] [PATCH 1/1] package/vlc: fix build with opencv3 Fabrice Fontaine
@ 2020-03-08 14:42 ` Thomas Petazzoni
2020-03-08 15:49 ` Fabrice Fontaine
0 siblings, 1 reply; 5+ messages in thread
From: Thomas Petazzoni @ 2020-03-08 14:42 UTC (permalink / raw)
To: buildroot
Hello Fabrice,
On Fri, 28 Feb 2020 14:38:09 +0100
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:
> Fixes:
> - http://autobuild.buildroot.org/results/210424bd33f660aa0757f62a558e1e03faf0f371
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
> ...lter-opencv_example.cpp-fix-build-wi.patch | 38 +++++++++++++++++++
> 1 file changed, 38 insertions(+)
> create mode 100644 package/vlc/0010-modules-video_filter-opencv_example.cpp-fix-build-wi.patch
>
> diff --git a/package/vlc/0010-modules-video_filter-opencv_example.cpp-fix-build-wi.patch b/package/vlc/0010-modules-video_filter-opencv_example.cpp-fix-build-wi.patch
> new file mode 100644
> index 0000000000..04c9958298
> --- /dev/null
> +++ b/package/vlc/0010-modules-video_filter-opencv_example.cpp-fix-build-wi.patch
> @@ -0,0 +1,38 @@
> +From 67244e60fc1d8c7a9350bac30611f56c398761e5 Mon Sep 17 00:00:00 2001
> +From: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> +Date: Fri, 28 Feb 2020 14:29:47 +0100
> +Subject: [PATCH] modules/video_filter/opencv_example.cpp: fix build with
> + opencv 3.4.9
> +
> +Convert CV_RGB to cvScalar to avoid the following build failure with
> +opencv 3.4.9:
> +
> +In file included from /home/naourr/work/instance-2/output-1/host/x86_64-buildroot-linux-uclibc/sysroot/usr/include/opencv2/imgproc/imgproc.hpp:48,
> + from video_filter/opencv_example.cpp:46:
> +video_filter/opencv_example.cpp: In function 'picture_t* Filter(filter_t*, picture_t*)':
> +video_filter/opencv_example.cpp:200:46: error: could not convert 'cv::Scalar_<double>((double)0, (double)0, (double)0, (double)0)' from 'cv::Scalar' {aka 'cv::Scalar_<double>'} to 'CvScalar'
> + cvRectangle( p_img[0], pt1, pt2, CV_RGB(0,0,0), 3, 8, 0 );
Thanks for looking into this. I must say I don't feel very confident
about the fix. Have you been able to trace which change in OpenCV
caused this build issue ?
Also, is the fix still compatible with OpenCV 2.x ? Indeed, VLC
requires OpenCV > 2.0, so I guess it can still work with some 2.x
OpenCV version.
Have you considered talking with the OpenCV community to see what is
the proper fix ?
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH 1/1] package/vlc: fix build with opencv3
2020-03-08 14:42 ` Thomas Petazzoni
@ 2020-03-08 15:49 ` Fabrice Fontaine
2020-03-08 21:28 ` Thomas Petazzoni
0 siblings, 1 reply; 5+ messages in thread
From: Fabrice Fontaine @ 2020-03-08 15:49 UTC (permalink / raw)
To: buildroot
Hello Thomas,
Le dim. 8 mars 2020 ? 15:42, Thomas Petazzoni
<thomas.petazzoni@bootlin.com> a ?crit :
>
> Hello Fabrice,
>
> On Fri, 28 Feb 2020 14:38:09 +0100
> Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:
>
> > Fixes:
> > - http://autobuild.buildroot.org/results/210424bd33f660aa0757f62a558e1e03faf0f371
> >
> > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> > ---
> > ...lter-opencv_example.cpp-fix-build-wi.patch | 38 +++++++++++++++++++
> > 1 file changed, 38 insertions(+)
> > create mode 100644 package/vlc/0010-modules-video_filter-opencv_example.cpp-fix-build-wi.patch
> >
> > diff --git a/package/vlc/0010-modules-video_filter-opencv_example.cpp-fix-build-wi.patch b/package/vlc/0010-modules-video_filter-opencv_example.cpp-fix-build-wi.patch
> > new file mode 100644
> > index 0000000000..04c9958298
> > --- /dev/null
> > +++ b/package/vlc/0010-modules-video_filter-opencv_example.cpp-fix-build-wi.patch
> > @@ -0,0 +1,38 @@
> > +From 67244e60fc1d8c7a9350bac30611f56c398761e5 Mon Sep 17 00:00:00 2001
> > +From: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> > +Date: Fri, 28 Feb 2020 14:29:47 +0100
> > +Subject: [PATCH] modules/video_filter/opencv_example.cpp: fix build with
> > + opencv 3.4.9
> > +
> > +Convert CV_RGB to cvScalar to avoid the following build failure with
> > +opencv 3.4.9:
> > +
> > +In file included from /home/naourr/work/instance-2/output-1/host/x86_64-buildroot-linux-uclibc/sysroot/usr/include/opencv2/imgproc/imgproc.hpp:48,
> > + from video_filter/opencv_example.cpp:46:
> > +video_filter/opencv_example.cpp: In function 'picture_t* Filter(filter_t*, picture_t*)':
> > +video_filter/opencv_example.cpp:200:46: error: could not convert 'cv::Scalar_<double>((double)0, (double)0, (double)0, (double)0)' from 'cv::Scalar' {aka 'cv::Scalar_<double>'} to 'CvScalar'
> > + cvRectangle( p_img[0], pt1, pt2, CV_RGB(0,0,0), 3, 8, 0 );
>
> Thanks for looking into this. I must say I don't feel very confident
> about the fix. Have you been able to trace which change in OpenCV
> caused this build issue ?
The issue is raised by
https://github.com/opencv/opencv/pull/11159/commits/7f9253ea0a9fe2635926379420002dbf0c3fce0f
which changed the CV_RGB definition from cvScalar to cv::Scalar
however cvRectangle was not updated and still waits for a CvScalar
color.
So, a better fix would be to remove the reference on CV_RGB and use
directly cvScalar. I'll send a v2 if you agree that this is a better
proposal.
>
> Also, is the fix still compatible with OpenCV 2.x ? Indeed, VLC
> requires OpenCV > 2.0, so I guess it can still work with some 2.x
> OpenCV version.
>
> Have you considered talking with the OpenCV community to see what is
> the proper fix ?
>
> Thanks!
>
> Thomas
> --
> Thomas Petazzoni, CTO, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com
Best Regards,
Fabrice
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH 1/1] package/vlc: fix build with opencv3
2020-03-08 15:49 ` Fabrice Fontaine
@ 2020-03-08 21:28 ` Thomas Petazzoni
2020-03-08 22:17 ` Fabrice Fontaine
0 siblings, 1 reply; 5+ messages in thread
From: Thomas Petazzoni @ 2020-03-08 21:28 UTC (permalink / raw)
To: buildroot
Hello,
On Sun, 8 Mar 2020 16:49:07 +0100
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:
> > Thanks for looking into this. I must say I don't feel very confident
> > about the fix. Have you been able to trace which change in OpenCV
> > caused this build issue ?
> The issue is raised by
> https://github.com/opencv/opencv/pull/11159/commits/7f9253ea0a9fe2635926379420002dbf0c3fce0f
> which changed the CV_RGB definition from cvScalar to cv::Scalar
> however cvRectangle was not updated and still waits for a CvScalar
> color.
> So, a better fix would be to remove the reference on CV_RGB and use
> directly cvScalar. I'll send a v2 if you agree that this is a better
> proposal.
I don't really know what is the right way of fixing this. Have you paid
attention to compatibility with OpenCV 2.x, if VLC can build with
OpenCV 2.x ?
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH 1/1] package/vlc: fix build with opencv3
2020-03-08 21:28 ` Thomas Petazzoni
@ 2020-03-08 22:17 ` Fabrice Fontaine
0 siblings, 0 replies; 5+ messages in thread
From: Fabrice Fontaine @ 2020-03-08 22:17 UTC (permalink / raw)
To: buildroot
Hello,
Le dim. 8 mars 2020 ? 22:28, Thomas Petazzoni
<thomas.petazzoni@bootlin.com> a ?crit :
>
> Hello,
>
> On Sun, 8 Mar 2020 16:49:07 +0100
> Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:
>
> > > Thanks for looking into this. I must say I don't feel very confident
> > > about the fix. Have you been able to trace which change in OpenCV
> > > caused this build issue ?
> > The issue is raised by
> > https://github.com/opencv/opencv/pull/11159/commits/7f9253ea0a9fe2635926379420002dbf0c3fce0f
> > which changed the CV_RGB definition from cvScalar to cv::Scalar
> > however cvRectangle was not updated and still waits for a CvScalar
> > color.
> > So, a better fix would be to remove the reference on CV_RGB and use
> > directly cvScalar. I'll send a v2 if you agree that this is a better
> > proposal.
>
> I don't really know what is the right way of fixing this. Have you paid
> attention to compatibility with OpenCV 2.x, if VLC can build with
> OpenCV 2.x ?
The second version is building fine with OpenCV 2.x which is not the
case for the first one. So I'll send a v2.
>
> Thomas
> --
> Thomas Petazzoni, CTO, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com
Best Regards,
Fabrice
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-03-08 22:17 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-28 13:38 [Buildroot] [PATCH 1/1] package/vlc: fix build with opencv3 Fabrice Fontaine
2020-03-08 14:42 ` Thomas Petazzoni
2020-03-08 15:49 ` Fabrice Fontaine
2020-03-08 21:28 ` Thomas Petazzoni
2020-03-08 22:17 ` Fabrice Fontaine
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.