* [Buildroot] [PATCH 1/1] package/libnetconf2: fixup the 'v' prefix in the version
@ 2019-10-24 18:06 Fabrice Fontaine
2019-10-24 20:25 ` Thomas Petazzoni
0 siblings, 1 reply; 5+ messages in thread
From: Fabrice Fontaine @ 2019-10-24 18:06 UTC (permalink / raw)
To: buildroot
In order for the luvi version to match what is given by
release-monitoring.org, the 'v' prefix should be encoded in
LIBNETCONF2_SITE and not LIBNETCONF2_VERSION.
Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
package/libnetconf2/libnetconf2.hash | 2 +-
package/libnetconf2/libnetconf2.mk | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/package/libnetconf2/libnetconf2.hash b/package/libnetconf2/libnetconf2.hash
index c6d1f5185d..9b78049ffb 100644
--- a/package/libnetconf2/libnetconf2.hash
+++ b/package/libnetconf2/libnetconf2.hash
@@ -1,2 +1,2 @@
-sha256 760061fb1c1fe87a2a068d5a9e5affcef280044c5940ef344854e9ea7ec26452 libnetconf2-v0.12-r2.tar.gz
+sha256 760061fb1c1fe87a2a068d5a9e5affcef280044c5940ef344854e9ea7ec26452 libnetconf2-0.12-r2.tar.gz
sha256 085122ea91161812dda9cd2f42d8c50ecc3a48cc1a4f15044d86cfc5aa887577 LICENSE
diff --git a/package/libnetconf2/libnetconf2.mk b/package/libnetconf2/libnetconf2.mk
index c3999b3e29..49a6de60a9 100644
--- a/package/libnetconf2/libnetconf2.mk
+++ b/package/libnetconf2/libnetconf2.mk
@@ -4,8 +4,8 @@
#
################################################################################
-LIBNETCONF2_VERSION = v0.12-r2
-LIBNETCONF2_SITE = $(call github,CESNET,libnetconf2,$(LIBNETCONF2_VERSION))
+LIBNETCONF2_VERSION = 0.12-r2
+LIBNETCONF2_SITE = $(call github,CESNET,libnetconf2,v$(LIBNETCONF2_VERSION))
LIBNETCONF2_INSTALL_STAGING = YES
LIBNETCONF2_LICENSE = BSD-3-Clause
LIBNETCONF2_LICENSE_FILES = LICENSE
--
2.23.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH 1/1] package/libnetconf2: fixup the 'v' prefix in the version
2019-10-24 18:06 [Buildroot] [PATCH 1/1] package/libnetconf2: fixup the 'v' prefix in the version Fabrice Fontaine
@ 2019-10-24 20:25 ` Thomas Petazzoni
2019-10-25 6:55 ` Heiko Thiery
0 siblings, 1 reply; 5+ messages in thread
From: Thomas Petazzoni @ 2019-10-24 20:25 UTC (permalink / raw)
To: buildroot
On Thu, 24 Oct 2019 20:06:53 +0200
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:
> In order for the luvi version to match what is given by
> release-monitoring.org, the 'v' prefix should be encoded in
> LIBNETCONF2_SITE and not LIBNETCONF2_VERSION.
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Sorry for missing this when reviewing/applying those packages.
Perhaps it would make sense to add a check in the check-package logic,
to verify that the version doesn't look like vX.Y.Z ?
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH 1/1] package/libnetconf2: fixup the 'v' prefix in the version
2019-10-24 20:25 ` Thomas Petazzoni
@ 2019-10-25 6:55 ` Heiko Thiery
2019-10-25 7:30 ` Thomas Petazzoni
0 siblings, 1 reply; 5+ messages in thread
From: Heiko Thiery @ 2019-10-25 6:55 UTC (permalink / raw)
To: buildroot
> Perhaps it would make sense to add a check in the check-package logic,
> to verify that the version doesn't look like vX.Y.Z ?
I would like to take care of that.
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH 1/1] package/libnetconf2: fixup the 'v' prefix in the version
2019-10-25 6:55 ` Heiko Thiery
@ 2019-10-25 7:30 ` Thomas Petazzoni
2019-10-25 8:06 ` Fabrice Fontaine
0 siblings, 1 reply; 5+ messages in thread
From: Thomas Petazzoni @ 2019-10-25 7:30 UTC (permalink / raw)
To: buildroot
On Fri, 25 Oct 2019 08:55:01 +0200
Heiko Thiery <heiko.thiery@gmail.com> wrote:
> > Perhaps it would make sense to add a check in the check-package logic,
> > to verify that the version doesn't look like vX.Y.Z ?
>
> I would like to take care of that.
Then you can poke around in utils/checkpackagelib/lib_mk.py and see to
add another check. I'm not sure how the check should work exactly, but
I'll let you figure that out :-)
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH 1/1] package/libnetconf2: fixup the 'v' prefix in the version
2019-10-25 7:30 ` Thomas Petazzoni
@ 2019-10-25 8:06 ` Fabrice Fontaine
0 siblings, 0 replies; 5+ messages in thread
From: Fabrice Fontaine @ 2019-10-25 8:06 UTC (permalink / raw)
To: buildroot
Dear all,
Le ven. 25 oct. 2019 ? 09:30, Thomas Petazzoni
<thomas.petazzoni@bootlin.com> a ?crit :
>
> On Fri, 25 Oct 2019 08:55:01 +0200
> Heiko Thiery <heiko.thiery@gmail.com> wrote:
>
> > > Perhaps it would make sense to add a check in the check-package logic,
> > > to verify that the version doesn't look like vX.Y.Z ?
> >
> > I would like to take care of that.
>
> Then you can poke around in utils/checkpackagelib/lib_mk.py and see to
> add another check. I'm not sure how the check should work exactly, but
> I'll let you figure that out :-)
At very least, we should just check that there is no v prefix, this is
the only requirement from release-monitoring: "Anitya will
automatically strip this from versions it finds." (see
https://release-monitoring.org/static/docs/user-guide.html#creating-a-new-project).
release-monitoring doesn't require that the version is in the X.Y.Z
form, X-Y-Z or X_Y_Z is allowed (and used in some packages).
>
> Thomas
> --
> Thomas Petazzoni, CTO, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com
Best Regards,
Fabrice
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-10-25 8:06 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-24 18:06 [Buildroot] [PATCH 1/1] package/libnetconf2: fixup the 'v' prefix in the version Fabrice Fontaine
2019-10-24 20:25 ` Thomas Petazzoni
2019-10-25 6:55 ` Heiko Thiery
2019-10-25 7:30 ` Thomas Petazzoni
2019-10-25 8:06 ` Fabrice Fontaine
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.