Build broken with --enable-external-ell since version 1.13

Build broken with --enable-external-ell since version 1.13

[Fabrice Fontaine]

[-- Attachment #1: Type: text/plain, Size: 402 bytes --]

Dear all,

Build is broken with --enable-external-ell since version 1.13 and commit
ed05585063f2e6d8f2fcd5f008b861062ac7a429:

make[1]: Entering directory '/home/fabrice/buildroot/output/build/iwd-1.13'
  GEN      ell/shared
/bin/bash: line 5: ell/shared: No such file or directory

Moreover, ell/useful.h is a private header of ELL so it shouldn't be
used by iwd.

Best Regards,

Fabrice

Re: Build broken with --enable-external-ell since version 1.13

[Marcel Holtmann]

[-- Attachment #1: Type: text/plain, Size: 482 bytes --]

Hi Fabrice,

> Build is broken with --enable-external-ell since version 1.13 and commit
> ed05585063f2e6d8f2fcd5f008b861062ac7a429:
> 
> make[1]: Entering directory '/home/fabrice/buildroot/output/build/iwd-1.13'
>  GEN      ell/shared
> /bin/bash: line 5: ell/shared: No such file or directory
> 
> Moreover, ell/useful.h is a private header of ELL so it shouldn't be
> used by iwd.

yes, it should be used. That is the intention for this header.

Regards

Marcel

Re: Build broken with --enable-external-ell since version 1.13

[Fabrice Fontaine]

[-- Attachment #1: Type: text/plain, Size: 1281 bytes --]

Hi Marcel,

Le mar. 6 avr. 2021 à 10:38, Marcel Holtmann <marcel@holtmann.org> a écrit :
>
> Hi Fabrice,
>
> > Build is broken with --enable-external-ell since version 1.13 and commit
> > ed05585063f2e6d8f2fcd5f008b861062ac7a429:
> >
> > make[1]: Entering directory '/home/fabrice/buildroot/output/build/iwd-1.13'
> >  GEN      ell/shared
> > /bin/bash: line 5: ell/shared: No such file or directory
> >
> > Moreover, ell/useful.h is a private header of ELL so it shouldn't be
> > used by iwd.
>
> yes, it should be used. That is the intention for this header.
I'm not sure to fully understand your answer.
ell/useful.h is defined as a private header by ELL since
https://git.kernel.org/pub/scm/libs/ell/ell.git/commit/?id=d7e2a556b8a53bf5704e822cd9d8d158dc765e22

So this header is not a part of the public API and, as a result, it is
not installed on the system.
However, it seems that ELL specifies that this header is "semi-private" in
https://git.kernel.org/pub/scm/libs/ell/ell.git/commit/?id=2a682421b06e41c45098217a686157f576847021

So, does your answer mean that ELL should be patched to install the
useful.h header (i.e. move useful.h from ell_libell_la_SOURCES to
pkginclude_HEADERS)?
>
> Regards
>
> Marcel
>
Best Regards,

Fabrice

Re: Build broken with --enable-external-ell since version 1.13

[Marcel Holtmann]

[-- Attachment #1: Type: text/plain, Size: 1868 bytes --]

Hi Fabrice,

>>> Build is broken with --enable-external-ell since version 1.13 and commit
>>> ed05585063f2e6d8f2fcd5f008b861062ac7a429:
>>> 
>>> make[1]: Entering directory '/home/fabrice/buildroot/output/build/iwd-1.13'
>>> GEN      ell/shared
>>> /bin/bash: line 5: ell/shared: No such file or directory
>>> 
>>> Moreover, ell/useful.h is a private header of ELL so it shouldn't be
>>> used by iwd.
>> 
>> yes, it should be used. That is the intention for this header.
> I'm not sure to fully understand your answer.
> ell/useful.h is defined as a private header by ELL since
> https://git.kernel.org/pub/scm/libs/ell/ell.git/commit/?id=d7e2a556b8a53bf5704e822cd9d8d158dc765e22
> 
> So this header is not a part of the public API and, as a result, it is
> not installed on the system.
> However, it seems that ELL specifies that this header is "semi-private" in
> https://git.kernel.org/pub/scm/libs/ell/ell.git/commit/?id=2a682421b06e41c45098217a686157f576847021
> 
> So, does your answer mean that ELL should be patched to install the
> useful.h header (i.e. move useful.h from ell_libell_la_SOURCES to
> pkginclude_HEADERS)?

it is not a header that is meant to be installed, it is shared header that is suppose to be used by ELL and iwd. There however is a bug when using external ELL. I think this should fix it:

diff --git a/Makefile.am b/Makefile.am
index 644f3556b43b..68035e46dc80 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -625,6 +625,7 @@ unit/tls-settings.8021x: unit/cert-ca.pem unit/cert-client.pem unit/cert-client-
 BUILT_SOURCES = $(ell_built_sources) src/builtin.h
 
 ell/shared: Makefile
+       $(AM_V_at)$(MKDIR_P) ell
        $(AM_V_GEN)for f in $(ell_shared) ; do \
                if [ ! -f $$f ] ; then \
                        $(LN_S) -t ell -f $(abs_srcdir)/../ell/$$f ; \

Regards

Marcel

Re: Build broken with --enable-external-ell since version 1.13

[Fabrice Fontaine]

[-- Attachment #1: Type: text/plain, Size: 2416 bytes --]

Hi Marcel,

Le mar. 6 avr. 2021 à 11:02, Marcel Holtmann <marcel@holtmann.org> a écrit :
>
> Hi Fabrice,
>
> >>> Build is broken with --enable-external-ell since version 1.13 and commit
> >>> ed05585063f2e6d8f2fcd5f008b861062ac7a429:
> >>>
> >>> make[1]: Entering directory '/home/fabrice/buildroot/output/build/iwd-1.13'
> >>> GEN      ell/shared
> >>> /bin/bash: line 5: ell/shared: No such file or directory
> >>>
> >>> Moreover, ell/useful.h is a private header of ELL so it shouldn't be
> >>> used by iwd.
> >>
> >> yes, it should be used. That is the intention for this header.
> > I'm not sure to fully understand your answer.
> > ell/useful.h is defined as a private header by ELL since
> > https://git.kernel.org/pub/scm/libs/ell/ell.git/commit/?id=d7e2a556b8a53bf5704e822cd9d8d158dc765e22
> >
> > So this header is not a part of the public API and, as a result, it is
> > not installed on the system.
> > However, it seems that ELL specifies that this header is "semi-private" in
> > https://git.kernel.org/pub/scm/libs/ell/ell.git/commit/?id=2a682421b06e41c45098217a686157f576847021
> >
> > So, does your answer mean that ELL should be patched to install the
> > useful.h header (i.e. move useful.h from ell_libell_la_SOURCES to
> > pkginclude_HEADERS)?
>
> it is not a header that is meant to be installed, it is shared header that is suppose to be used by ELL and iwd. There however is a bug when using external ELL. I think this should fix it:
>
> diff --git a/Makefile.am b/Makefile.am
> index 644f3556b43b..68035e46dc80 100644
> --- a/Makefile.am
> +++ b/Makefile.am
> @@ -625,6 +625,7 @@ unit/tls-settings.8021x: unit/cert-ca.pem unit/cert-client.pem unit/cert-client-
>  BUILT_SOURCES = $(ell_built_sources) src/builtin.h
>
>  ell/shared: Makefile
> +       $(AM_V_at)$(MKDIR_P) ell
>         $(AM_V_GEN)for f in $(ell_shared) ; do \
>                 if [ ! -f $$f ] ; then \
>                         $(LN_S) -t ell -f $(abs_srcdir)/../ell/$$f ; \
Thanks for your help, this would fix it if iwd would ship the ell
directory however, on buildroot side, we're retrieving iwd through git
and as a result, there is no ell directory.
The README specifies that you provide tarballs with the ELL directory.
Could you tell me what is the official link to retrieve them so I
could update buildroot?
>
> Regards
>
> Marcel
>
Best Regards,

Fabrice

Re: Build broken with --enable-external-ell since version 1.13

[Marcel Holtmann]

[-- Attachment #1: Type: text/plain, Size: 2414 bytes --]

Hi Fabrice,

>>>>> Build is broken with --enable-external-ell since version 1.13 and commit
>>>>> ed05585063f2e6d8f2fcd5f008b861062ac7a429:
>>>>> 
>>>>> make[1]: Entering directory '/home/fabrice/buildroot/output/build/iwd-1.13'
>>>>> GEN      ell/shared
>>>>> /bin/bash: line 5: ell/shared: No such file or directory
>>>>> 
>>>>> Moreover, ell/useful.h is a private header of ELL so it shouldn't be
>>>>> used by iwd.
>>>> 
>>>> yes, it should be used. That is the intention for this header.
>>> I'm not sure to fully understand your answer.
>>> ell/useful.h is defined as a private header by ELL since
>>> https://git.kernel.org/pub/scm/libs/ell/ell.git/commit/?id=d7e2a556b8a53bf5704e822cd9d8d158dc765e22
>>> 
>>> So this header is not a part of the public API and, as a result, it is
>>> not installed on the system.
>>> However, it seems that ELL specifies that this header is "semi-private" in
>>> https://git.kernel.org/pub/scm/libs/ell/ell.git/commit/?id=2a682421b06e41c45098217a686157f576847021
>>> 
>>> So, does your answer mean that ELL should be patched to install the
>>> useful.h header (i.e. move useful.h from ell_libell_la_SOURCES to
>>> pkginclude_HEADERS)?
>> 
>> it is not a header that is meant to be installed, it is shared header that is suppose to be used by ELL and iwd. There however is a bug when using external ELL. I think this should fix it:
>> 
>> diff --git a/Makefile.am b/Makefile.am
>> index 644f3556b43b..68035e46dc80 100644
>> --- a/Makefile.am
>> +++ b/Makefile.am
>> @@ -625,6 +625,7 @@ unit/tls-settings.8021x: unit/cert-ca.pem unit/cert-client.pem unit/cert-client-
>> BUILT_SOURCES = $(ell_built_sources) src/builtin.h
>> 
>> ell/shared: Makefile
>> +       $(AM_V_at)$(MKDIR_P) ell
>>        $(AM_V_GEN)for f in $(ell_shared) ; do \
>>                if [ ! -f $$f ] ; then \
>>                        $(LN_S) -t ell -f $(abs_srcdir)/../ell/$$f ; \
> Thanks for your help, this would fix it if iwd would ship the ell
> directory however, on buildroot side, we're retrieving iwd through git
> and as a result, there is no ell directory.
> The README specifies that you provide tarballs with the ELL directory.
> Could you tell me what is the official link to retrieve them so I
> could update buildroot?

the iwd tarballs contain the ELL sources and also ell/useful.h. They are available on kernel.org.

Regards

Marcel

Re: Build broken with --enable-external-ell since version 1.13

[Fabrice Fontaine]

[-- Attachment #1: Type: text/plain, Size: 2736 bytes --]

Le mar. 6 avr. 2021 à 12:28, Marcel Holtmann <marcel@holtmann.org> a écrit :
>
> Hi Fabrice,
>
> >>>>> Build is broken with --enable-external-ell since version 1.13 and commit
> >>>>> ed05585063f2e6d8f2fcd5f008b861062ac7a429:
> >>>>>
> >>>>> make[1]: Entering directory '/home/fabrice/buildroot/output/build/iwd-1.13'
> >>>>> GEN      ell/shared
> >>>>> /bin/bash: line 5: ell/shared: No such file or directory
> >>>>>
> >>>>> Moreover, ell/useful.h is a private header of ELL so it shouldn't be
> >>>>> used by iwd.
> >>>>
> >>>> yes, it should be used. That is the intention for this header.
> >>> I'm not sure to fully understand your answer.
> >>> ell/useful.h is defined as a private header by ELL since
> >>> https://git.kernel.org/pub/scm/libs/ell/ell.git/commit/?id=d7e2a556b8a53bf5704e822cd9d8d158dc765e22
> >>>
> >>> So this header is not a part of the public API and, as a result, it is
> >>> not installed on the system.
> >>> However, it seems that ELL specifies that this header is "semi-private" in
> >>> https://git.kernel.org/pub/scm/libs/ell/ell.git/commit/?id=2a682421b06e41c45098217a686157f576847021
> >>>
> >>> So, does your answer mean that ELL should be patched to install the
> >>> useful.h header (i.e. move useful.h from ell_libell_la_SOURCES to
> >>> pkginclude_HEADERS)?
> >>
> >> it is not a header that is meant to be installed, it is shared header that is suppose to be used by ELL and iwd. There however is a bug when using external ELL. I think this should fix it:
> >>
> >> diff --git a/Makefile.am b/Makefile.am
> >> index 644f3556b43b..68035e46dc80 100644
> >> --- a/Makefile.am
> >> +++ b/Makefile.am
> >> @@ -625,6 +625,7 @@ unit/tls-settings.8021x: unit/cert-ca.pem unit/cert-client.pem unit/cert-client-
> >> BUILT_SOURCES = $(ell_built_sources) src/builtin.h
> >>
> >> ell/shared: Makefile
> >> +       $(AM_V_at)$(MKDIR_P) ell
> >>        $(AM_V_GEN)for f in $(ell_shared) ; do \
> >>                if [ ! -f $$f ] ; then \
> >>                        $(LN_S) -t ell -f $(abs_srcdir)/../ell/$$f ; \
> > Thanks for your help, this would fix it if iwd would ship the ell
> > directory however, on buildroot side, we're retrieving iwd through git
> > and as a result, there is no ell directory.
> > The README specifies that you provide tarballs with the ELL directory.
> > Could you tell me what is the official link to retrieve them so I
> > could update buildroot?
>
> the iwd tarballs contain the ELL sources and also ell/useful.h. They are available on kernel.org.
Thanks for your help, everything is building perfectly fine with the
official tarball, the above patch is not needed.
>
> Regards
>
> Marcel
>
Best Regards,

Fabrice