[Buildroot] [PATCH 1/1] libkcapi: bump to version 1.1.3

[Buildroot] [PATCH 1/1] libkcapi: bump to version 1.1.3

[Fabrice Fontaine]

Remove patch (already in version)

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
 .../0001-Fix-getrandom-call-in-kcapi-rng.c.patch   | 31 ----------------------
 package/libkcapi/libkcapi.hash                     |  2 +-
 package/libkcapi/libkcapi.mk                       |  2 +-
 3 files changed, 2 insertions(+), 33 deletions(-)
 delete mode 100644 package/libkcapi/0001-Fix-getrandom-call-in-kcapi-rng.c.patch

diff --git a/package/libkcapi/0001-Fix-getrandom-call-in-kcapi-rng.c.patch b/package/libkcapi/0001-Fix-getrandom-call-in-kcapi-rng.c.patch
deleted file mode 100644
index d83edd9261..0000000000
--- a/package/libkcapi/0001-Fix-getrandom-call-in-kcapi-rng.c.patch
+++ /dev/null
@@ -1,31 +0,0 @@
-From 581717cfb0e35c041246da0c0c591a6e9f7a40e5 Mon Sep 17 00:00:00 2001
-From: Fabrice Fontaine <fontaine.fabrice@gmail.com>
-Date: Wed, 2 May 2018 21:03:45 +0200
-Subject: [PATCH] Fix getrandom call in kcapi-rng.c
-
-_GNU_SOURCE must be defined and unistd.h must be included to be able to
-use getrandom
-
-Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
-
-[Upstream status: https://github.com/smuellerDD/libkcapi/pull/56]
----
- lib/kcapi-rng.c | 2 ++
- 1 file changed, 2 insertions(+)
-
-diff --git a/lib/kcapi-rng.c b/lib/kcapi-rng.c
-index 45f4d18..9ceabd4 100644
---- a/lib/kcapi-rng.c
-+++ b/lib/kcapi-rng.c
-@@ -18,6 +18,8 @@
-  * DAMAGE.
-  */
- 
-+#define _GNU_SOURCE
-+#include <unistd.h>
- #include <linux/random.h>
- #ifdef HAVE_GETRANDOM
- #include <sys/random.h>
--- 
-2.14.1
-
diff --git a/package/libkcapi/libkcapi.hash b/package/libkcapi/libkcapi.hash
index 9cb1e80ccb..b340ea84b6 100644
--- a/package/libkcapi/libkcapi.hash
+++ b/package/libkcapi/libkcapi.hash
@@ -1,5 +1,5 @@
 # Locally calculated
-sha256 ac80211317750f6a545b1e5547cfb6ae450b37c11acb6d24982a581705eb5250	libkcapi-1.1.0.tar.xz
+sha256 19c044310eda0bf5403fae8df2eeffcfef33b67cb5b01def5f440d41ff16b55f	libkcapi-1.1.3.tar.xz
 sha256 b0336f8f07a6abf8b0a59d961f53601d7c4a7c09a8137805b730a34a976039f8	COPYING
 sha256 e6d6a009505e345fe949e1310334fcb0747f28dae2856759de102ab66b722cb4	COPYING.gplv2
 sha256 13aa749a5b0a454917a944ed8fffc530b784f5ead522b1aacaf4ec8aa55a6239	COPYING.bsd
diff --git a/package/libkcapi/libkcapi.mk b/package/libkcapi/libkcapi.mk
index 1a45f4f996..1557d2017a 100644
--- a/package/libkcapi/libkcapi.mk
+++ b/package/libkcapi/libkcapi.mk
@@ -4,7 +4,7 @@
 #
 ################################################################################
 
-LIBKCAPI_VERSION = 1.1.0
+LIBKCAPI_VERSION = 1.1.3
 LIBKCAPI_SOURCE = libkcapi-$(LIBKCAPI_VERSION).tar.xz
 LIBKCAPI_SITE = http://www.chronox.de/libkcapi
 LIBKCAPI_AUTORECONF = YES
-- 
2.14.1

[Buildroot] [PATCH 1/1] libkcapi: bump to version 1.1.3

[Peter Korsgaard]

>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:

 > Remove patch (already in version)
 > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
 > ---
[snip]

 > -LIBKCAPI_VERSION = 1.1.0
 > +LIBKCAPI_VERSION = 1.1.3

Is this meant for master or next? E.G. does this fix any significant
issues?

-- 
Bye, Peter Korsgaard

[Buildroot] [PATCH 1/1] libkcapi: bump to version 1.1.3

[Fabrice Fontaine]

Dear Peter,

Le mar. 28 ao?t 2018 ? 00:09, Peter Korsgaard <peter@korsgaard.com> a
?crit :

> >>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:
>
>  > Remove patch (already in version)
>  > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
>  > ---
> [snip]
>
>  > -LIBKCAPI_VERSION = 1.1.0
>  > +LIBKCAPI_VERSION = 1.1.3
>
> Is this meant for master or next? E.G. does this fix any significant
> issues?
>
The bump does not fix any autobuilder issues but it fixes some significant
issues especially on kcapi_hasher.
Issues on kcapi_hasher have been found by Coverity and are related to fd
leak, buffer overrun, ...):
https://github.com/smuellerDD/libkcapi/commits/master/apps/kcapi-hasher.c
Here is an extract of the ChangeLog:

Changes 1.1.3
 * Fix: default location of FIPS 140-2 HMAC control file is .<orig file>.hmac
   (was accidentally moved to <orig file>.hmac with 1.1.2)

Changes 1.1.2
 * Fix: Bug fixes for GCC 8.1.0 regarding string length checks by
	Krzysztof Kozlowski
 * Enhancement: ensure that tests execute on architectures other than X86
	by Ondrej Mosn??ek
 * Fix: Bug fix to initialize FDs at the correct time in kcapi-kernel-if.c
	by Ondrej Mosn??ek
 * Test fix: Support test execution outside build environment by
	Ondrej Mosn??ek

Changes 1.1.1
 * Fix: Bug fixes for kcapi_hasher by Ondrej Mosn??ek

So perhaps we could apply it to master.

>
> --
> Bye, Peter Korsgaard
>
Best Regards,

Fabrice
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20180828/74179798/attachment.html>

[Buildroot] [PATCH 1/1] libkcapi: bump to version 1.1.3

[Thomas Petazzoni]

Hello Fabrice,

On Mon, 27 Aug 2018 23:43:23 +0200, Fabrice Fontaine wrote:
> Remove patch (already in version)
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
>  .../0001-Fix-getrandom-call-in-kcapi-rng.c.patch   | 31 ----------------------
>  package/libkcapi/libkcapi.hash                     |  2 +-
>  package/libkcapi/libkcapi.mk                       |  2 +-
>  3 files changed, 2 insertions(+), 33 deletions(-)
>  delete mode 100644 package/libkcapi/0001-Fix-getrandom-call-in-kcapi-rng.c.patch

Since the number of changes were really small and only bug fixes, I
applied to master. I hope I won't regret it :-)

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com