* [Buildroot] [PATCH 1/1] package/busybox: fix S0{1sys, 2k}logd indentation
@ 2019-04-15 8:36 Fabrice Fontaine
2019-04-15 10:36 ` Carlos Santos
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Fabrice Fontaine @ 2019-04-15 8:36 UTC (permalink / raw)
To: buildroot
Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
package/busybox/S01syslogd | 8 ++++----
package/busybox/S02klogd | 8 ++++----
2 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/package/busybox/S01syslogd b/package/busybox/S01syslogd
index 6e642a678a..15006bc06f 100644
--- a/package/busybox/S01syslogd
+++ b/package/busybox/S01syslogd
@@ -44,12 +44,12 @@ restart() {
}
case "$1" in
- start|stop|restart)
+ start|stop|restart)
"$1";;
reload)
# Restart, since there is no true "reload" feature.
restart;;
- *)
- echo "Usage: $0 {start|stop|restart|reload}"
- exit 1
+ *)
+ echo "Usage: $0 {start|stop|restart|reload}"
+ exit 1
esac
diff --git a/package/busybox/S02klogd b/package/busybox/S02klogd
index a4200cfb34..0677e1e5ca 100644
--- a/package/busybox/S02klogd
+++ b/package/busybox/S02klogd
@@ -44,12 +44,12 @@ restart() {
}
case "$1" in
- start|stop|restart)
+ start|stop|restart)
"$1";;
reload)
# Restart, since there is no true "reload" feature.
restart;;
- *)
- echo "Usage: $0 {start|stop|restart|reload}"
- exit 1
+ *)
+ echo "Usage: $0 {start|stop|restart|reload}"
+ exit 1
esac
--
2.20.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH 1/1] package/busybox: fix S0{1sys, 2k}logd indentation
2019-04-15 8:36 [Buildroot] [PATCH 1/1] package/busybox: fix S0{1sys, 2k}logd indentation Fabrice Fontaine
@ 2019-04-15 10:36 ` Carlos Santos
2019-04-15 11:00 ` Fabrice Fontaine
2019-04-15 22:10 ` Arnout Vandecappelle
2019-04-26 12:30 ` Peter Korsgaard
2 siblings, 1 reply; 5+ messages in thread
From: Carlos Santos @ 2019-04-15 10:36 UTC (permalink / raw)
To: buildroot
What?s wrong with the current indentation?
(Sorry for the top-posting. Answering from the phone).
Em 15 de abr de 2019, ?(s) 05:36, Fabrice Fontaine <fontaine.fabrice@gmail.com> escreveu:
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
> package/busybox/S01syslogd | 8 ++++----
> package/busybox/S02klogd | 8 ++++----
> 2 files changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/package/busybox/S01syslogd b/package/busybox/S01syslogd
> index 6e642a678a..15006bc06f 100644
> --- a/package/busybox/S01syslogd
> +++ b/package/busybox/S01syslogd
> @@ -44,12 +44,12 @@ restart() {
> }
>
> case "$1" in
> - start|stop|restart)
> + start|stop|restart)
> "$1";;
> reload)
> # Restart, since there is no true "reload" feature.
> restart;;
> - *)
> - echo "Usage: $0 {start|stop|restart|reload}"
> - exit 1
> + *)
> + echo "Usage: $0 {start|stop|restart|reload}"
> + exit 1
> esac
> diff --git a/package/busybox/S02klogd b/package/busybox/S02klogd
> index a4200cfb34..0677e1e5ca 100644
> --- a/package/busybox/S02klogd
> +++ b/package/busybox/S02klogd
> @@ -44,12 +44,12 @@ restart() {
> }
>
> case "$1" in
> - start|stop|restart)
> + start|stop|restart)
> "$1";;
> reload)
> # Restart, since there is no true "reload" feature.
> restart;;
> - *)
> - echo "Usage: $0 {start|stop|restart|reload}"
> - exit 1
> + *)
> + echo "Usage: $0 {start|stop|restart|reload}"
> + exit 1
> esac
> --
> 2.20.1
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH 1/1] package/busybox: fix S0{1sys, 2k}logd indentation
2019-04-15 10:36 ` Carlos Santos
@ 2019-04-15 11:00 ` Fabrice Fontaine
0 siblings, 0 replies; 5+ messages in thread
From: Fabrice Fontaine @ 2019-04-15 11:00 UTC (permalink / raw)
To: buildroot
Hello Carlos,
Le lun. 15 avr. 2019 ? 12:36, Carlos Santos <unixmania@gmail.com> a ?crit :
>
> What?s wrong with the current indentation?
Current file indentation is mixing spaces with tabs. I removed spaces
to use only tabs.
>
> (Sorry for the top-posting. Answering from the phone).
>
> Em 15 de abr de 2019, ?(s) 05:36, Fabrice Fontaine <fontaine.fabrice@gmail.com> escreveu:
>
> > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> > ---
> > package/busybox/S01syslogd | 8 ++++----
> > package/busybox/S02klogd | 8 ++++----
> > 2 files changed, 8 insertions(+), 8 deletions(-)
> >
> > diff --git a/package/busybox/S01syslogd b/package/busybox/S01syslogd
> > index 6e642a678a..15006bc06f 100644
> > --- a/package/busybox/S01syslogd
> > +++ b/package/busybox/S01syslogd
> > @@ -44,12 +44,12 @@ restart() {
> > }
> >
> > case "$1" in
> > - start|stop|restart)
> > + start|stop|restart)
> > "$1";;
> > reload)
> > # Restart, since there is no true "reload" feature.
> > restart;;
> > - *)
> > - echo "Usage: $0 {start|stop|restart|reload}"
> > - exit 1
> > + *)
> > + echo "Usage: $0 {start|stop|restart|reload}"
> > + exit 1
> > esac
> > diff --git a/package/busybox/S02klogd b/package/busybox/S02klogd
> > index a4200cfb34..0677e1e5ca 100644
> > --- a/package/busybox/S02klogd
> > +++ b/package/busybox/S02klogd
> > @@ -44,12 +44,12 @@ restart() {
> > }
> >
> > case "$1" in
> > - start|stop|restart)
> > + start|stop|restart)
> > "$1";;
> > reload)
> > # Restart, since there is no true "reload" feature.
> > restart;;
> > - *)
> > - echo "Usage: $0 {start|stop|restart|reload}"
> > - exit 1
> > + *)
> > + echo "Usage: $0 {start|stop|restart|reload}"
> > + exit 1
> > esac
> > --
> > 2.20.1
> >
Best Regards,
Fabrice
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH 1/1] package/busybox: fix S0{1sys, 2k}logd indentation
2019-04-15 8:36 [Buildroot] [PATCH 1/1] package/busybox: fix S0{1sys, 2k}logd indentation Fabrice Fontaine
2019-04-15 10:36 ` Carlos Santos
@ 2019-04-15 22:10 ` Arnout Vandecappelle
2019-04-26 12:30 ` Peter Korsgaard
2 siblings, 0 replies; 5+ messages in thread
From: Arnout Vandecappelle @ 2019-04-15 22:10 UTC (permalink / raw)
To: buildroot
On 15/04/2019 10:36, Fabrice Fontaine wrote:
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Applied to master, thanks.
Note that the other init scripts that were updated by Carlos have the same
issue (copy&paste, I guess):
package/rsyslog/S01rsyslogd
package/sysklogd/S01syslogd
package/sysklogd/S02klogd
package/syslog-ng/S01syslog-ng
Regards,
Arnout
> ---
> package/busybox/S01syslogd | 8 ++++----
> package/busybox/S02klogd | 8 ++++----
> 2 files changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/package/busybox/S01syslogd b/package/busybox/S01syslogd
> index 6e642a678a..15006bc06f 100644
> --- a/package/busybox/S01syslogd
> +++ b/package/busybox/S01syslogd
> @@ -44,12 +44,12 @@ restart() {
> }
>
> case "$1" in
> - start|stop|restart)
> + start|stop|restart)
> "$1";;
> reload)
> # Restart, since there is no true "reload" feature.
> restart;;
> - *)
> - echo "Usage: $0 {start|stop|restart|reload}"
> - exit 1
> + *)
> + echo "Usage: $0 {start|stop|restart|reload}"
> + exit 1
> esac
> diff --git a/package/busybox/S02klogd b/package/busybox/S02klogd
> index a4200cfb34..0677e1e5ca 100644
> --- a/package/busybox/S02klogd
> +++ b/package/busybox/S02klogd
> @@ -44,12 +44,12 @@ restart() {
> }
>
> case "$1" in
> - start|stop|restart)
> + start|stop|restart)
> "$1";;
> reload)
> # Restart, since there is no true "reload" feature.
> restart;;
> - *)
> - echo "Usage: $0 {start|stop|restart|reload}"
> - exit 1
> + *)
> + echo "Usage: $0 {start|stop|restart|reload}"
> + exit 1
> esac
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH 1/1] package/busybox: fix S0{1sys, 2k}logd indentation
2019-04-15 8:36 [Buildroot] [PATCH 1/1] package/busybox: fix S0{1sys, 2k}logd indentation Fabrice Fontaine
2019-04-15 10:36 ` Carlos Santos
2019-04-15 22:10 ` Arnout Vandecappelle
@ 2019-04-26 12:30 ` Peter Korsgaard
2 siblings, 0 replies; 5+ messages in thread
From: Peter Korsgaard @ 2019-04-26 12:30 UTC (permalink / raw)
To: buildroot
>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Committed to 2019.02.x, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-04-26 12:30 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-15 8:36 [Buildroot] [PATCH 1/1] package/busybox: fix S0{1sys, 2k}logd indentation Fabrice Fontaine
2019-04-15 10:36 ` Carlos Santos
2019-04-15 11:00 ` Fabrice Fontaine
2019-04-15 22:10 ` Arnout Vandecappelle
2019-04-26 12:30 ` Peter Korsgaard
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.