All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH 1/1] libftdi1: fix python build with cmake < 3.7
@ 2019-01-19 20:53 Fabrice Fontaine
  2019-01-20  5:35 ` Baruch Siach
  0 siblings, 1 reply; 3+ messages in thread
From: Fabrice Fontaine @ 2019-01-19 20:53 UTC (permalink / raw)
  To: buildroot

Fixes:
 - http://autobuild.buildroot.org/results/1091872e2b77d789e361d1ddefd235c738933c55

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
 ...n-CMakeLists.txt-fix-build-with-cmake-3.7.patch | 34 ++++++++++++++++++++++
 1 file changed, 34 insertions(+)
 create mode 100644 package/libftdi1/0005-python-CMakeLists.txt-fix-build-with-cmake-3.7.patch

diff --git a/package/libftdi1/0005-python-CMakeLists.txt-fix-build-with-cmake-3.7.patch b/package/libftdi1/0005-python-CMakeLists.txt-fix-build-with-cmake-3.7.patch
new file mode 100644
index 0000000000..c9fcb0ee4f
--- /dev/null
+++ b/package/libftdi1/0005-python-CMakeLists.txt-fix-build-with-cmake-3.7.patch
@@ -0,0 +1,34 @@
+From ddfbe611fd273ea6a0c1ac86c184fa8b395fa2fe Mon Sep 17 00:00:00 2001
+From: Fabrice Fontaine <fontaine.fabrice@gmail.com>
+Date: Sat, 19 Jan 2019 21:09:22 +0100
+Subject: [PATCH] python/CMakeLists.txt: fix build with cmake < 3.7
+
+VERSION_GREATER_EQUAL has been added only in cmake 3.7:
+https://cmake.org/cmake/help/v3.7/release/3.7.html
+
+So replace this statement by NOT CMAKE_VERSION VERSION_LESS
+
+Fixes:
+ - http://autobuild.buildroot.org/results/1091872e2b77d789e361d1ddefd235c738933c55
+
+Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
+[Upstream status:
+http://developer.intra2net.com/mailarchive/html/libftdi/2019/msg00009.html]
+---
+ python/CMakeLists.txt | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/python/CMakeLists.txt b/python/CMakeLists.txt
+index 7bdd9f9..376dae6 100644
+--- a/python/CMakeLists.txt
++++ b/python/CMakeLists.txt
+@@ -1,5 +1,5 @@
+   # workaround for cmake bug #0013449
+-  if ( NOT DEFINED CMAKE_FIND_ROOT_PATH OR CMAKE_VERSION VERSION_GREATER_EQUAL 3.0.0 )
++  if ( NOT DEFINED CMAKE_FIND_ROOT_PATH OR NOT CMAKE_VERSION VERSION_LESS 3.0.0 )
+     find_package ( SWIG )
+   else ()
+     find_program ( SWIG_EXECUTABLE NAMES swig2.0 swig )
+-- 
+2.14.1
+
-- 
2.14.1

^ permalink raw reply related	[flat|nested] 3+ messages in thread
* [Buildroot] [PATCH 1/1] libftdi1: fix python build with cmake < 3.7
  2019-01-19 20:53 [Buildroot] [PATCH 1/1] libftdi1: fix python build with cmake < 3.7 Fabrice Fontaine
@ 2019-01-20  5:35 ` Baruch Siach
  2019-01-20  8:55   ` Fabrice Fontaine
  0 siblings, 1 reply; 3+ messages in thread
From: Baruch Siach @ 2019-01-20  5:35 UTC (permalink / raw)
  To: buildroot

Hi Fabrice,

On Sat, Jan 19 2019, Fabrice Fontaine wrote:
> Fixes:
>  - http://autobuild.buildroot.org/results/1091872e2b77d789e361d1ddefd235c738933c55
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
>  ...n-CMakeLists.txt-fix-build-with-cmake-3.7.patch | 34 ++++++++++++++++++++++
>  1 file changed, 34 insertions(+)
>  create mode 100644 package/libftdi1/0005-python-CMakeLists.txt-fix-build-with-cmake-3.7.patch
>
> diff --git a/package/libftdi1/0005-python-CMakeLists.txt-fix-build-with-cmake-3.7.patch b/package/libftdi1/0005-python-CMakeLists.txt-fix-build-with-cmake-3.7.patch
> new file mode 100644
> index 0000000000..c9fcb0ee4f
> --- /dev/null
> +++ b/package/libftdi1/0005-python-CMakeLists.txt-fix-build-with-cmake-3.7.patch
> @@ -0,0 +1,34 @@
> +From ddfbe611fd273ea6a0c1ac86c184fa8b395fa2fe Mon Sep 17 00:00:00 2001
> +From: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> +Date: Sat, 19 Jan 2019 21:09:22 +0100
> +Subject: [PATCH] python/CMakeLists.txt: fix build with cmake < 3.7
> +
> +VERSION_GREATER_EQUAL has been added only in cmake 3.7:
> +https://cmake.org/cmake/help/v3.7/release/3.7.html
> +
> +So replace this statement by NOT CMAKE_VERSION VERSION_LESS
> +
> +Fixes:
> + - http://autobuild.buildroot.org/results/1091872e2b77d789e361d1ddefd235c738933c55
> +
> +Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> +[Upstream status:
> +http://developer.intra2net.com/mailarchive/html/libftdi/2019/msg00009.html]
> +---
> + python/CMakeLists.txt | 2 +-
> + 1 file changed, 1 insertion(+), 1 deletion(-)
> +
> +diff --git a/python/CMakeLists.txt b/python/CMakeLists.txt
> +index 7bdd9f9..376dae6 100644
> +--- a/python/CMakeLists.txt
> ++++ b/python/CMakeLists.txt
> +@@ -1,5 +1,5 @@
> +   # workaround for cmake bug #0013449
> +-  if ( NOT DEFINED CMAKE_FIND_ROOT_PATH OR CMAKE_VERSION VERSION_GREATER_EQUAL 3.0.0 )
> ++  if ( NOT DEFINED CMAKE_FIND_ROOT_PATH OR NOT CMAKE_VERSION VERSION_LESS 3.0.0 )

VERSION_GREATER_EQUAL is added in Buildroot patch 0004. Why not fix it
there?

> +     find_package ( SWIG )
> +   else ()
> +     find_program ( SWIG_EXECUTABLE NAMES swig2.0 swig )
> +--
> +2.14.1
> +

baruch

--
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -

^ permalink raw reply	[flat|nested] 3+ messages in thread
* [Buildroot] [PATCH 1/1] libftdi1: fix python build with cmake < 3.7
  2019-01-20  5:35 ` Baruch Siach
@ 2019-01-20  8:55   ` Fabrice Fontaine
  0 siblings, 0 replies; 3+ messages in thread
From: Fabrice Fontaine @ 2019-01-20  8:55 UTC (permalink / raw)
  To: buildroot

Hi Baruch,

Le dim. 20 janv. 2019 ? 06:35, Baruch Siach <baruch@tkos.co.il> a ?crit :
>
> Hi Fabrice,
>
> On Sat, Jan 19 2019, Fabrice Fontaine wrote:
> > Fixes:
> >  - http://autobuild.buildroot.org/results/1091872e2b77d789e361d1ddefd235c738933c55
> >
> > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> > ---
> >  ...n-CMakeLists.txt-fix-build-with-cmake-3.7.patch | 34 ++++++++++++++++++++++
> >  1 file changed, 34 insertions(+)
> >  create mode 100644 package/libftdi1/0005-python-CMakeLists.txt-fix-build-with-cmake-3.7.patch
> >
> > diff --git a/package/libftdi1/0005-python-CMakeLists.txt-fix-build-with-cmake-3.7.patch b/package/libftdi1/0005-python-CMakeLists.txt-fix-build-with-cmake-3.7.patch
> > new file mode 100644
> > index 0000000000..c9fcb0ee4f
> > --- /dev/null
> > +++ b/package/libftdi1/0005-python-CMakeLists.txt-fix-build-with-cmake-3.7.patch
> > @@ -0,0 +1,34 @@
> > +From ddfbe611fd273ea6a0c1ac86c184fa8b395fa2fe Mon Sep 17 00:00:00 2001
> > +From: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> > +Date: Sat, 19 Jan 2019 21:09:22 +0100
> > +Subject: [PATCH] python/CMakeLists.txt: fix build with cmake < 3.7
> > +
> > +VERSION_GREATER_EQUAL has been added only in cmake 3.7:
> > +https://cmake.org/cmake/help/v3.7/release/3.7.html
> > +
> > +So replace this statement by NOT CMAKE_VERSION VERSION_LESS
> > +
> > +Fixes:
> > + - http://autobuild.buildroot.org/results/1091872e2b77d789e361d1ddefd235c738933c55
> > +
> > +Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> > +[Upstream status:
> > +http://developer.intra2net.com/mailarchive/html/libftdi/2019/msg00009.html]
> > +---
> > + python/CMakeLists.txt | 2 +-
> > + 1 file changed, 1 insertion(+), 1 deletion(-)
> > +
> > +diff --git a/python/CMakeLists.txt b/python/CMakeLists.txt
> > +index 7bdd9f9..376dae6 100644
> > +--- a/python/CMakeLists.txt
> > ++++ b/python/CMakeLists.txt
> > +@@ -1,5 +1,5 @@
> > +   # workaround for cmake bug #0013449
> > +-  if ( NOT DEFINED CMAKE_FIND_ROOT_PATH OR CMAKE_VERSION VERSION_GREATER_EQUAL 3.0.0 )
> > ++  if ( NOT DEFINED CMAKE_FIND_ROOT_PATH OR NOT CMAKE_VERSION VERSION_LESS 3.0.0 )
>
> VERSION_GREATER_EQUAL is added in Buildroot patch 0004. Why not fix it
> there?
Indeed, I can fix the issue in patch 0004, I'll send a v2.
>
> > +     find_package ( SWIG )
> > +   else ()
> > +     find_program ( SWIG_EXECUTABLE NAMES swig2.0 swig )
> > +--
> > +2.14.1
> > +
>
> baruch
>
> --
>      http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
> =}------------------------------------------------ooO--U--Ooo------------{=
>    - baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -
Best Regards,

Fabrice

^ permalink raw reply	[flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-01-20  8:55 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-19 20:53 [Buildroot] [PATCH 1/1] libftdi1: fix python build with cmake < 3.7 Fabrice Fontaine
2019-01-20  5:35 ` Baruch Siach
2019-01-20  8:55   ` Fabrice Fontaine

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.