[Buildroot] [PATCH 1/1] package/lxc: fix license

[Buildroot] [PATCH 1/1] package/lxc: fix license

[Fabrice Fontaine]

Commit 5a393677314dfdaa6a4bd6a847b642ae54517538 forgot to update
license which has been changed from COPYING to LICENSE.GPL2 and
LICENSE.LGPL2.1 since version 4.0.0 and
https://github.com/lxc/lxc/commit/cc73685dd09315b292968ee91a08a8f295376b35

It should be noted that COPYING describes GPLv3 for an unknown reason

Fixes:
 - http://autobuild.buildroot.org/results/2da182d0b84e2597e135506f8166a54660c4b2f5

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
 package/lxc/lxc.hash | 3 ++-
 package/lxc/lxc.mk   | 4 ++--
 2 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/package/lxc/lxc.hash b/package/lxc/lxc.hash
index faaa17dde0..411947f165 100644
--- a/package/lxc/lxc.hash
+++ b/package/lxc/lxc.hash
@@ -1,3 +1,4 @@
 # Locally calculated
 sha256  d56d91d772449c57e9a67b770dab8967e412051d8d6246ce56c63264671672e5  lxc-4.0.3.tar.gz
-sha256  dc626520dcd53a22f727af3ee42c770e56c97a64fe3adb063799d8ab032fe551  COPYING
+sha256  ab15fd526bd8dd18a9e77ebc139656bf4d33e97fc7238cd11bf60e2b9b8666c6  LICENSE.GPL2
+sha256  dc626520dcd53a22f727af3ee42c770e56c97a64fe3adb063799d8ab032fe551  LICENSE.LGPL2.1
diff --git a/package/lxc/lxc.mk b/package/lxc/lxc.mk
index 0d88cd6c8c..ac8c432f24 100644
--- a/package/lxc/lxc.mk
+++ b/package/lxc/lxc.mk
@@ -6,8 +6,8 @@
 
 LXC_VERSION = 4.0.3
 LXC_SITE = https://linuxcontainers.org/downloads/lxc
-LXC_LICENSE = LGPL-2.1+
-LXC_LICENSE_FILES = COPYING
+LXC_LICENSE = GPL-2.0, LGPL-2.1+
+LXC_LICENSE_FILES = LICENSE.GPL2 LICENSE.LGPL2.1
 LXC_DEPENDENCIES = host-pkgconf
 LXC_INSTALL_STAGING = YES
 
-- 
2.27.0

[Buildroot] [PATCH 1/1] package/lxc: fix license

[Thomas Petazzoni]

On Wed, 15 Jul 2020 21:04:38 +0200
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:

> Commit 5a393677314dfdaa6a4bd6a847b642ae54517538 forgot to update
> license which has been changed from COPYING to LICENSE.GPL2 and
> LICENSE.LGPL2.1 since version 4.0.0 and
> https://github.com/lxc/lxc/commit/cc73685dd09315b292968ee91a08a8f295376b35
> 
> It should be noted that COPYING describes GPLv3 for an unknown reason

Has this been reported upstream ?

>  LXC_VERSION = 4.0.3
>  LXC_SITE = https://linuxcontainers.org/downloads/lxc
> -LXC_LICENSE = LGPL-2.1+
> -LXC_LICENSE_FILES = COPYING
> +LXC_LICENSE = GPL-2.0, LGPL-2.1+

Do we have some details about what is under GPL, what is under LGPL ?

Is it GPL-2.0, or GPL-2.0+ ?

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

[Buildroot] [PATCH 1/1] package/lxc: fix license

[Fabrice Fontaine]

Hi Thomas,

Le mer. 15 juil. 2020 ? 21:30, Thomas Petazzoni
<thomas.petazzoni@bootlin.com> a ?crit :
>
> On Wed, 15 Jul 2020 21:04:38 +0200
> Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:
>
> > Commit 5a393677314dfdaa6a4bd6a847b642ae54517538 forgot to update
> > license which has been changed from COPYING to LICENSE.GPL2 and
> > LICENSE.LGPL2.1 since version 4.0.0 and
> > https://github.com/lxc/lxc/commit/cc73685dd09315b292968ee91a08a8f295376b35
> >
> > It should be noted that COPYING describes GPLv3 for an unknown reason
>
> Has this been reported upstream ?
I created an issue here: https://github.com/lxc/lxc/issues/3484.
>
> >  LXC_VERSION = 4.0.3
> >  LXC_SITE = https://linuxcontainers.org/downloads/lxc
> > -LXC_LICENSE = LGPL-2.1+
> > -LXC_LICENSE_FILES = COPYING
> > +LXC_LICENSE = GPL-2.0, LGPL-2.1+
>
> Do we have some details about what is under GPL, what is under LGPL ?
Yes, each file has a SPDX header since
https://github.com/lxc/lxc/commit/cc73685dd09315b292968ee91a08a8f295376b35.
Most of them are LGPL but some source files under tools directory are
GPL-2.0-only.
>
> Is it GPL-2.0, or GPL-2.0+ ?
It is GPL-2.0.
>
> Thomas
> --
> Thomas Petazzoni, CTO, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com
Best Regards,

Fabrice

[Buildroot] [PATCH 1/1] package/lxc: fix license

[Thomas Petazzoni]

On Wed, 15 Jul 2020 21:38:48 +0200
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:

> > Has this been reported upstream ?  
> I created an issue here: https://github.com/lxc/lxc/issues/3484.

Thanks!

> > Do we have some details about what is under GPL, what is under LGPL ?  
> Yes, each file has a SPDX header since
> https://github.com/lxc/lxc/commit/cc73685dd09315b292968ee91a08a8f295376b35.
> Most of them are LGPL but some source files under tools directory are
> GPL-2.0-only.

Then it would be good to annotate in the LXC_LICENSE variable under
what license is which part.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com