All of
 help / color / mirror / Atom feed
From: Eric Sunshine <>
To: "Ævar Arnfjörð Bjarmason" <>
Cc: Git List <>,
	Junio C Hamano <>,
	Jan Judas <>
Subject: Re: [PATCH] gc: remove trailing dot from "gc.log" line
Date: Tue, 31 Aug 2021 12:15:04 -0400	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On Tue, Aug 31, 2021 at 10:37 AM Ævar Arnfjörð Bjarmason
<> wrote:
> Remove the trailing dot from the warning we emit about gc.log. It's
> common for various terminal UX's to allow the user to select "words",
> and by including the trailing dot a user wanting to select the path to
> gc.log will need to manually remove the trailing dot.
> Such a user would also probably need to adjust the path if it e.g. had
> spaces in it, but this should address this very common case.
> Signed-off-by: Ævar Arnfjörð Bjarmason <>
> Suggested-by: Jan Judas <>
> ---
> diff --git a/builtin/gc.c b/builtin/gc.c
> @@ -502,7 +502,7 @@ static int report_last_gc_error(void)
>                 warning(_("The last gc run reported the following. "
>                                "Please correct the root cause\n"
> -                              "and remove %s.\n"
> +                              "and remove %s\n"

Bikeshedding: Adding a colon after "remove" would give this a slightly
more grammatically-correct feel:

    Please correct the root cause
    and remove: /path/to/repo/.git/gc.log

>                                "Automatic cleanup will not be performed "
>                                "until the file is removed.\n\n"
>                                "%s"),

Even more bikeshedding:

    Please correct the root cause and remove
    to allow automatic cleanup to resume.

or something.

  reply	other threads:[~2021-08-31 16:15 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-31 13:46 UX suggestion Jan Judas
2021-08-31 14:37 ` [PATCH] gc: remove trailing dot from "gc.log" line Ævar Arnfjörð Bjarmason
2021-08-31 16:15   ` Eric Sunshine [this message]
2021-08-31 18:17     ` Junio C Hamano
2021-08-31 18:23       ` Eric Sunshine
2021-08-31 20:36         ` Ævar Arnfjörð Bjarmason
2021-09-01  2:10           ` Eric Sunshine
2021-09-02 17:27   ` Jan Judas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.