All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Sunshine <sunshine@sunshineco.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
	"Git List" <git@vger.kernel.org>,
	"Jan Judas" <snugar.i@gmail.com>
Subject: Re: [PATCH] gc: remove trailing dot from "gc.log" line
Date: Tue, 31 Aug 2021 14:23:55 -0400	[thread overview]
Message-ID: <CAPig+cTaJ=xm=K5Y8yn8RiOFHBH-nzhRztYRz3kYsqsyJUTACg@mail.gmail.com> (raw)
In-Reply-To: <xmqqpmtttr56.fsf@gitster.g>

On Tue, Aug 31, 2021 at 2:18 PM Junio C Hamano <gitster@pobox.com> wrote:
> Eric Sunshine <sunshine@sunshineco.com> writes:
> > On Tue, Aug 31, 2021 at 10:37 AM Ævar Arnfjörð Bjarmason
> > <avarab@gmail.com> wrote:
> >>                 warning(_("The last gc run reported the following. "
> >>                                "Please correct the root cause\n"
> >> -                              "and remove %s.\n"
> >> +                              "and remove %s\n"
> >
> > Even more bikeshedding:
> >
> >     Please correct the root cause and remove
> >     /path/to/repo/.git/gc.log
> >     to allow automatic cleanup to resume.
> >
> > or something.
>
> I also found the line break before "and remove" strange, but I think
> that is because the "Please" is not at the beginning of the
> paragraph, but is a second sentence.  Perhaps unfolding "and remove"
> would make the first line overly long?

Yep, you're right, and perhaps my "Even more bikeshedding" didn't
clearly indicate that I was bikeshedding more about combining the
"Please correct..." and "Automatic cleanup..." sentences into a single
sentence, both as a another way to deal with the punctuation issue
(thus allowing easy double-click) and to make the whole thing read a
bit better.

  reply	other threads:[~2021-08-31 18:24 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-31 13:46 UX suggestion Jan Judas
2021-08-31 14:37 ` [PATCH] gc: remove trailing dot from "gc.log" line Ævar Arnfjörð Bjarmason
2021-08-31 16:15   ` Eric Sunshine
2021-08-31 18:17     ` Junio C Hamano
2021-08-31 18:23       ` Eric Sunshine [this message]
2021-08-31 20:36         ` Ævar Arnfjörð Bjarmason
2021-09-01  2:10           ` Eric Sunshine
2021-09-02 17:27   ` Jan Judas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAPig+cTaJ=xm=K5Y8yn8RiOFHBH-nzhRztYRz3kYsqsyJUTACg@mail.gmail.com' \
    --to=sunshine@sunshineco.com \
    --cc=avarab@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=snugar.i@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.