All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Stone <daniel@fooishbar.org>
To: Andy Yan <andy.yan@rock-chips.com>
Cc: Sascha Hauer <s.hauer@pengutronix.de>,
	dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
	Benjamin Gaignard <benjamin.gaignard@collabora.com>,
	Sandy Huang <hjc@rock-chips.com>,
	linux-rockchip@lists.infradead.org,
	Michael Riesch <michael.riesch@wolfvision.net>,
	kernel@pengutronix.de, Peter Geis <pgwipeout@gmail.com>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v7 22/24] drm: rockchip: Add VOP2 driver
Date: Mon, 14 Mar 2022 13:38:35 +0000	[thread overview]
Message-ID: <CAPj87rNXuJ6MQMb7dJHWZcqxaH9cyu1f2_NWidT_zsm44STmaw@mail.gmail.com> (raw)
In-Reply-To: <d98782df-43c8-475b-375d-ad6aff4fae44@rock-chips.com>

Hi Andy,

On Mon, 14 Mar 2022 at 11:02, Andy Yan <andy.yan@rock-chips.com> wrote:
>    Remember you said our downstream vop2 driver is very slow on weston.
>
> Would you please share the case you run ? or how can i test frame rate
> on weston?

We were able to observe this by just using either waylandsink (using
dmabuf from the V4L2 rkvdec/rkvpu drivers), or even weston-simple-egl.
I have not been able to do a full review of Sascha's submission, but
from what I've seen of it, it should have fixed those issues. (I don't
have RK3568 hardware to hand anymore.)

Cheers,
Daniel

WARNING: multiple messages have this Message-ID (diff)
From: Daniel Stone <daniel@fooishbar.org>
To: Andy Yan <andy.yan@rock-chips.com>
Cc: devicetree@vger.kernel.org,
	Benjamin Gaignard <benjamin.gaignard@collabora.com>,
	Peter Geis <pgwipeout@gmail.com>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Sandy Huang <hjc@rock-chips.com>,
	dri-devel@lists.freedesktop.org,
	linux-rockchip@lists.infradead.org,
	Michael Riesch <michael.riesch@wolfvision.net>,
	kernel@pengutronix.de, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v7 22/24] drm: rockchip: Add VOP2 driver
Date: Mon, 14 Mar 2022 13:38:35 +0000	[thread overview]
Message-ID: <CAPj87rNXuJ6MQMb7dJHWZcqxaH9cyu1f2_NWidT_zsm44STmaw@mail.gmail.com> (raw)
In-Reply-To: <d98782df-43c8-475b-375d-ad6aff4fae44@rock-chips.com>

Hi Andy,

On Mon, 14 Mar 2022 at 11:02, Andy Yan <andy.yan@rock-chips.com> wrote:
>    Remember you said our downstream vop2 driver is very slow on weston.
>
> Would you please share the case you run ? or how can i test frame rate
> on weston?

We were able to observe this by just using either waylandsink (using
dmabuf from the V4L2 rkvdec/rkvpu drivers), or even weston-simple-egl.
I have not been able to do a full review of Sascha's submission, but
from what I've seen of it, it should have fixed those issues. (I don't
have RK3568 hardware to hand anymore.)

Cheers,
Daniel

WARNING: multiple messages have this Message-ID (diff)
From: Daniel Stone <daniel@fooishbar.org>
To: Andy Yan <andy.yan@rock-chips.com>
Cc: Sascha Hauer <s.hauer@pengutronix.de>,
	dri-devel@lists.freedesktop.org,  devicetree@vger.kernel.org,
	 Benjamin Gaignard <benjamin.gaignard@collabora.com>,
	Sandy Huang <hjc@rock-chips.com>,
	linux-rockchip@lists.infradead.org,
	 Michael Riesch <michael.riesch@wolfvision.net>,
	kernel@pengutronix.de,  Peter Geis <pgwipeout@gmail.com>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v7 22/24] drm: rockchip: Add VOP2 driver
Date: Mon, 14 Mar 2022 13:38:35 +0000	[thread overview]
Message-ID: <CAPj87rNXuJ6MQMb7dJHWZcqxaH9cyu1f2_NWidT_zsm44STmaw@mail.gmail.com> (raw)
In-Reply-To: <d98782df-43c8-475b-375d-ad6aff4fae44@rock-chips.com>

Hi Andy,

On Mon, 14 Mar 2022 at 11:02, Andy Yan <andy.yan@rock-chips.com> wrote:
>    Remember you said our downstream vop2 driver is very slow on weston.
>
> Would you please share the case you run ? or how can i test frame rate
> on weston?

We were able to observe this by just using either waylandsink (using
dmabuf from the V4L2 rkvdec/rkvpu drivers), or even weston-simple-egl.
I have not been able to do a full review of Sascha's submission, but
from what I've seen of it, it should have fixed those issues. (I don't
have RK3568 hardware to hand anymore.)

Cheers,
Daniel

_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

WARNING: multiple messages have this Message-ID (diff)
From: Daniel Stone <daniel@fooishbar.org>
To: Andy Yan <andy.yan@rock-chips.com>
Cc: Sascha Hauer <s.hauer@pengutronix.de>,
	dri-devel@lists.freedesktop.org,  devicetree@vger.kernel.org,
	 Benjamin Gaignard <benjamin.gaignard@collabora.com>,
	Sandy Huang <hjc@rock-chips.com>,
	linux-rockchip@lists.infradead.org,
	 Michael Riesch <michael.riesch@wolfvision.net>,
	kernel@pengutronix.de,  Peter Geis <pgwipeout@gmail.com>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v7 22/24] drm: rockchip: Add VOP2 driver
Date: Mon, 14 Mar 2022 13:38:35 +0000	[thread overview]
Message-ID: <CAPj87rNXuJ6MQMb7dJHWZcqxaH9cyu1f2_NWidT_zsm44STmaw@mail.gmail.com> (raw)
In-Reply-To: <d98782df-43c8-475b-375d-ad6aff4fae44@rock-chips.com>

Hi Andy,

On Mon, 14 Mar 2022 at 11:02, Andy Yan <andy.yan@rock-chips.com> wrote:
>    Remember you said our downstream vop2 driver is very slow on weston.
>
> Would you please share the case you run ? or how can i test frame rate
> on weston?

We were able to observe this by just using either waylandsink (using
dmabuf from the V4L2 rkvdec/rkvpu drivers), or even weston-simple-egl.
I have not been able to do a full review of Sascha's submission, but
from what I've seen of it, it should have fixed those issues. (I don't
have RK3568 hardware to hand anymore.)

Cheers,
Daniel

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2022-03-14 13:38 UTC|newest]

Thread overview: 231+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-25  7:51 [PATCH v7 00/24] drm/rockchip: RK356x VOP2 support Sascha Hauer
2022-02-25  7:51 ` Sascha Hauer
2022-02-25  7:51 ` Sascha Hauer
2022-02-25  7:51 ` Sascha Hauer
2022-02-25  7:51 ` [PATCH v7 01/24] drm/rockchip: Embed drm_encoder into rockchip_decoder Sascha Hauer
2022-02-25  7:51   ` Sascha Hauer
2022-02-25  7:51   ` Sascha Hauer
2022-02-25  7:51   ` Sascha Hauer
2022-02-25  7:51 ` [PATCH v7 02/24] drm/rockchip: Add crtc_endpoint_id to rockchip_encoder Sascha Hauer
2022-02-25  7:51   ` Sascha Hauer
2022-02-25  7:51   ` Sascha Hauer
2022-02-25  7:51   ` Sascha Hauer
2022-02-25  7:51 ` [PATCH v7 03/24] drm/rockchip: dw_hdmi: rename vpll clock to reference clock Sascha Hauer
2022-02-25  7:51   ` Sascha Hauer
2022-02-25  7:51   ` Sascha Hauer
2022-02-25  7:51   ` Sascha Hauer
2022-02-28 10:59   ` Dmitry Osipenko
2022-02-28 10:59     ` Dmitry Osipenko
2022-02-28 10:59     ` Dmitry Osipenko
2022-02-28 10:59     ` Dmitry Osipenko
2022-02-25  7:51 ` [PATCH v7 04/24] dt-bindings: display: rockchip: dw-hdmi: use "ref" as clock name Sascha Hauer
2022-02-25  7:51   ` Sascha Hauer
2022-02-25  7:51   ` Sascha Hauer
2022-02-25  7:51   ` Sascha Hauer
2022-02-25  7:51 ` [PATCH v7 05/24] arm64: dts: rockchip: rk3399: rename HDMI ref clock to 'ref' Sascha Hauer
2022-02-25  7:51   ` Sascha Hauer
2022-02-25  7:51   ` Sascha Hauer
2022-02-25  7:51   ` Sascha Hauer
2022-02-25  7:51 ` [PATCH v7 06/24] drm/rockchip: dw_hdmi: add rk3568 support Sascha Hauer
2022-02-25  7:51   ` Sascha Hauer
2022-02-25  7:51   ` Sascha Hauer
2022-02-25  7:51   ` Sascha Hauer
2022-02-25  7:51 ` [PATCH v7 07/24] dt-bindings: display: rockchip: dw-hdmi: Add compatible for rk3568 HDMI Sascha Hauer
2022-02-25  7:51   ` Sascha Hauer
2022-02-25  7:51   ` Sascha Hauer
2022-02-25  7:51   ` Sascha Hauer
2022-02-25  7:51 ` [PATCH v7 08/24] drm/rockchip: dw_hdmi: add regulator support Sascha Hauer
2022-02-25  7:51   ` Sascha Hauer
2022-02-25  7:51   ` Sascha Hauer
2022-02-25  7:51   ` Sascha Hauer
2022-02-25  7:51 ` [PATCH v7 09/24] dt-bindings: display: rockchip: dw-hdmi: Add " Sascha Hauer
2022-02-25  7:51   ` Sascha Hauer
2022-02-25  7:51   ` Sascha Hauer
2022-02-25  7:51   ` Sascha Hauer
2022-02-25  7:51 ` [PATCH v7 10/24] drm/rockchip: dw_hdmi: Add support for hclk Sascha Hauer
2022-02-25  7:51   ` Sascha Hauer
2022-02-25  7:51   ` Sascha Hauer
2022-02-25  7:51   ` Sascha Hauer
2022-02-25 10:26   ` Dmitry Osipenko
2022-02-25 10:26     ` Dmitry Osipenko
2022-02-25 10:26     ` Dmitry Osipenko
2022-02-25 10:26     ` Dmitry Osipenko
2022-02-25 10:49     ` Sascha Hauer
2022-02-25 10:49       ` Sascha Hauer
2022-02-25 10:49       ` Sascha Hauer
2022-02-25 10:49       ` Sascha Hauer
2022-02-25 11:10       ` Dmitry Osipenko
2022-02-25 11:10         ` Dmitry Osipenko
2022-02-25 11:10         ` Dmitry Osipenko
2022-02-25 11:10         ` Dmitry Osipenko
2022-02-25 11:37         ` Sascha Hauer
2022-02-25 11:37           ` Sascha Hauer
2022-02-25 11:37           ` Sascha Hauer
2022-02-25 11:37           ` Sascha Hauer
2022-02-25 12:41         ` Robin Murphy
2022-02-25 12:41           ` Robin Murphy
2022-02-25 12:41           ` Robin Murphy
2022-02-25 12:41           ` Robin Murphy
2022-02-25 13:11           ` Sascha Hauer
2022-02-25 13:11             ` Sascha Hauer
2022-02-25 13:11             ` Sascha Hauer
2022-02-25 13:11             ` Sascha Hauer
2022-02-25 13:33             ` Robin Murphy
2022-02-25 13:33               ` Robin Murphy
2022-02-25 13:33               ` Robin Murphy
2022-02-25 13:33               ` Robin Murphy
2022-02-28 14:19             ` Sascha Hauer
2022-02-28 14:19               ` Sascha Hauer
2022-02-28 14:19               ` Sascha Hauer
2022-02-28 14:19               ` Sascha Hauer
2022-02-28 22:56               ` Dmitry Osipenko
2022-02-28 22:56                 ` Dmitry Osipenko
2022-02-28 22:56                 ` Dmitry Osipenko
2022-02-28 22:56                 ` Dmitry Osipenko
2022-03-01  8:37                 ` Sascha Hauer
2022-03-01  8:37                   ` Sascha Hauer
2022-03-01  8:37                   ` Sascha Hauer
2022-03-01  8:37                   ` Sascha Hauer
2022-03-01 13:22                   ` Dmitry Osipenko
2022-03-01 13:22                     ` Dmitry Osipenko
2022-03-01 13:22                     ` Dmitry Osipenko
2022-03-01 13:22                     ` Dmitry Osipenko
2022-03-01 13:39               ` Robin Murphy
2022-03-01 13:39                 ` Robin Murphy
2022-03-01 13:39                 ` Robin Murphy
2022-03-01 13:39                 ` Robin Murphy
2022-03-02 11:25                 ` Sascha Hauer
2022-03-02 11:25                   ` Sascha Hauer
2022-03-02 11:25                   ` Sascha Hauer
2022-03-02 11:25                   ` Sascha Hauer
2022-03-04 14:22                   ` Sascha Hauer
2022-03-04 14:22                     ` Sascha Hauer
2022-03-04 14:22                     ` Sascha Hauer
2022-03-04 14:22                     ` Sascha Hauer
2022-03-04 23:55                     ` Dmitry Osipenko
2022-03-04 23:55                       ` Dmitry Osipenko
2022-03-04 23:55                       ` Dmitry Osipenko
2022-03-04 23:55                       ` Dmitry Osipenko
2022-03-08  3:31                       ` Andy Yan
2022-03-08  3:31                         ` Andy Yan
2022-03-08  3:31                         ` Andy Yan
2022-03-08  3:31                         ` Andy Yan
2022-03-09  1:41                         ` zhangqing
2022-03-09  8:18                           ` Sascha Hauer
2022-03-09  8:18                             ` Sascha Hauer
2022-03-09  8:18                             ` Sascha Hauer
2022-03-09  8:18                             ` Sascha Hauer
2022-03-09  8:37                             ` elaine.zhang
2022-03-09  8:37                               ` elaine.zhang
2022-03-09  8:37                               ` elaine.zhang
2022-03-09  8:37                               ` elaine.zhang
2022-03-09 12:06                               ` Robin Murphy
2022-03-09 12:06                                 ` Robin Murphy
2022-03-09 12:06                                 ` Robin Murphy
2022-03-09 12:06                                 ` Robin Murphy
2022-02-25  7:51 ` [PATCH v7 11/24] dt-bindings: display: rockchip: dw-hdmi: Add additional clock Sascha Hauer
2022-02-25  7:51   ` Sascha Hauer
2022-02-25  7:51   ` Sascha Hauer
2022-02-25  7:51   ` Sascha Hauer
2022-03-09 12:06   ` Robin Murphy
2022-03-09 12:06     ` Robin Murphy
2022-03-09 12:06     ` Robin Murphy
2022-03-09 12:06     ` Robin Murphy
2022-02-25  7:51 ` [PATCH v7 12/24] drm/rockchip: dw_hdmi: Use auto-generated tables Sascha Hauer
2022-02-25  7:51   ` Sascha Hauer
2022-02-25  7:51   ` Sascha Hauer
2022-02-25  7:51   ` Sascha Hauer
2022-02-25  7:51 ` [PATCH v7 13/24] drm/rockchip: dw_hdmi: drop mode_valid hook Sascha Hauer
2022-02-25  7:51   ` Sascha Hauer
2022-02-25  7:51   ` Sascha Hauer
2022-02-25  7:51   ` Sascha Hauer
2022-02-25  7:51 ` [PATCH v7 14/24] drm/rockchip: dw_hdmi: Set cur_ctr to 0 always Sascha Hauer
2022-02-25  7:51   ` Sascha Hauer
2022-02-25  7:51   ` Sascha Hauer
2022-02-25  7:51   ` Sascha Hauer
2022-02-25  7:51 ` [PATCH v7 15/24] drm/rockchip: dw_hdmi: add default 594Mhz clk for 4K@60hz Sascha Hauer
2022-02-25  7:51   ` Sascha Hauer
2022-02-25  7:51   ` Sascha Hauer
2022-02-25  7:51   ` Sascha Hauer
2022-03-07 12:06   ` Andy Yan
2022-03-07 12:06     ` Andy Yan
2022-03-07 12:06     ` Andy Yan
2022-03-07 12:06     ` Andy Yan
2022-02-25  7:51 ` [PATCH v7 16/24] dt-bindings: display: rockchip: dw-hdmi: Make unwedge pinctrl optional Sascha Hauer
2022-02-25  7:51   ` Sascha Hauer
2022-02-25  7:51   ` Sascha Hauer
2022-02-25  7:51   ` Sascha Hauer
2022-02-25  7:51 ` [PATCH v7 17/24] arm64: dts: rockchip: rk356x: Add VOP2 nodes Sascha Hauer
2022-02-25  7:51   ` Sascha Hauer
2022-02-25  7:51   ` Sascha Hauer
2022-02-25  7:51   ` Sascha Hauer
2022-02-25  8:04   ` Sascha Hauer
2022-02-25  8:04     ` Sascha Hauer
2022-02-25  8:04     ` Sascha Hauer
2022-02-25  8:04     ` Sascha Hauer
2022-02-25  7:51 ` [PATCH v7 18/24] arm64: dts: rockchip: rk356x: Add HDMI nodes Sascha Hauer
2022-02-25  7:51   ` Sascha Hauer
2022-02-25  7:51   ` Sascha Hauer
2022-02-25  7:51   ` Sascha Hauer
2022-02-25  7:51 ` [PATCH v7 19/24] arm64: dts: rockchip: rk3568-evb: Enable VOP2 and hdmi Sascha Hauer
2022-02-25  7:51   ` Sascha Hauer
2022-02-25  7:51   ` Sascha Hauer
2022-02-25  7:51   ` Sascha Hauer
2022-02-25  7:51 ` [PATCH v7 20/24] arm64: dts: rockchip: enable vop2 and hdmi tx on quartz64a Sascha Hauer
2022-02-25  7:51   ` Sascha Hauer
2022-02-25  7:51   ` Sascha Hauer
2022-02-25  7:51   ` Sascha Hauer
2022-02-25  7:51 ` [PATCH v7 21/24] drm/rockchip: Make VOP driver optional Sascha Hauer
2022-02-25  7:51   ` Sascha Hauer
2022-02-25  7:51   ` Sascha Hauer
2022-02-25  7:51   ` Sascha Hauer
2022-02-25  7:51 ` [PATCH v7 22/24] drm: rockchip: Add VOP2 driver Sascha Hauer
2022-02-25  7:51   ` Sascha Hauer
2022-02-25  7:51   ` Sascha Hauer
2022-03-03 16:07   ` Aw: " Frank Wunderlich
2022-03-03 16:07     ` Frank Wunderlich
2022-03-03 16:07     ` Frank Wunderlich
2022-03-03 16:07     ` Frank Wunderlich
2022-03-07 12:18   ` Andy Yan
2022-03-07 12:18     ` Andy Yan
2022-03-07 12:18     ` Andy Yan
2022-03-07 12:54     ` Sascha Hauer
2022-03-07 12:54       ` Sascha Hauer
2022-03-07 12:54       ` Sascha Hauer
2022-03-07 12:54       ` Sascha Hauer
2022-03-07 13:09     ` Daniel Stone
2022-03-07 13:09       ` Daniel Stone
2022-03-07 13:09       ` Daniel Stone
2022-03-07 13:09       ` Daniel Stone
2022-03-08  8:42       ` Andy Yan
2022-03-08  8:42         ` Andy Yan
2022-03-08  8:42         ` Andy Yan
2022-03-08  8:42         ` Andy Yan
2022-03-08 14:04         ` Daniel Stone
2022-03-08 14:04           ` Daniel Stone
2022-03-08 14:04           ` Daniel Stone
2022-03-08 14:04           ` Daniel Stone
2022-03-09  2:03           ` Andy Yan
2022-03-09  2:03             ` Andy Yan
2022-03-09  2:03             ` Andy Yan
2022-03-09  2:03             ` Andy Yan
2022-03-09  7:37             ` Andy Yan
2022-03-09  7:37               ` Andy Yan
2022-03-09  7:37               ` Andy Yan
2022-03-09  7:37               ` Andy Yan
2022-03-14 11:02               ` Andy Yan
2022-03-14 11:02                 ` Andy Yan
2022-03-14 11:02                 ` Andy Yan
2022-03-14 11:02                 ` Andy Yan
2022-03-14 13:38                 ` Daniel Stone [this message]
2022-03-14 13:38                   ` Daniel Stone
2022-03-14 13:38                   ` Daniel Stone
2022-03-14 13:38                   ` Daniel Stone
2022-02-25  7:51 ` [PATCH v7 23/24] dt-bindings: display: rockchip: Add binding for VOP2 Sascha Hauer
2022-02-25  7:51   ` Sascha Hauer
2022-02-25  7:51   ` Sascha Hauer
2022-02-25  7:51   ` Sascha Hauer
2022-02-25  7:51 ` [PATCH v7 24/24] dt-bindings: display: rockchip: dw-hdmi: fix ports description Sascha Hauer
2022-02-25  7:51   ` Sascha Hauer
2022-02-25  7:51   ` Sascha Hauer
2022-02-25  7:51   ` Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAPj87rNXuJ6MQMb7dJHWZcqxaH9cyu1f2_NWidT_zsm44STmaw@mail.gmail.com \
    --to=daniel@fooishbar.org \
    --cc=andy.yan@rock-chips.com \
    --cc=benjamin.gaignard@collabora.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=hjc@rock-chips.com \
    --cc=kernel@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=michael.riesch@wolfvision.net \
    --cc=pgwipeout@gmail.com \
    --cc=s.hauer@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.