All of lore.kernel.org
 help / color / mirror / Atom feed
From: Simon Glass <sjg@chromium.org>
To: Ilias Apalodimas <ilias.apalodimas@linaro.org>
Cc: u-boot@lists.denx.de, trini@konsulko.com,
	Rick Chen <rick@andestech.com>,
	 Sean Anderson <seanga2@gmail.com>,
	Heinrich Schuchardt <xypron.glpk@gmx.de>,
	Masahisa Kojima <masahisa.kojima@linaro.org>
Subject: Re: [PATCH 3/8 v7] tpm2: Introduce TIS tpm core
Date: Sat, 13 Nov 2021 11:15:54 -0700	[thread overview]
Message-ID: <CAPnjgZ01izP9BXkM+X9EFtv3fk-z1pYTZrAHc1A4Tu_250xRyw@mail.gmail.com> (raw)
In-Reply-To: <20211109070223.76456-4-ilias.apalodimas@linaro.org>

On Tue, 9 Nov 2021 at 00:02, Ilias Apalodimas
<ilias.apalodimas@linaro.org> wrote:
>
> There's a lot of code duplication in U-Boot right now.  All the TPM TIS
> compatible drivers we have at the moment have their own copy of a TIS
> implementation.
>
> So let's create a common layer which implements the core TIS functions.
> Any driver added from now own, which is compatible with the TIS spec, will
> only have to provide the underlying bus communication mechanisms.
>
> Signed-off-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>
> ---
>  drivers/tpm/tpm2_tis_core.c | 463 ++++++++++++++++++++++++++++++++++++
>  drivers/tpm/tpm_tis.h       | 136 +++++++++++
>  include/tpm-v2.h            |   1 +
>  3 files changed, 600 insertions(+)
>  create mode 100644 drivers/tpm/tpm2_tis_core.c
>

Please can you add a change log to each patch? You have a vague one in
the cover letter but I am left to guess how each patch has changed.

Reviewed-by: Simon Glass <sjg@chromium.org>

Regards,
Simon

  parent reply	other threads:[~2021-11-13 18:16 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-09  7:02 [PATCH 0/8 v7] TPM cleanups and MMIO driver Ilias Apalodimas
2021-11-09  7:02 ` [PATCH 1/8 v7] tpm: refactor function names and macros for infineon v1.2 TPM Ilias Apalodimas
2021-11-09  7:02 ` [PATCH 2/8 v7] tpm: refactor function names for LPC based TPMs Ilias Apalodimas
2021-11-09  7:02 ` [PATCH 3/8 v7] tpm2: Introduce TIS tpm core Ilias Apalodimas
2021-11-13 18:14   ` Simon Glass
2021-11-13 18:15   ` Simon Glass [this message]
2021-11-15 11:09     ` Ilias Apalodimas
2021-11-09  7:02 ` [PATCH 4/8 v7] tpm2: Add a TPMv2 MMIO TIS driver Ilias Apalodimas
2021-11-09  7:02 ` [PATCH 5/8 v7] tpm: Use the new API on tpm2 spi driver Ilias Apalodimas
2021-11-09  7:02 ` [PATCH 6/8 v7] configs: Enable tpmv2 mmio on qemu for arm/arm64 Ilias Apalodimas
2021-11-09  7:02 ` [PATCH 7/8 v7] doc: qemu: Add instructions for swtpm usage Ilias Apalodimas
2021-11-13 18:14   ` Simon Glass
2021-11-15 11:10     ` Ilias Apalodimas
2022-01-27 15:06       ` Simon Glass
2022-01-27 22:08         ` Heinrich Schuchardt
2021-11-09  7:02 ` [PATCH 8/8 v7] MAINTAINERS: Add entry for TPM drivers Ilias Apalodimas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAPnjgZ01izP9BXkM+X9EFtv3fk-z1pYTZrAHc1A4Tu_250xRyw@mail.gmail.com \
    --to=sjg@chromium.org \
    --cc=ilias.apalodimas@linaro.org \
    --cc=masahisa.kojima@linaro.org \
    --cc=rick@andestech.com \
    --cc=seanga2@gmail.com \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    --cc=xypron.glpk@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.