All of lore.kernel.org
 help / color / mirror / Atom feed
From: Simon Glass <sjg@chromium.org>
To: u-boot@lists.denx.de
Subject: [PATCH] gpio-uclass: fix gpio flags save condition
Date: Fri, 5 Feb 2021 19:43:49 -0700	[thread overview]
Message-ID: <CAPnjgZ0ARDx0gSOLOKULrWuoci2qXi5YRe0OKZo85+J4Cvvmhg@mail.gmail.com> (raw)
In-Reply-To: <20210205154852.51513f4f@kmaincent-XPS-13-7390>

Hi K?ry,

On Fri, 5 Feb 2021 at 07:48, K?ry Maincent <kory.maincent@bootlin.com> wrote:
>
> Hi Simon,
>
> On Thu, 4 Feb 2021 19:45:22 -0700
> Simon Glass <sjg@chromium.org> wrote:
>
>
> > Thank you for that. I think that is because dm_gpio_set_dir_flags()
> > does not clear the flags first. But we now do actually update
> > desc->flags, where as before it was just supposed to happen. So I
> > think this function needs to update to clear the direction flags, then
> > add in the ones passed.
> >
> > I have pushed this to u-boot-dm/gpio-working if you can test it again.
>
> I have tested your v4 series of patches and all works well for my onewire on
> gpio.
> Thanks for your update.

Thank you. You could reply to the patches with your Tested-by tag if you like.

Regards,
Simon

      reply	other threads:[~2021-02-06  2:43 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-22 15:23 [PATCH] gpio-uclass: fix gpio flags save condition Kory Maincent
2021-01-24 20:24 ` Simon Glass
2021-01-25 14:27   ` Köry Maincent
2021-02-05  2:45     ` Simon Glass
2021-02-05 14:48       ` Köry Maincent
2021-02-06  2:43         ` Simon Glass [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAPnjgZ0ARDx0gSOLOKULrWuoci2qXi5YRe0OKZo85+J4Cvvmhg@mail.gmail.com \
    --to=sjg@chromium.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.