All of lore.kernel.org
 help / color / mirror / Atom feed
From: Simon Glass <sjg@chromium.org>
To: u-boot@lists.denx.de
Subject: [PATCH] gpio-uclass: fix gpio flags save condition
Date: Sun, 24 Jan 2021 13:24:14 -0700	[thread overview]
Message-ID: <CAPnjgZ3YWrAxnHBg520o8aYvvbWpKBp2MLDpdjLt8miuqZUFSA@mail.gmail.com> (raw)
In-Reply-To: <20210122152349.26295-1-kory.maincent@bootlin.com>

Hi Kory,

On Fri, 22 Jan 2021 at 08:23, Kory Maincent <kory.maincent@bootlin.com> wrote:
>
> The commit cd2faeba1a moves the location where we save the flags to the gpio
> descriptor but it adds a "!" character.
> This breaks the condition we expect to save the flags.
>
> Signed-off-by: Kory Maincent <kory.maincent@bootlin.com>
> ---
>  drivers/gpio/gpio-uclass.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>

This does indeed seem to be a bug, and the tests do not cover it. But
this happens to be fixed by my GPIO series. I'm about to send out v3
so will copy you on it.

Regards,
Simon

  reply	other threads:[~2021-01-24 20:24 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-22 15:23 [PATCH] gpio-uclass: fix gpio flags save condition Kory Maincent
2021-01-24 20:24 ` Simon Glass [this message]
2021-01-25 14:27   ` Köry Maincent
2021-02-05  2:45     ` Simon Glass
2021-02-05 14:48       ` Köry Maincent
2021-02-06  2:43         ` Simon Glass

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAPnjgZ3YWrAxnHBg520o8aYvvbWpKBp2MLDpdjLt8miuqZUFSA@mail.gmail.com \
    --to=sjg@chromium.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.