All of lore.kernel.org
 help / color / mirror / Atom feed
From: Simon Glass <sjg@chromium.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/2] PCI: autoconfig: Don't allocate 64-bit addresses to 32-bit only resources
Date: Mon, 14 May 2018 13:53:46 -0600	[thread overview]
Message-ID: <CAPnjgZ0B1iq-miAThsKfzwVgovt-fOnr+_=UE5y0VoeZVR3dWw@mail.gmail.com> (raw)
In-Reply-To: <20180514163813.1219-2-tuomas.tynkkynen@iki.fi>

Hi Tuomas,

On 14 May 2018 at 10:38, Tuomas Tynkkynen <tuomas.tynkkynen@iki.fi> wrote:
> Currently, if we happen to allocate an address requiring 64 bits to a
> device only supporting 32-bit BARs, the address eventually gets silently
> truncated to 32 bits. Avoid this by adding a new flag to
> pciauto_region_allocate() to bail out in such situations.
>
> Signed-off-by: Tuomas Tynkkynen <tuomas.tynkkynen@iki.fi>
> ---
>  drivers/pci/pci_auto.c        | 6 ++++--
>  drivers/pci/pci_auto_common.c | 7 ++++++-
>  drivers/pci/pci_auto_old.c    | 5 +++--
>  include/pci.h                 | 2 +-
>  4 files changed, 14 insertions(+), 6 deletions(-)

Reviewed-by: Simon Glass <sjg@chromium.org>

Please can you add a function comment to pciauto_region_allocate()?

Regards,
Simon

  reply	other threads:[~2018-05-14 19:53 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-14 16:38 [U-Boot] [PATCH 1/2] PCI: Add newlines to debug prints in pci_auto_common.c Tuomas Tynkkynen
2018-05-14 16:38 ` [U-Boot] [PATCH 2/2] PCI: autoconfig: Don't allocate 64-bit addresses to 32-bit only resources Tuomas Tynkkynen
2018-05-14 19:53   ` Simon Glass [this message]
2018-05-28 19:12   ` [U-Boot] [U-Boot, " Tom Rini
2018-05-14 19:53 ` [U-Boot] [PATCH 1/2] PCI: Add newlines to debug prints in pci_auto_common.c Simon Glass
2018-05-28 19:12 ` [U-Boot] [U-Boot, " Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAPnjgZ0B1iq-miAThsKfzwVgovt-fOnr+_=UE5y0VoeZVR3dWw@mail.gmail.com' \
    --to=sjg@chromium.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.