All of lore.kernel.org
 help / color / mirror / Atom feed
From: Simon Glass <sjg@chromium.org>
To: Jeffy Chen <jeffy.chen@rock-chips.com>
Cc: Joe Hershberger <joe.hershberger@ni.com>,
	Jan Kiszka <jan.kiszka@siemens.com>,
	U-Boot Mailing List <u-boot@lists.denx.de>,
	Tom Warren <twarren@nvidia.com>,
	Ian Campbell <ijc@hellion.org.uk>,
	linux-rockchip@lists.infradead.org,
	York Sun <yorksun@freescale.com>
Subject: Re: [PATCH v1 2/6] ARM: bootm: Try to use relocated ramdisk
Date: Thu, 7 Jan 2016 20:34:01 -0700	[thread overview]
Message-ID: <CAPnjgZ0GMwkHesVSYzNYfp0O8TifZgQbC71LYWjMqEHDEn3OEQ@mail.gmail.com> (raw)
In-Reply-To: <1451893823-20309-3-git-send-email-jeffy.chen@rock-chips.com>

Hi Jeffy,

On 4 January 2016 at 00:50, Jeffy Chen <jeffy.chen@rock-chips.com> wrote:
> After boot_ramdisk_high(), ramdisk would be relocated to
> initrd_start & initrd_end, so use them instead of rd_start & rd_end.
>
> Signed-off-by: Jeffy Chen <jeffy.chen@rock-chips.com>
> ---
>
>  arch/arm/lib/bootm.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/lib/bootm.c b/arch/arm/lib/bootm.c
> index a477cae..ac94995 100644
> --- a/arch/arm/lib/bootm.c
> +++ b/arch/arm/lib/bootm.c
> @@ -225,7 +225,10 @@ static void boot_prep_linux(bootm_headers_t *images)
>                 if (BOOTM_ENABLE_MEMORY_TAGS)
>                         setup_memory_tags(gd->bd);
>                 if (BOOTM_ENABLE_INITRD_TAG) {
> -                       if (images->rd_start && images->rd_end) {
> +                       if (images->initrd_start && images->initrd_end) {
> +                               setup_initrd_tag(gd->bd, images->initrd_start,
> +                                                images->initrd_end);
> +                       } else if (images->rd_start && images->rd_end) {

Can you please add comments to these members (initrd_start/end) in
image.h? At present it is not clear what they are, compared to
rd_start/end.

>                                 setup_initrd_tag(gd->bd, images->rd_start,
>                                                  images->rd_end);
>                         }
> --
> 2.1.4
>
>

Regards,
Simon

WARNING: multiple messages have this Message-ID (diff)
From: Simon Glass <sjg@chromium.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v1 2/6] ARM: bootm: Try to use relocated ramdisk
Date: Thu, 7 Jan 2016 20:34:01 -0700	[thread overview]
Message-ID: <CAPnjgZ0GMwkHesVSYzNYfp0O8TifZgQbC71LYWjMqEHDEn3OEQ@mail.gmail.com> (raw)
In-Reply-To: <1451893823-20309-3-git-send-email-jeffy.chen@rock-chips.com>

Hi Jeffy,

On 4 January 2016 at 00:50, Jeffy Chen <jeffy.chen@rock-chips.com> wrote:
> After boot_ramdisk_high(), ramdisk would be relocated to
> initrd_start & initrd_end, so use them instead of rd_start & rd_end.
>
> Signed-off-by: Jeffy Chen <jeffy.chen@rock-chips.com>
> ---
>
>  arch/arm/lib/bootm.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/lib/bootm.c b/arch/arm/lib/bootm.c
> index a477cae..ac94995 100644
> --- a/arch/arm/lib/bootm.c
> +++ b/arch/arm/lib/bootm.c
> @@ -225,7 +225,10 @@ static void boot_prep_linux(bootm_headers_t *images)
>                 if (BOOTM_ENABLE_MEMORY_TAGS)
>                         setup_memory_tags(gd->bd);
>                 if (BOOTM_ENABLE_INITRD_TAG) {
> -                       if (images->rd_start && images->rd_end) {
> +                       if (images->initrd_start && images->initrd_end) {
> +                               setup_initrd_tag(gd->bd, images->initrd_start,
> +                                                images->initrd_end);
> +                       } else if (images->rd_start && images->rd_end) {

Can you please add comments to these members (initrd_start/end) in
image.h? At present it is not clear what they are, compared to
rd_start/end.

>                                 setup_initrd_tag(gd->bd, images->rd_start,
>                                                  images->rd_end);
>                         }
> --
> 2.1.4
>
>

Regards,
Simon

  reply	other threads:[~2016-01-08  3:34 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-04  7:50 [PATCH v1 0/6] rockchip: kylin: Boot with android boot image Jeffy Chen
2016-01-04  7:50 ` [U-Boot] " Jeffy Chen
     [not found] ` <1451893823-20309-1-git-send-email-jeffy.chen-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2016-01-04  7:50   ` [PATCH v1 1/6] common/image-fdt.c: Make boot_get_fdt() perform a check for Android images Jeffy Chen
2016-01-04  7:50     ` [U-Boot] " Jeffy Chen
2016-01-08  3:33     ` Simon Glass
2016-01-08  3:33       ` [U-Boot] " Simon Glass
2016-01-04  7:50   ` [PATCH v1 2/6] ARM: bootm: Try to use relocated ramdisk Jeffy Chen
2016-01-04  7:50     ` [U-Boot] " Jeffy Chen
2016-01-08  3:34     ` Simon Glass [this message]
2016-01-08  3:34       ` Simon Glass
2016-01-04  7:50   ` [PATCH v1 3/6] rockchip: rk3036: Bind GPIO banks Jeffy Chen
2016-01-04  7:50     ` [U-Boot] " Jeffy Chen
2016-01-08  3:34     ` Simon Glass
2016-01-08  3:34       ` [U-Boot] " Simon Glass
2016-01-04  7:50   ` [PATCH v1 4/6] rockchip: kylin: Add default gpt partition table Jeffy Chen
2016-01-04  7:50     ` [U-Boot] " Jeffy Chen
2016-01-08  3:34     ` Simon Glass
2016-01-08  3:34       ` [U-Boot] " Simon Glass
2016-01-04  7:50   ` [PATCH v1 5/6] rockchip: kylin: Enable boot with android boot image Jeffy Chen
2016-01-04  7:50     ` [U-Boot] " Jeffy Chen
     [not found]     ` <1451893823-20309-6-git-send-email-jeffy.chen-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2016-01-08  3:34       ` Simon Glass
2016-01-08  3:34         ` [U-Boot] " Simon Glass
     [not found]         ` <CAPnjgZ1G=5=gqy6yGV1NZ13Zv0BACRYMPpdAoFAi+sv2TPXknw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-01-08 10:51           ` Jeffy Chen
2016-01-08 10:51             ` [U-Boot] " Jeffy Chen
     [not found]             ` <568F94B8.60101-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2016-01-11 16:58               ` Simon Glass
2016-01-11 16:58                 ` [U-Boot] " Simon Glass
     [not found]                 ` <CAPnjgZ2_wS1N8uO23+M0RJZovVFx7Wc_uMqOC37nGGBQN7NZZA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-01-12  2:36                   ` Jeffy Chen
2016-01-12  2:36                     ` [U-Boot] " Jeffy Chen
2016-01-04  7:50   ` [PATCH v1 6/6] rockchip: kylin: Check fastboot request Jeffy Chen
2016-01-04  7:50     ` [U-Boot] " Jeffy Chen
     [not found]     ` <1451893823-20309-7-git-send-email-jeffy.chen-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2016-01-08  3:34       ` Simon Glass
2016-01-08  3:34         ` [U-Boot] " Simon Glass

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAPnjgZ0GMwkHesVSYzNYfp0O8TifZgQbC71LYWjMqEHDEn3OEQ@mail.gmail.com \
    --to=sjg@chromium.org \
    --cc=ijc@hellion.org.uk \
    --cc=jan.kiszka@siemens.com \
    --cc=jeffy.chen@rock-chips.com \
    --cc=joe.hershberger@ni.com \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=twarren@nvidia.com \
    --cc=u-boot@lists.denx.de \
    --cc=yorksun@freescale.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.