All of lore.kernel.org
 help / color / mirror / Atom feed
From: Simon Glass <sjg@chromium.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/4] usb: dwc2-otg: redefine fifo-size for rk3288
Date: Fri, 1 Jul 2016 08:15:02 -0700	[thread overview]
Message-ID: <CAPnjgZ0JJCHCv-ni+GJ0udmQy0wknz76N=LqwQZmPpNbk-m6_w@mail.gmail.com> (raw)
In-Reply-To: <577606EB.8050406@rock-chips.com>

Hi,

On 30 June 2016 at 23:00, Ziyuan Xu <xzy.xu@rock-chips.com> wrote:
>
> Hi Simon,
>
> On 2016?06?30? 23:23, Simon Glass wrote:
>>
>> Hi Ziyuan,
>>
>> On 30 June 2016 at 00:21, Ziyuan Xu <xzy.xu@rock-chips.com> wrote:
>>>
>>> Redefine RX FIFO size & TX FIFO size for rk3288.
>>>
>>> Signed-off-by: Ziyuan Xu <xzy.xu@rock-chips.com>
>>> ---
>>>
>>>   drivers/usb/gadget/dwc2_udc_otg_regs.h | 6 ++++++
>>>   1 file changed, 6 insertions(+)
>>>
>>> diff --git a/drivers/usb/gadget/dwc2_udc_otg_regs.h b/drivers/usb/gadget/dwc2_udc_otg_regs.h
>>> index 78ec90e..a0617c8 100644
>>> --- a/drivers/usb/gadget/dwc2_udc_otg_regs.h
>>> +++ b/drivers/usb/gadget/dwc2_udc_otg_regs.h
>>> @@ -130,8 +130,14 @@ struct dwc2_usbotg_reg {
>>>   #define HIGH_SPEED_CONTROL_PKT_SIZE    64
>>>   #define HIGH_SPEED_BULK_PKT_SIZE       512
>>>
>>> +#ifdef CONFIG_ROCKCHIP_RK3288
>>> +#define RX_FIFO_SIZE                   (275*4)
>>> +#define NPTX_FIFO_SIZE                 (16*4)
>>> +#else
>>>   #define RX_FIFO_SIZE                   (1024*4)
>>>   #define NPTX_FIFO_SIZE                 (1024*4)
>>> +#endif
>>
>> I cannot see where this is used. Can you explain? Also can you add a
>> reason for the change in your commit message?
>
> The total FIFO size of dwc2 on Rockchip SoCs is shorter than the existent, so redefined
> them to fit Rockchip SoCs.

$ git grep RX_FIFO_SIZE
drivers/i2c/kona_i2c.c:#define MAX_RX_FIFO_SIZE           64U     /* bytes */
drivers/i2c/kona_i2c.c:   unsigned int bytes_to_read = MAX_RX_FIFO_SIZE;
drivers/i2c/kona_i2c.c:           if (msg->len - bytes_read <=
MAX_RX_FIFO_SIZE) {
drivers/usb/gadget/dwc2_udc_otg.c:        writel(RX_FIFO_SIZE >> 2,
&reg->grxfsiz);
drivers/usb/gadget/dwc2_udc_otg.c:        writel((NPTX_FIFO_SIZE >> 2)
<< 16 | ((RX_FIFO_SIZE >> 2)) << 0,
drivers/usb/gadget/dwc2_udc_otg.c:
((RX_FIFO_SIZE + NPTX_FIFO_SIZE +
drivers/usb/gadget/dwc2_udc_otg_regs.h:#define RX_FIFO_SIZE
           (1024*4)
drivers/usb/host/dwc2.c:
writel(CONFIG_DWC2_HOST_RX_FIFO_SIZE, &regs->grxfsiz);
drivers/usb/host/dwc2.c:          nptxfifosize |=
CONFIG_DWC2_HOST_RX_FIFO_SIZE <<
drivers/usb/host/dwc2.c:          ptxfifosize |=
(CONFIG_DWC2_HOST_RX_FIFO_SIZE +
drivers/usb/host/dwc2.h:#define CONFIG_DWC2_HOST_RX_FIFO_SIZE
   (516 + CONFIG_DWC2_MAX_CHANNELS)

If we need a Rockchip-specific value for this then it should go in
Kconfig or device tree.

>
>>> +
>>>   #define PTX_FIFO_SIZE                  (1536*1)
>>>
>>>   #define DEPCTL_TXFNUM_0                (0x0<<22)
>>> --
>>> 1.9.1

Regards,
Simon

  reply	other threads:[~2016-07-01 15:15 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-30  7:21 [U-Boot] [PATCH 0/4] rockchip: rk3288: add fastboot support Ziyuan Xu
2016-06-30  7:21 ` [U-Boot] [PATCH 1/4] usb: phy: implement usb-otg phy control for rk3288 Ziyuan Xu
2016-06-30 15:23   ` Simon Glass
2016-06-30  7:21 ` [U-Boot] [PATCH 2/4] usb: dwc2-otg: redefine fifo-size " Ziyuan Xu
2016-06-30 15:23   ` Simon Glass
2016-07-01  5:46     ` Ziyuan Xu
2016-07-01  6:00     ` Ziyuan Xu
2016-07-01 15:15       ` Simon Glass [this message]
2016-07-04  6:41         ` Ziyuan Xu
2016-06-30  7:22 ` [U-Boot] [PATCH 3/4] rockchip: rk3288: add fastboot support Ziyuan Xu
2016-06-30 15:23   ` Simon Glass
2016-06-30 21:55     ` Steve Rae
2016-07-01  6:22       ` Ziyuan Xu
2016-07-01  3:25     ` [U-Boot] [PATCH 3/4] rockchip: rk3288: add fastboot support[Involving remittance information, please pay attention to the safety of property] Ziyuan Xu
2016-06-30  7:22 ` [U-Boot] [PATCH 4/4] rockchip: firefly-rk3288: undef CONFIG_EFI_LOADER Ziyuan Xu
2016-06-30  8:34 ` [U-Boot] [PATCH 0/4] rockchip: rk3288: add fastboot support Alexander Graf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAPnjgZ0JJCHCv-ni+GJ0udmQy0wknz76N=LqwQZmPpNbk-m6_w@mail.gmail.com' \
    --to=sjg@chromium.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.