All of lore.kernel.org
 help / color / mirror / Atom feed
From: Simon Glass <sjg@chromium.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 3/6] tegra: dts: Sync tegra20 device tree files with Linux
Date: Mon, 9 May 2016 13:26:29 -0600	[thread overview]
Message-ID: <CAPnjgZ0KKCf9OnSdHbkg_pu7sdbtoGq-maPNN5PtrKUvOF_J0Q@mail.gmail.com> (raw)
In-Reply-To: <5730C431.5010300@wwwdotorg.org>

Hi Stephen,

On 9 May 2016 at 11:09, Stephen Warren <swarren@wwwdotorg.org> wrote:
> On 05/08/2016 04:55 PM, Simon Glass wrote:
>>
>> Sync everything except the display panel, which will come in a future
>> patch.
>> One USB port is left disabled since we don't want to support it in U-Boot.
>
>
> I'd rather be a bit more careful here, and only import the DT nodes directly
> related to display output.
>
> This change brings in a slew of other nodes that aren't used by U-Boot
> (something we've historically explicitly avoided) such as pinctrl, audio,
> Tegra KBC, I2C mux, & regulators.

I believe that audio, KBC and regulators are used.

>
> It also doesn't sync the /aliases node with the kernel (e.g. Seaboard I2C,
> and I think USB for all boards), and at least Harmony's USB nodes don't seem
> to match what's in the kernel so I'm not sure where the DT content came
> from, e.g. consider usb at c5004000's nvidia,phy-reset-gpio used an integer
> rather than GPIO_ACTIVE_LOW, which is present in at least the most recent
> kernel release (v4.5).

This was against v4.4, but I may have messed up the merge in some
cases. since I had to change the addresses from 64 bit.

>
> Splitting this up a bit or limiting it to just display-related nodes would
> make it easier to debug any issues that crop up with the sync. Also, have we
> made an explicit decision to change the policy of only including DT nodes
> that U-Boot actually uses, rather than simply copying the entire kernel DT
> into U-Boot? I'm pretty sure that some board(s) have deliberate differences
> in areas other than display, e.g. since U-Boot doesn't (or at least didn't)
> support pinctrl-based I2C muxed which are used on some Tegra20 boards in the
> kernel at least, and hence U-Boot likely either disabled those I2C ports or
> picked an explicit pinmux configuration to hard-code to.

I think I know what you mean, and I don't believe that actually
affects any I2C ports that are used in U-Boot. Do you have any
example?

I'd rather have the DT completely in sync, so far as can be done. We
have this merge window to find problems. I don't see a big benefit to
leaving stuff out...at least with other boards we've defaulted to just
bringing everything in.

Are we mostly talking about the pinmux stuff?

Regards,
Simon

  reply	other threads:[~2016-05-09 19:26 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-08 22:55 [U-Boot] [PATCH v2 0/6] tegra: Move tegra20 towards the 'new' display bindings Simon Glass
2016-05-08 22:55 ` [U-Boot] [PATCH v2 1/6] errno: Add copyright header and header guard Simon Glass
2016-05-08 22:55 ` [U-Boot] [PATCH v2 2/6] errno: Allow errno_str() to be used without CONFIG_ERRNO_STR Simon Glass
2016-05-08 22:55 ` [U-Boot] [PATCH v2 3/6] tegra: dts: Sync tegra20 device tree files with Linux Simon Glass
2016-05-09 17:09   ` Stephen Warren
2016-05-09 19:26     ` Simon Glass [this message]
2016-05-10 17:45       ` Stephen Warren
2016-05-13  3:11         ` Simon Glass
2016-05-08 22:55 ` [U-Boot] [PATCH v2 4/6] video: tegra: Move to using simple-panel and pwm-backlight Simon Glass
2016-05-08 22:55 ` [U-Boot] [PATCH v2 5/6] tegra: video: Always use write-through cache on LCD Simon Glass
2016-05-08 22:55 ` [U-Boot] [PATCH v2 6/6] fdt: Drop some unused compatible strings Simon Glass
2016-05-09 16:53 ` [U-Boot] [PATCH v2 0/6] tegra: Move tegra20 towards the 'new' display bindings Stephen Warren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAPnjgZ0KKCf9OnSdHbkg_pu7sdbtoGq-maPNN5PtrKUvOF_J0Q@mail.gmail.com \
    --to=sjg@chromium.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.