All of lore.kernel.org
 help / color / mirror / Atom feed
From: Simon Glass <sjg@chromium.org>
To: Neha Malcom Francis <n-francis@ti.com>
Cc: u-boot@lists.denx.de, trini@konsulko.com, afd@ti.com,
	vigneshr@ti.com,  rogerq@kernel.org, alpernebiyasak@gmail.com,
	nm@ti.com, bb@ti.com
Subject: Re: [PATCH 13/21] Makefile: Add DM, SYSFW_PATH, SYSFW_HS_INNER_CERT_PATH to BINMAN_INDIRS
Date: Fri, 20 Jan 2023 12:46:04 -0700	[thread overview]
Message-ID: <CAPnjgZ0L6gfKcXs5+-_zd76vrRZm2Hfc_zyxusQHMc_+RfOw=Q@mail.gmail.com> (raw)
In-Reply-To: <20230120101903.179959-14-n-francis@ti.com>

Hi Neha,

On Fri, 20 Jan 2023 at 03:19, Neha Malcom Francis <n-francis@ti.com> wrote:
>
> To remain consistent with the build commands utilised for K3 devices,
> we add the paths where component binaries are located to BINMAN_INDIRS.
> Adding SYSFW_PATH for system firmware binaries, SYSFW_HS_INNER_CERT_PATH
> for HS device certificate and DM for Device Manager firmware.
> This way, the existing build command does not change even though we
> migrate to using binman.
>
> Signed-off-by: Neha Malcom Francis <n-francis@ti.com>
> ---
>  Makefile | 16 ++++++++++++++++
>  1 file changed, 16 insertions(+)
>
> diff --git a/Makefile b/Makefile
> index c568a6e59a..218cb675fc 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -1317,6 +1317,22 @@ u-boot.ldr:      u-boot
>  # Use 'make BINMAN_VERBOSE=3' to set vebosity level
>  default_dt := $(if $(DEVICE_TREE),$(DEVICE_TREE),$(CONFIG_DEFAULT_DEVICE_TREE))
>
> +ifneq ($(SYSFW_PATH),)
> +override BINMAN_INDIRS += $(dir $(SYSFW_PATH))
> +endif
> +
> +ifneq ($(SYSFW_HS_PATH),)
> +override BINMAN_INDIRS += $(dir $(SYSFW_HS_PATH))
> +endif
> +
> +ifneq ($(SYSFW_HS_INNER_CERT_PATH),)
> +override BINMAN_INDIRS += $(dir $(SYSFW_HS_INNER_CERT_PATH))
> +endif
> +
> +ifneq ($(DM),)
> +override BINMAN_INDIRS += $(dir $(DM))
> +endif
> +
>  quiet_cmd_binman = BINMAN  $@
>  cmd_binman = $(srctree)/tools/binman/binman $(if $(BINMAN_DEBUG),-D) \
>                 $(foreach f,$(BINMAN_TOOLPATHS),--toolpath $(f)) \
> --
> 2.34.1
>

Let's try to do this another way as it needs to use a bintool for the
tool that you run. See my other comments.

Regards,
Simon

  reply	other threads:[~2023-01-20 19:46 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-20 10:18 [PATCH 00/21] Migration to using binman to generate bootloader Neha Malcom Francis
2023-01-20 10:18 ` [PATCH 01/21] ti: tools: config: Add board config class to generate config binaries Neha Malcom Francis
2023-01-20 19:46   ` Simon Glass
2023-01-20 10:18 ` [PATCH 02/21] tools: sysfw: Add script for generating configuration blobs Neha Malcom Francis
2023-01-23 14:19   ` Neha Malcom Francis
2023-01-23 18:42     ` Simon Glass
2023-01-24 10:04       ` Neha Malcom Francis
2023-01-20 10:18 ` [PATCH 03/21] tools: binman: add ti-secure entry type Neha Malcom Francis
2023-01-20 19:46   ` Simon Glass
2023-01-20 10:18 ` [PATCH 04/21] ti: sysfw: tiboot3: Add support for packaging sysfw.itb and tiboot3.bin Neha Malcom Francis
2023-01-20 10:18 ` [PATCH 05/21] j721e: schema: yaml: Add general schema and J721E board config files Neha Malcom Francis
2023-01-20 10:18 ` [PATCH 06/21] j721e: dts: binman: Package tiboot3.bin, sysfw.itb, tispl.bin, u-boot.img Neha Malcom Francis
2023-01-20 10:18 ` [PATCH 07/21] j7200: yaml: Add J7200 board config files Neha Malcom Francis
2023-01-20 10:18 ` [PATCH 08/21] j7200: dts: binman: Package tiboot3.bin, tispl.bin, u-boot.img Neha Malcom Francis
2023-01-20 10:18 ` [PATCH 09/21] am65x: yaml: Add AM65x board config files Neha Malcom Francis
2023-01-20 10:18 ` [PATCH 10/21] am65: dts: binman: Package tiboot3.bin, sysfw.itb, tispl.bin, u-boot.img Neha Malcom Francis
2023-01-20 10:18 ` [PATCH 11/21] config: am64x: Add board config for AM64x Neha Malcom Francis
2023-01-20 10:18 ` [PATCH 12/21] am64x: dts: binman: Package tiboot3.bin, tispl.bin u-boot.img Neha Malcom Francis
2023-01-20 10:18 ` [PATCH 13/21] Makefile: Add DM, SYSFW_PATH, SYSFW_HS_INNER_CERT_PATH to BINMAN_INDIRS Neha Malcom Francis
2023-01-20 19:46   ` Simon Glass [this message]
2023-01-20 10:18 ` [PATCH 14/21] j721s2: yaml: Add board config for J721S2 Neha Malcom Francis
2023-01-20 10:18 ` [PATCH 15/21] j721s2: dts: binman: Package tiboot3.bin, tispl.bin and u-boot.img Neha Malcom Francis
2023-01-20 19:46   ` Simon Glass
2023-01-20 10:18 ` [PATCH 16/21] am62: yaml: Add board config for AM62 Neha Malcom Francis
2023-01-20 10:18 ` [PATCH 17/21] am625: dts: binman: Package tiboot3.bin, tispl.bin and u-boot.img Neha Malcom Francis
2023-01-20 10:19 ` [PATCH 18/21] am62a: yaml: Add board config for AM62ax Neha Malcom Francis
2023-01-20 10:19 ` [PATCH 19/21] am62a: dts: binman: Package tiboot3.bin, tispl.bin, u-boot.img Neha Malcom Francis
2023-01-20 10:19 ` [PATCH 20/21] k3: tools: config.mk: Update makefile and remove scripts Neha Malcom Francis
2023-01-20 10:19 ` [PATCH 21/21] doc: board: ti: Update documentation for binman flow Neha Malcom Francis
2023-01-20 19:46 ` [PATCH 00/21] Migration to using binman to generate bootloader Simon Glass
2023-01-23 12:31   ` Neha Malcom Francis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAPnjgZ0L6gfKcXs5+-_zd76vrRZm2Hfc_zyxusQHMc_+RfOw=Q@mail.gmail.com' \
    --to=sjg@chromium.org \
    --cc=afd@ti.com \
    --cc=alpernebiyasak@gmail.com \
    --cc=bb@ti.com \
    --cc=n-francis@ti.com \
    --cc=nm@ti.com \
    --cc=rogerq@kernel.org \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.