Re: [PATCH v3 1/3] mmc: rockchip_sdhci: add phy and clock config for rk3399

[Simon Glass <sjg@chromium.org>]

Hi Jack,

On Fri, 29 Oct 2021 at 09:45, Jack Mitchell <ml@embed.me.uk> wrote:
>
> Hi,
>
> > snip
>
> > +
> > +static int rk3399_emmc_get_phy(struct udevice *dev)
> > +{
> > +     struct rockchip_sdhc *priv = dev_get_priv(dev);
> > +     ofnode phy_node;
> > +     void *grf_base;
> > +     u32 grf_phy_offset, phandle;
> > +
> > +     phandle = dev_read_u32_default(dev, "phys", 0);
> > +     phy_node = ofnode_get_by_phandle(phandle);
> > +     if (!ofnode_valid(phy_node)) {
> > +             debug("Not found emmc phy device\n");
> > +             return -ENODEV;
> > +     }
>
> I've just upgraded u-boot on my 3399 board and the emmc is failing to
> initialise as it can't find this "phys" node. It's a standard board
> setup with the following in the DT.
>
> &sdhci {
>         bus-width = <8>;
>         mmc-hs400-1_8v;
>         mmc-hs400-enhanced-strobe;
>         non-removable;
>         status = "okay";
> };
>
> &emmc_phy {
>         status = "okay";
> };
>
> and a vanilla rk3399.dtsi from 2021.10. Do you have any idea why this
> might be failing?
>
> U-Boot SPL 2021.10-00075-g8db2642c55-dirty (Oct 29 2021 - 16:42:46 +0100)
> Not found emmc phy device
> Trying to boot from MMC1
>
> Has anyone booted a 3399 board sucessfully since these patches went in?

Yes, chromebook_bob works OK for me.

Regards,
Simon