* [U-Boot] [PATCH 1/2] x86: crownbay: Enable saving environment in SPI flash
@ 2015-03-11 9:22 Bin Meng
2015-03-11 9:22 ` [U-Boot] [PATCH 2/2] x86: galileo: " Bin Meng
2015-03-12 22:15 ` [U-Boot] [PATCH 1/2] x86: crownbay: " Simon Glass
0 siblings, 2 replies; 7+ messages in thread
From: Bin Meng @ 2015-03-11 9:22 UTC (permalink / raw)
To: u-boot
Saving U-Boot's environment in SPI flash on Intel CrownBay board.
Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
---
include/configs/crownbay.h | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/include/configs/crownbay.h b/include/configs/crownbay.h
index b927b1c..4a74f82 100644
--- a/include/configs/crownbay.h
+++ b/include/configs/crownbay.h
@@ -56,4 +56,12 @@
#undef CONFIG_VIDEO
#undef CONFIG_CFB_CONSOLE
+/* Environment configuration */
+#undef CONFIG_ENV_IS_NOWHERE
+#undef CONFIG_ENV_SIZE
+#define CONFIG_ENV_IS_IN_SPI_FLASH
+#define CONFIG_ENV_SIZE 0x1000
+#define CONFIG_ENV_SECT_SIZE 0x1000
+#define CONFIG_ENV_OFFSET 0
+
#endif /* __CONFIG_H */
--
1.8.2.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [U-Boot] [PATCH 2/2] x86: galileo: Enable saving environment in SPI flash
2015-03-11 9:22 [U-Boot] [PATCH 1/2] x86: crownbay: Enable saving environment in SPI flash Bin Meng
@ 2015-03-11 9:22 ` Bin Meng
2015-03-12 22:15 ` Simon Glass
2015-03-12 22:15 ` [U-Boot] [PATCH 1/2] x86: crownbay: " Simon Glass
1 sibling, 1 reply; 7+ messages in thread
From: Bin Meng @ 2015-03-11 9:22 UTC (permalink / raw)
To: u-boot
Saving U-Boot's environment in SPI flash on Intel Galileo board.
Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
---
include/configs/galileo.h | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/include/configs/galileo.h b/include/configs/galileo.h
index 65a2c3e..288acf3 100644
--- a/include/configs/galileo.h
+++ b/include/configs/galileo.h
@@ -62,4 +62,12 @@
#define CONFIG_DW_ALTDESCRIPTOR
#define CONFIG_PHYLIB
+/* Environment configuration */
+#undef CONFIG_ENV_IS_NOWHERE
+#undef CONFIG_ENV_SIZE
+#define CONFIG_ENV_IS_IN_SPI_FLASH
+#define CONFIG_ENV_SIZE 0x1000
+#define CONFIG_ENV_SECT_SIZE 0x1000
+#define CONFIG_ENV_OFFSET 0
+
#endif /* __CONFIG_H */
--
1.8.2.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [U-Boot] [PATCH 1/2] x86: crownbay: Enable saving environment in SPI flash
2015-03-11 9:22 [U-Boot] [PATCH 1/2] x86: crownbay: Enable saving environment in SPI flash Bin Meng
2015-03-11 9:22 ` [U-Boot] [PATCH 2/2] x86: galileo: " Bin Meng
@ 2015-03-12 22:15 ` Simon Glass
2015-03-25 22:35 ` Simon Glass
1 sibling, 1 reply; 7+ messages in thread
From: Simon Glass @ 2015-03-12 22:15 UTC (permalink / raw)
To: u-boot
On 11 March 2015 at 02:22, Bin Meng <bmeng.cn@gmail.com> wrote:
> Saving U-Boot's environment in SPI flash on Intel CrownBay board.
>
> Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
> ---
>
> include/configs/crownbay.h | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/include/configs/crownbay.h b/include/configs/crownbay.h
> index b927b1c..4a74f82 100644
> --- a/include/configs/crownbay.h
> +++ b/include/configs/crownbay.h
> @@ -56,4 +56,12 @@
> #undef CONFIG_VIDEO
> #undef CONFIG_CFB_CONSOLE
>
> +/* Environment configuration */
> +#undef CONFIG_ENV_IS_NOWHERE
> +#undef CONFIG_ENV_SIZE
> +#define CONFIG_ENV_IS_IN_SPI_FLASH
> +#define CONFIG_ENV_SIZE 0x1000
> +#define CONFIG_ENV_SECT_SIZE 0x1000
> +#define CONFIG_ENV_OFFSET 0
> +
> #endif /* __CONFIG_H */
> --
> 1.8.2.1
>
Acked-by: Simon Glass <sg@chromium.org>
^ permalink raw reply [flat|nested] 7+ messages in thread
* [U-Boot] [PATCH 2/2] x86: galileo: Enable saving environment in SPI flash
2015-03-11 9:22 ` [U-Boot] [PATCH 2/2] x86: galileo: " Bin Meng
@ 2015-03-12 22:15 ` Simon Glass
2015-03-13 1:40 ` Bin Meng
0 siblings, 1 reply; 7+ messages in thread
From: Simon Glass @ 2015-03-12 22:15 UTC (permalink / raw)
To: u-boot
On 11 March 2015 at 02:22, Bin Meng <bmeng.cn@gmail.com> wrote:
> Saving U-Boot's environment in SPI flash on Intel Galileo board.
>
> Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
> ---
>
> include/configs/galileo.h | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/include/configs/galileo.h b/include/configs/galileo.h
> index 65a2c3e..288acf3 100644
> --- a/include/configs/galileo.h
> +++ b/include/configs/galileo.h
> @@ -62,4 +62,12 @@
> #define CONFIG_DW_ALTDESCRIPTOR
> #define CONFIG_PHYLIB
>
> +/* Environment configuration */
> +#undef CONFIG_ENV_IS_NOWHERE
> +#undef CONFIG_ENV_SIZE
> +#define CONFIG_ENV_IS_IN_SPI_FLASH
> +#define CONFIG_ENV_SIZE 0x1000
> +#define CONFIG_ENV_SECT_SIZE 0x1000
> +#define CONFIG_ENV_OFFSET 0
> +
> #endif /* __CONFIG_H */
> --
> 1.8.2.1
>
Acked-by: Simon Glass <sg@chromium.org>
I wonder at what point we should move some of this to x86-common.h?
^ permalink raw reply [flat|nested] 7+ messages in thread
* [U-Boot] [PATCH 2/2] x86: galileo: Enable saving environment in SPI flash
2015-03-12 22:15 ` Simon Glass
@ 2015-03-13 1:40 ` Bin Meng
2015-03-25 22:35 ` Simon Glass
0 siblings, 1 reply; 7+ messages in thread
From: Bin Meng @ 2015-03-13 1:40 UTC (permalink / raw)
To: u-boot
Hi Simon,
On Fri, Mar 13, 2015 at 6:15 AM, Simon Glass <sjg@chromium.org> wrote:
> On 11 March 2015 at 02:22, Bin Meng <bmeng.cn@gmail.com> wrote:
>> Saving U-Boot's environment in SPI flash on Intel Galileo board.
>>
>> Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
>> ---
>>
>> include/configs/galileo.h | 8 ++++++++
>> 1 file changed, 8 insertions(+)
>>
>> diff --git a/include/configs/galileo.h b/include/configs/galileo.h
>> index 65a2c3e..288acf3 100644
>> --- a/include/configs/galileo.h
>> +++ b/include/configs/galileo.h
>> @@ -62,4 +62,12 @@
>> #define CONFIG_DW_ALTDESCRIPTOR
>> #define CONFIG_PHYLIB
>>
>> +/* Environment configuration */
>> +#undef CONFIG_ENV_IS_NOWHERE
>> +#undef CONFIG_ENV_SIZE
>> +#define CONFIG_ENV_IS_IN_SPI_FLASH
>> +#define CONFIG_ENV_SIZE 0x1000
>> +#define CONFIG_ENV_SECT_SIZE 0x1000
>> +#define CONFIG_ENV_OFFSET 0
>> +
>> #endif /* __CONFIG_H */
>> --
>> 1.8.2.1
>>
>
> Acked-by: Simon Glass <sg@chromium.org>
>
> I wonder at what point we should move some of this to x86-common.h?
I believe we can only put
#define CONFIG_ENV_IS_IN_SPI_FLASH
in x86-common.h and leave others still in the board file due to they
are spi flash/board-specific.
Regards,
Bin
^ permalink raw reply [flat|nested] 7+ messages in thread
* [U-Boot] [PATCH 1/2] x86: crownbay: Enable saving environment in SPI flash
2015-03-12 22:15 ` [U-Boot] [PATCH 1/2] x86: crownbay: " Simon Glass
@ 2015-03-25 22:35 ` Simon Glass
0 siblings, 0 replies; 7+ messages in thread
From: Simon Glass @ 2015-03-25 22:35 UTC (permalink / raw)
To: u-boot
On 12 March 2015 at 16:15, Simon Glass <sjg@chromium.org> wrote:
> On 11 March 2015 at 02:22, Bin Meng <bmeng.cn@gmail.com> wrote:
>> Saving U-Boot's environment in SPI flash on Intel CrownBay board.
>>
>> Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
>> ---
>>
>> include/configs/crownbay.h | 8 ++++++++
>> 1 file changed, 8 insertions(+)
>>
>> diff --git a/include/configs/crownbay.h b/include/configs/crownbay.h
>> index b927b1c..4a74f82 100644
>> --- a/include/configs/crownbay.h
>> +++ b/include/configs/crownbay.h
>> @@ -56,4 +56,12 @@
>> #undef CONFIG_VIDEO
>> #undef CONFIG_CFB_CONSOLE
>>
>> +/* Environment configuration */
>> +#undef CONFIG_ENV_IS_NOWHERE
>> +#undef CONFIG_ENV_SIZE
>> +#define CONFIG_ENV_IS_IN_SPI_FLASH
>> +#define CONFIG_ENV_SIZE 0x1000
>> +#define CONFIG_ENV_SECT_SIZE 0x1000
>> +#define CONFIG_ENV_OFFSET 0
>> +
>> #endif /* __CONFIG_H */
>> --
>> 1.8.2.1
>>
>
> Acked-by: Simon Glass <sg@chromium.org>
Applied to u-boot-x86, thanks!
^ permalink raw reply [flat|nested] 7+ messages in thread
* [U-Boot] [PATCH 2/2] x86: galileo: Enable saving environment in SPI flash
2015-03-13 1:40 ` Bin Meng
@ 2015-03-25 22:35 ` Simon Glass
0 siblings, 0 replies; 7+ messages in thread
From: Simon Glass @ 2015-03-25 22:35 UTC (permalink / raw)
To: u-boot
On 12 March 2015 at 19:40, Bin Meng <bmeng.cn@gmail.com> wrote:
> Hi Simon,
>
> On Fri, Mar 13, 2015 at 6:15 AM, Simon Glass <sjg@chromium.org> wrote:
>> On 11 March 2015 at 02:22, Bin Meng <bmeng.cn@gmail.com> wrote:
>>> Saving U-Boot's environment in SPI flash on Intel Galileo board.
>>>
>>> Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
>>> ---
>>>
>>> include/configs/galileo.h | 8 ++++++++
>>> 1 file changed, 8 insertions(+)
>>>
>>> diff --git a/include/configs/galileo.h b/include/configs/galileo.h
>>> index 65a2c3e..288acf3 100644
>>> --- a/include/configs/galileo.h
>>> +++ b/include/configs/galileo.h
>>> @@ -62,4 +62,12 @@
>>> #define CONFIG_DW_ALTDESCRIPTOR
>>> #define CONFIG_PHYLIB
>>>
>>> +/* Environment configuration */
>>> +#undef CONFIG_ENV_IS_NOWHERE
>>> +#undef CONFIG_ENV_SIZE
>>> +#define CONFIG_ENV_IS_IN_SPI_FLASH
>>> +#define CONFIG_ENV_SIZE 0x1000
>>> +#define CONFIG_ENV_SECT_SIZE 0x1000
>>> +#define CONFIG_ENV_OFFSET 0
>>> +
>>> #endif /* __CONFIG_H */
>>> --
>>> 1.8.2.1
>>>
>>
>> Acked-by: Simon Glass <sg@chromium.org>
>>
>> I wonder at what point we should move some of this to x86-common.h?
>
> I believe we can only put
>
> #define CONFIG_ENV_IS_IN_SPI_FLASH
>
> in x86-common.h and leave others still in the board file due to they
> are spi flash/board-specific.
Yes that sounds right.
Applied to u-boot-x86, thanks!
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2015-03-25 22:35 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-03-11 9:22 [U-Boot] [PATCH 1/2] x86: crownbay: Enable saving environment in SPI flash Bin Meng
2015-03-11 9:22 ` [U-Boot] [PATCH 2/2] x86: galileo: " Bin Meng
2015-03-12 22:15 ` Simon Glass
2015-03-13 1:40 ` Bin Meng
2015-03-25 22:35 ` Simon Glass
2015-03-12 22:15 ` [U-Boot] [PATCH 1/2] x86: crownbay: " Simon Glass
2015-03-25 22:35 ` Simon Glass
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.