From: Simon Glass <sjg@chromium.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 12/14] tegra: Set vdd_core and vdd_cpu to high
Date: Fri, 13 Jan 2012 09:55:25 -0800 [thread overview]
Message-ID: <CAPnjgZ0Xs824yznQp_m4g_A+oZyA+S=cAOeS=tar6DDPP12EnA@mail.gmail.com> (raw)
In-Reply-To: <4F0C8620.2060003@nvidia.com>
Hi Stephen,
On Tue, Jan 10, 2012 at 10:40 AM, Stephen Warren <swarren@nvidia.com> wrote:
> On 12/26/2011 12:33 PM, Simon Glass wrote:
>> From: Jimmy Zhang <jimmzhang@nvidia.com>
>>
>> At cold boot, the default voltage supplied by pmu is not high enough
>> to support emc to run at its highest clock frequency. The code added
>> here is to update the default vdd_core and vdd_cpu to higher values.
>>
>> (Sorry if I have mangled this comment)
>
> ?? Remove that last line?
Actually that is the truth! Unfortunately this commit originally
brought in the whole PMU and assorted other things in one big patch. I
split those things out in this series, and I think this may actually
relate to something else.
>
> I thought this issue only affected the T25 SKU when coupled with a
> particular voltage regulator that wasn't reprogrammed to explicitly
> support T25. Hence, shouldn't this code only be enabled for specific boards?
>
>> diff --git a/board/nvidia/common/board.c b/board/nvidia/common/board.c
> ...
>> ?/*
>> + * Routine: power_det_init
>> + * Description: turn off power detects
>> + */
>> +static void power_det_init(void)
>> +{
>> +#if defined(CONFIG_TEGRA2)
>> + ? ? struct pmc_ctlr *const pmc = (struct pmc_ctlr *)TEGRA2_PMC_BASE;
>> +
>> + ? ? /* turn off power detects */
>> + ? ? writel(0, &pmc->pmc_pwr_det_latch);
>> + ? ? writel(0, &pmc->pmc_pwr_det);
>> +#endif
>> +}
>
> I can't tell how that code relates to the commit description.
Neither could I, hence my comment. But I think I just made a mistake -
I have been back through the commits and actually I think it should
be:
Tegra core power rail has leakage voltage around 0.2V while system in
suspend mode. The source of the leakage should be coming from PMC
power detect
logic for IO rails power detection.
That can be disabled by writing a '0' to PWR_DET_LATCH followed by
writing '0'
to PWR_DET (APBDEV_PMC_PWR_DET_0).
so I will change it.
Regards,
Simon
>
> --
> nvpublic
next prev parent reply other threads:[~2012-01-13 17:55 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-26 19:32 [U-Boot] [PATCH 0/14] tegra: warmboot (suspend / resume) support Simon Glass
2011-12-26 19:32 ` [U-Boot] [PATCH 01/14] Add AES crypto library Simon Glass
2012-01-08 5:49 ` Mike Frysinger
2012-01-08 8:57 ` Marek Vasut
2012-01-08 9:09 ` Mike Frysinger
2012-01-08 10:40 ` Marek Vasut
2012-01-08 16:35 ` Simon Glass
2011-12-26 19:32 ` [U-Boot] [PATCH 02/14] tegra: Move ap20.h header into arch location Simon Glass
2011-12-26 19:32 ` [U-Boot] [PATCH 03/14] tegra: Add crypto library for warmboot code Simon Glass
2012-01-08 5:51 ` Mike Frysinger
2012-01-08 16:42 ` Simon Glass
2011-12-26 19:32 ` [U-Boot] [PATCH 04/14] tegra: Add flow, gp_padctl, fuse, sdram headers Simon Glass
2011-12-26 19:32 ` [U-Boot] [PATCH 05/14] tegra: Add tegra_get_chip_type() to detect SKU Simon Glass
2012-01-09 23:24 ` Stephen Warren
2012-01-12 19:35 ` Simon Glass
2012-01-12 19:48 ` Stephen Warren
2012-01-13 21:06 ` Simon Glass
2011-12-26 19:32 ` [U-Boot] [PATCH 06/14] tegra: Add EMC support for optimal memory timings Simon Glass
2012-01-09 23:38 ` Stephen Warren
2012-01-12 20:43 ` Simon Glass
2012-01-13 17:47 ` Simon Glass
2011-12-26 19:33 ` [U-Boot] [PATCH 07/14] tegra: Add PMU to manage power supplies Simon Glass
2012-01-10 17:56 ` Stephen Warren
2012-01-12 23:17 ` Simon Glass
2012-01-12 23:43 ` Stephen Warren
2012-01-12 23:55 ` Simon Glass
2011-12-26 19:33 ` [U-Boot] [PATCH 08/14] tegra: Set up PMU for Nvidia boards Simon Glass
2012-01-10 18:02 ` Stephen Warren
2012-01-12 23:42 ` Simon Glass
2011-12-26 19:33 ` [U-Boot] [PATCH 09/14] tegra: Add warmboot implementation Simon Glass
2012-01-10 18:30 ` Stephen Warren
2012-01-13 19:34 ` Simon Glass
2012-01-13 22:04 ` Yen Lin
2012-01-13 23:05 ` Simon Glass
2012-01-13 23:08 ` Stephen Warren
2012-01-14 0:04 ` Yen Lin
2011-12-26 19:33 ` [U-Boot] [PATCH 10/14] tegra: Setup PMC scratch info from ap20 setup Simon Glass
2011-12-26 19:33 ` [U-Boot] [PATCH 11/14] tegra: Set up warmboot code on Nvidia boards Simon Glass
2011-12-26 19:33 ` [U-Boot] [PATCH 12/14] tegra: Set vdd_core and vdd_cpu to high Simon Glass
2012-01-10 18:40 ` Stephen Warren
2012-01-13 17:55 ` Simon Glass [this message]
2011-12-26 19:33 ` [U-Boot] [PATCH 13/14] tegra: Add EMC settings for Seaboard, Harmony Simon Glass
2012-01-10 18:46 ` Stephen Warren
2012-01-12 23:05 ` Simon Glass
2012-01-12 23:42 ` Stephen Warren
2012-01-12 23:54 ` Simon Glass
2012-01-13 0:01 ` Stephen Warren
2012-01-13 0:05 ` Simon Glass
2012-01-13 0:10 ` Stephen Warren
2012-01-13 0:18 ` Simon Glass
2011-12-26 19:33 ` [U-Boot] [PATCH 14/14] tegra: Enable LP0 on Seaboard Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPnjgZ0Xs824yznQp_m4g_A+oZyA+S=cAOeS=tar6DDPP12EnA@mail.gmail.com' \
--to=sjg@chromium.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.